- 25 Nov, 2019 40 commits
-
-
Peter Kasting authored
Previously, light-mode tooltips were light-on-dark, and dark-mode were dark-on-light. This reverses that, since opposite-scheme tooltips stick out oddly and look buggy. For example, on CrOS, hovering a tab gave a dark-on-light "tooltip" (preview), but hovering the new tab button was light-on-dark. Since translucent tooltips will now stand out less, this adds a border, just as non-translucent tooltips have. This also makes non-translucent tooltips more closely resemble translucent ones by using GetResultingPaintColor() instead of simply clamping opacity. Bug: 1024091 Change-Id: Ie6cda816b285423446d8d8f119288683b913d3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931756 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#718723}
-
Robbie Gibson authored
The root cause for the original failure was because the omnibox started grouping searches and urls separately. This meant that on smaller screen size devices (iPhone SE), all the searches were at the top and the URLs for SwitchToTab were hidden below the keyboard. The solution here is to enter more text into the omnibox so fewer searches appear and only the URLs appear. Fixed: 1025199 Change-Id: Id518359ad421aead5948492a677de2d7ba13eeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930802Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#718722}
-
Jeremy Apthorp authored
Nothing seems to depend on the possibility of having multiple callbacks. Change-Id: I9935be6345d37fe9d445f741c803aab949aab125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930096 Auto-Submit: Jeremy Apthorp <jeremya@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#718721}
-
James Hawkins authored
This value is no longer set or read. Bug: none Test: none Change-Id: I53c4d95c0341bcfcca23b39706cd89971f8c2983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929919 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#718720}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=dmazzoni@chromium.org Bug: 1023677 Change-Id: I172954a36c4a6103cf71995f2e53a08b3a5b8211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926821 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#718719}
-
Rahul Arakeri authored
As follow up to crrev.com/c/1925180, this CL splits up tests in fast/scrolling/scrollbars into smaller tests. Bug: 1027299 Change-Id: Idb4ac6fe7ca0729941b6f88ca30f14ecdab16347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932237Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718718}
-
Gauthier Ambard authored
This CL adds a metric to differentiate the omnibox shortcut and the NewTab shortcut. Fixed: 1025115 Change-Id: I4469813bb08b1f6c3e372afca18e6d75d90ef04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917370 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#718717}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/eecfdbf1701d..bb8e777557dd $ git log eecfdbf17..bb8e77755 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 junyer Fix nullptr-with-nonzero-offset bugs found by UBSan. 2019-11-25 junyer Check if empty() instead of comparing size() with 0. 2019-11-10 junyer Fix a latent bug in Regexp::Walker<T>::Reset(). Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I3dc03d39a07a4a676e41aa59ccd17fdcd0a20ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933930Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#718716}
-
Yue Zhang authored
Bug: 1027197 Change-Id: Id30af64014564ee244dade0e84eb7a14abf642bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931437 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718715}
-
Yi Gu authored
Currently we verify the v2 hit testing result unconditionally which should be changed due to two major reasons: 1. the mismatch rate is relatively low (0.02%~0.03%). 2. the verification badly affects the async hit testing performance because both of them share the same querying queue in blink. This patch basically reverts crrev.com/c/1157227. Bug: 985385 Change-Id: Id58c25777bc26585169053521186cd3b9ac6dd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922300Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718714}
-
James Hawkins authored
Bug: none Test: none Change-Id: Ica8c4e209e5969cad312ff161d5f04787a3aa0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932701 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=khmel@chromium.org Bug: 1023677 Change-Id: Ieabfcdac4097b9cf9839dc3e05bc950b328b989a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926670 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#718712}
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation in the browser process from the renderer process without relying on InterfaceProvider. Bug: 955171, 978694, 936482 Change-Id: I0f962d8f9a21d95b376062fdc2d585130fa0e71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893165 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#718711}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d07418c4577e..61169e9c4794 git log d07418c4577e..61169e9c4794 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 benjaminwagner@google.com Fix asset_utils when no service_account_json 2019-11-25 bsalomon@google.com Reland "Revert "Revert "Make FP optimizations helpers use SkAlphaType not GrColorType""" 2019-11-25 robertphillips@google.com Add code path that avoids large indexBuffer draws 2019-11-25 fmalita@chromium.org [sksg] Temporarily inline Path fillType accessors Created with: gclient setdep -r src/third_party/skia@61169e9c4794 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I9361020453c7b2873966482ea3d290f33f55208d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934254Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718710}
-
Dan Harrington authored
Bug: 1024945 Change-Id: Ia0bc333f73b020d7ed93defc65ee2dcb38424df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933634Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#718709}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74637ca12a6a..9a1a942e18ee git log 74637ca12a6a..9a1a942e18ee --date=short --no-merges --format='%ad %ae %s' 2019-11-25 lalitm@google.com Merge "trace_processor: eliminate useless order by constraints from query set" Created with: gclient setdep -r src/third_party/perfetto@9a1a942e18ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I73737fb5ffd2faf2fc06f8721c0bfcaae43ddb7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934251Reviewed-by:
-
Sigurdur Asgeirsson authored
As-is the crash dumps don't contain the computed values, which isn't very useful. Bug: 1017827 Change-Id: I6ebf14417795744020eb5a560287bc45eb45722b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932164 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
-
Chris Lu authored
This change adds neverTranslateSite to InfobarTranslateModalDelegate while also implementing all of the InfobarTranslateModalDelegate actions in InfobarTranslateCoordinator. Bug: 1014959 Change-Id: I401d54783317be62ac2968bd315fd67ad50ba4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904691 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#718706}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1023677 Change-Id: Ia0abbed688be555909aa5b2d59d5a54bc9de32f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926879 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#718705}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=dmazzoni@chromium.org Bug: 1023677 Change-Id: Id651135546370ff40df9bdc0df18cfd66c6793e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927019 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Mikel Astiz authored
The set of always-encrypted-types is now moved to model_type.h to make this concept a core sync primitive. As part of this, we've favored simplicity and let upper layers assume that, for the regular case where encrypt-everything is off, the set of encrypted datatypes is equal to always-encrypted-types. This allows removing IsEncryptionEnabledForPasswordsOnly(), which now becomes the exact opposite of IsEncryptEverythingEnabled(). Bug: 1019687 Change-Id: I2ebafdc9d754cc1bea9c0ad935465d1153b6ecbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932806Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#718703}
-
Etienne Pierre-doray authored
To measure disk usage. This metric expects improvement from https://chromium-review.googlesource.com/c/chromium/src/+/1845956 Current: 761134 KB Bug: 933975 Change-Id: I66f4384af6f982ff1e94b7f98e892c8a50e2e5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879972 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718702}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=khmel@chromium.org Bug: 1023677 Change-Id: I9fe9aae2a5a929b9631e8642e1d9cb75678b8e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926817 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Wenyu Fu authored
Update HomepagePolicyManager with the latest API to check if the preference is managed. Checking the pref alone cannot tell if the policy is enforced or not, because Homepage preference can be set without the policy. Bug: 978197 Change-Id: I400e04bc624c92af27e94ace2f378a5e8d896e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931380Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718700}
-
Yuly Novikov authored
Since they fail all 3 retries when they are flaky, upgrading the expectation from RetryOnFailure to Failure. TBR=bsheedy Bug: 1026468 Change-Id: I5bff99bf33b3217bf9969a820f5a67d179c53237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934241Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718699}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/63dced9f4598..712a26f3842b git log 63dced9f4598..712a26f3842b --date=short --no-merges --format='%ad %ae %s' 2019-11-25 titovartem@google.com Add IvfVideoFrameGenerator Created with: gclient setdep -r src/third_party/webrtc@712a26f3842b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I19ed1cf078bbce6b60a879098625b2a54dd6125c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933753Reviewed-by:
-
haozhe authored
Firefox passed the tests. Chrome does not support mask-position which is in the spec. Bug filed: https://bugs.chromium.org/p/chromium/issues/detail?id=1027585 Bug: 900581 Change-Id: Ibe5db28d0b692ab3d2763d7e52406962d0cbf2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924695Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#718697}
-
Theresa Wellington authored
A previous CL refactorted AppMenuPropertiesDelegateImpl to use an ObservableSupplier for obtaining the BookmarkBridge rather than a setter in the AppMenuPropertiesDelegate interface. When a callback is registered with the ObservableSupplier, a call to the callback is posted if the supplied object is already available. This changed the timing of when the BookmarkBridge is supplied, allowing the app menu to be opened before the BookmarkBridge is supplied. This CL attempts to get the BookmarkBridge from the supplier directly when #updateBookmarkMenuItem is called if the BookmarkBridge is null and adds another null check in case the bridge is still not available. BUG=1027222 Change-Id: I8d8bbeb812286c8c18baf0ae65da11bd48386d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934448Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#718696}
-
Alexandre Frechette authored
Bug: 1024076 Change-Id: I1ca04cc7a1ee4513d6beece853ff132072b71c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924687Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#718695}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f24db461826..d0f4dbab33c4 Created with: gclient setdep -r src-internal@d0f4dbab33c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Id1ef78a7973b311428ae36b2d45dae0083ceb398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934250Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718694}
-
Bo Liu authored
Previous implementation accidentally ignored reflective exceptions, which included exceptions by the actual call itself. Ignore it for now, but will leave bug open to investigate proper fix. Bug: 1026626 Change-Id: Ia3636f923053009d3589a59259e2eace833cad84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933737Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718693}
-
Joe DeBlasio authored
This CL adds jdeblasio@ as an owner only of chrome/browser/download/mixed_content_download_blocking*. Bug: 973214 Change-Id: Ib7a32152e9f05ac32c6c99b780275c0cc5bfc737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932467Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#718692}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7248ed3b. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." 09908954 "Fetch Metadata: Assert portal support for WPT." c8d798a2 "Migrate more layout instability tests to WPT." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Idb0cd0da883dd76a7e4f5ba5f4abb3970ff5e2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934367Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718691}
-
Kevin McNee authored
|mojo::ReportBadMessage| does not automatically close the relevant receiver (|frame_host_associated_receiver_|). We return immediately after the |ReportBadMessage|, so the callbacks are not run. Since the pipe is not closed, this DCHECKS. Bug: None Change-Id: I521fe8c29679a92c9d5689e78758e4adde814b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929911 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#718690}
-
Owen Min authored
Bug: 1028129 Tbr: dpapad@chromium.org Change-Id: I19337a65e4cb12d91d87f9decd2626788b6026cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933590Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718689}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ice39e92722d0434f66a85dd53de30ad65804ca35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934252Reviewed-by:
-
Dominic Battre authored
This CL introduces a --force-disable-variation-ids parameter to prevent variation ids and trigger variation ids from being sent via the X-Client-Data request header for debugging purposes. Bug: 1027576 Change-Id: Iacaaee31b1a62e50cc9b61a709cca5651038ddf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930958 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#718687}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7b44da5f..c4a36ad5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I391da318c13f4e5fab5ebf3ed32e5eaa0a3b7e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933485Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718686}
-
Andrew Grieve authored
This fixes compatibility with JDK 11. use_errorprone_java_compiler GN arg cannot be re-enabled until newly added checks are either fixed or silenced. Bug: 894616, 1027541 Change-Id: Ic3727188867623b05228c58157818b500a886194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933767Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Christopher Grant authored
This reverts commit 0c8f0867. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/arm-unpublished-builder-rel/15653 TBR=agrieve Bug: 1027573 Original change's description: > Android: Support pure-32-bit version codes on 64-bit build configs > > See the associated bug for reasons why this work is happening. > > Refactor the version number generator script to be more explicit, and do > away with the hack that was in place to support multiple version numbers > in 64-bit config. > > Also, add the new pure 32-bit Mono and Trichrome numbers, as well as an > alias 32_64 version number, which is equivalent to the ambiguous > "Monochrome" version. > > Bug: 1027573 > Change-Id: Iae270f84ad3cf3c28e9001460a016aa7f75237e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931100 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718671} TBR=cjgrant@chromium.org,agrieve@chromium.org Change-Id: Ic5874955be3e1c723635accb5f9381540f3d6b34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1027573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934428Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#718684}
-
