- 26 Jul, 2019 40 commits
-
-
chrome://favicon2Victor Hugo Vianna Silva authored
Instead of making the distinction between page url and icon url with parameter url_type, we now have 2 optional parameters page_url and icon_url. In case both are specified, page_url takes precedence. Bug: 973192 Change-Id: I2daca543515b71998263908a48d113a37ced8eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704258 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#681138}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf99f644ae32..3a6f61256488 git log bf99f644ae32..3a6f61256488 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 eashanbhatt@google.com cros_chrome_sdk: Add --fallback-versions Created with: gclient setdep -r src/third_party/chromite@3a6f61256488 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia4550915f2e142b107cc5eba8c2be89668a0e6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719949Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681137}
-
John Rummell authored
UMA stats are showing that the number of successful navigator.requestMediaKeySystemAccess() calls are lower on canary than before this change was landed. It's possible that the checks for secure playback are not working properly on some devices, so reverting part of the change that added them to verify. Bug: 707127,727918,846120 Test: EncryptedMedia content_browsertests pass Change-Id: I9d1be799121859181c996e5ea47234fae6c6fcf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719729 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#681136}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I1c67a5c7e6af723022c1d631d90b405feb090a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700927Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681135}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I86a25d42415090528ba4a21821375d7a4d745e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700838 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Chirantan Ekbote <chirantan@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681134}
-
David Bertoni authored
This CL adds support for Service Worker-based extensions to the ExtensionBuilder class. It also renames the SetBackgroundPage() member function to SetBackgroundContext(). Bug: 853378 Change-Id: I30018b46aafefdfb8e6e450101b86f489669cc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719376 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#681133}
-
Sajjad Mirza authored
Change-Id: If50d3479146a47dca502ddcf84b9eacdcd7ff710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719650Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#681132}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c5817614666e..1c7dba2cadad git log c5817614666e..1c7dba2cadad --date=short --no-merges --format='%ad %ae %s' 2019-07-25 rmhasan@google.com [ Typ ] Make conflicts disallowed policy apply to test expectations with globs Created with: gclient setdep -r src/third_party/catapult@1c7dba2cadad The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:973936 Change-Id: I672efdb121067c508af41e693adf4cd2524194ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719580Reviewed-by:
-
Nigel Tao authored
"TODO... implement" has stayed unimplemented since 2014 (commit 630a27a6, https://codereview.chromium.org/118463002) Change-Id: I944d5d8c1e226f221e5c3c4f4a85d8f421a291e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716398 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#681130}
-
Hwanseung Lee authored
Use enum class instead of enum for DesktopDragDropClientAuraX11::SourceState enum class is more type safety. Bug: 940736 Change-Id: Ib5365bbfda80b10301f6b6b6d25975e44b7e745a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713546Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#681129}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6129e06e7f87..180f6291f9c9 Created with: gclient setdep -r src-internal@180f6291f9c9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7d845e06838cf5f154f5e6d8f36621943d4ddf58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719709Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681128}
-
Vladimir Levin authored
The beforeactivate signal could have caused us to be unlocked (probably kCommitting, which is considered an unlocked state). In that case, we shouldn't DCHECK or start commits, we should just early out since the commit is already in progress. R=chrishtr@chromium.org, rakina@chromium.org Bug: 987730 Change-Id: I5fec0b992dc0673ff661e600604af307c9e8ca42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719330Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681127}
-
Yuly Novikov authored
Mirrored by android_angle_rel_ng, in order to limit the tests being run to be only those relevant for ANGLE changes, reducing bot flakiness. Bug: angleproject:3475 Change-Id: Ic0595fcf37be4ca076cef467d2e4466950c19f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719409Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#681126}
-
Zhenyao Mo authored
This GPU accounts for around 80% of all Win/AMD crashes. Looking through crash reports, many of these crashes related to GPU video decoding. A user who can reproduce this crash confirmed falling back to D3D9 gets rid of the crash, so does disable accelerated video decode. However, the latter caused video playback to be janky. BUG=983787 TEST=gpu_unittests, manual R=kbr@chromium.org Change-Id: I1269d18efef34a9e927e2e406694fffaa89f9407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719672 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Maggie Chen authored
This histogram is added on the browser side to provide watchdog under-kill info for the watchdog Finch A/B experiment. Bug: 949839 Change-Id: I6522ca8476a39867e8be232e79d3a5ca961ac1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713660 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#681124}
-
Suzy Li authored
This CL removes uvm extension support and corresponding counters for registration at blink layer. This is the second CL for removing uvm for registration. The first CL: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1504071 Bug: 986345 Change-Id: Idf74c8a6343609120ac596fd86d2c8d5c7861cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710143Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Suzy Li <suzyli@google.com> Cr-Commit-Position: refs/heads/master@{#681123}
-
Chih-Yu Huang authored
Some devices failed at minimum FPS check when encoding large resolution video. We should check the FPS at performance test, instead of functional test. This CL removes the minimum FPS check. BUG=chromium:978352,b:136573600 TEST=Run video_encode_accelerator_unittest on Kevin Change-Id: I5207bf46b4a3ebfe8fde560cbbdddb455a64d8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716450Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#681122}
-
Michael Spang authored
The original change to use ThreadPriority::DISPLAY for the renderer compositor thread (7b97c324 "base: Allow renderer thread priorities to be changed.") also applied the priority to the IO thread to avoid delays in IPC message delivery to the compositor thread. We recently added a feature to control compositor thread priority, but it does not affect setting the IO thread priority. Instead, we always try to raise the priority on Linux, Android, & Chrome OS, and never try on Windows or Mac. This causes strange situations such as having render IO threads run with higher priority than any browser or GPU process thread even though the priority Features were disabled. Fix the BlinkCompositorUseDisplayThreadPriority feature to also apply to the IO thread and use it to control the initial thread priority, as well as whether we ask the browser to adjust it (which is used on Chrome OS for some cgroup manipulation that needs to be done from the browser). After this change, each of the display priority flags also control the IO thread priority of the corresponding process. Bug: 937462 Change-Id: I1950182fccd8bc6ea35359792878283c2fd9401c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714204Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#681121}
-
Eliot Courtney authored
We are still working on PIP, so we still would like to use the metrics. Bug: 986491 Bug: b/121299293 Test: compiles Change-Id: I1e067e85681c3147ce0db7f07a3fee33c7f0b736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716331Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#681120}
-
Jacob DeWitt authored
Now that WebXR spec issue 664 has been resolved with the decision to follow the Gamepad spec convention of using -1 for up and 1 for down for the y axis values, remove/update related TODO comments to reflect this. Bug: 966060 Change-Id: I3694631c35d3ad2e0990c132f2936f8ae1db1ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717576 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#681119}
-
Shakti Sahu authored
This issue occurs when we open new incognito tab directly from the launcher. The issue is that both regular and incognito profile get created at the same time and we miss the NOTIFICATION_PROFILE_CREATED event for which we register later. This results in not creating the SimpleDownloadManagerCoordinator for incognito, thereby missing all the download updates. A solution is to check if we already have a incognito profile, and initialize the SimpleDownloadManagerCoordinator for that. Bug: 980570 Change-Id: I1196e2ca2e15978dd0ac15fffc51f8ab99c267c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717625Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#681118}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7734ba9a7d52..6e3a40600f24 git log 7734ba9a7d52..6e3a40600f24 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 huyna89@gmail.com Prevent an UAF in CPDFSDK_AnnotHandlerMgr::GetNextAnnot(). Created with: gclient setdep -r src/third_party/pdfium@6e3a40600f24 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: chromium:980161 Change-Id: I6b4280fe452ede9c487828d99a8430b52582207f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717463Reviewed-by:
-
Nicolás Peña Moreno authored
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/S36p6Y16u5c Bug: 965505, 972038 Change-Id: Id2aac424b508ea698da5c73972d4c1b0442a2618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715739 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#681116}
-
Glenn Hartmann authored
This records WebAPK Session Duration to UKM, mirroring the existing UMA metric of the same purpose. TBR=msramek@chromium.org Bug: 982362 Change-Id: I9deb8be6f8df3908268c6d03f33e27a4c0fd731a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710501 Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#681115}
-
Orin Jaworski authored
This CL fixes a bug in the chrome://omnibox debug tool whereby some responses would be dropped if the host didn't match input text. Examples of such cases include queries with trailing spaces or some URLs with path. This has the effect of improving batch processing because large query batches often contained bug-triggering queries. Bug: 964528 Change-Id: I5d65d45037f4c996ce886cb6c7de761f23be1550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716237Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#681114}
-
Lan Wei authored
We want to put the feature of "dynamic delegation of autoplay" in a origin trial, and we need to add a UMA metrics to track this feature's usage. So we add a new feature kAutoplayDynamicDelegation. Bug: 985914 Change-Id: Icabf1fd996967e36deb6f3c00bee26c4473b7ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717241 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
-
Melissa Zhang authored
This CL removes |enable_stay_in_chrome| and replaces it with |show_stay_in_chrome| bool that determines whether the button is visible. This is because it is confusing for the user if the button is visible but disabled. The |stay_in_chrome| bool is false when the ArcExternalProtocolDialog invokes the intent picker, as staying in Chrome for an external protocol doesn't do anything. BUG=978728 Change-Id: I47f9783baa0880eb7dbcb8ebda8ff84cc7763d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714588 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This page displays a spinner while waiting for the SIM card to be detected, and displays an error if the SIM card is unable to be found. Bug: 968858 Change-Id: I38a294258edfd193fda246fabf0ee71418be9556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717689 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#681111}
-
Will Harris authored
BUG=None TEST=load chrome, view chrome://histograms, look it Windows.PatchLevel and check it matches a value in enums.xml Change-Id: Ic31ed6b676030d41eda339e909b0b822b7508455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718984 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
-
Dana Fried authored
We're still working on this feature, so we don't want to expire them. Bug: 984201 Change-Id: Ibdd0b6c9f77bc02779828a1c5f8108e568e746e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719146 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#681109}
-
Varun Khaneja authored
And never expire InternalErrorStatusCode2 histograms since it is critical to ensure that there are no errors in connecting to GmsCore for Safe Browsing lookups. R=holte Bug: 986648 Change-Id: Iefc06682aa7c4e5bb55bf54330931fc51ad4d4d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719629 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Sophie Chang authored
Bug: 986438 Change-Id: Ie2c45b4b192c97f106ffa157f7ab1dcce47a8e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719408 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#681107}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3a98df0bdd49..365720e237c2 git log 3a98df0bdd49..365720e237c2 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 ehmaldonado@chromium.org Revert "depot_tools: Move six to depot_tools' .vpython" Created with: gclient setdep -r src/third_party/depot_tools@365720e237c2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I2dba4b144ae0ea68f28c7adc65025f1844c8b6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717460Reviewed-by:
-
Nina Satragno authored
This change fixes gn refusing to build when `generate_linker_map` is true for android targets from a linux host. Bug: 986842 Change-Id: Ieb5e4d236ca54c87cf5f09fe26ce82a9bfe3191f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715024Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#681105}
-
Jacob DeWitt authored
This is better than failing silently by setting position + orientation to identity because an XRRigidTransform should never be created with a matrix that can't be decomposed. The previous approach would result in an invalid XRRigidTransform object since position + orientation values wouldn't match the transformation matrix. Bug: 969149 Change-Id: Id848a301d61e0fd9fdcab612effd0a3de27854fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717457 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
-
ssid authored
This reverts commit 11db5550. Reason for revert: Fix tests Original change's description: > Revert "Support startup tracing for sampling profiler" > > This reverts commit 21db0fea. > > Reason for revert: Likely reason for deterministically failing > TracingSampleProfilerTest.TestStartupTracing on Mac ASan 64 bot. > > Bug: 987615 > > Original change's description: > > Support startup tracing for sampling profiler > > > > The profiler buffers events and adds to trace when enabled. > > > > Change-Id: I0291b83379cae5192fe08c545709a59dd1c8704c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717684 > > Commit-Queue: ssid <ssid@chromium.org> > > Reviewed-by: oysteine <oysteine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#680740} > > TBR=oysteine@chromium.org,ssid@chromium.org > > Change-Id: I073798fd81482b2356f8588242b48769bf1f4e0f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718106 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680817} TBR=oysteine@chromium.org,ssid@chromium.org,fhorschig@chromium.org Change-Id: I66afe6ba6dc6158f0f18677b92f539ed2e3e8781 Bug: 987615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719305 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1717115. Because "scheme" is more spec-conformant name. Bug: 906850 Change-Id: Ie27cf2a4329b624d7692b6808928e8888d897500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718991 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#681102}
-
Nicolás Peña Moreno authored
Bug: 879270, 942033 Change-Id: I2cf90c23c3e1e3c81850bcb40e54e2ae39117dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719407Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#681101}
-
Hazem Ashmawy authored
Add a class that parses WebView crashes JSON logs. The collected info should be combined with info collected from other logs then used in WebView crash UI. Bug: 964392 Change-Id: I3afab2fdbeaee81bb7d87f49e85cd87e4dca30a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636064 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#681100}
-
Regan Hsu authored
Change-Id: I79e9ef044ff60f63d388310167befb0ef7052b2d Bug: 967907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706804 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#681099}
-
