- 28 Feb, 2020 40 commits
-
-
Connie Wan authored
WebUI has access to the Browser, so this should allow interfacing with Mohnstrudel. It also allows us to clean up a good portion of TabStripController that was only being used by the Editor Bubble. Still left to do: make it so that the dialog doesn't necesesarily need to take a TabGroupHeader. Bug: 1055537 Change-Id: Ia341453a092a8083075d7a31b6e39705d883fbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072365 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745309}
-
Anand K. Mistry authored
The existing SMB integration is based on file_system_provider, which internally saves (if requested) mounts and restores them on login. Smbfs is no longer based on FSP, and therefore needs to use its own mechanism for saving and restoring mount on login. Bug: 939235 Change-Id: I3c6c96cc8c733c74b5e071167d7d9ebf3b9eb12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071537Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#745308}
-
Gyuyoung Kim authored
This CL migrates the legacy ReplicateWebTestRuntimeFlagsChanges IPC message to the new Mojo defined in WebTestClient interface. To do that, this CL needs to introduce WebTestControl interface to send messages from the browser process to the renderer. Then, WebTestRenderThreadObserver starts to handle incoming Mojo requests through the RegisterMojoInterfaces implementation. This CL renames the existing |web_test_control_map_| to |blink_test_control_map_| in order to add a new |web_test_control_map|. Lastly, this CL removes all things related to the legacy IPC of the ReplicateWebTestRuntimeFlagsChanges message. Bug: 1039247 Change-Id: Ia41ef43093d7279020bcb79986e3328ed0338f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063610Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#745307}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings files page from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I8318818f7827ce47e9af9646c4541d0d2bb9963c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067391Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#745306}
-
Jinsuk Kim authored
This CL promotes the method to Tab's public method. Bug: 995903 Change-Id: I62ddc3d5c05929664aef6bef5b2a03934bcfa868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045617 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#745305}
-
dpapad authored
This test was reported as flaky (timeouts) on Linux CFI, but was disabled on all Linux bots at r629744, which seems unnecessary. Bug: 929288 Change-Id: Ifd5ffe065318e82a883f51673e4f730f6fb03342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079518 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745304}
-
Ted Choc authored
The ModelList can and should be the single source of truth, and this remove the redundant list. BUG=1050813 Change-Id: I91aad1c8398470425f50a28e6c64791b18d4fe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078777Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#745303}
-
Ian Kilpatrick authored
Layout now generates some paint information on physical fragments. Specifically (for this bug at least) if a sub-tree contains any floats. This conflicted with the relayout boundary optimization. If a float was added we wouldn't paint it, as we'd stop layout at the relayout boundary, not telling the parent fragments that this subtree contained a float. This patch only allows relayout boundaries to occur at positioned objects which always have self painting layers (which is the most common self painting layer). For the sites that I found which use this optimization (devtools, facebook, bing) all occur on a positioned object. Bug: 1049973 Change-Id: Iafaf68bf9642788a71e8f882a154e6acd7cbef46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076078 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#745302}
-
Scott Violet authored
WebLayer's ShouldOverrideUrlLoading() defines a set of known scheme. Any URL that not in the set will fail to load if not initiated by a user gesture. The set is incomplete and needs to include some other schemes such as 'blob'. This patch moves from a regex in the java side to weblayer/browser/content_browser_client_impl.cc where it can use existing constants. BUG=1056259 TEST=covered by wpt Change-Id: I1d38e4f6a27099426786736aeeea6a2f24851882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074811Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#745301}
-
Thomas Lukaszewicz authored
Removed the SetImageFromVectorIcon() function that used a default color value from a global call to GetInstanceForNativeUi() when not explicitly provided with a color value. Image buttons based on vector icons can now be created from CreateColorTrackingVectorImageButton(). These image buttons will update their colors to track the color values in their view hierarchy's native theme object. Bug: None Change-Id: I04c0f3794881b92832cd20a15b0b60c3efba976c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079214 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#745300}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1040828 Change-Id: I6819a779c2b7ce452335178bfdbf79656f9580ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073419Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#745299}
-
John Lee authored
Bug: 1027373 Change-Id: I0aa95bb619edffe9ee3ae6a83603777dc9fc6df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079376 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745298}
-
John Lee authored
This event is necessary as when a tab group is dragged from another window, the dragged element will still have the old ID. The dragged element's ID needs to be updated with the new ID so that the same element can be re-used. Bug: 1048894 Change-Id: I5495326a90efd3350b3eedcb1cbb4efda8c69acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076761 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745297}
-
Dominic Mazzoni authored
As requested by this comment: https://chromium-review.googlesource.com/c/chromium/src/+/1970742/7/printing/common/metafile_utils.cc#125 A change to Skia (https://skia-review.googlesource.com/c/skia/+/271816) now lets us use a std::vector for children of a StructureElementNode, rather than a raw array. Now we no longer need custom code to recursively destroy the tree after we write a PDF. Bug: 607777 Change-Id: Iaffa00e4a27d27866cfa57e8f9da51fbdb8f2939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077277Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#745296}
-
liberato@chromium.org authored
Previously, CodecImage::Render...Buffer() methods would dcheck if there was no wait coordinator; this would indicate that it has been recycled before all uses were done. It turns out, however, that it doesn't quite always imply that. During teardown of VideoFrameSubmitter (possibly when the renderer is destroyed, or just the video element), the VideoFrames held by the renderer are dropped. This triggers recycling on the gpu side, and calls CodecImage::NotifyUnused. Unfortunately, nobody ever got any returned resources from viz, so viz might still try to draw with the CodecImage. This CL just makes those calls fail, so we'll just use whatever was in the texture already. Bug: 1054528 Change-Id: Iabe40d92e48f972381145a83e20ce35d1e0bf443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078800 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745295}
-
Ken Rockot authored
This refactors the existing mojom() GN template so that it can support mojom inputs from within the build's generated output directory. The key conceptual change here is that output file paths (like foo.mojom.cc etc) are now derived from the input file's path (relative to source root *or* the root_gen_dir, depending on where the mojom file lives) rather than simply coming from the source file's source_gen_dir (via process_file_template) which is always wrong for paths that are already in the generated output directory. Adds a basic compile/smoke test to verify that these kinds of targets work. This is a precursor to having test coverage for an automated mojom downgrading script. NOTE: This also removes support for the typemap configuration |blacklist| variable which is no longer used and which would have otherwise complicated this CL further. Bug: 1035484 Change-Id: I714929e5f26aeac4eb7b5bf227f99003e971cf01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076710Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#745294}
-
Kenichi Ishibashi authored
ServiceWorkerDatabase::Status is an alias of storage::mojom::ServiceWorkerDatabaseStatus. ServiceWorkerRegistry can't use the alias once ServiceWorkerDatabase is moved to the storage service. ServiceWorkerRegistry should use the original one. Bug: 1055677 Change-Id: Idc8505a53bca5fef17792fe13ac0268489509387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074838 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#745293}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/840d5db64e4d..4017f982cd1d git log 840d5db64e4d..4017f982cd1d --date=short --first-parent --format='%ad %ae %s' 2020-02-27 rwkeane@google.com DNS-SD: Querier Cleanup Created with: gclient setdep -r src/third_party/openscreen/src@4017f982cd1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ibf17f517965f35e586bf78a793612bd50db8c7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079345Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745292}
-
Vasiliy Telezhnikov authored
Few non-trivial problems were discovered with shared images on WebView. For this reason we should disable feature by default and proceed with launching it using finch when the problems will be addressed. Keeping feature enabled by default is not safe for now. VizForWebView depends on SharedImages, so this CL adds EnableSharedImagesForWebView to fieldtrials_testing_config and server-side finch config, but launching EnableSharedImageForWebview will be blocker for VizForWebView. Bug: 1052114, 900973 Change-Id: I562500319dc5ae8b86781654a15aa4e8a8dd59cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079432 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745291}
-
Luciano Pacheco authored
The query and the remvoval are performed in-line, so checking for "contains()" isn't necessary. Bug: 1056443 Change-Id: I86a5dc0601948502b0ce0a94845422b4db07fd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078515 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#745290}
-
Sylvain Defresne authored
This reverts commit 4ed2234c. Reason for revert: causes `gn gen --ide=xcode` to fails with error code 250 when targeting iOS (this is caused by an assertion failure in gn in debug mode resulting in a crash in release), Original change's description: > generate_wrapper targets for iOS' non-EG/EG2 tests, EG, and EG2 tests > > The existing iOS recipe utilizes an isolate template, and an > isolated.gen.json file to fill the template in per test with > config-variables and path-variables. This isolate template contains > the command arguments to invoke the iOS test runner. > > To support the iOS recipe migration to the Chromium recipe, I use GN to > generate a script per test target instead of the isolate template. The > script is pre-baked with arguments to the test runner (run.py). The > given Swarming task is expected to execute the test by invoking the > generated script. > > Invoking the generated script requires changes to gn_isolate_map.pyl > for each iOS test target, and thus, these changes are only additive. > > * "ios_test_runner_wrapper" template wraps the generate_wrapper target. > It bakes iOS specific arguments into the script, such that it can > launch run.py with the given args. > * ios_eg2_test, ios_eg_test, and test templates have > been updated to utilize the ios_test_runner_wrapper for iOS targets. > * mb.py to skip generated_directory check when writing isolates. > View crbug/ in comments. > > Change-Id: I941d37dfdff0bd1ead1baff70907a197fee3fe64 > Bug: 1055328,912681 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023748 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745105} TBR=rohitrao@chromium.org,sdefresne@chromium.org,eugenebut@chromium.org,jbudorick@chromium.org,jeffyoon@chromium.org Change-Id: I649d1051b276738c87ea54633e447ebdadad539f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055328, 912681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078260Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#745289}
-
Brian Sheedy authored
Re-enables conformance/context/context-release-upon-reload.html on Nexus 5Xs. This test was previously flakily crashing, but could not be diagnosed due to an issue that was preventing the minidumps from symbolizing properly. That issue has been fixed, so re-enable to see if the test is still flaky, and if so, get a symbolized minidump. TBR=ynovikov@chromium.org Bug: 1052344 Change-Id: I52fd7769570df3664d2927c325e6e7e5e95c06e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079378Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745288}
-
Changwan Ryu authored
Bug: N/A Change-Id: I8d0e186a866973f977db1f157c58fd53450e3b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073223 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#745287}
-
Ilya Sherman authored
Studies that use the Feature API -- which should be the vast majority of current studies -- do not need to specify a group name that matches the server config. Only the enabled features and params matter. R=rkaplow@chromium.org Bug: none Change-Id: Ic701f3b95af596fc7def453814717dbd4502317c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072117 Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#745286}
-
Hoch Hochkeppel authored
Updates the check used for gating the availability of various commands (CanCreateWebApp) to include a check for the current page being in an error state, correctly reflecting the functionality of the code associated with this check (CreateWebAppFromCurrentWebContents). Currently the only user scenario this changes is the enabled state of the "Creates shortcut" command, but this ensures that any other commands leveraging the same functionality will be appropriately gated as well. Other commands already using this check (such as the command for installing a PWA) are already disabled in the error page state due to additional restrictions. Test: Navigate to an invalid page (e.g. "foo.bar") and invoke More tools > Create shortcut. Without this change, nothing will appear to happen until navigating to a valid page, at which point the "Create shortcut?" dialog will finally appear. With this change the "Create shortcut" menu option will be disabled until you navigate to a valid page. Bug: 1056709 Change-Id: I9cd15876ca9bc1443b776fe8ea326608cd8ea0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063031 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745285}
-
Ahmed Fakhry authored
Auto rotation depends on the tablet physical state of the device, not the UI state. Therefore AccelerometerFileReader should keep reading accelerometer data as long as the device is physically a tablet (detached or flipped). BUG=1056862 TEST=Manually on hatch. Change-Id: I96f6c8f1430fa2d50b20aaa97bd25e072bce098f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079618Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#745284}
-
Henrique Nakashima authored
References were migrated downstream, so these are not needed anymore. Conveniently, this gets rid of the last dependency out of CachedFeatureFlags so it can be moved to a separate module. Bug: 1012975 Change-Id: I4716689255c2c3a8ad641c2716bf7c319353c68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071109 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#745283}
-
Christopher Lam authored
This CL adds a python script that generates a file with CSS Variables that are specified in a JSON5 file. This will allow unified semantic color (and other properties) specification in Chrome OS. Bug: 1018654 Change-Id: I3a427cbb04f59659143739f717689810da661fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041110Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#745282}
-
Peter Kotwicz authored
This CL merges androidx.browser.trusted.sharing.ShareData and WebApkInfo.ShareData Bug=997771 Change-Id: I96ab7e2a25a20594821977cfde194442cb9f6a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069843 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#745281}
-
rajendrant authored
Adds checks for whether navigation is committed and only for http/https navigations. Bug: 1055573 Change-Id: Ib65801efbe1cd66362c885e5b2f0442de65aa918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078784Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#745280}
-
Brandon Wylie authored
This version includes a fix for the crash reported in the attached bug. This change also rolled out to finch, but this will still crash if you build locally with an agsa version earlier than 10.98. Bug: 1053930 Change-Id: I57f83aa1861aba7e6bef58be5a969d13d15ac078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071356 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#745279}
-
Steven Bennetts authored
This CL: * Reduces log spam for "Strength" updates for non active networks. * Reduces redundant log spam for "GetShillProperties". * Increases the lines provided for network feedback logs from 400 to 4000. (Currently feedback logs are ~50000 lines or so, so the relative cost is <10% for critical networking information). Bug: 1054951 Change-Id: Ibac865efe8672b9d972a23371e72f79e39127a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068720Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#745278}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a4f9aa037585..fdf027a728e9 git log a4f9aa037585..fdf027a728e9 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 vapier@chromium.org my_activity: add short url for android CLs 2020-02-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-27 sokcevic@google.com Print content of description backup on exit 2020-02-27 ehmaldonado@google.com git-cl: Add tests for git-cl presubmit Created with: gclient setdep -r src/third_party/depot_tools@fdf027a728e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324,chromium:1056193,chromium:1056309 Tbr: agable@chromium.org Change-Id: I1b66cb222fbb77c5ea7fee609e3793a535971077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745277}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b194b7a67c8..9c9e8d96fb56 Created with: gclient setdep -r src-internal@9c9e8d96fb56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1056809 Tbr: jbudorick@google.com Change-Id: I1cc1a7d7dce812143ecd01ef5402ea1cd76fd399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079286Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745276}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dbb0a25d1fab..a7dc87893807 git log dbb0a25d1fab..a7dc87893807 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 mtklein@google.com add some more instructions 2020-02-27 jvanverth@google.com Add GrD3DUtil. 2020-02-27 jvanverth@google.com Add DXGI_FORMAT to BackendFormat. 2020-02-27 mtklein@google.com bit_and and gather 2020-02-27 robertphillips@google.com Add a GrSimpleMeshDrawOpHelper CreatePipeline method that doesn't require a GrFlushState 2020-02-27 bsalomon@google.com Reset GrGLGpu::fBoundDrawFramebuffer on resetContext 2020-02-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-27 nifong@google.com Add SK_NO_FONTS check around font uses in skottie Created with: gclient setdep -r src/third_party/skia@a7dc87893807 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I9600e205af7cfade0f3e11f3e5169eef6d9c803e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745275}
-
Lei Zhang authored
As is, touching web_ui.h results in ~4000 targets getting rebuilt. Forward declare content::WebUI in some headers, or just remove unneeded web_ui.h includes, reduces the number of rebuilt targets to ~850. Change-Id: Ia55aeb559cc16b16f5b872a7262c51cc3522205c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065433Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#745274}
-
Josh Nohle authored
Screenshot at https://storage.cloud.google.com/chromium-translation-screenshots/7fc580944eb5da2b860990438606d22fd6f90311 Fixed: 1008185 Change-Id: Ia00e85fdd1ebd7108dbb152142c8037a484ed4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008410Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#745273}
-
rbpotter authored
fake_input_method_private.js is also used by browser settings tests, so it should not be in the chromeos/ specific folder. Bug: 1026426 Change-Id: I3c88ce63115463dc2966538c6a2536d41d8d71e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076090 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745272}
-
Bettina authored
The experiment is no longer used anymore. Bug: 1054179 Fixes: 1054179 Change-Id: Ie00127cd5327e3313e7684db25797cd14d58ca70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067563Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#745271}
-
Vasiliy Telezhnikov authored
There is few dependencies between features: VizForWebView requires UseSkiaRenderer and UseSkiaForGLReadback. UseSkiaRenderer requires EnableSharedImageForWebview. Previously we enforced dependencies in AwMainDelegate which involves changing of command line arguments and has two problems: 1. Finch experiments are not initialized yet at that moment, so they have to enable four features instead of one. 2. Command line overrides finch trials flags. This CL changes how we check for features to enforce all dependencies. Bug: 805739 Change-Id: I34f823640f355637ea0b27d1dec1b5afc3e9bec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067349Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#745270}
-