- 03 Jan, 2018 40 commits
-
-
Darren Shen authored
Adds tests for normalizing <url> and <gradient>s. One test is failing because we can't normalize gradients yet. Spec: https://drafts.css-houdini.org/css-typed-om-1/#resourcevalue-normalization Bug: 788570 Change-Id: I40d567a1e94c3ab4f9a3d7c8ca626da7661ac78e Reviewed-on: https://chromium-review.googlesource.com/845244Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#526643}
-
Peter Boström authored
On titlecase systems the "www.example.com Says" heading is awkward, so to end with the URL these are being replaced by "From www.example.com" and corresponding "From an Example Page at www.example.com". Bug: chromium:683346 Change-Id: Ie520328276259f787541a02e39ed725687c1dff6 Reviewed-on: https://chromium-review.googlesource.com/846249Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#526642}
-
chrome://flagsThanh Le authored
Added the link to the flag on chrome://interventions-internals. The value is overridden by the the "Ignore Blacklist" button on chrome://interventions-internals. When all observer removed, the ignore status is reset to the flag value. Doc: https://docs.google.com/document/d/1cyJ-TxBBDdX6GyQzTMNUUzs3Rdis28HhIGsA--YsNxQ Screenshot: https://drive.google.com/a/chromium.org/file/d/1UjyYyJV3JTBg_qJTKT98u-8eruuBmdZR Bug: 793883 Change-Id: I224b6f9b7a3f52d36481e15afeee994f0b68df02 Reviewed-on: https://chromium-review.googlesource.com/841428Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#526641}
-
Matt Giuca authored
JS library load_time_data now properly depends upon parse_html_subset. Bug: 798657 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I70724a633dcf4e3088162693c9bae16fbf8d3468 Reviewed-on: https://chromium-review.googlesource.com/848592 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#526640}
-
Eric Karl authored
When we upload an image and color convert it with Skia, Skia may decide to re-use the original image's texture memory, keeping it in its cache. This change causes the GPU Image Decode Cache to take ownership of and delete this original image, preventing additional caching. Bug: 787182 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: If1522276ba165b3c268a0631d9b7bd2c897489e7 Reviewed-on: https://chromium-review.googlesource.com/830978 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526639}
-
Tom Anderson authored
When using scale factors > 1, it is necessary to set the scale factor on all GtkStyleContext's so that GTK will fetch higher resolution assets. This was only seen on the Breeze theme, because it's the only one that uses bitmap backgrounds. BUG=794358 R=erg@chromium.org Change-Id: Ib2c42e4869156caba94f377b583cbac96f44ad98 Reviewed-on: https://chromium-review.googlesource.com/847683Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526638}
-
Xu Xing authored
Goal is to create resource in LayerTreeResourceProvider and use mapped id in DisplayResourceProvider. Reference document: https://docs.google.com/document/d/1MDrKY4ebi4kQMKOsSbVtDPQnMckja8PjVWut0tC3ynk BUG=793212 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0b23f3e473eff1c6da45b6ed0ed9ab04f9e16eea Reviewed-on: https://chromium-review.googlesource.com/816555Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#526637}
-
Derek Cheng authored
Create the following subdirectories: -- "presentation": to hold classes related to presentation -- "test" to hold mock/test objects -- "providers" to hold in-browser MRP implementations with a subdirectory for each MRP. (providers/wired_display, providers/cast) Attempted to simplify build rules a bit by merging the !is_android rule with enable_extensions rule. Converted some usage of base::Bind / base::Callback into Once/Repeating equivalents. Change-Id: Id71626d2168a3322073d56e6410136d1e7955290 Reviewed-on: https://chromium-review.googlesource.com/840607 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#526636}
-
Sasha Bermeister authored
Remove WebStorageQuotaError and replace users with QuotaStatusCode in WebKit/common. This is pre-work to change all users of QuotaStatusCode to use the mojo enum instead. Bug: 781643 Change-Id: Id2d29fe42cf4217c17a5af1d9d832505b7e9edc7 Reviewed-on: https://chromium-review.googlesource.com/828224 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#526635}
-
Darren Shen authored
Currently we need a secure context mode to call toCSSValue. toCSSValue is used for converting CSSStyleValues to CSSValues. However, there's no reason why we need a secure context mode, since we don't do any parsing. This patch removes secure context mode from toCSSValue. We had to make two changes: - CSSUnsupportedValue takes a CSSValue instead of string. Previously, we would parse a string into a CSSValue, then convert it back into a string to give to CSSUnsupportedValue, which would then parse it again when needed. We can just store the CSSValue instead and parse once. - CSSUnparsedValue::toCSSValue creates a CSSVariableReferenceValue, which requires a CSSParserContext. This makes sense if we need to parse the tokens (e.g. for variable resolution). However, CSSUnparsedValue doesn't parse the tokens (hence its name), so it doesn't make sense to create a CSSParserContext. We added a new constructor to CSSVariableReferenceValue that doesn't take a CSSParserContext. Bug: 545318 Change-Id: I03bf66ab3061e00169ddff99b2a128ae3191f793 Reviewed-on: https://chromium-review.googlesource.com/845253 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#526634}
-
Will Chen authored
My previous CL changed devtools PRESUBMIT to use eslint from devtools-node-modules: https://chromium-review.googlesource.com/c/chromium/src/+/837651 I inadvertently broke the PRESUBMIT workflow for non-Linux developers because devtools-node-modules was only sync'ed for Linux. Bug: 773287 Change-Id: Ib4bd8ca5a3b61b3289057870996f41a52e8f1784 Reviewed-on: https://chromium-review.googlesource.com/848322Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526633}
-
Wei Li authored
Since the SKP file format support can be changed, so does support of MSKP files, we avoid storing MSKP files directly, rather just generate on the fly as we need them. This change is needed as it blocks skia roll on new SKP support https://skia-review.googlesource.com/c/skia/+/90020. BUG= TBR=thestig@chromium.org Change-Id: I45e43dfd39ee157900687b014daa5f0fed56e3b0 Reviewed-on: https://chromium-review.googlesource.com/846472 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Mike Reed <reed@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526632}
-
Tom Anderson authored
BUG=794358 Change-Id: I48f8e5a6f129734a76fad5622bd1680c4946dffe Reviewed-on: https://chromium-review.googlesource.com/847680Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526631}
-
Ryan Sturm authored
This method gets updated whenever network bytes are used, which allows flexibility in tracking larger requests. Bug: 797976 Change-Id: I5a23c09be18af82c049d260d924c0370e4f555cb Reviewed-on: https://chromium-review.googlesource.com/846241Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526630}
-
Emily Stark authored
These histograms record the CT policy compliance of the connection when processing an Expect-CT header and when checking CT requirements for an Expect-CT site on connection setup. Bug: Change-Id: Ib06128448cb9aa2e3b19f50d3d3b5accbfc9fdbd Reviewed-on: https://chromium-review.googlesource.com/846350Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#526629}
-
Gajendra N authored
This CL does a minor cleanup by removing an overridden constructor which isn't required. BUG=None R=msw@chromium.org Change-Id: I3855f5efa83532c53e866c1bb68bcb25b38f5655 Reviewed-on: https://chromium-review.googlesource.com/844304Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#526628}
-
Pavel Feldman authored
This change migrates unguessable tokens' serialization format from `(790345...265EE7)` to `7903415...265EE7`. When unguessable token is used for instrumentation and tracing, it can be used as a handle. Having non-URL characters such as punctuation in the serialized form of the token limits its use and requires it to be escaped / post-processed. If wrapping in () is not essential to the token, I'm suggesting that we drop it. Bug: 778263 Change-Id: Ib88c15c478f6dca89425f272e35893dd399f91fd Reviewed-on: https://chromium-review.googlesource.com/845146Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526627}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/8c3988c59ebe..c8c9a24a117a $ git log 8c3988c59..c8c9a24a1 --date=short --no-merges --format='%ad %ae %s' 2018-01-02 jmadill Entry Points: Refactor generator script. 2017-12-29 oetuaho Simplify creating the call DAG 2018-01-02 jmadill VertexArray: Add enabled attribs bitmask. 2017-12-28 jmadill Entry Points: Speed up auto-gen. 2017-12-20 jiawei.shao ES31: Clean up Program::link 2017-12-06 yizhou.jiang Enable depth buffer to workaround driver bug on Intel windows 2017-12-12 oetuaho Clean up creating constant folded nodes 2017-12-20 oetuaho Unify looking for symbols with a specific name in the AST 2017-12-13 jiawei.shao ES31: Support struct arrays as Geometry Shader inputs Created with: roll-dep src/third_party/angle BUG=782317 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I928d4f21878a87834bff362e3a405c40b8fdadb1 Reviewed-on: https://chromium-review.googlesource.com/848375 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526626}
-
Jaebaek Seo authored
Enabling --use-zoom-for-dsf needs a conversions between integer values and float values for Android WebView contents size (See AwContents::OnWebLayoutContentsSizeChanged()). The previous code adopted ceiling for those conversions, which resulted in test failures of AndroidViewIntegrationTest. This CL adopts rounding for those conversions instead. Bug: 737777 Change-Id: I8b22981c0d94ff983e4d8d4254b0c4155892d5d8 Reviewed-on: https://chromium-review.googlesource.com/832326Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526625}
-
Pavel Feldman authored
We added logic to block cross-site documents from renderer processes when Site Isolation modes are enabled. This helps prevent sensitive information from leaking to a process that doesn't need access to it. It would be helpful to web developers to have a console message when a blocking event occurs explaining what happened and why. Bug: 793937 Change-Id: Ia6e4b8095a925b8580a044421021810565ea66d8 Reviewed-on: https://chromium-review.googlesource.com/833218 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526624}
-
Jennifer Apacible authored
This adds a button in the media controls for the picture in picture feature. This is currently behind a flag and currently doesn't do anything. Bug: 726619 Change-Id: I2cb3151769016ff4e5c26fb6eb2319bdeab2fcae Reviewed-on: https://chromium-review.googlesource.com/832949 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#526623}
-
Pramod B S authored
Required [Exposed] to get rid of [PrimaryGlobal] Spec: https://github.com/heycam/webidl/issues/365 Bug: 792432 Change-Id: I4ed66ed7116eaf4ded7d07d991c81c01e827ca1c Reviewed-on: https://chromium-review.googlesource.com/847393Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#526622}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/57c2b8b16ab9..ecdadd98e0ae $ git log 57c2b8b16..ecdadd98e --date=short --no-merges --format='%ad %ae %s' 2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ c8c9a24a1..910a3dafd (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ia6791719a0a64297bc2816f1474647320def1808 Reviewed-on: https://chromium-review.googlesource.com/848325Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526621}
-
Tarun Bansal authored
Also increase the network quality store size from 10 to 20 to match the maximum prefs size. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Bug: 798568 Change-Id: I5c0957adbd201e3ef52102032ec5c0f207132367 Reviewed-on: https://chromium-review.googlesource.com/846252 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526620}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/94dc17710fd7..fa2260d08dcf $ git log 94dc17710..fa2260d08 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,b/69623057 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id152074370c9b206ea55eab4ed889fa124df69ad Reviewed-on: https://chromium-review.googlesource.com/848235Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526619}
-
Qiang Xu authored
changes: Implement WindowState::OnWindowAddedToRootWindow to handle MoveAllTransientChildrenToNewRoot. Bug: 789249, 778438 Test: emulator tests and added test coverage Change-Id: I9c4633902aaaca9da094c6398a4957f680a430df Reviewed-on: https://chromium-review.googlesource.com/804918 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#526618}
-
danakj authored
The IOSurface textures for RenderPasses do this, citing bug 146070. We can do the same for the RenderPass textures. This affects any pixel tests that have anti-aliasing, as the float value of texcoords is changed. So we have to add anti-aliased versions of a few pixel tests, and rebase a number. R=ccameron@chromium.org Bug: 146070 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I41628534048b526afb2ac02378d71c329cc02344 Reviewed-on: https://chromium-review.googlesource.com/841284 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526617}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: If609357050a82bcc3f8e1e8dda3595b35c93c0e4 Reviewed-on: https://chromium-review.googlesource.com/848073Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#526616}
-
Eric Lawrence authored
The security interstitial bypass keyword hasn't changed in two years and awareness of the bypass has been increased in blogs and social media. Rotate the keyword to help prevent misuse. Change-Id: Id3250926afbc98241e9390420ccb68765e618ce6 Bug: 797344 Reviewed-on: https://chromium-review.googlesource.com/843085 Commit-Queue: Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#526615}
-
Yafei Duan authored
This CL is depending on the CL of switching OfflinePageModel, and trying to address the issue of perf regression and increased crash rate during CreateArchiveTask. After code review, this CL will merge with 845261 as reland of 833495. This CL contains: - Removing CreateArchiveTask and moving all its logic into OPMTaskified. - Changed when ClearCachedPages is called in OPMTaskified, to make it exactly same with OPMImpl to see if this will fix perf regression. If not, it might be the issue of database closing. Bug: 797628, 797423 Change-Id: Ib810d48637802c82713dfc506d05a14b69110170 Reviewed-on: https://chromium-review.googlesource.com/847684 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#526614}
-
chrome://flagsLeo Zhang authored
Bug: 727436 Change-Id: I2ca1864627998febcae1cbd68c5a4308481fd5ad Reviewed-on: https://chromium-review.googlesource.com/838800Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#526613}
-
David Bokan authored
When an element is position: fixed to the bottom of the screen, hiding the URL bar produces a transform in the compositor so that the Element appears to stay fixed to the viewport bottom. This is because, as the URL bar is hidden, the viewport height is expanded. However, this expansion happens entirely in the compositor. Until the user releases their finger, Blink will not get a resize so the Element won't get be repositioned with the updated viewport height. With root-layer-scrolling, the root scroller becomes the root PaintLayer. We previously carved out exceptions for the root layer since its scrolling was delegated to special "frame scrolling" layers in the compositor. This patch removes these exceptions and marks the LayoutView's scrolling layer as being a "position fixed container" so that position: fixed Elements use it as their container. It also marks this layer as being affected by URL bar resizes so that we apply the above-mentioned URl bar transform. Bug: 798434 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I69623c619471ced826aa61340d946a0eeb0110ae Reviewed-on: https://chromium-review.googlesource.com/847458Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526612}
-
Ryan Landay authored
We currently don't allow grapheme clusters to be split after Indic virama characters (this seems to be a custom deviation from the grapheme cluster rules in UAX #29). According to a Googler familiar with Indic languages, this behavior is correct for other Indic languages, but not for Tamil ("Tamil is an exception because it doesn't compound glyphs to form a single glyph when combining a pure consonant with a vowel+consonant combo.") This is causing at least two problems: 1. It's not possible to put the insertion point between certain pairs of Tamil characters when typing (crbug.com/693687). 2. Inputting Tamil with phonetic keyboard IMEs is super broken (crbug.com/675477). This CL fixes both of these problems by treating the Tamil virama character differently from other Indic viramas. Note: this does *not* address the issue in crbug.com/792713 where the Tamil handwriting IME on Android inserting lone SpacingMark characters triggers odd behavior. Bug: 675477, 693687 Change-Id: Iae95e70418aeadcbab5296245ad7253cf3c31cde Reviewed-on: https://chromium-review.googlesource.com/843461Reviewed-by:Emil A Eklund <eae@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#526611}
-
Will Chen authored
This test is quite flaky because it was unintentionally dumping an internal object property that's unstable between runs instead of the actual object contents. Drive-by: removes extraneous method definition for ApplicationTestRunner.addIDBValueAsync Bug: none Change-Id: I749bb2d1379aa0658e590caeb9cd6d6773c59021 Reviewed-on: https://chromium-review.googlesource.com/846253Reviewed-by:
Eugene Ostroukhov <eostroukhov@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526610}
-
Jonathan authored
Updating the filter file for new failures that have been found. TBR=kylechar@chromium.org Bug: 794961 Change-Id: Idd96cb7029e2c16038cb3e1d43dd3a4f2573c244 Reviewed-on: https://chromium-review.googlesource.com/847422Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#526609}
-
Matt Reynolds authored
Haptics on Dualshock4 devices are typically not supported by OS-level haptics APIs, so in order to support vibration effects on these devices we issue device-specific reports using the raw HID protocol. Dualshock4ControllerBase implements the common logic for creating the report buffer from the vibration intensity values. Users should implement WriteOutputReport to provide the OS-specific logic for sending the report to the device. BUG=749295 Change-Id: I742316f385235b44c0658dd9e571fa73cf4f496e Reviewed-on: https://chromium-review.googlesource.com/810053 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#526608}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/bd319d25b886..7365f0261183 $ git log bd319d25b..7365f0261 --date=short --no-merges --format='%ad %ae %s' 2018-01-02 dtu [pinpoint] Add subdirectories for job-page and jobs-page elements. 2017-12-22 dtu [pinpoint] Shorten pinpoint element paths. 2017-12-27 erikchen Add explicit --is-local-build flag. 2018-01-02 mheikal Catapult: Manifest parsing now works with xml namespaces stripped 2018-01-02 eakuefner [TBMv2] Smoke test diagnostic equality in JS 2018-01-02 bokan Remove gesturesExpectedInViewportCoordinates branches 2018-01-02 eakuefner Stop merging by tags in add_reserved_diagnostics 2018-01-02 perezju [Telemetry] Fix binding to devtools agent on CrOS after login Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie1097cf9cdf898208274b57bf1d998e4369bef43 Reviewed-on: https://chromium-review.googlesource.com/848023 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526607}
-
Vladimir Levin authored
This patch removes at raster decode flag, which is only used in tests. R=enne@chromium.org, chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I1f8f81856c12c8f521a6e57268d35430dc3135c7 Reviewed-on: https://chromium-review.googlesource.com/848302Reviewed-by:
enne <enne@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526606}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/e8bb6da08dc6..57c2b8b16ab9 $ git log e8bb6da08..57c2b8b16 --date=short --no-merges --format='%ad %ae %s' 2017-12-31 reed remove unused declarations Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I747c70ab678ea9e324c1b794d44d9a71140a6f25 Reviewed-on: https://chromium-review.googlesource.com/848310Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526605}
-
Jonathan authored
The gn_isolate_map to telemetry_perf_unittestes_viz doesn't work as there is no associated build target. Providing an executable override doesn't seem to resolve this. I'm removing the config to get the Linux Viz bot back up and running until the error can be sorted out. TBR=dpranke@chromium.org Bug: 795760 Change-Id: I28dd3bc515aaa16bae59258ba0b1bb0b42ac4676 Reviewed-on: https://chromium-review.googlesource.com/846231Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#526604}
-