- 23 May, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/9674a1a54754..7f4277e21b52 git log 9674a1a54754..7f4277e21b52 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 johnkslang@users.noreply.github.com Merge pull request #111 from Naghasan/codeplay-range Created with: gclient setdep -r src/third_party/spirv-headers/src@7f4277e21b52 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I7ed14d2401f3b5e4f898d2546406390e3d1ae36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627306Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662855}
-
Scott Violet authored
Specifically OnWallpaperPreviewStarted. As this function is called async, it's entirely possible for there to be no active window. BUG=940322 TEST=none Change-Id: I551e7d10a4293ba2e3cb047114661393d873dce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628034Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#662854}
-
Emil A Eklund authored
Fix DCHECK in ComputeAbsoluteHorizontal and ComputeAbsoluteVertical that doesn't work when either of the values are saturated yet failed to check one of the values prior to the DCHECK. Also added if DCHECK_IS_ON guard. Bug: 966563 Change-Id: I54b4a3f0b8b94fd86245401c76fc0abe80444671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625819Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#662853}
-
Sébastien Séguin-Gagnon authored
The Send to your Devices activity should be offered right next to the copy activity. Bug: 966523 Change-Id: I2e8855fbd0894ed6ff7499f55a8cee8eca4e4a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627657 Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662852}
-
Alex Cooper authored
The code has supported updating inlineVerticalFieldOfView for a while, but has always used a hard-coded default. This change exposes the ability for a webpage to update or read this value, and changes the default value to match the specced 90 degrees (pi/2) requirement. As part of this change, magic-window is also updated to adjust this value. Bug: 953412 Change-Id: I583935c487ee58a0a588e5161e66976a3c0e9675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625924 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662851}
-
Hector Carmona authored
Moved icons: - gmail.png - maps.png - news.png - translate.png - youtube.png Bug: 950188 Change-Id: Ib1b5fad4be494dae18517865a11003412c0a1bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626732 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#662850}
-
May Lippert authored
Bug: 950007 Change-Id: I6185c0911ebf520a1634cd5c632eadedad7912c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627815 Auto-Submit: May Lippert <maybelle@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662849}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/37e000347c2f..63ab0c82ecf5 git log 37e000347c2f..63ab0c82ecf5 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 Max) Gu [FCP++] Filter loading image and text candidate Created with: gclient setdep -r src/third_party/catapult@63ab0c82ecf5 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:960365 TBR=eyaich@google.com Change-Id: Ib8f6eafc409cafb547f4540a414458ba05efc0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627954Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662848}
-
smut authored
Bug: 966276 Change-Id: I347386b75c3f595050248f33993fc48f893ef2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626808Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#662847}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/07a101971791..b8fe7211c465 git log 07a101971791..b8fe7211c465 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 43557651+sparmarNV@users.noreply.github.com Allow arrays of out per-primitive builtins for mesh shaders (#2617) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b8fe7211c465 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Id729f12078936102a548bdd5416955018878d6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627858Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662846}
-
Lucas Tenório authored
The tests were flaky due to a race condition with the HTTPSForwarder initialization. By performing a login before the SetUpOnMainThread exits we can eliminate that problem. Tested on my machine by doing about 80 runs for all tests. Bug: 965369 Change-Id: If86b03f82ad0482d1098aad26613466118b7fcf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627453 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#662845}
-
John Chen authored
On Mac, the --use-mock-keychain is needed by the network service to load the correct keychain. Bug: 960926 Change-Id: Icae42bc00198e6178de923b23598101248e1add1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627937 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#662844}
-
Alex Cooper authored
The current implementation of the OpenVRGamepadHelper always adds the optional grip and secondary axes buttons; however, if those buttons are missing and no additional buttons need to be supported, they should not be included. A prime example of this is the vive controller, which has a trigger, a grip, and a touchpad, but no secondary axis button. This is essentially the controller that the new TestGamepadOptionalData test builds. Bug: 964026 Change-Id: I1de93b5bd7bd0d9e75013cf33b8f333e5d70270f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627914Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#662843}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/35a5a9e7beddb9cec70d7bc1b70a6ac441093f87..2e0d354690064c90ee245c715b92e2bb32492571 This picks up the AMD workaround and the 0-RTT change to help with measurement. Bug: none Change-Id: I89972affc3532a7acd70c90d588d13b94ccef275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627940 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#662842}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/617f67de972a..b0016cc731ae Created with: gclient setdep -r src-internal@b0016cc731ae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: I566be8b5a2d37de607dbb003f8add5ceee395314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627957Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662841}
-
Tommy Steimel authored
This CL changes MediaNotificationBackgroundTest to be a subclass of testing::Test instead of AshTestBase. This makes the test independent of Ash code and ready to be moved out of Ash. Bug: 959478 Change-Id: I5ca7648abab8ce392c300f9a3dd69f920f24aeb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627652Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662840}
-
Nick Burris authored
Android scrollbars can't be interacted with by user input. This change makes the SolidColorScrollbarLayer explicitly not hit testable to ensure we don't enter any scrollbar scrolling code paths. Also updated a few tests in layer_tree_host_impl_unittest.cc that were using a SolidColorScrollbarLayer as a generic (hit-testable) scrollbar layer, which should instead use a PaintedScrollbarLayer. Bug: 954366 Change-Id: Icae9f43e043c412603d30330386710bf59482fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601348 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662839}
-
Eric Willigers authored
Web Share has an accept list for MIME types and file extensions. When a file share attempt fails because a file has a MIME type or extension not an accept list, we now log an error. BUG=965461 Change-Id: Ic860ba6842c5fe1cf09bad3de9a4f3e99ce304e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623656 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#662838}
-
Qingsi Wang authored
service and ignore msg-too-big read errors. Blocked packets are buffered in a send queue with a limited capacity, and are flushed after the previous send is complete. We originally remove a socket when it encounters read errors and reboot the service when no socket left. The msg-too-big error will be ignored after this change. Bug: 933869, 964951 Change-Id: I3665dd732526591f350834757bc0e6d1c0d6b3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617614 Commit-Queue: Qingsi Wang <qingsi@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#662837}
-
Azeem Arshad authored
This CL fixes issue with Auto connect toggle button toggling for other networks. This was caused because the updates to fake pref objects that control this toggle is not propagated down to the children, thus the toggle maintains same value from last network detail page. Fixed this by updating the entire pref object instead of just the value sub-property. Bug: 957224 Change-Id: Ic95c2b0ed9f77d9547114fe01acfcc18023c38fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622415 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#662836}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6768b27cc897..d2e8e116faf1 git log 6768b27cc897..d2e8e116faf1 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d2e8e116faf1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I720cf4570459ebe14c5103660bab0594dda69722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662835}
-
Andrew Grieve authored
Found this was necessary for system_webview_shell_layout_test_apk, which doesn't have any native code, but the underlying webview apk does. Bug: 853280 Change-Id: I6a3559d41309c22c1cc4027f7387b619d04b7e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627935 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#662834}
-
jonross authored
In order to support Mus, we added a series of methods to allow Aura to request the allocation of a new LocalSurfaceId. This allowed both aura/mus and cc/ to generate these Ids. As Aura was not responsible for ParentLocalSurfaceId allocation, the Window Service was. With the removal of Mus, this code path is no longer needed. This change reverts that path. Leaving cc/ solely in charge of child allocation. This change is a merged revert of four changes: Revert "chromeos: gets aura as mus client library working with client ids" This reverts commit 2b5a978b. Revert "chromeos: gets aura as mus client library working with client ids" This reverts commit 2b5a978b. Revert "cc: provides function to synchronously allocate LocalSurfaceIds" This reverts commit 39db70bb. Revert "Call function when LayerTreeHostImpl generates a LocalSurfaceId" This reverts commit 7a340f40 TEST=cc_unittests Bug: 958239 Change-Id: Ie81d68f9dc6a6ff0bc57acccc5e9182bf819af95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625394Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#662833}
-
Ned Williamson authored
This CL contains a basic fuzzer for WebGL shaders that shows some essential design ideas: 1) a protobuf spec defines how shaders will be generated 2) conversion from protobuf message to shader string is provided in its own library that has unit tests 3) we add a basic fuzzer to compile shader programs using libANGLE This is by no means complete and serves as a foundation for the fuzzer so subsequent CLs will be easier to review. Later CLs will slowly complete the core grammar for GLSL before incorporating some more complex testcases from the Khronos compliance suite. BUG=900487 Change-Id: I67df52a73926d22637afad9a966790f34011175c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623556 Commit-Queue: Ned Williamson <nedwill@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#662832}
-
Shivani Sharma authored
This is a temporary fix so that the intervention does not break back button for pdfs. The root cause is that mouse click on pdf is not considered a user gesture (crbug.com/934637). Once this is fixed, then this CL's changes can be removed. Bug: 965434 Change-Id: I15d8392e98d1578a1c30f242c847fbcf8e4bd8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623137 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662831}
-
Vincent Boisselle authored
This reverts commit a2d78e6e. Reason for revert: breaks components_unittests:AutofillDownloadManagerTest.QueryAPITestWhenTooLongUrl unittest in android-kitkat-arm-rel See https://ci.chromium.org/p/chromium/builders/ci/android-kitkat-arm-rel/17779 Original change's description: > Reland "Reland "Added handling of large requests to Autofill API."" > > This is a reland of 4149e2e9 > > Original change's description: > > Reland "Added handling of large requests to Autofill API." > > > > This is a reland of c6677df1 > > > > Original change's description: > > > Added handling of large requests to Autofill API. > > > > > > Increased the limit of Query GET requests, added a POST Query fallback, and > > > added UMA metrics to keep track of URL length and associated events. > > > > > > This change might be needed when metadata is enabled. > > > > > > Bug: 948862 > > > Change-Id: If0934a685758ab8999ceea6ce22a27499e4f772f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549615 > > > Commit-Queue: Vincent Boisselle <vincb@google.com> > > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#656080} > > > > Bug: 948862 > > Change-Id: I29eee8f16ae6c3775eb31e8e95d4a289c31f1485 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594618 > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > Commit-Queue: Vincent Boisselle <vincb@google.com> > > Cr-Commit-Position: refs/heads/master@{#656452} > > Bug: 948862 > Change-Id: I8fdc33c0e496862232dfed6e13349e55fbd36e07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594190 > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Commit-Queue: Vincent Boisselle <vincb@google.com> > Cr-Commit-Position: refs/heads/master@{#662780} TBR=rogerm@chromium.org,ftirelo@chromium.org,vincb@google.com Change-Id: I0f5f9fb013fcb17b443e0def188f237707dfa5c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628032 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662830}
-
Chris Morin authored
Simplify the upgrade failure handling by ignoring the result of the dbus call, and instead waiting for the ArcInstanceStopped signal before signaling a failure. Also check for disk space in Chrome instead of in session_manager. This is the first change in a series that will have Chrome call to Upstart directly to start the container, cutting out session_manager entirely. BUG=b:133248517 TEST=Run test cases and manually test container startup/shutdown. Change-Id: I7c5ef4be82b5fbb2deca1fae7a2a0ebc06952e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623631 Commit-Queue: Chris Morin <cmtm@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#662829}
-
Robert Ma authored
* Also fetch DETAILED_ACCOUNTS in query_cl to make sure we have owner info (altough currently the only user of that method doesn't need it). * Do not fetch DETAILED_LABELS as we never use it. * Extract query options into a constant now that two methods use the same options. * Exclude WIP CLs in query_exportable_open_cls and get up to 500 CLs to reduce the chance of missing in-flight exportable CLs. Change-Id: I308f6d8e730940b15f40fdb0aa2d61f9b86d6369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626301 Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#662828}
-
Jon Mann authored
Bug: 966270 Change-Id: I12169fe0f9e56364c7839521e478008faf3be604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626638 Commit-Queue: Jon Mann <jonmann@chromium.org> Auto-Submit: Jon Mann <jonmann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#662827}
-
Dana Fried authored
Make sure that the callback is not null, and that we use the widget that is reported being closed rather than calling GetWidget() - just in case the view has somehow come unglued from the widget. I really can't think of any other way this could crash. Bug: 966308 Change-Id: Ic0c2ee9adb8b1e26326c1300238db058e5022819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627817 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#662826}
-
Maksym Onufriienko authored
Added closeCurrentTab in smoke_egtest. Bug: 922813 Change-Id: I79f5066d068f38b97af4527b6c2b1562bd2a3a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625849 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#662825}
-
Dmitry Titov authored
Change-Id: I5f4a016bb924eaf227f4df23b1ffae37bc02cc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625815 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#662824}
-
Stephen Martinis authored
This is (as far as I know) the first time chromium is using containment, so I'm enabling on a bot which shouldn't affect the CQ that much. Once this lands, I'll enable on the rest of the CQ bots. Bug: 965222 Change-Id: Ie0f85f50eec68c4de89f12047209b9ad570ec129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626149Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#662823}
-
Andrew Grieve authored
This flag doesn't exist, and so test_runner.py has been passing it through as a chrome flag to tests :P Change-Id: I562e5c62a9a3fa7caf4b7bdfd49713d0f21d7774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625837 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662822}
-
Morten Stenshorne authored
A video element creates some children (flexboxes, etc.), and the video ought to be their containing "block" for all purposes, but LayoutVideo is not a LayoutBlock (it's LayoutReplaced), so it doesn't really work. Make sure that we don't skip upwards and escape from the innards of the video element and start adding percentage descendants to blocks that are not in the containing block chain of the video (the video may be out-of-flow positioned). Bug: 965032 Change-Id: Ic9fdb7b9dcff5724b9488d85dfafc9c87f4bee62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622806Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#662821}
-
Aga Wronska authored
Bug: 963696 Change-Id: Ib60cbe41bdd99d45625e6b0950c6bda738a06349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611026Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#662820}
-
rbpotter authored
Rename canUsePolyfill -> can_use_polyfill Bug: 925517 Change-Id: I0a5575f1193f4379c4cc8cd5fcc4ba1214145d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627854 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#662819}
-
Lily Chen authored
This change adds a virtual test suite which enables CookiesWithoutSameSiteMustBeSecure and adds a new tentative test to test that (with the feature enabled) cookies with SameSite=None must have the Secure attribute, and will be rejected otherwise. Bug: 961439 Change-Id: Icd99b6fc9ef38f72b648fb81f3fd0aa241e75a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612052 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#662818}
-
Abhishek Arya authored
R=rnk@chromium.org Bug: 915245 Change-Id: I715d3e0ea051e1032722e77795c11e58875b7413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627810Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#662817}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d9fa0744e82b..6bb193c86a9a git log d9fa0744e82b..6bb193c86a9a --date=short --no-merges --format='%ad %ae %s' 2019-05-23 spang@chromium.org Vulkan: Implement glImportSemaphoreFdEXT Created with: gclient setdep -r src/third_party/angle@6bb193c86a9a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: Ie88022a70fc0e00f19abf48115aaa277a4f9ac15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627951Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662816}
-