- 03 Jan, 2018 40 commits
-
-
Reilly Grant authored
The only production implementations of the OnTunnelConnectCompleted, OnBeforeTunnelRequest and OnTunnelHeadersReceived are empty. They are used however in http_proxy_client_socket_pool_unittest.cc which has had to have some test expectations removed. This effectively reverts r294252 as DRP's custom HTTP headers are now added by the DataReductionProxyNetworkDelegate instead of the DataReductionProxyDelegate. Bug: 721403 Change-Id: Ifb683e7fc28e97efc7182df1a33bf46f1b74a7ec Reviewed-on: https://chromium-review.googlesource.com/846261Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526757}
-
Yuri Wiitala authored
A recent change(*) switched a shmem buffer Clone() call from READ_WRITE to READ_ONLY. New VIZ tab capture implementation depends on the special semantics of the READ_WRITE argument, only in-so-much as it avoids a crash due to what looks like a design flaw in base::SharedMemory (details in crbug). This change reverts the call point, until a long- term solution can be worked out. Testing: Confirmed that the change works with both tab capture and USB webcam capture. * See: https://chromium-review.googlesource.com/820011 and http://crbug.com/793503 Bug: 797470 Change-Id: I9bffdd0b71cbfa37b6b5bda03ce8863b560d8747 Reviewed-on: https://chromium-review.googlesource.com/848239Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526756}
-
xdai authored
It's a follow-up CL of https://chromium-review.googlesource.com/c/chromium/src/+/820854. Bug: 791654 Test: Manual, browser_tests Change-Id: I7e04a6839d1af6897a560a9875280ea7a2c18004 Reviewed-on: https://chromium-review.googlesource.com/833486 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#526755}
-
Daniel Bratell authored
There are two overloaded GetRestrictedCookieManager functions in different files which in certain non-standard jumbo configurations end up in the same translation unit. When that happens, base::Bind doesn't know which one to use and there is a compilation error. This patch renames one of them GetRestrictedCookieManagerForWorker so that there will never be any confusion. Bug: 746953 Change-Id: I7b3e6ba32aed44e575ee108111871e45b5e2689c Reviewed-on: https://chromium-review.googlesource.com/847010 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#526754}
-
Sky Malice authored
This results in a regression, in the sense that we're going to be worse at syncing custom tabs because of this change. The problem was that we could assign the same sync id to two seperate tabs on Android when the main windowed of Chrome was not fully loaded. To fix this, this CL stops giving out sync ids if we don't have full native data. While refactoring the checking for a tabbed window, realized that it's possible to get all null tab objects, and this should be treated as not having native data as well. Bug: 639009, 797452 Change-Id: I0f477326b9d2c3fa526399623f089a791f1b3046 Reviewed-on: https://chromium-review.googlesource.com/843574Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#526753}
-
bsheedy authored
Finally adds some Markdown documentation files about VR instrumentation and browser tests. Specifically: * The VR test framework * VR instrumentation tests and rule parameterization * Notable differences between VR instrumentation and browser tests Bug: 756261 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib55c034d2cc41a86ff095aba327ebf0f52a5b752 Reviewed-on: https://chromium-review.googlesource.com/848028Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526752}
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:628174 Change-Id: Ibee6850f5f58296eec80097dc2c74aa1237a6c31 Reviewed-on: https://chromium-review.googlesource.com/848321 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526751}
-
Gabriel Charette authored
Proper MessageLoop::IsIdleForTesting() that corresponds to the actual idleness criteria for MessageLoop. A pre-requirement for a simpler ScopedTaskEnvironment::RunUntilIdle() implementation. R=fdoray@chromium.org Bug: 708584 Change-Id: I6c35d72868ab313788c166c76e179c8cd3ace438 Reviewed-on: https://chromium-review.googlesource.com/847752Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#526750}
-
Daniel Park authored
Sets attributes flags to secure if there is an incognito tab visible on the screen using TabModelSelectorObserver & OverviewModeObserver Bug: 764599 Change-Id: Iac33dd9cad83a697316f7f925bcbb80444e54b4a Reviewed-on: https://chromium-review.googlesource.com/809508 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526749}
-
Reid Kleckner authored
Created by patching in https://chromium-review.googlesource.com/c/chromium/src/+/835358 and manually editting the revision in update.py. TBR-ing rsesek@ again for the sandbox changes. TBR-ing bretw@ again for the ppapi adapter LLD warning suppression. I will manually build and test net_unittests after uploading to goma, but I've built this clang revision locally and they are not flaky for me. R=inglorion@chromium.org,hans@chromium.org TBR=rsesek@chromium.org,brettw@chromium.org Bug: 787920, 797267, 797168 Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_mips_dbg;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: Ifd25c014e79ad7a5d4533941ae7fd74a86860191 Reviewed-on: https://chromium-review.googlesource.com/845700Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526748}
-
Troy Hildebrandt authored
When updating the menu item spacing for the Chrome Home bottom navigation menu, we were checking the length of a potentially null array so a null check has been added. Bug: 796185 Change-Id: I1382aace706ad2b0ffb13e9c84bf78efc7284ceb Reviewed-on: https://chromium-review.googlesource.com/848242 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#526747}
-
danakj authored
This is a reland of 5c4d3d4a The IOSurface textures for RenderPasses do this, citing bug 146070. We can do the same for the RenderPass textures. This affects any pixel tests that have anti-aliasing, as the float value of texcoords is changed. So we have to add anti-aliased versions of a few pixel tests, and rebase a number. TBR=piman Bug: 146070 Change-Id: I7b1c86f821b86485c571d5b97e0e22f04705d99a Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/848354Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#526746}
-
Dave Tapuska authored
Invalid input should be thrown out not cause a crash of the browser. BUG=772626 Change-Id: I26128ff4491987cb6798f7f0f0078102c44dca43 Reviewed-on: https://chromium-review.googlesource.com/847305Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#526745}
-
Xianzhu Wang authored
I'm investigating the flakiness. According blink-dev discussion we should skip flaky tests instead of marking them flaky. Bug: 798116 Change-Id: I9d2fcf31ab2475169c97108bc0d2c02c242c7658 TBR: battre@chromium.org Reviewed-on: https://chromium-review.googlesource.com/848274Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526744}
-
Rouslan Solomakhin authored
Bug: 792961 Change-Id: I9643f51f355711af731e2e77021d50598099327c Reviewed-on: https://chromium-review.googlesource.com/849152Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526743}
-
stkhapugin@chromium.org authored
Removes almost all usage of scoped_nsobject in ios/. Bug: 717540 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ide8fc8476e2dccaa91ba2311cdf5bb06b91d3779 Reviewed-on: https://chromium-review.googlesource.com/846805Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526742}
-
Steven Bennetts authored
This CL: * Moves a bunch of related DisplayManager and DisplayConfigurator code to a separate InitializeDisplayManager method to help improve managability of Shell::Init. * Renames ShutdownObserver -> DisplayShutdownObserver. * Removes unnecessary DBusThreadManager dependencies from shell.cc. * Moves observer responsibility from Shell to ProjectingObserver Bug: 678949 Change-Id: I07159d0562bc032f03c653beb927ab8aaf053bbc Reviewed-on: https://chromium-review.googlesource.com/833500Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#526741}
-
Ryan Landay authored
This CL fixes a bug where using Find In Page to search for text in an element using a :first-letter CSS psuedo element highlights one extra character at the end of the result text and skips a character at the beginning. We have the same bug in the function we use for other marker types (e.g. composition and spelling) so I'm fixing it there too. There's still another issue that this CL does not fix that prevents the first letter itself from becoming highlighted. I am not yet sure what else needs to be changed to fix this. Bug: 798004 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If1f09dd5485be8f2817e06b3b3ef65f8b1bb11ec Reviewed-on: https://chromium-review.googlesource.com/847834Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#526740}
-
Sidney San Martín authored
r526520 started including a bookmark button's inset when calculating its width. This turns out to change the layout and, because the inset is cr_lineWidth, there's no way to pick padding constants which make the padding and spacing the same on retina and non-retina. The inset (which comes from GradientButton) isn't really used in MD, so overriding insetInView: to return zero gets the right behavior back. This class's layout code could still use cleanup. Bug: 796836 Change-Id: I52741d9fb92db92fa07ba8b27077d8451383a47f Reviewed-on: https://chromium-review.googlesource.com/848032Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526739}
-
Michael Lippautz authored
The limit was defined as ~0ul (unsigned long) which is unsigned 32bit on Windows 64bit and thus extended with 0 for uintptr_t. This results in bogus return of StackFrameDepth::IsSafeToRecurse of true even though recursion might be disabled due to stack pressure. This reverts commit e5d92d31. Tbr: haraken@chromium.org Bug: chromium:798479 Change-Id: Id7a897af323e230e11c7a1417f383bc868f6fe05 Reviewed-on: https://chromium-review.googlesource.com/848896Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#526738}
-
Bin Zhao authored
It seems possible that socket is closed but not removed from CastSocketService. Calling send() on a closed socket may cause crash. Added a check. Bug: 784899 Change-Id: I9f0af39a10194321395213d167a09a947619fde2 Reviewed-on: https://chromium-review.googlesource.com/846240Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526737}
-
Gabriel Charette authored
Partial reland... keep StartWatching() calls to try to isolate the issue This is a reland of 91c22dbf Original change's description: > Remove hang watching of deprecated BrowserThreads. > > This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/705775 > > That CL caused issue 768886 (spike in hang reports). I suspect this > was caused by a change in enum IDs rather than this change to the > hang watching code and this CL will help narrow down the cause. > > R=asvitkine@chromium.org > > Bug: 689520,768886 > Change-Id: Id7bf1c7b5f5d34c4b1e7b1e71e9b015725695997 > Reviewed-on: https://chromium-review.googlesource.com/743846 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512509} Bug: 689520, 768886 Change-Id: I138fc4b33e6316496ff35e927b2cfb5246b53a6d NOPRESUBMIT=TRUE (shuffling of code using deprecated BrowserThread IDs) Change-Id: I138fc4b33e6316496ff35e927b2cfb5246b53a6d Reviewed-on: https://chromium-review.googlesource.com/848355Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#526736}
-
Sadrul Habib Chowdhury authored
The root windows should use the FrameSinkId of the compositor. In regular aura, compositors get valid FrameSinkId from context_factory_private(). If window server is hosting viz, then use the id from that. BUG=754872 Change-Id: I7b1de89f9575ebd532042ffcd0b3a8058d85f251 Reviewed-on: https://chromium-review.googlesource.com/847333 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526735}
-
Rouslan Solomakhin authored
Bug: 781291 Change-Id: I4405edc4e76f3c00b4ea83eab07b3387edc7a80f Reviewed-on: https://chromium-review.googlesource.com/849155Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526734}
-
Xing Liu authored
This CL introduces a backend that uses URLFetcher and save in memory download data to a blob. Currently there is an issue that only content/browser uses storage::BlobStorageContext and content/public does not expose it. Only BrowserContext::CreateMemoryBackedBlob does the browser side save blob task for media API, which only expose the UUID in content::BlobHandle. Bug: 95809 Change-Id: Iac93952dd9a73a8c3eba6e6a1d1bf642a9a0d50f Reviewed-on: https://chromium-review.googlesource.com/833026 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#526733}
-
Mark Cogan authored
As of iOS 9, it's not necessary to stop observing notifications on dealloc. Bug: 798685 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib1a330d9dc9145fc9d5c546f0eca1b6faec401f8 Reviewed-on: https://chromium-review.googlesource.com/848932Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#526732}
-
Daniel Bratell authored
base::Time in the global scope collides with X11 headers which have a global typedef of Time to int. This patch moves the code so that the symbols are imported into the local namespace (content) instead. X11 headers appear in some non-standard jumbo configurations (extremely large jumbo chunks) but could happen at any time otherwise as well. Bug: 746953 Change-Id: Iadc929ca4eb7d556490d58c791bbe8b2ef119726 Reviewed-on: https://chromium-review.googlesource.com/848916 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#526731}
-
Fady Samuel authored
During tear down, surfaces will be garbage collected which may force other surfaces to activate. However, during tear down, a RenderWidgetHostViewChildFrame may no longer have a CrossProcessFrameConnector and so it cannot send the new SurfaceInfo anywhere. If RWHVChildFrame does not have a CPFC then we should just simply drop the SurfaceInfo. Bug: 797801 Change-Id: I4b22af61ebc786dcc285311512cbc81bb570ba74 Reviewed-on: https://chromium-review.googlesource.com/849132Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#526730}
-
Ned Nguyen authored
Change-Id: I575ea1ce33848592ff725c7824078143df445f2f Reviewed-on: https://chromium-review.googlesource.com/849012 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#526729}
-
Tarun Bansal authored
Bug: 656170 Change-Id: I44efd7c4209a0acac58c3a9857cf6842d1c9f509 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/848234 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526728}
-
Simon authored
TBR=nednguyen@google.com NOTRY=true Bug: 798536 Change-Id: Ie01236ca17cd385de37e3f97730258aed9832544 Reviewed-on: https://chromium-review.googlesource.com/849013Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#526727}
-
Becky Zhou authored
Browser controls are accessible if the browser controls are not hidden before the tab modal javascript dialog is shown. The app modal dialog is also using the same dialog view now for consistency. Bug: 687010 Change-Id: I6f36e8ef06129dd220d75d08878480672993fc72 Reviewed-on: https://chromium-review.googlesource.com/757166 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#526726}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/7365f0261183..77863be41ffd $ git log 7365f0261..77863be41 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 nednguyen Move the call to set platform performance mode out of platform_backend.DidCreateBrowser and remove that API Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I86304e72fc36369803ef926c1afd27306503a563 Reviewed-on: https://chromium-review.googlesource.com/848746 Commit-Queue: <catapult-deps-roller@chromium.org> Reviewed-by: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526725}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/731082ce7ea6..35d2b7e9de9d $ git log 731082ce7..35d2b7e9d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If67063d4a798edd8bf4baa8e33879aff5c05ce99 Reviewed-on: https://chromium-review.googlesource.com/848749 Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526724}
-
Ned Nguyen authored
NOTRY=true Bug: 771997 Change-Id: Ifacd6cb915236770e1ef0c4f90d23fc41c106401 Reviewed-on: https://chromium-review.googlesource.com/726239 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#526723}
-
Philippe Hamel authored
Bug: 786472 Change-Id: I03a23cc70529ff2854ec538d6954411d6d89abdd Reviewed-on: https://chromium-review.googlesource.com/830824 Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526722}
-
kylechar authored
In VizProcessTransportFactory we already have a context provider that is shared on the main thread. It's used for all ui::Compositors already. Implement VizProcessTransportFactory::SharedMainThreadContextProvider() to return that context provider. Bug: 776050 Change-Id: Ie113fab9d2b49042f173138e4f9f143b191ae848 Reviewed-on: https://chromium-review.googlesource.com/827687 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#526721}
-
Helen Li authored
The paths to quic certs are changed in r525466. This CL is to update the run.py to use the new paths. Bug: 763998 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia55e97118b13d2e7b56fba95c6dca8aeb6ecb3c9 Reviewed-on: https://chromium-review.googlesource.com/848078Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#526720}
-
Sandra Sun authored
As we have implemented Snap at GestureScrollEnd on main thread, https://chromium-review.googlesource.com/c/chromium/src/+/756887, we'd like to turn the flag to experimental so it would be easier to test the feature on Canary. Bug: 497851 Change-Id: Ibdd23f17cbbbc47cbbe6d52bc492c2d910f32ce8 Reviewed-on: https://chromium-review.googlesource.com/836463Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#526719}
-
Wez authored
This reverts commit b86ebc88. Reason for revert: Introduces flakiness due to removal of global StatisticsRecorder teardown - see crbug.com/798717. This is a cross-platyform issue but in practice only caused base_unittests failures on the Fuchsia FYI bots, presumably due to differences in test ordering. Original change's description: > Simplified and optimized StatisticsRecorder. > > StatisticsRecorder is now an actual container of collections. > > There is only one global recorder at any time, referenced by > StatisticsRecorder::top_. > > Each StatisticsRecorder also has a pointer to the previous global recorder. > > We now have a stack (singly linked list) of StatisticsRecorder objects, where > the top of the stack (StatisticsRecorder::top_) is the current global recorder. > > This pattern is clearer and cleaner. It avoids a bunch of static variables, > indirections, unique_ptrs and calls to operator new. It gets rid of the ugly > hacks of UninitializeForTesting. It reduces memory fragmentation by having fewer > dynamically allocated objects. > > Removed methods Reset, UninitializeForTesting and DumpHistogramsToVlog. They are > now unnecessary. > > Reviewed, clarified and documented the thread safety status of each method. > > Added comments. > > > Change-Id: Ia1a7611905009d0449068c801464ad0df7813c0d > Bug: > Reviewed-on: https://chromium-review.googlesource.com/830997 > Commit-Queue: François Degros <fdegros@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526570} TBR=asvitkine@chromium.org,gayane@chromium.org,holte@chromium.org,skare@chromium.org,fdegros@chromium.org Change-Id: I4bd60c636a821bf681eb452636ade1098d3a4899 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/848273Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#526718}
-