- 23 Oct, 2018 11 commits
-
-
Kevin Marshall authored
Finishes the switch from using hand-rolled SDK target definitions to using targets automatically generated from SDK metadata files. A slightly oddball Vulkan copy rule remains intact. * Remove the old targets from fuchsia_sdk/BUILD.gn * Switch existing dependents of fuchsia_sdk:* targets to use fuchsia_sdk/sdk:* instead. * Some "gn format" fixups. TBR=jam@chromium.org Bug: 888753 Change-Id: I3aa9e6aa68cebae343609fc85c9a1c7d0ed1c7aa Reviewed-on: https://chromium-review.googlesource.com/c/1292570Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601799}
-
Scott Violet authored
It's flaky, but only on ChromeOS, and only with single-process-mash. BUG=897879 TEST=test only change TBR=yigu@chromium.org Change-Id: I26d5e39edc67c16d1334a2279d7f93796746143a Reviewed-on: https://chromium-review.googlesource.com/c/1295188Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601798}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8e270567..20f55e63 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0a53febcde9b02bdc06bb3cc5eaded2b16dfae46 Reviewed-on: https://chromium-review.googlesource.com/c/1294848Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601797}
-
Lei Zhang authored
BUG=897920 Change-Id: I6ff877d4059874e5066baa902aa682401050cabb Reviewed-on: https://chromium-review.googlesource.com/c/1294842 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#601796}
-
Bret Sepulveda authored
Disables NavigationRaceFromCrossProcessRenderer and EmbedWithInitialCrossOriginFrame. They are flaky on Windows 7 debug. TBR=ekaramad@chromium.org Bug: 897971 Change-Id: I3616355526307d4420c4176a0b77d17ffac7705e Reviewed-on: https://chromium-review.googlesource.com/c/1295184Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#601795}
-
Erik Luo authored
CompilerScriptMapping assumes that attaching sourcemaps get added to `_contentScriptsBindings` or `_regularBindings`. Blackboxed sources were skipped, for some reason, so detaching would throw an error. In bad cases, navigations will detach sourcemaps, throw errors, and prevent Console from clearing. Bug: 888688 Change-Id: I2c460271a868eca9a6d67371d9097cc552f20b56 Reviewed-on: https://chromium-review.googlesource.com/c/1295310Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#601794}
-
Zach Helfinstein authored
Improves the clarity of the codebase, as the AutomationManager's primary responsibility is to handle navigation around the page. Bug: None Change-Id: I897cbab60abdd081a6cb687476c57ff294f9e127 Reviewed-on: https://chromium-review.googlesource.com/c/1294516Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#601793}
-
Joey Arhar authored
Bug: 895081 Change-Id: I49c6131e1cc432e470e4b04353282d3ebebcb063 Reviewed-on: https://chromium-review.googlesource.com/c/1286758Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#601792}
-
Scott Chen authored
Replacing placeholder strings, and move all the add-string calls to under one function. also fixes a path bug for apps/ -> google_apps/ introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1285210 Bug: 874122 Change-Id: Ibd7940c6de71e3a3befc1c5342f6f6097e37de6e Reviewed-on: https://chromium-review.googlesource.com/c/1285325 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#601791}
-
rbpotter authored
Check the internals of the duplex capability, instead of only checking for its existence, to determine whether to display the duplex checkbox. Pull default value from the printer if it is available. Currently a speculative fix, as have not been able to identify a printer which sets the duplex capability field but does not actually support duplex. Bug: 896244 Change-Id: Iebafc3878a1e7658b821465439ee172c479ce413 Reviewed-on: https://chromium-review.googlesource.com/c/1290145 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601790}
-
Frank Liberato authored
To try to reduce time to first frame regressions, this CL makes D3D11VideoDecoder fall back to VDAVideoDecoder via FallbacKVideoDecoder. This prevents a round trip or two between the GPU and renderer processes. Bug: 832917 Change-Id: I2b3df44805fd950328beb6db88590718550630d1 Reviewed-on: https://chromium-review.googlesource.com/c/1294810 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#601789}
-
- 22 Oct, 2018 29 commits
-
-
Sean Topping authored
Merge-With: eureka-internal/209868 Bug: internal b/117985053 Test: CQ Change-Id: Id10498c6fea52563a8afefc37e6ddd48c1c1bd18 Reviewed-on: https://chromium-review.googlesource.com/c/1292109 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#601788}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b145370ba063..0339f0866c5f git log b145370ba063..0339f0866c5f --date=short --no-merges --format='%ad %ae %s' 2018-10-22 cbruni@chromium.org [tracing] Do not skip over entries when importing histograms Created with: gclient setdep -r src/third_party/catapult@0339f0866c5f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:897372 TBR=sullivan@chromium.org Change-Id: I74635f52def221f71e6d35462bd405ddc3ca25dc Reviewed-on: https://chromium-review.googlesource.com/c/1295031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601787}
-
Mike Wasserman authored
Avoid clearing the text/search on escape key release only. (eg. when a context menu closes, consuming the press event) Bug: NONE Test: KSV search not cleared pressing escape to close a context menu. Change-Id: Iaee63b9e31bf371ec3d95fd9ef4b688c0254b697 Reviewed-on: https://chromium-review.googlesource.com/c/1295171Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#601786}
-
Nico Weber authored
Both bots are red; this improves things a bit (but likely not completely, I only looked at a handful recent builds each). Bug: 897969,897970,330262 Change-Id: I2c399774175e57285eafc1c0de99a6f893e62fea Reviewed-on: https://chromium-review.googlesource.com/c/1295270Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601785}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/099769d5218b..d1868688a387 Created with: gclient setdep -r src-internal@d1868688a387 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ida99e8d2ece7ccbe863dfb15400e06fc3bcf60c2 Reviewed-on: https://chromium-review.googlesource.com/c/1295030Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601784}
-
Aidan Wolter authored
CAOS used to fetch the first 1s of data as quickly as possible and send it to the audio decoder. This was causing the AudioRendererAlgorithm to be unable to fill the entire buffer and AudioRendererMixerInput to fill in the remaining section of the buffer with silence. The user-facing experience is the first second of audio after a resume/seek/skip could have dropouts. To fix this, we remove this rapid-fetch logic, and fetch all data at the same rate specified by the audio_params. Bug: b/116860605 Test: pause/wait for CAOS close/resume 30+ times without reproducing. Change-Id: I00e479f5413d9c737d55839ce5017498a096ffae Reviewed-on: https://chromium-review.googlesource.com/c/1295229Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#601783}
-
Victor Vasiliev authored
I am not sure why those were not caught by the presubmit, but I suspect that it's due to code being in net/third_party. R=rch@chromium.org Change-Id: I525e777487d7e376aaa40d956305e5d1a8374bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1294869Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#601782}
-
chrome://net-internals#importchrome://net-export/Eric Roman authored
Bug: 897268 Change-Id: Ic77f0d71d3dccc71b12173aef9cbf567c258036b Reviewed-on: https://chromium-review.googlesource.com/c/1295110Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601781}
-
Majid Valipour authored
Add two different metrics: - Duration of mutate in dispatcher. This represents the main per-frame cost that is experienced by animation worklet clients. - Duration of mutate in globalscope. This is the main per-frame cost for each global scope. Bug: 780528 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icb7a369534bd0bd8e0e2b9e2cddc5e632eaf50df Reviewed-on: https://chromium-review.googlesource.com/c/951922 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601780}
-
Gang Wu authored
Bug:893799 Change-Id: I63a74404f8b4e1782797c0da8acaec7c6050ad3d Reviewed-on: https://chromium-review.googlesource.com/c/1294400 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#601779}
-
Min Qin authored
When download history is not fully loaded, onDownloadCreated() can get called by downloads already created by the DownloadManager. And DownloadHistory will call set_info() to attach DownloadRow to the download item regardless of its state. However, this is not needed for non in-progress download. For non in-progress downloads, if set_info() is called, a later DownloadHistory::OnDownloadUpdated() call could still result in clear_info() gets called before DownloadHistory::ItemAdded(). So the assumption in the comments may not hold. This CL also removes the call to OnDownloadUpdated() in ItemAdded(). OnDownloadUpdated() can be called any time before ItemAdded(), and it will queue a sql update to the history db. So there is no need to call OnDownloadUpdated after ItemAdded(). This CL also exposes and fixes a bug in DownloadHistoryTest BUG=842245 Change-Id: I8d6da374671fa0e56d0c2eb57577ce5726812b3e Reviewed-on: https://chromium-review.googlesource.com/c/1294072Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601778}
-
Nico Weber authored
It's been defaulted to true for a while now on Linux and Windows, so rely on the default setting instead. Bug: none Change-Id: Id24297dff08b28ee5e28f6cb6267018a4a1443e1 Reviewed-on: https://chromium-review.googlesource.com/c/1294298Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601777}
-
Matt Menke authored
While the HTTP spec further limits what values are legal, nulls are particularly concerning, and it's safest just to reject them. See discussion here: https://github.com/whatwg/xhr/issues/165 Chrome will be the first browser to reject nulls in responses, despite there being wpt tests for this, so we'll have to keep an eye out for breakages. For reference, 0x00 through 0x1F aren't allowed in header values or fields, (https://tools.ietf.org/html/rfc7230#section-3.2 - VCHAR excludes those characters). CRs and LFs are of course needed, and 0x0C and 0x0B are allowed by other specs for particular header parsers, strangely. This CL does not affect other code that can generate HTTP response headers, which still uses the old behavior of just removing nulls. ServiceWorkers, extensions, WebPackages, Dial (?), and various tests still inherit the old behavior, since they create headers directly with a method that can't fail. It does introduce a new helper method, however, that they should eventually be switched to use: HttpResponseHeaders::TryToCreate(). We should probably put off conversion until this successfully makes it to stable. Bug: 832086 Change-Id: Ib75ac03a6a298238cafb41eaa5f046c082fd0bdf Reviewed-on: https://chromium-review.googlesource.com/c/1291812Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#601776}
-
John Rummell authored
H264Decoder will now call H264Accelerator::SetStream() for each buffer so that the accelerator can check for encrypted streams. It will be called from Decode() so that the accelerator can return kTryAgain if it determines that additional data is needed to handle the stream (e.g. decryption key is needed). Default implementation of SetStream() does nothing, and returns kNotSupported which allows Decode() to continue. The decoder will also call H264Accelerator::ParseSliceHeader() before calling the same method on H264Parser. This allows the accelerator to handle the slice header if it is encrypted. Default implementation returns kNotSupported which forces the decoder to call the H264Parser method. BUG=837455 TEST=new media_unittests pass Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6d31b57f85b366ca9518904923b00300341afe98 Reviewed-on: https://chromium-review.googlesource.com/c/1166220 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#601775}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/e188b5435de7..137d99c91fc7 $ git log e188b5435..137d99c91 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 huisu ML_VAR_PARTITION: enable at speed 5 2018-10-18 chiyotsai Changes 4-tap SSSE3 filter to 8-tap AVX2 filter. 2018-10-17 chiyotsai Add SSSE3 support for 4-tap interpolation filter 2018-10-17 jingning Replace MAX_LAG_BUFFERS with MAX_ARF_GOP_SIZE for gop size 2018-10-17 angiebird Add do_motion_search 2018-10-17 angiebird Preserve code of doing mv search in raster order 2018-10-17 huisu Enable rect partition search for HBD at speed 1 2018-10-16 chiyotsai Adds SSE2 support for interpolation filter for width 4 and 8 2018-10-17 urvang For keyframe-only coding do not boost in q mode 2018-10-16 chiyotsai Refactor SSE2 Code for 4-tap interpolation filter on width 16. 2018-10-12 yunqingwang Optimize vp9_highbd_temporal_filter_apply_c 2018-10-16 chiyotsai Add SSE2 support for 4-tap interpolation filter for width 16. 2018-10-16 angiebird Variant implementation of changing mv search order 2018-10-15 angiebird Add feature_score_loc_sort 2018-10-12 angiebird Init mv_[dist/cost]_sum in init_tpl_stats 2018-10-10 angiebird Change mv search order according to feature_score 2018-10-16 huisu Fix a bug in ml_prune_rect_partition() 2018-10-16 jingning Refactor tpl dependency model to support multi-layer ARF updates 2018-10-16 yunqingwang Fix the filter tap calculation in mips optimizations 2018-10-15 jianj fix output file check in vpxenc tests script. (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Id5bc4c9f32a0991bc6b162f721869e30d210ccf7 Reviewed-on: https://chromium-review.googlesource.com/c/1294671Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#601774}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=hansberry@chromium.org Bug: 681136 Change-Id: I310de48fb3c0d0423cf0cadff7de18e6a4815548 Reviewed-on: https://chromium-review.googlesource.com/c/1288513Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601773}
-
Theresa authored
Remove the IPH shown after document mode migration. This is part of an ongoing effort to simplify ToolbarPhone in prepartion for refactoring. BUG=897835 Change-Id: I52510e945dbb352ce2dc2c9aae1314967a9c9b9b Reviewed-on: https://chromium-review.googlesource.com/c/1294597Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#601772}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e95b35010759..d0dc9924c431 git log e95b35010759..d0dc9924c431 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 yshaul@google.com chromeos_config: Move top level test declarations into own config Created with: gclient setdep -r src/third_party/chromite@d0dc9924c431 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I52b79269eaaca697e1da82fbe7b7cd267fd2dd6f Reviewed-on: https://chromium-review.googlesource.com/c/1294790Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601771}
-
Pedro Amaral authored
Bug: 851166 Change-Id: Icbd81a2dc22e274173ddf8f9cf79820c077f56ba Reviewed-on: https://chromium-review.googlesource.com/c/1286765Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#601770}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ae9bed9f4af1..36623f65c39c git log ae9bed9f4af1..36623f65c39c --date=short --no-merges --format='%ad %ae %s' 2018-10-22 tsepez@chromium.org Add missing property to event_properties.in 2018-10-22 tsepez@chromium.org Call last uncovered document methods. 2018-10-22 tsepez@chromium.org Add FPDFFormFillEmbeddertest.DocumentAActions. 2018-10-22 tsepez@chromium.org Remove pdfium_diff target from pdf_is_standalone block. Created with: gclient setdep -r src/third_party/pdfium@36623f65c39c The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie305554b4a882c8f4d899840bb26f5b01ddc08f9 Reviewed-on: https://chromium-review.googlesource.com/c/1295029Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601769}
-
Dominick Ng authored
This CL adds an additional test for the non-installed URL case, as well as some extra documentation for profile fetching. BUG=893927 Change-Id: Icb6d98121f9c4347561a31c9ea97af15b10ebdfb Reviewed-on: https://chromium-review.googlesource.com/c/1292659Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#601768}
-
Giovanni Ortuño Urquidi authored
Implements GetScanState() by directly querying the state from the `active_adapter_`. Follow up CLs will add the ability to change the ScanState and listen to changes. Bug: 870192 Change-Id: Idd03f808e4a458c4b54b2d374f9086629735c200 Reviewed-on: https://chromium-review.googlesource.com/c/1290431Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#601767}
-
Andrey Kosyakov authored
Change-Id: I9fb3d228d53f47b3679e2c35679d5dbf0470f43a Reviewed-on: https://chromium-review.googlesource.com/c/1294720Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#601766}
-
Sahel Sharify authored
This cl is a fix for the following cl: https://chromium-review.googlesource.com/c/chromium/src/+/1281687 The original cl fixes the crbug.com/884728 by making sure that the GSU/GSE events with inertial phase are not bubbled to the parent. In the original cl Mac is an exception since on this platform the GSU events with inertial phase are received from the OS rather than being generated by the fling controller. What the original cl is missing is that Mac is not the only platform on which we receive GSU events with inertial phase from OS. On Windows devices with high precision touchpad the same thing happens. This cl makes sure that we only stop bubbling the GSU/GSE events that are generated from the fling controller: i.e. GSU/GSE events with inertial phase that are either from touchscreen source or from touchpad source but on ChromeOS only. (touchpad fling happens on chromeOS only, and on Mac and on Windows(high precision touchpad) GSU events with inertial phase are not generated by the fling controller.) Bug: 884728, 897901 Change-Id: I5d620cc147707f1727c938a868a4082639095568 Reviewed-on: https://chromium-review.googlesource.com/c/1294398 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#601765}
-
Dmitry Gozman authored
These utility functions have a single client, and abstract away from it with a delegate. Instead, we can just inline the code and simplify it a bit. Bug: none Change-Id: I0a0e0f13077331a917f430e92b62183e2d98f762 Reviewed-on: https://chromium-review.googlesource.com/c/1283937 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#601764}
-
Michael Giuffrida authored
See https://crrev.com/c/1294419 for a new PRESUBMIT to check this. Bug: 897868 Change-Id: I05fab30fdf8c0b58a8925595ff22d848b3e85176 Reviewed-on: https://chromium-review.googlesource.com/c/1294589Reviewed-by:
Zachary Kuznia <zork@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601763}
-
dpapad authored
Take into account that in Shadow DOM v1 document-fragment elements are reported in an Event's path. Bug: 897168 Change-Id: I95d16b46ec2b66244b03f5b9aec98d0ca6dc7abc Reviewed-on: https://chromium-review.googlesource.com/c/1294422Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601762}
-
Matthew Jones authored
This patch fixes a crash caused by calling setToolbarSwipeLayout on a null object. This is the result of a device changing display size and returning to chrome. When the display size is set to small the device uses phone assets and on some devices, when the display is set to large some devices will use tablet assets. The crash comes from the value cached by the Duet feature which doesn't expect the device assets to change. Bug: 896655 Change-Id: I5d4a0d6d989a1a48d595a303a965e460592ad20b Reviewed-on: https://chromium-review.googlesource.com/c/1294515Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#601761}
-
Zhenyao Mo authored
BUG=896932 TEST=about:histograms R=kbr@chromium.org,sunnyps@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I20db893a19ff93120ce40fded22eaa153546ac3b Reviewed-on: https://chromium-review.googlesource.com/c/1290202 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#601760}
-