- 08 Oct, 2020 40 commits
-
-
Fabio Rocha authored
Remove scoped feature list from SystemWebAppManagerTest in system_web_app_manager_unittest.cc, now that kDesktopPWAsWithoutExtensions is always true. Bug: 1065748 Change-Id: Ibf6dc5e53a5ea1a6c37d479a2f17d5efafc8fd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459687Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815156}
-
Mohammad Refaat authored
Also make sure that the restore prompt doesn't show if the user already restored. Bug: 1136307 Change-Id: I733202c348923224c20d5e8728cbab9cd21466d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459804 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#815155}
-
Ghazale Hosseinabadi authored
This CL fixes the flakiness of DeveloperPrivateApiTest. InspectInactiveServiceWorkerBackground. Bug: 1134506 Change-Id: Iaba317d3995da20fda2548b00da6579db4b91059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458107Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#815154}
-
Mugdha Lakhani authored
Bug: 1087486, 1091211 Change-Id: I9c4ed3d09cce8c9e4fc7e708f1c94b990d8e93af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454169Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#815153}
-
Mohammad Refaat authored
This fixes the problem when crash happens as there is no active webstate when the new window opens. Also this is consistent with the behavior of single window/multi-window when we don't show the restore prompt when there is external intent (opening chrome from another app with url parameter). Bug: 1135459 Change-Id: Ia979db92f3d938f57a7b7a5f4821075a82b396fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454250 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
sandromaggi authored
Refactors the |WebController::GetOuterHtml| to take an |ElementFinder:: Result| instead of a |Selector|. Also adds UT for the action. Bug: b/168107066 Change-Id: Ie5d9688e2c1389bbb9d7a9bff0f8c38b145a88aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455346 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#815151}
-
Torne (Richard Coles) authored
When referring to Android surface objects, use a JavaRef instead of a bare jobject, to make sure we manage reference lifetimes correctly. This changes the following interfaces: - ScopedJavaSurface::AcquireExternalSurface - GpuSurfaceTracker::SurfaceRecord::SurfaceRecord - Compositor::SetSurface Most of the callers of these functions already had JavaParamRef objects and were relying on the implicit conversion to jobject, which is no longer necessary with this change; the remaining callers have been updated. Change-Id: Ic667ad98974bbe8b0674afbce3c0eb6072001468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453270Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#815150}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I0335dc8f0094b8b8bf6c6ef68c668cdcdb00ddd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457546 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#815149}
-
David Bienvenu authored
Also some lint fixes and other cleanup; no functional changes Bug: 1010217 Change-Id: Ia41657b7e1892056074ba6a21488b78e4ddc65da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459062 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#815148}
-
Alex Rudenko authored
ClearInspectTool was not clearing inspect_tool_ in the expected order (DisableFrameOverlay checks inspect_tool_ via IsVisible method), thus, breaking hideHighlight functionality. This was broken in https://crrev.com/c/2397735 Fixed: 1136455 Change-Id: I97dc444cffee98cb41a8ac8285f4e7d0cc797715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460732 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#815147}
-
Tanmoy Mollik authored
Bookmark is not loaded in default maxout time which is 3 seconds. Increasing it to 4 seconds in order to check if the crash persists. Bug: 1133426 Change-Id: If4fcc9230803c781adff4ba88db36038bfcc11e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456111Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#815146}
-
Bruce Dawson authored
The reason for the timeouts on this test are believed to be understood and resolved in crrev.com/c/2209755 so it's time to try reenabling the test. Bug: 974787 Change-Id: I17e587da4446beb352ceeeac09d7fd1e0cfb5f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459788 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#815145}
-
Eric Willigers authored
Calls like https_server()->GetURL("app.com", "/ssl/google.html") generate GURL values. We now store such values by value instead of by reference. Bug: 1136278 Change-Id: I1267e9bdf77c062d1ae83c6dc231dc4dc3b7da6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459546Reviewed-by:Caroline Rising <corising@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815144}
-
Olga Sharonova authored
[sheriff] Disable flaky RenderWidgetHostViewChildFrameBrowserTest.VisualPropertiesPropagation_RootWindowSegments on Mac and Linux TBR=acolwell@chromium.org Bug: 1089994 Change-Id: Ic20c5e88c3f2b3b0df1c39cbf981ab787c9ef7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461329Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#815143}
-
Gauthier Ambard authored
It seems to pass now. Fixed: 1129589 Change-Id: Id2fd68a6e3f860f593871c4a223bc0a8f034cefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460825Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815142}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I83eae6b0a81cbaf204cde6ac0c69b16c4a97fd9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456947Reviewed-by:
-
Avi Drissman authored
GetBlueTouchBarButton() is unused; remove it. Remove the wrapper functions that return the touchbar classes. Chrome builds with a new enough SDK that they are not needed. Bug: none Change-Id: I19d25a92ce857b1bcced66b8905a22faf701da7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459398 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#815140}
-
Dylan Cutler authored
Using this factory method instead of CreateSanitizedCookie better expresses the intent of this code: to deserialize cookies that were already added to the cookie store. This mitigates a bug in the current code where cookies with a __Host- prefix would fail the check below. I believe this is what causes the crashes that causd us to change a DCHECK to an early return in http://crrev.com/c/2335554. Also since CanonicalCookie::FromStorage will DCHECK IsCanonical(), we do not need to check the CanonicalCookie's validity in this file. Bug: 1102874 Change-Id: I0759ecc155d9be84b0bae13064d8218702d4c8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456630 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#815139}
-
Thomas Lukaszewicz authored
This reverts commit fcffa1cc. Reason for revert: Reverting due to failure on Linux ASAN LSAN bot See link below for failure details: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20%281%29/82545 Original change's description: > Fix ifdef guard for OS_CHROMEOS. > > There's on going work to unset OS_LINUX on Chrome OS build, > however, it is not yet completed, so it is still defined. > > This CL adds the explicit !defined(OS_CHROMEOS) to fix > the behavior. > > Bug: 1110266 > Test: Built locally. > Change-Id: I60731672aabb6bb6025e29a0b641988e68ecade5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460826 > Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815116} TBR=hidehiko@chromium.org,guidou@chromium.org Change-Id: I59d4a9dfe96d45199c87fcf42a65d9e05e7b76d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462015Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#815138}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d7dc4dcf. With Chromium commits locally applied on WPT: ae057949 "Add infrastructure/testdriver/actions/penPointerEventProperties.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I8b0f4a826db30d9991f8e1eb4a97a4d97250e3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461566Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815137}
-
Laís Minchillo authored
R=mmenke Fixed: 1122903 Change-Id: I9e9c7f006c1a1b22913f368ac513692116a0f77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461271 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#815136}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4ce93ca21f488ca307b7e26e3aea0644c5af7e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461548Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#815135}
-
Ilya Nikolaevskiy authored
This would allow to batch all scaling operations performed by webrtc into one operation. Also, clean obsolete debug output. Also, efficient implementation requires passing a media::VideoFrameBuffer into adapter, so a ref counted wrapper is added. Bug: chromium:1132299 Change-Id: Iafb6d3523eb3655d1f67878c68be82f58354a5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454651Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#815134}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ie1e7cebe3008c18055aa005cb48c83105ce90a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456049Reviewed-by:
-
Yutaka Hirano authored
Make it a base::TimeDelta for better readability. Bug: None Change-Id: If4cd579ccedcc6fa1d99124f681ef6e68bc843ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460827Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#815132}
-
Eric Seckler authored
Up to now, while it is possible to pass custom perfetto::Track objects to typed TRACE_EVENT macros, the TrackDescriptors for these tracks were not written to the trace. This patch hooks up typed macros to perfetto's TrackRegistry. For this purpose, it adds another delegation callback through which the layer in //base can request a new TracePacket (for the descriptor) from the event sink in services/tracing. TBR: weili@chromium.org Bug: 1065905 Change-Id: Iadc7c47b9840a3c18ab9372cb7e3361c9b78d3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455608 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#815131}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53db73226239..8a7ceda7a71f 2020-10-08 tvanderlippe@chromium.org Typecheck sources/JavaScriptBreakpointsSidebarPane.js with TypeScript 2020-10-08 tvanderlippe@chromium.org Remove duplicate typedef and unify usages 2020-10-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-08 sigurds@chromium.org [ts] Type-check sdk/ConsolePinPane.js with TypeScript 2020-10-08 szuend@chromium.org [ts] Type-check NetworkManageCustomHeadersView.js with TypeScript 2020-10-08 szuend@chromium.org [ts] Type-check network/RequestHeadersView.js with TypeScript 2020-10-08 sigurds@chromium.org [ts] Type-check sdk/ConsoleSidebar.js with TypeScript 2020-10-08 szuend@chromium.org [ts] Type-check network/RequestCookiesView.js with TypeScript 2020-10-08 sigurds@chromium.org Use more precise types in components/ 2020-10-08 sigurds@chromium.org [ts] Type-check sdk/ConsoleModel.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I47e23dcbb2e8b910d6ccdf7ea0073bd15e1f8563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461646Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815130}
-
sandromaggi authored
Adding an action to check the value of an element. This action can be used for controlling flow (e.g. checking if a field is filled and offering a FocusElementAction if not) - or for debugging (e.g. logging if a field is filled after a SetFormFieldValueAction). Bug: b/169924567 Change-Id: I08888de3e5702a04ae72f6fd36faff198c3f409f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450089 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#815129}
-
Laís Minchillo authored
Change testCanInjectHeaders to pass an ImmutableMap to loadUrl instead of a mutable map. Some older WebView versions would crash if an immutable map was passed. This test now prevents this to regress in the future. R=ntfschr Test: run_webview_instrumentation_test_apk -f *testCanInjectHeaders* Change-Id: Ie74893361088dec46f0470ba934b1d185dc0f9fb Fixed: 1032049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449473 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#815128}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602136563-0d72642499ba1a8379313d017bceff00a59e9e7c.profdata to chrome-linux-master-1602158210-2b3a542037c8eff782f3f4efb30eab1c7f804d13.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ica99366f1645017a65cbbcd8e194b149162a13d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461686Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602136563-35c37307a75e48d8d50dea3abef2bbe00d3f301f.profdata to chrome-mac-master-1602158210-9de918de8f612323e79e5b6447a9374f3934b014.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I36f1cc66321d60cf63b819b62a4e73533a488d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461399Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ac0723a06b53..8d43858ed21a 2020-10-08 kjlubick@google.com [canvaskit] Update jsfiddle links and fix renderSKP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Ic616fe728a9d613e4fa1f238c67e06118a11d873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461398Reviewed-by:
-
Alex Moshchuk authored
The existing entries were failing to actually disable those tests on the bot, seemingly because they were missing "All/". Example failure: https://ci.chromium.org/p/chromium/builders/ci/Site%20Isolation%20Android/46774 Bug: 906256 Change-Id: Ic59ee49e16ac063bd2a25dff879a2bd47ff22ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459571 Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#815124}
-
Vladimir Levin authored
If, for any reason, we should have recursed into a subtree for a compositing update but it was prevented by the display lock, then we have to restore this state so that we can recurse later. This is a real DCHECK that I have seen, and also is a speculative fix for the referenced bug. R=chrishtr@chromium.org Bug: 1133244 Change-Id: I5adfa04563d94702fa1b38dd2753e76e2a86e317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453790 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#815123}
-
Manu Cornet authored
Bug: 1056219 Change-Id: Ie2b0b9149653eac2b33d3d841937b99517b404e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446211 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815122}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/851a5e7f..dba8d09f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id0dabb440cf253328bc93835279d78b9a4c5a5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461586Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815121}
-
Viktor Semeniuk authored
This change makes username editing compliant with Butter for passwords feature. Account and profile passwords storage are treated as separate entities for the already used username checkup. Bug: 1135181 Change-Id: Idac7d0188e16c4053fb52c746a793469a50a0116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450310 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#815120}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6a09a9d46097..a8bb3df77a94 2020-10-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from bacaef3237c5 to 2067d1a93e6e (8 revisions) 2020-10-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from a638f3acae94 to dc8a96d60b6b (2 revisions) 2020-10-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 635de036d766 to 952149303d06 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I936dfaea29ecdcaa63a4fbeaff23a72e94d596a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461395Reviewed-by:
-
Matt Jones authored
The omnibox needs to be unfocused to unsuppress the bottom sheet that is triggered when attempting to share. This patch does that by providing a runnable to the ShareButtonCoordinator that performs the unfocus action. Bug: 1135907 Change-Id: I3b9f14f76b90f13f381f910e4b495ebbecba9168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456508 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#815118}
-
Hyunjune authored
Reason for revert: After a patch[1], this issue is fixed. So this patch is not needed anymore. Because pass a if statement relied to check cull-rect and a function called |ClearInvalidationMask| is called in painting time. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2050382 Original change's description: > Fix that mask containing image with clip-path can not apply to client > > When image contained mask is loading, it touches a mask flag called > |computed_invalidation_mask_|. > Because |MarkForLayoutAndParentResourceInvalidation| is called in > |ImageChanged| without layout while loading, so this flag would be > changed without clear. And this flag is used in the next layout. > Actually this mask can not apply to client element in next time. > This patch clears the mask flag in pre-paint time. > > Bug: 1086070 > Change-Id: I55a7a16faafe4eeefac88e8e15e6d3b18b097acf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432151 > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> > Cr-Commit-Position: refs/heads/master@{#813061} TBR=fs@opera.com,hyunjune.kim@samsung.com,schenney@chromium.org Change-Id: Ifca23ff31590ebc13e1b5a7492c04724847e748f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1086070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460527Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#815117}
-
