- 12 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fc2bd2179672..2b36c8eb3e1c 2020-08-12 patrick.brosset@microsoft.com Remove the previewed class when pressing Escape in the .cls pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1114726 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I701c748e0343ad1517e004c701f647478e106af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353094Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797401}
-
Tommy Martino authored
Change-Id: I93a77f3be4ff44dd95f5ee7e8e176f44ae312758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353109Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797400}
-
James Long authored
Instead of displaying below the "general details" section, the class and package-specific node details have now been moved up and placed in the same list layout as the general details, making the panel more uniform. Icons have also been added beside all links, the same as the favicon for the page, to indicate that the links take you to a different graph. Bug: 1102546 Change-Id: Ib05b35b7108685dad3cb5f0a87841302fa061e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349983 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#797399}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7f46a7432a9..00fcb720bc39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC szager@google.com,smcgruer@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: szager@google.com,smcgruer@google.com Change-Id: Idd24a57863d844e753e44264b3136a974befbd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351378Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797398}
-
Sonny Sasaka authored
The battery client should be initialized only when the show-bluetooth-device-battery flag is enabled. Bug: b:160905767 Change-Id: Iaa8532554085d902740766767ed65177265e557d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341824 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#797397}
-
Alex Keng authored
This CL changes the return value of TSFBridge::Initialize from void to HRESULT and refactors the logics in TSFTextStore::TSFTextStore out to TSFTextStore::Initialize. The HRESULTs of various COM calls during TSF initialization are propagated so the caller can handle errors, if any, accordingly. Note at the moment upstream doesn't have any use case for the HRESULT, but downstream will use the value for WebView2 initialization, ex. handling errors due to creating CLSID_TF_CategoryMgr instance in a thread initialized with COM_MTA (while all TSF functions expect STA) Change-Id: I227000a594f203eecc37838ff877d3dcd077df2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340543 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#797396}
-
John Williams authored
Change-Id: I9edc1a14022d1393fc6fa61afafddcdb944edfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348412Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#797395}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09afd88dfed8..dfa133b7b48c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If86b511849d143ff9950245f2f2bcda630dd9ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351122Reviewed-by:
-
dizg authored
Bug: 1115056 Change-Id: I46e9750b9755e2ee62b3e3974b0ff6663d00de41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346354 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#797393}
-
Chris Hamilton authored
This migrates our code to use the recently added blink token types rather than our own equivalent types. Change-Id: I02fa92bef1c4906595ae7d526909e41ad93b3294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341221 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#797392}
-
Aya ElAttar authored
- This CL is based on dpapapd@ comments on crrev.com/c/2098906 - Moved ChromeURLDisabledUI to a separate folder under webui/chromeos directory. Change-Id: I17a3ab761b91a05af00d6c6db5e9d857d7ba488b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349708Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#797391}
-
Ilya Nikolaevskiy authored
Bug: chromium:1112391 Change-Id: Ic02acc66b236d6f376e8593c490066c61c7eff0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351830 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797390}
-
Chris Harrelson authored
When this flag is on, we will use GeometryMapper for overlap testing and squashing sparsity tests. This code will be rolled out via a Finch experiment in order to estimate its impact on performance. Bug: 1115577 Change-Id: I42d29d1e25d8d4df9ea1410af3203342c3242040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343675 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797389}
-
Swapnil authored
When the browser is shutdown, we start destroying the objects. In ExtensionInstallEventLogManger, we used to destroy |logger_| after the |extension_log_upload_| pointer. This could cause to a crash because we try add a LOGOUT event before the shutdown. And while adding the LOGOUT event, ExtensionInstallEventLogManager::Add method is invoked which posts a task to invoke InstallEventLogManagerBase::LogUpload::OnLogChange. Thus we should destroy the |extension_log_upload_| pointer after destroying the |logger_| pointer so that we add the LOGOUT event and prevent the crash. Similarly, this should be fixed for ARC++ reporting. Bug: 1114191 Change-Id: I6e88f5747b6a5b7a36e1dcee3083204833c9aeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346306Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#797388}
-
Brian Sheedy authored
Removes the special casing that was recently added to the GPU context loss pixel tests, as we have confirmed that the tests otherwise pass if not for the expected crash check. Bug: 1061298 Change-Id: I00ec5ec7034a68025b505a28f69c852ad304de7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353049 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#797387}
-
Bo Liu authored
RenderProcessHost::Shutdown does not go through fast shutdown, but does go through RenderProcessHostImpl::ProcessDied. This ends up being recorded as out of memory kill on Android. Add RenderProcessHost::ShutdownRequested, and plumb it to where ProcessedCrashCounts is recorded. Then record a count of how much this would affect the OOM metric if it's taken into account. Bug: 1115517 Change-Id: I43ac22e4dfcc2ff0c23423355817420b2a5aa5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351170Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797386}
-
Becca Hughes authored
Change-Id: I63b64b85cd4c9b42bef2a3f1518d79d573e9131f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352514Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#797385}
-
Becca Hughes authored
BUG=1053599 Change-Id: I9dbe1a011579fb3e7f8cf9b99a85b97bda5bb086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341935 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#797384}
-
Peter Kasting authored
No intended behavior change. Not a complete list, just changing a few places I was already touching. Bug: none Change-Id: I53b652722671366803a5e6b76fec7b1c41c3cc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345509 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797383}
-
James Hawkins authored
Networking components have a lot of dependencies that need to be in place for testing, so use internet-config-dialog as the host instead of OS Settings. Note that ideally this would not be required for testing, but with Polymer2 going away soon, it's not worth building more infra to support this case. R=khorimoto@chromium.org Bug: none Test: none Change-Id: I06ca337eb0c18e362d91d8ddee81ffe2707dd0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352551Reviewed-by:
-
Xinghui Lu authored
Bug: 1097310 Change-Id: Iac117bddb711cbd493c05e8a86a40ca8d00f0130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353090Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797381}
-
Brian Sheedy authored
Switches the GPU experimental Linux NVIDIA builder to trigger tests on the new machines running GTX 1660 GPUs. Submitting with no-try since the only failures are crbug.com/1115172. No-Try: true Bug: 1042292, 1115314 Change-Id: I800f38e1bde84b156d8abfb05ae8816e66b36f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346801 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Shimi Zhang authored
Bug: None Change-Id: Iaa4911dc743216c9fde6d44b3677e6d0951b64a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350246 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#797379}
-
K. Moon authored
Adds a "PdfPartialLoading" feature to control whether or not the PDF viewer tries to use partial loading. The default state is enabled, as this feature has shipped already, but we would like to experiment with disabling it to address certain problems related to partial loading. Bug: 1115149 Change-Id: Ie66fddf5b633269226bc01fca20ac7013f0c1e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349429 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#797378}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d7b09c4c3acf..a465e2e30890 2020-08-12 mtklein@google.com add SKPath::readFromMemory() fuzzer 2020-08-12 robertphillips@google.com Reenable the small path renderer on the DDL1 bots 2020-08-12 jvanverth@google.com Switch GN defs on Mac and iOS to use frameworks, take 3 2020-08-12 bungeman@google.com Avoid copy of SkImageInfo in HeapAllocator::allocPixelRef 2020-08-12 brianosman@google.com Reland "Add inline threshold to SkSL::Program::Settings" 2020-08-12 johnstiles@google.com Fix AutoDisableInline to avoid re-enabling inlining. 2020-08-12 robertphillips@google.com Allow small path renderer usage in DDL recordings 2020-08-12 johnstiles@google.com Revert "Guard dumpInfo() calls with GR_TEST_UTILS, instead of SK_DEBUG." 2020-08-12 johnstiles@google.com Revert "Remove dumpInfo() entirely when GR_TEST_UTILS is off." 2020-08-12 johnstiles@google.com Revert "Guard gencode dumpInfo() calls with GR_TEST_UTILS, instead of SK_DEBUG." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: fmalita@google.com Change-Id: I76ab27318eae7db9b358297e830c942029e3a71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353093Reviewed-by:
-
wutao authored
Bug: b/163417826 Test: manual Change-Id: I970a36f4d98e5fccd435b8a9b5131da2e030f06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349984 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797376}
-
Mohamed Heikal authored
Internal checkouts can use a different protocol buffers and runtime, thus use variables to refer to them so they could be changed based on your checkout. TBR=# noop change to proto runtime target name Bug: 1114836 Change-Id: I564b5f7bfa65ff549c335766c26b2d1dd07241fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346861 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#797375}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Idbe07418af1f0d55096c919755c9adece4ff5c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352515Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#797374}
-
Cathy Li authored
This reverts commit d6d62019. Reason for revert: We want to keep control over the margins from the Chrome side. Original change's description: > [Feed V2] Update margins to render the external surface cards correctly. > > Bug: 1106425, b/161142289 > Change-Id: If3c89644289b6eb1d5b61f6680f03bf95e3b6888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303172 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Commit-Queue: Justin DeWitt <dewittj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789547} TBR=dewittj@chromium.org,dtrainor@chromium.org,carlosk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1106425 Bug: b/161142289 Change-Id: I5b01fbb8167caaa027a9d7423c1272d66c35a56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347220Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#797373}
-
Omer Katz authored
Epoch based metrics will rely on "forced" tag (currently we wrongly account event that should be forced as non-forced) and a unique epoch id. Bug: 986235 Change-Id: I3156eecf7e4dcca12a9d2f11ea82b380ded46f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351918 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#797372}
-
Juliet Levesque authored
Change display of HTTP request/response dictionaries and contact data to have indentation maintained. Change-Id: I9134dab98f8e79fac3e6fd40c4dc0c14f63fab2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350242Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#797371}
-
Adam Rice authored
In February 2020 many web tests were timing out on the Fuchsia bots. The underlying issue appears to be fixed (see https://bugs.chromium.org/p/chromium/issues/detail?id=1055553#c58), so re-enable them. BUG=1057020,1056022 Change-Id: I45d74e7502ad6d8ff82b665ea4bc5d55bfd5e420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266592Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#797370}
-
Chris Sharp authored
Also fix the mappings to actually appear when viewing the doc as markdown. Change-Id: Ie68a1651a95b2876dcea1fe31a7aea54c872d2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350250Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#797369}
-
Ken Rockot authored
In preparation for reusing most of this thing within the Storage Service process, this moves SandboxedVfs into //sql and abstracts out the few Blink-specific dependencies into a small delegate interface. Bug: 1052045 Change-Id: I947611c63060446692c7f78b4f555b9f90994842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351159 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#797368}
-
Tomasz Wiszkowski authored
Bug: 1085184 Change-Id: Idcaa9416a06fa8f08ab52aeb4c9ab89b4a4e94fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347406Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#797367}
-
Yusuke Sato authored
BUG=None TEST=None Change-Id: Iffca1cb97e79d336a3b41bdbefdf441f98cca6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350237Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#797366}
-
Marc Treib authored
This CL adds the plumbing in ConsentAuditor[Impl] to record this new type of consent, and the corresponding sync proto messages. It's not used so far; that will follow in another CL. Bug: 1111252 Change-Id: Ib528273e88bfbd6546e6d1fc26c0884fef1e6e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351923 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#797365}
-
Michael Crouse authored
This addresses attempting to clear a nonexistent blocklist on history clear. This also adds a nullptr check for the HintsAgent before determining if a hint is available. Bug: 1115360,1115362 Change-Id: I2513c966d5a81eedd260363c28e328e97e08cab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351372 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797364}
-
Stephen McGruer authored
This reverts commit af7117b8. Reason for revert: Tentative revert as suspect of https://crbug.com/1115630 . Will monitor + re-land if this doesn't fix the bot (with my apologies :)) Original change's description: > Remove refcount thrashes of value in setAttribute. > > This removes the refcount thrashes in Element::setAttribute() avoiding > nearly 13% of regression in blink_perf.bindings set-attribute.html story > when StringImpl is made threadsafe. > > Bug: 1083392 > Change-Id: Ia5fe7193c24ae8baa4f16a21a2a79f80e7dc0b5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351950 > Auto-Submit: Albert J. Wong <ajwong@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797240} TBR=ajwong@chromium.org,jbroman@chromium.org Change-Id: I672f63ec54742db85ee1f699849eac24806d9af0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1083392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353115Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797363}
-
Mark Pearson authored
Change-Id: I7e365794b24f3ca6879114371e6ce500d0ccd2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350142 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#797362}
-
