- 12 Jan, 2021 40 commits
-
-
Yulun Wu authored
Bug: 1139477 Change-Id: I8901748651f62b2894a0c8b3f4e46bed6ddc6c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612207Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842667}
-
Kevin McNee authored
Several mime_handler_view tests have a copy of the test extension id. We now use the common constant. Bug: None Change-Id: If9c08f486698a1c32fc9c2871a379e474589a2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624771 Commit-Queue: Kevin McNee <mcnee@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#842666}
-
Trevor Perrier authored
This CL enables selecting the app and translate target languages in the new detailed language settings on Android. This feature is all behind a release flag. Both settings preferences use the added LanguageItemPreference which launches the existing AddLanguageFragment on tap to select a language. Languages options in the AddLanguageFragment are filtered based on what the language will be used for. setTargetLanguage is added to the TranslateBridge. The Advanced Settings section is implemented as an Expandable Preference Group. Currently the only preference that works in the advanced section is the Target Language. Screenshots can be found here: https://crbug.com/1127531#c5 Bug: 1127531 Change-Id: I18707df2e3736920d1e7a4102b55863b99eb21e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593923 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#842665}
-
Vladimir Levin authored
This patch extends the previous early out to ensure that we skip doing work for post-layout observers in post-lifecycle. Previously the early out only skipped non-post-layout observers in post-layout. R=szager@chromium.org, chrishtr@chromium.org Bug: 1165803 Change-Id: I639354ef603fc1aa25598816f6ef2bb8852f1fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625128Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842664}
-
Xing Liu authored
This reverts commit 3c5bfcbb. Reason for revert: Release build bot is still failing. https://bugs.chromium.org/p/chromium/issues/detail?id=1165869 https://ci.chromium.org/p/chrome/builders/ci/android-arm-official-tests/1731 Original change's description: > Reland "Read later: Fix crash and check URL scheme when adding a reading list." > > This reverts commit abd87a46. > > Diff: > > 1. Use @RequiresRestart for test BookmarkBridgeTest.testAddToReadingList. > > 2. Add a logging in EmptyReadingListManager.Add. > > Notices still can't repro the test failure with batch test script. > > Bug: 1157808,1163225 > Change-Id: I4774d7f3468a6aac07dcde167fd8649d7b1e8d26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622890 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842237} TBR=dtrainor@chromium.org,xingliu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ib282f1fd2aaaab2739c6cf96d25f257d35b511e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157808 Bug: 1163225 Bug: 1165869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625276 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842663}
-
Jeffrey Young authored
Stop manual layout of Ambient mode. Use layout manager to position photo view and Ambient Assistant view. BUG=b/163170162 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I91b52e6e84e6a844ed13fe1c50d1e9389454e8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611024Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#842662}
-
Daniel Hosseinian authored
Keywords are shown a little differently than other property values. Given that the string is expected to be a long list, wrap the property value instead of ellipsing. Screenshot: https://imgur.com/a/GC1hHCx Bug: 93619 Change-Id: I450cdc70067e8a23052ee09c1ce5312a9832f7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623711 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842661}
-
David Roger authored
Change-Id: I7549fbdcb7e37ba59a791119523ea1b8f250c3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624730 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842660}
-
Joel Riley authored
This came up in our team's testing, that it is confusing that the user's reading speed isn't remembered if they activate STS on different Chrome tabs for instance. If STS is hard reset (deactivating feature or reboot), its ok to restore system default speech rate. AX-Relnotes: Select-to-speak will now retain user selected reading speed across sessions, unless Select-to-speak is deactivated or otherwise hard restarts (from reboot, restart, etc). Bug: 1165823 Change-Id: Ia2e456fac2854133714e41c5341cde0ace54ecbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623839Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#842659}
-
Wen Fan authored
Update page most visited info when there is no custom link When you Toggle Most visited sites (InstantService::ToggleMostVisitedOrCustomLinks), the change will not be notified to the page if there is no custom link. The add shortcut button status will not be correct. Bug: 1161688 Change-Id: Ia18355afc4686aa881d5c0c57b8a7e8bb97925de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612334 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#842658}
-
Xing Liu authored
For snackbars that don't have action buttons, currently talkback will read out "Added to reading list. null. Options available near bottom of the screen". We should check whether content description for the action button is null when generating the accessibility string. Bug: 1164726 Change-Id: Iac7b286a442ce4be01323f686dfc558be56cf33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622735 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#842657}
-
Łukasz Anforowicz authored
This reverts commit bbc4b0fe. Reason for revert: Gathered sufficient diagnostics - DwoC reports can be found in https://crbug.com/1164906 Original change's description: > Adding DumpWithoutCrashing if StartLoad happens in an MHTML. > > MHTML documents should never trigger HTML requests. Let's double-check > this with an explicit DumpWithoutCrashing added in this CL. > > Bug: 1151438 > Change-Id: I7a518308d85d58cb15deeec579df2f1c41e6abb6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597028 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838787} TBR=yhirano@chromium.org,lukasza@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1151438 Change-Id: I202fc1fdc6972ae6b028d4e89b4d827663d3e06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624532Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#842656}
-
Tommy Martino authored
This adds a helper function that platforms can use to determine if the current site's URL should prevent the Link to Text feature from being offered. This will be called in a follow-up by platform-specific code that enables/disables the option. For the time being, we expect the number of sites affected to be very small and will reevaluate if the list gets longer than ~a dozen. Eventually we'd like to make this more dynamic (possibly delivering the URLs and regexes from a server), but this version is meant to get a very quick spot fix out the door. Bug: 1157981 Change-Id: I1785459b298d93528415d8735aaa01c4d7a7769e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587432Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#842655}
-
Ionel Popescu authored
This CL removes the hover effects for controls on Android since it isn't really applicable for touch screen devices. In the future we could further refine the behavior for desktop that have touch support to differentiate based on the available pointing devices, but since we haven't received any feedback I will not update the behavior for now. Bug: 1160076 Change-Id: Id1fe4b9e2c9dfc226c7183584cc44fa23df76661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622840Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842654}
-
Dana Fried authored
LayoutManagerBase::GetAvailableSize(host, child) will now do the following: - as before, if the cached layout is still valid since the last call to Layout(), it will return the available size of |child| in |host|'s layout - if the layout has been invalidated since the last call to Layout(), a new cached layout for |host| is calculated, which will be used in the next call to Layout() assuming the layout is not invalidated again This gives us two guarantees we did not have before: 1. instead of returning [no bounds], a correct size bound will almost always be returned 2. a safeguard is in place to ensure that we don't get a stale value during |host|'s layout calculation - in fact, we no longer allow the method to be called during |host|'s layout calculation (it will DCHECK()) In general it is legal to call GetAvailableSize() during |child|'s Layout() - which happens after |host|'s layout is committed - but not during, for example, a FlexRule computation. It doesn't make sense for a FlexRule (or similar) to call GetAvailableSize() because it already receives a size bound from the caller. This also fixes a potential issue (related to crbug.com/1041614) which could result in a view calling layout code in response to certain types of widget setup (among other possible situations) before the layout's child data is updated, resulting in a DCHECK() or crash in the layout manager. (For at least the short term an example crash can be found here: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8858322112097966752/+/steps/unit_tests__with_patch_/0/logs/Deterministic_failure:_PasswordSaveUpdateWithAccountStoreViewTest.HasTitleAndTwoButtons__status_CRASH_/0) Change-Id: I3e491c3cb7a648867597ecf830fe52d11f483419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622720 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#842653}
-
Daniel Hosseinian authored
Polish the properties dialog to gracefully handle long values. Per UX guidance, set the max width of values to 300px and ellipse the rest by default. "Keywords" will later override the CSS to wrap instead of ellipsing. Screenshot: https://imgur.com/a/wD5sMrt Bug: 93619 Change-Id: Iab80a500c596447da8648871e2105b1b649d64f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622581 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Ben Pastene authored
The builder was duplicated on chromium.memory with: https://chromium-review.googlesource.com/c/chromium/src/+/2615132 This deletes the old builder now that the new one is running green: https://ci.chromium.org/p/chromium/builders/ci/linux-ubsan-vptr Bug: 1137496 Change-Id: Id7c6a1a520671124d4618b9d30dd12cb68b0ee97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615665Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#842651}
-
Becca Hughes authored
It was used by Kaleidoscope which has now been removed. Change-Id: I03b0a6cf4d0da45f12b80d3eab8b0fbd041a5523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613284 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#842650}
-
Daniel Hosseinian authored
Both properties are already loaded by the PDF Viewer UI, so there's no need to send them again from the plugin, unlike the other properties. Bug: 93619 Change-Id: I223fcc10d758da910bbf0b65bef5e4f6763ac210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622576 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
On devices that do not support multi-windows, iOS will still interpret "swipe gesture" as a request from the user to close the window and will use a new session identifier on following startup. To avoid losing state, there exist a workaround that load the session using the old session identifier on those device but the workaround was only applied to the regular tabs, thus it was possible to lose incognito tabs in that case. Refactor the code setting the session identifier in Browser to be shared between regular and incognito BrowserState. Bug: 1153606 Change-Id: I833978da3697c88d8d31ab956f91be840d1e74e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622393 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#842648}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7f0e7d0d262a..c0ef8ccfcd8b 2021-01-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 348ba200aa29 to 3549479dc4cc (3 revisions) 2021-01-12 jonahr@google.com GL: Clean up Display code related to multithreading 2021-01-12 syoussefi@chromium.org Reland "Use is_apple instead of is_mac and is_ios everywhere" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1161513 Tbr: timvp@google.com Change-Id: I9e34c9eac5ecf17cf015d835d1ee22139ea8d91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842647}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c0b5a6bb2b2..c8e16bbe32be 2021-01-12 egdaniel@google.com Add recycled gpu resource ref counting and use it in GrVkCommandBuffer. 2021-01-12 tdenniston@google.com [svg] Implement feGaussianBlur 2021-01-12 jvanverth@google.com Fix issues with MTLPixelFormatBGR10A2Unorm on older OSes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I96cac990a1163f9bf528de3c04ab9549d39b5ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624950Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8d7ce656. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm jsbell@chromium.org: external/wpt/service-workers/cache-storage yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ib6cf2e6dcfdceab26112360fbf4a7fb91170b103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624867Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842645}
-
Jan Krcal authored
This CL disables the FRE for profiles created through the updated profile creation flow (as the user is presented with a very similar sign-in promo in the flow). Bug: 1115056 Change-Id: Iff161d371d32fc369a26a0a2e3f99daa2b1f8fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624212 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#842644}
-
Jeffrey Cohen authored
Bug: 1164076 Change-Id: I95c40a60e3d68958c5f3d0d7002534dafc332b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616865 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#842643}
-
David Black authored
Previously the pin button was 8dip from the edge of the view. The spec calls for 4dip. This CL also reduces scope of screen capture related constants.h Bug: 1165348 Change-Id: I585b332e82735ecad2dcc2707928a39a2ebbc76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624030Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea9b5bbcb53e..e2ffb3742633 2021-01-12 tvanderlippe@chromium.org Remove Closure-related types in legacy-defs 2021-01-12 tvanderlippe@chromium.org Move String.hashCode into string-utilities 2021-01-12 tvanderlippe@chromium.org Move unescapeCssString into elements/ 2021-01-12 jacktfranklin@chromium.org Remove Set#firstValue proto method 2021-01-12 tvanderlippe@chromium.org [module.json extensions] coverage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549,chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1b74af1acfe9a5ed67e93cb5aab2114ffeaf8943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624948Reviewed-by:
-
David Tseng authored
ChromeVox's cursors module contains a clean, clear, and simple interface to work with the ideas of positions (cursors) and ranges over the automation tree. It predates and largely motivates the creation of AXPosition/AXRange in ui/accessibility. Future changes will attempt to rebase these js classes partly or completely on top of their native counterparts. R=dmazzoni@chromium.org Test: existing (moved) tests. Change-Id: Ie27cd9ae2c2b406c8f2edcc5148dee03d7bb6281 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622053Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#842640}
-
David Black authored
Problems addressed: - Selection ring was too small - Focus ring was too tight around view - Focus ring had wrong corner radius Before: http://shortn/_cqPPbTDIUI After: http://shortn/_Bvt34oqzIC Bug: 1147182, 1163739 Change-Id: I1e70ad9ffa00d0e57e32ea1f77ba5201ef79a8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623707Reviewed-by:
-
Chris Davis (EDGE) authored
During early startup a call is made to GetHardwareInfoSync which queries WMI for the model, manufacturer and serial number. Querying WMI is an outbound call that can hang. I have looked at traces showing 100-500ms outbound hangs. The model and manufacturer strings can be read from the registry for windows in a known location. This isn't the case for the bios serial number, but it turns out nobody is using that anyways (at least through GetHardwareInfoSync) so I am removing it. Bug: 1164623 Change-Id: Iabb414f42f75008730440529b055d5951ce37dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619419Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842638}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53a231c0ae86..e3e59aac750e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If0a15388e0958f5932e0746a9357370a9999464a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624529Reviewed-by:
-
David Black authored
It was previously assumed (at least by me) that hiding the holding space tray would result in closing of the holding space bubble. This was not actually guaranteed to be the case. This means that it was theoretically possible to keep the holding space bubble open even after detaching the holding space model and client, though I have not been able to reproduce this in the real world w/o forcing state programmatically. It's possible that a user was able to reach such a state which could result in the crash in the attached bug if interacting with the Files app chip. Bug: 1165305 Change-Id: I039072d2d07eaf741ae70d551ac7889eaee0a46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623726Reviewed-by:
-
Kevin Ellis authored
Source of the flakiness fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2621924 These tests were not actually able to run on the compositor since the keyframes where empty and thus not affecting a property that could be composited. The flakes were appearing on both the virtual and base test suites; however, only the virtual version was disabled. This patch re-enables the test in the virtual test suite. Bug: 1139023 Change-Id: I4811b7fa0850cb7346448e008f4652eda547f372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622340Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#842635}
-
Norge Vizcay authored
* A new service is introduced to act as a bridge between Java and c++ password store and provide the required functionality. The service supports the following directives: - Clear all password store credentials. - Read password store credentials. - Write credential into the password store. - Edit credential from password store. More context: https://docs.google.com/document/d/1baR4V7_1myXAGRBve6tjH7M1y3b46NLSMCmvwUniTng/edit?usp=sharing&resourcekey=0-zhjniBnKxbx700x72JViMg Bug: 1164365 Change-Id: Ic343609d738524a597a724593ae5bf4d766738e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591128 Commit-Queue: Norge Vizcay <vizcay@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#842634}
-
Stefan Zager authored
Change-Id: I40207e26b973cf669b0a45b4215c486e2bcc29fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617057 Auto-Submit: Stefan Zager <szager@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#842633}
-
Yao Xiao authored
Use floc-accessible-since to bound the history query time range (in addition to 7-days-ago-from-now). floc-accessible-since represents the point in time from which history is eligible to be used when calculating a user's floc id. It will be reset to base::Time::Now() when a user clears all cookies, or when the browser restarts with "Clear on exit" enabled. When the floc-accessible-since is updated to be greater than the begin time of the history used to compute the current floc, invalidate the current floc. This could happen at the browser startup, or during a browser session when getting an explicit notification. We only invalidate the floc rather than recomputing, because we don't want the floc to change more frequently than the scheduled update rate. Bug: 1157383 Change-Id: I60708820b353ae3c30be6eb34fe0596a6080003f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617622 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#842632}
-
Takumi Fujimoto authored
Media.Remoting.VideoPixelRateSupport - How big the video resolution is and whether it's supported Media.Remoting.Compatibility - Record various reasons why the media may not be compatible with remoting Bug: 1163944 Change-Id: I3c46662b71a7a860d6e63f6db3218c9c576d4305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605289Reviewed-by:
Jordan Bayles <jophba@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#842631}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c60dda78e4ab..002c03c4b6ed 2021-01-12 treehugger-gerrit@google.com Merge "Remove legacy flow event macros" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I144976791692c27e80ec030195215d3869c14119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623432Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/469db8fabd5f..3889691dd695 2021-01-12 zmin@chromium.org Disable ActionRunnerTest.testSwipe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1164657 Tbr: eseckler@google.com Change-Id: I2d7a0ceeed66aeacb5ba3c947baa38c2d57711b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624947Reviewed-by:
-
Jonah Ryan-Davis authored
Update ANGLE's active histograms to expire on Jun 30, 2021, and make sure they each have 2 owners. Bug: chromium:1165066 Change-Id: I78a421a54f74e7a24f889abf286c514da6f70b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622278Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#842628}
-
