- 08 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d9ed1c2732ba..c03ce008b9fe git log d9ed1c2732ba..c03ce008b9fe --date=short --no-merges --format='%ad %ae %s' 2019-11-08 bclayton@google.com Kokoro: Allow 'Fixes:' in bug check Created with: gclient setdep -r src/third_party/swiftshader@c03ce008b9fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I14335fc30741957daa56b0cd8b9c096888608a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713915}
-
Simon Que authored
Bug: 1022686 Change-Id: I925f5f3922ba297349af65a60705cb4970d3cff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906386 Commit-Queue: Simon Que <sque@chromium.org> Auto-Submit: Simon Que <sque@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#713914}
-
manuk authored
Previously, the DemoteByTypeRule was only usable if the params were set in the OmniboxBundledExperimentV1 study. With this CL, a group in any study that enables the OmniboxDemoteByType feature will also be able to set the params. Bug: 264066 Change-Id: I7f0695f4cb71e46a7a533d240db2e91f105cda03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903665Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#713913}
-
Bruce Dawson authored
The Windows 10 19013 Preview SDK has an extra UCRT file in the debuggers directory and this file (api-ms-win-downlevel-kernel32-l2-1-0.dll) is needed when running cdb.exe on Windows 7. This change allows the copy_cdb_to_output action to run with 18632 and later SDKs. Once we require a later SDK we should add the new file to the list of outputs for this action but this will smooth the otherwise bumpy transition. Bug: 10216507 Change-Id: I2304aea73dfcd25258697c37d05b05dc6adff55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904873Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713912}
-
Jinsuk Kim authored
With https://crrev.com/c/1898161, HistoryNavigationDelegate returns nulled-out BottomSheetController when the activity is already destroyed. All the public methods of NavigationSheetCoordinator should take it into account and early out in any calls to them when it is detected. Bug: 1022285 Change-Id: I605a136f73c4e33ac880142321c3205b12eff940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906846 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#713911}
-
Robert Liao authored
These appear unused and some use ATL. BUG=5027 Change-Id: I3b9ffae2134d03afe74e054ac7ce7896294db898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906257 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713910}
-
Rouslan Solomakhin authored
Before this patch, specifying an empty list of modifiers would crash Android PaymentRequest, because it would clear its own list of modifiers before initializing it. This patch checks that the list of modifiers is initialized before clearing it. The new test EmptyParametersTest.NoCrash crashes without the patch and passes with the patch. After this patch, specifying an empty list of modifiers does not crash Android PaymentRequest. The android_browsertests were chosen to make sure both Android and desktop behave correctly. Although WPTs could also find the bug, they currently don't run on the waterfall (neither desktop nor Android). Bug: 1022810 Change-Id: I661aa80889822a73939c5f96662dc3531689a85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906806 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713909}
-
Shivani Sharma authored
Bug: 932236 Change-Id: I4a30d7f9230682b75215f753ddc4e128e1c45be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790062 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#713908}
-
Rob Buis authored
Blink currently does not properly render MathML but allows authors to specify fallback content via an annotation child of the <semantics> element. This is implemented by CSS rules in a dedicated UA sheet. This CL adds a mathml-fallback.css UA sheet with the same CSS rules and uses it when MathMLCore is disabled, in order to preserve existing behavior in that case. When MathMLCore is enabled, the existing mathml.css UA sheet is still used for now but its content will be modified in future CLs when the MathML implementation is refined. Bug: 6606 Change-Id: I4d68f10185d7e25f64bffeee0da5a184fac39932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904186Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#713907}
-
Eric Roman authored
Bug: 1021236 Change-Id: Id03f517e8a5ed285c695d51b54182f99d3c91fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904866 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#713906}
-
John Z Wu authored
- Implement GetURLLoaderFactory() - Implement GetIdentityManager() - Use a real SyncCredentialsFilter - Implement GetPasswordSyncState() Bug: 867297 Change-Id: I1b4fddc1601b7cfd007957ca88ea493d35e55555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904869Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#713905}
-
Etienne Pierre-doray authored
Bug: 839091 Change-Id: Ie40872cdd6a7ea1d5d628a8aa49b0df5b9f48a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904269 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#713904}
-
Antonio Gomes authored
The replacement is now possible that all users are in Blink. Essentially, the former is a pure interface for the later. As a follow up step the use of WebString will be replace by WTF::String. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I84f540d050e72180a9026f595e586d1319efed1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904669 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#713903}
-
Peter Kotwicz authored
This CL removes the --aggressively-prewarm-renderers command line flag. I am deleting it because there are no plans on turning on the flag behaviour by default. BUG=1022819 Change-Id: I6fcfe9be782ed5a1f20831b89b356b28e1671045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906310Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#713902}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/99b558b594a1..2e30fde04687 git log 99b558b594a1..2e30fde04687 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 jlavrova@google.com Font resolution: all unit tests working 2019-11-08 kjlubick@google.com [canvaskit] Expand SkAnimatedImage 2019-11-08 kjlubick@google.com [canvaskit] Fix null dereference when GrContext cannot be made 2019-11-08 egdaniel@google.com Handle failure to create VkRenderPasses in vulkan backend. 2019-11-08 mtklein@google.com Pre-flight SkTLS_pthread changes for C++17 2019-11-08 mtklein@google.com remove redundant comparison ops Created with: gclient setdep -r src/third_party/skia@2e30fde04687 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: Idfcc045a389982ea02602897440dba6aca1787a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906867Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/814c68a9..2a7f3180 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I63eddd17a3834c7fd9be6ae356da51c9dd1a32ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906826Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713900}
-
Mario Sanchez Prada authored
As agreed on crrev.com/c/1879260, we are now renaming this interface to prevent a naming clash now that we have migrated to the new Mojo types, which would lead to confusing situations like having a mojo::Remote<video_capture::mojom::Receiver>. Bug: 955171 Change-Id: I2fdc736643ac652de6db27af1de593ee13ca83f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901468 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#713899}
-
Simon Que authored
Bug: 1022800 Change-Id: Ibb932d484610190dbc95814f21b5b7c5bb2aa5f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906446Reviewed-by:
-
Mei Liang authored
This CL adds an API to TabSelectionEditorController that shows the TabSelectionEditor with the given tabs, and the first n tabs being selected. There is also a divider shows between the first n selected tabs and the rest of the tabs. Change-Id: I32aa764dc62bbabc89fe54641963b9f64274134e Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896866Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713897}
-
Peter Boström authored
After r713254 there are hopefully no longer performance issues with enabling FocusRings everywhere. Bug: chromium:924232 Change-Id: I99cca2635f3d618d72b2371ce6a07eecea01ffee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903611Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713896}
-
Michael Wasserman authored
This reverts commit efd7d333. Reason for revert: BackForwardCacheBrowserTest.WebMidiNotCached is consistently failing since this landed on at least one bot: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8840 Tracking as part of Bug: 1022876 Original change's description: > BFCache: Add a browser_test for WebMIDI > > Bug: 981740 > Change-Id: I40605b9b6b343a3e0b4a12fe3b0e5e0b6f992390 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903182 > Commit-Queue: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Fergal Daly <fergal@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713734} TBR=toyoshim@chromium.org,kouhei@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org,fergal@chromium.org Change-Id: Ibb109e18bec2fc12305efc483972acb743c75714 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 981740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906874Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#713895}
-
Alison Maher authored
When LayoutNGListItem::OrdinalValueChanged() is called on an ":after" list item element, |marker_| is a nullptr. Similar to LayoutNGListItem::ListStyleTypeChanged(), we need to check that |marker_| is not nullptr before invalidation to avoid null-dereferences in this case. Bug: 1020669 Change-Id: I66913cde0420a3612e881dab9e44a006c276ec64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902666 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713894}
-
Xing Liu authored
Range [111000000, 111999999] is reserved for Chime job scheduler. Bug: 1013386 Change-Id: Ia211cf20adc4580bcdbb6fcc3303dc0fd4367c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904947Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713893}
-
Toni Barzic authored
Updates WindowTransformToHomeScreenAnimation to use window_util::HideAndMaybeMinimizeWithoutAnimation(). Change-Id: I3cb191d72a351bf6dd700857b85d2b0775aa4bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905268Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713892}
-
Avi Drissman authored
Work around an Installer.app bug. Bug: 1022413 Change-Id: I4eab147d15bcae44f1d0fc6a4e4da9ac78a34772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904688 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#713891}
-
Bruce Dawson authored
The post_build_ninja_summary.py uses "weighted time" as one of its key measures to summarize build performance but this is only documented in a comment in the script itself. This adds documentation to the page that recommends using this script for build-speed investigations (chiefly through set NINJA_SUMMARIZE_BUILD=1). This also updates the example output to say elapsed time instead of the inaccurate term CPU time. Change-Id: I148df429722a33f70123d9f3076b1b7e5e6cb347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902113Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713890}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1917f7a09940..d5c0b56e84e0 git log 1917f7a09940..d5c0b56e84e0 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 danakj@chromium.org Use git fetch --no-tags to fetch commits to apply via cherry-pick. Created with: gclient setdep -r src/third_party/depot_tools@d5c0b56e84e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1019824 Change-Id: I82a2b944fd99329515f04e978c11cd5310ed3335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906868Reviewed-by:
-
Elly Fong-Jones authored
TBR=lazyboy@chromium.org Bug: 1003244 Change-Id: I88bfd3e89650a53fb6701685fa317f6cd6100f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906946Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#713888}
-
Mike Dougherty authored
Bug: 987646 Change-Id: Ie3ad81dddbd70f63f5ee1a251490913224bcb8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898514 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#713887}
-
Aaron Krajeski authored
It seems like maybe this was just overlooked? The fix is as easy as adding it to the idl file. It seems like this is already in the spec as: https://html.spec.whatwg.org/multipage/canvas.html#offscreencanvasrenderingcontext2d contains the line OffscreenCanvasRenderingContext2D includes CanvasTransform; And https://html.spec.whatwg.org/multipage/canvas.html#canvastransform lists the getTransform() function. Bug: 1016454 Change-Id: Icb5405d716524e2a0b6935db81b18ff53cd31d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872562Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#713886}
-
Ana Salazar authored
Bug: 1020386 Change-Id: Ife52a8257203b980492d77f4290b4bf1802f8c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902229 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713885}
-
John Z Wu authored
Bug: 723854 Change-Id: I6cb7a4c60dd458c76d59019175c04984e0b75abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904757Reviewed-by:
-
Eric Seckler authored
This reverts commit 0d929861. Reason for revert: Breaks UBSAN builds (crbug.com/1022818). Original change's description: > perfetto: Use TraceProcessor for proto2json conversion > > TraceProcessor replaces the existing (unmaintainable) proto2json > converter and adds features like combining of BEGIN/END events > and support for heap profiles. > > Also updates a devtools test that was expecting separate begin/end > events where TraceProcessor now combines them into a complete event. > > We have reduced the trace procesor's binary size overhead > by selectively excluding features Chrome doesn't need from >400kB to > ~50kB. We could probably save a couple more kB if we invest even more > eng time and accept the maintenance burden for this in trace processor, > however, we feel that we've reached an acceptable state that balances > binary size & code health. > > Binary-Size: see paragraph above. > Bug: 1006770 > Change-Id: Ia7f6b3a784c1a9c40574e1dcd80eca1ca2dfb03f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746258 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713593} TBR=caseq@chromium.org,oysteine@chromium.org,skyostil@chromium.org,eseckler@chromium.org Change-Id: Icc6bd802248c59d82d9697caaaae65a98f0487cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1006770, 1022818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907006Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#713883}
-
Nektarios Paisios authored
This is a followup to crrev.com/c/1796047 This patch changes AXPosition::CreateNext/PreviousCharacterPosition so that it can also accept the BoundaryBehavior::StopIfAlreadyAtBoundary. This is necessary to be able to support navigating through characters that are not in the basic multilingual plain when using IAccessible2 and ATK. If a client calls e.g. IAccessibleText::get_CharacterAtOffset and the provided offset is in the middle of a multi-byte character, both the start and end offsets need to be adjusted. We can't always assume that only the end offset would need to be changed in order to cover the range that a particular character occupies. R=dmazzoni@chromium.org, kbabbitt@microsoft.com Bug: 720370 Change-Id: I1ce87325da2479b9d8d7085adae8aac41f79f294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888540 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#713882}
-
Alex Moshchuk authored
It is possible for window objects in <webview> tags to have window.opener relationships. In particular, one <webview> can use window.open('', 'foo') to look up another <webview> which has window.name equal to 'foo', and update its window.opener to point to itself. This triggers an UpdateOpener IPC, which ensures that the new opener chain has proper proxies so that 'foo' is able to reach any frame on that chain (see RenderFrameHostManager::DidChangeOpener). Unfortunately, this had a bug because the proxy creation also tried to create proxies for the outer delegate (i.e., the chrome app) SiteInstance, for all frames on the new opener chain, including subframes. This is wrong because we intentionally do not want to expose a guest's subframes to the embedder -- see RenderFrameHostManager::CreateProxiesForChildFrame(), which intentionally skips the outer delegate's proxy. In this case, this later led to a crash in CreateRenderFrameProxy(), because the proxy we tried to create for a subframe didn't have a RenderViewHost (which is intentional -- we do not create a RVH for the outer delegate's SiteInstance, just the proxy, and only for the guest's main frame). This CL fixes this by ensuring that we skip the outer delegate SiteInstance when creating proxies for subframes in CreateProxiesForSiteInstance(), which is used when updating the opener chain as well as more generically (e.g., when creating speculative RenderFrameHosts). This hopefully will better protect against this type of bug in the future compared to a more targeted fix in opener update logic (e.g., if/when we add OOPIF support in GuestViews). Change-Id: I6a2e452883faa140a86523b2afda372c62cbdbcb Bug: 1013553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903245Reviewed-by:James MacLean <wjmaclean@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713881}
-
Michael Lippautz authored
Pre-finalizers are heavy and not supposed to be used on short-living small objects. Spend an additional word to store the header on registration. This allows inspecting liveness without going through a call on every garbage collection. Bug: 982754 Change-Id: I30a2d60198dd6b2b49febcd49983d17175874dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904177 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#713880}
-
Scott Graham authored
On being asked to review https://chromium-review.googlesource.com/c/chromium/src/+/1732329/30#message-bf7d81a19611d7d93e129ac9921dbea9f690ae3e I realized I'm not too up-to-date on the latest Chromium styles, so I should probably remove myself here. Removed cpu@ too, as I don't think he's active here any more. Change-Id: I7bdfa937384c931dbb6d6b5f52d0fefb76296864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906253Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713879}
-
John Z Wu authored
- Turn on kAutofillNoLocalSaveOnUploadSuccess so that uploading a card does not create a local only copy. - Turn on kAutofillNoLocalSaveOnUnmaskSuccess so that unmasking a card does not save a full card locally. - Remove ability to delete cards from Google Pay. - Add menu item to go to payments website. Change-Id: I009ab5b1671320f8eac0c10d7e3c0843a2139c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904541Reviewed-by:
-
Toni Barzic authored
Change-Id: Ic6231566fbf929d263ce69dcf2437e7650d3d5fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904337Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713877}
-
Wez authored
Bug: 999737, 706728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780074 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#712377} Change-Id: I627b5250055233ea89718a9143de356c85633add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905270 Cr-Commit-Position: refs/heads/master@{#713876}
-
