- 25 May, 2020 39 commits
-
-
Yoshifumi Inoue authored
This patch changes "block-style-00{1,2}.html" to utilize |selection_test()| and integrates into "block-style-001.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ic2ae843b078ab9d85d6a7cb47337458fe3b031eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214584 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771480}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. The use of the function in SearchPermissionsServiceTest is updated and a new test is added for non-primary off-the-record profiles. Bug: 1060940 Change-Id: I39d1451c386d93fb47cbf2576d3b4280e634cb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213563 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#771479}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590362592-27d6169705690c1f85a434239769339f2909dab4.profdata to chrome-win32-master-1590378757-fbe5ba418cc3b4a3b6daa4da92a12bf985342290.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5cfb578711a914a50ef8fa68ef46d0a5f7ce42a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214688Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771478}
-
Xianzhu Wang authored
Adjust the order of field to fill gaps after inherited fields. Change-Id: Iafb34294d0643ffc4f761921a8382b595897463d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214462 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771477}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590362592-b410bf229b3e4363919a6ee2322f1e85184470ca.profdata to chrome-mac-master-1590378757-0e86ea9817fe6c644c14c0cd7e1701a48ebcda53.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I07879cf3c4faa1fd573ef6432a857687fa3bc63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214685Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771476}
-
Yoshifumi Inoue authored
This patch changes "4916887.html" to utilize |selection_test()| and renames to "color_of_indented_text.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I97c3a41130d62af6b4255fd161d9f21aaeccb5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212239 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771475}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e6d4f1bcfd1..b5391d98b8d8 2020-05-25 csmartdalton@google.com Reland "Reland "Add a tessellation mode that uses indirect draws"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I526850c2a739f159ef2d0c695cbb2cf9fae86271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214681Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771474}
-
Alexey Baskakov authored
We should break down this synchronous call chain: web_app::WebAppSyncBridge::CommitUpdate() web_app::ScopedRegistryUpdate::~ScopedRegistryUpdate() web_app::WebAppInstallFinalizer::UninstallWebApp() web_app::WebAppInstallFinalizer::UninstallWebAppOrRemoveSource() web_app::WebAppInstallFinalizer::UninstallExternalWebApp() web_app::InstallFinalizer::UninstallExternalWebAppByUrl() web_app::PendingAppManagerImpl::UninstallApps() web_app::PendingAppManager::SynchronizeInstalledApps() web_app::ExternalWebAppManager::OnScanForExternalWebApps() web_app::ExternalWebAppManager::ScanForExternalWebApps() web_app::ExternalWebAppManager::Start() web_app::WebAppProvider::OnRegistryControllerReady() web_app::WebAppSyncBridge::OnDatabaseOpened() web_app::WebAppDatabase::OnAllMetadataRead() syncer::ModelTypeStoreImpl::ReadAllMetadataDone() WebAppSyncBridge::OnDatabaseOpened() must not cause immediate WebAppSyncBridge::CommitUpdate() on same `this`. Bug: 1084939 Change-Id: Ib32c52780a647a0985418c0f92985f041869f104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212236Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#771473}
-
Kent Tamura authored
active_selection_*_ data members are referred only in listbox mode. We don't need to update them in the menulist mode. Bug: 1052232 Change-Id: Ib688c6e9977f42cd1cefdd83388fdc286345b842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212108 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#771472}
-
Yutaka Hirano authored
This reverts commit fb330032. Reason for revert: Failing on bots: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/b8879653217445589120 Original change's description: > Add tests for QuickAnswersView > > Add a test-fixture and basic tests for QuickAnswersView. Current tests > verify the view's positioning with respect to its anchor and more tests > will be added in follow-up CLs. > > Bug: b:157182213 > Test: Built and ran ash:ash_unittests on local build. > Change-Id: I44634313ff6538e48ef7375641e1971bfc989ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210977 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Abhijeet Singh <siabhijeet@google.com> > Cr-Commit-Position: refs/heads/master@{#771207} TBR=xiyuan@chromium.org,siabhijeet@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:157182213, 1085632 Change-Id: Iedb2530ed4d8c6b56ba8b5f3fe42fcc4d0052c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212238Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771471}
-
Hiroki Nakagawa authored
This CL renames ServiceWorkerHost's running_hosted_version to version because it's obvious that the version kept by ServiceWorkerHost is the running hosted version. Bug: 931087 Change-Id: Icfa6ae852418c7e089b254b19a745756fd6d3c74 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206935 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#771470}
-
Bo Majewski authored
Rather than counting time since last time we scheduled a throttled change event, we count time since last time we posted one. This allows us to post an event with 0 delay first, before starting to throttle them. Bug: 936790 Change-Id: Id9a40890d8d7fdb53e57f657c979f2ac5f4f7f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210089Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Bo Majewski <majewski@chromium.org> Cr-Commit-Position: refs/heads/master@{#771469}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c63db0f9a76..7ca48df80a7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yhirano@google.com Change-Id: I2761e57aacdfe89c7024132321c6188aa5e10b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214580Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771468}
-
Yutaka Hirano authored
Tbr: yigu@chromium.org No-Try: True Change-Id: I95fdbddabf525f5455574622e138874b5245044e Bug: 1060164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213644Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771467}
-
Fergal Daly authored
Move a lot of stuff from constructor to initializers and mark fields as const where possible. Also - add comment referencing https://crbug.com/855189 - delete GetClientHintsPreferences which is unused. There's more that can be done but this is all of the stuff that was easy. Change-Id: I97bc5b9cc67fada0bb57426271fd38c376adcac9 Bug: 855189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203040 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771466}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ff64aa2b. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" fc4093a6 "Move mouse-pointer-preventdefault.html to wpt" 3304d0fe "Revert "Move mouse-pointer-preventdefault.html to wpt"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I700238d8da3501763e14cda400d973e536be2b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212388Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771465}
-
Alex Danilo authored
Adds a transition for the background-color property on the search box wrapper so that it fades out while the search text entry field is collapsing to stop the sudden change of color when the text field starts to collapse. Bug: 1075941 Change-Id: I25d38c2db817b2585b8c86c046e5d88e041ec30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210297Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#771464}
-
Hiroki Nakagawa authored
ServiceWorkerProviderHost is equivalent to RenderFrameHostImpl, DedicatedWorkerHost, and SharedWorkerHost. For name consistency, this CL renames ServiceWorkerProviderHost to ServiceWorkerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I583838006e8c10540acbe0a2681d11b8d9aad1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203781Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#771463}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I1c87ca2f4b9de688f18e382c187c13911950a3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214622Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771462}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ie6278431712a48c834491a56afc352a7ff63fa5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189714Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#771461}
-
Yutaka Hirano authored
virtual/cross-origin-isolation was removed at https://crrev.com/c/1975477. virtual/stable/external/wpt/html/cross-origin-embedder-policy was removed at https://crrev.com/c/2096403. Bug: 1086065 Change-Id: I89655a99ff9de4be8357e8640fad95602b941d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212018 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771460}
-
chrome://newtabYutaka Hirano authored
This reverts commit 8ba04bb7. Reason for revert: DiceBrowserTest.EnableSyncAfterToken is failing. Original change's description: > WebUI NTP: redirect sign-in to chrome://newtab (reland) > > This is a reland of 142274a8 with a fix > for DiceBrowserTest.EnableSyncAfterToken. Original change's info: > > Bug: 1015293 > > Change-Id: Ic76e7911403a925fa46a5b5fc58eca95fa292269 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209392 > > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > Auto-Submit: Esmael Elmoslimany <aee@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#771116} > > TBR=thestig@chromium.org > > Bug: 1015293, 1085540 > Change-Id: I05450e311b9458b6927763cbf6b4c75c0621b56e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212818 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771246} TBR=droger@chromium.org,thestig@chromium.org,tiborg@chromium.org,aee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015293, 1085540 Change-Id: Ic2d3ed8d4c34373fa200563b922a4b4af0b08abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213643Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771459}
-
Jing Wang authored
This is requested by our UX Claire. Add first name and last name, and add one more way to trigger phone number. Updated the unit test. Test: tested with Chrome on Linux Bug: 1042084 Change-Id: Ib9cd1185f8538f2655fc30a2a092de8aa27c4b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210083Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771458}
-
Darren Shen authored
This CL deletes "win" and "linux" specific functions in chrome.input.ime, which resulted in a chain reaction of deletions, including InputImeApi, InputMethodEngine and UI code. This CL is intentionally kept as small as possible. There will be additional cleanups in the future. Proposal doc: http://doc/1eIsYPs2JhzQ8qmM-96amsashfFmAAC9xoYRmY2CIjtM Change-Id: I689badba5157f76b5a92d6a9b705a198760e7f00 Bug: 1083803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198861 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#771457}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/65ee6497d620..31c9c6949e02 2020-05-25 jiawei.shao@intel.com Add tests for image2DArray If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I23b1ecf1131637df8c51cc7a2dc44d9fb7d7d160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771456}
-
Yutaka Hirano authored
The test has been marked as flaky on Mac and Windows, but it's flaky on Linux too. Marge the entries. Bug: 824775 Change-Id: I13e270b3583abcba2f8db6527c8f9305f33b3c47 Tbr: tguilbert@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212016Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771455}
-
Dominick Ng authored
Call TestWebAppProvider::Start() in the tests to stop the App Service waiting for web apps to be published. BUG=1082879 Change-Id: I97912bc2a2cc82fddb9d2a599115b315728342f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212101 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771454}
-
Tetsui Ohkubo authored
According to https://wayland.freedesktop.org/docs/html/apa.html, the drag source should consider the drag is successful when wl_data_offer.finish is called, and unsuccessful when wl_data_offer.destroy is called without finish. TEST=DataDeviceTest.DataOfferNotFinished BUG=b:64963392 Change-Id: I3338e1c1dff7f0860daa8f36bc2d5dcb0b30b873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206300Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#771453}
-
Mason Freed authored
This CL is the result of the following mechanical replacements, within the third_party/blink/web_tests folder, on only .html and .js files: '.createShadowRoot()' -> '.attachShadow({mode: 'open'})' 'document.createElement('content')' -> 'document.createElement('span')' Several web_tests did not pass after the above replacements were made. Those tests were reverted - the changes in this CL are only the tests that pass in the same way that they did prior to the replacements. The only exceptions, which were re-baselined here, had *only* a console warning message like this, which is now missing: CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M80, around February 2020. Please use... In addition, most of the same test expectations files were completely removed from the virtual/web-components-v0-disabled folder, since these tests no longer depend on WCv0 features, and no longer fail. Bug: 937746 Change-Id: I157b48633206ddb249c55a7728c94955e88746b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211053 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#771452}
-
Yutaka Hirano authored
Bug: 971031 Change-Id: I3c6fa661fca7830e58a2903b2d72a5295ecb6d49 No-Try: True Tbr: szager@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212235Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771451}
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include tests of Shadow DOM v0 specific features, such as event traversal across V0 shadow root boundaries, style rules for distributed content, etc. These should be well covered by WPT tests. Bug: 937746 Change-Id: Iaa04fa009604154c299cc1e2a491d3894f5feb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208380 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#771450}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590348122-b4a98cfa761f6a5746f6b74a779b8e835db07494.profdata to chrome-win64-master-1590362592-805b073f67f6767a04b0846155f52acdc9e41f5d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I1e3833eaac15f26645df82b4a4ef3e617f1a3a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214568Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771449}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590348122-c91d474ae42bf6602e65e69b0e8b32c4d4bec034.profdata to chrome-win32-master-1590362592-27d6169705690c1f85a434239769339f2909dab4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae5e5e312b8ff7f14c867a9c7d6d5928878f0fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771448}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590348122-2e26c137c810071abb9373a57153395ae8f3d2ad.profdata to chrome-mac-master-1590362592-b410bf229b3e4363919a6ee2322f1e85184470ca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4ec94a430b077149d1d4dc8c9d36d982fabb46d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214566Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771447}
-
Joel Hockey authored
Change-Id: I94f00041f8f0a738f9e8659839c6e3821c8a3228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214581 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#771446}
-
John Z Wu authored
This will embed the version number into the Info.plist, which can be helpful for clients to verify ios/web_view's version. Change-Id: Id66b0ea25f3e044b37c409cf2cfdf4661ade0e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211915 Auto-Submit: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#771445}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a7c6e8c2045..2c63db0f9a76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com Change-Id: I72e777ac7d884ee6312bf68b54e270f963bbc9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214563Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771444}
-
Mason Freed authored
This CL is the result of the following mechanical replacements, within the third_party/blink/web_tests folder, on only .html and .js files: '.createShadowRoot()' -> '.attachShadow({mode: 'open'})' 'document.createElement('content')' -> 'document.createElement('span')' Several web_tests did not pass after the above replacements were made. Those tests were reverted - the changes in this CL are only the tests that pass in the same way that they did prior to the replacements. The only exceptions, which were re-baselined here, had *only* a console warning message like this, which is now missing: CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M80, around February 2020. Please use... In addition, most of the same test expectations files were completely removed from the virtual/web-components-v0-disabled folder, since these tests no longer depend on WCv0 features, and no longer fail. Bug: 937746 Change-Id: Ie27e959a39e4c6de6655abb13f71b2e0d56853c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208387 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#771443}
-
My Nguyen authored
https://crrev.com/c/2174018 refactors assistive_window_controller so a mock controller in input_method_manager_impl_unittest is no longer needed. Change-Id: I47d6ff51b069451ddd8ec121bcaacc3ca7050d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212233Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#771442}
-
- 24 May, 2020 1 commit
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/477512c0b367..0e6d4f1bcfd1 2020-05-24 csmartdalton@google.com Revert "Reland "Add a tessellation mode that uses indirect draws"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ia2cfd198f5125da49df2675ff0c015c3dcbe5996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771441}
-