GitLab

Change-Id: Ia542a4fdc9ee86b06b23a20a8d01ea0ae562224f
Reviewed-on: https://chromium-review.googlesource.com/c/1347041Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610319}

This updates the expectation for css/css-font-loading/idlharness.https.html
and removes the Failure expectation from TestExpectation file.

The expected.txt file contains some FAIL lines because
- variationSettings attribute does not exist in FontFace (crbug.com/907723)
- FontFaceSet constructor is not exposed (crbug.com/651795)

Bug: 824955,907723,651795
Change-Id: I527badfeea8d21ac16a9bfd20d1f0f255ff553ce
Reviewed-on: https://chromium-review.googlesource.com/c/1347951
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610318}

This CL removes the last remaining traces of GA from files app.

It does not replace the remaining metrics that were being recorded
with UMAs, we're removing them as well as either:
a) There's coverage via an existing UMA, or
b) We don't care to record that metric anymore.

Bug: 847729
Change-Id: I602de642bac43df64f1ecd9035314d5019268aa8
Reviewed-on: https://chromium-review.googlesource.com/c/1347648Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610317}

https://chromium.googlesource.com/catapult.git/+log/aa21a922d4a8..4176781039b6


git log aa21a922d4a8..4176781039b6 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 lwsong@google.com Added new pipeline metrics


Created with:
  gclient setdep -r src/third_party/catapult@4176781039b6

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I0efadf017d22d539a2cb05eddf798cebf43a0589
Reviewed-on: https://chromium-review.googlesource.com/c/1347079Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610316}

ThinLTO caching currently has a bug the shows up in Chrome OS and
causes bad images to be generated with LLD.  This CL disables
ThinLTO caching with LLD for Chrome OS, until we can get the
ThinLTO caching bug fixed.

BUG=chromium:889967
TEST=Tested this patch, build Chrome with LLD in Chrome OS with
ThinLTO enabled, and the resulting images were good.

Change-Id: I549ee133f0a40f9296ab4d57e8054bcb84e801a8
Reviewed-on: https://chromium-review.googlesource.com/c/1345537Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610315}

In the original comparison logic of performance entries, entries are identified
based on entryType, name, detail (if listed) and startTime (if listed). An entry
is set to be found only when all of the attributes match. If any of the
attribute is not found, the test would just said the entry is not found. But
the developer wouldn't know which attribute cause the comparison to fail.

In a new logic, we use the name as the identifier for entries. Once the entry
is found, we then compare their attributes. In this way, developers would know
which attribute caused the failure by the error message.

Another benefit of the refactoring is that it factors out the logic of single
entry comparison. The logic will be useful for test cases in later patches.

Bug: 758385
Change-Id: Ib5721367228f32567efa74cd14a75688fbb34af7
Reviewed-on: https://chromium-review.googlesource.com/c/1346913
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610314}

Chrome internally uses X-Client-Data header, and this should not
triggers CORS preflight request.

TBR=jochen@chromium.org

Bug: 870173, 907018
Change-Id: I67f1711b9065223f9e174e207980940e175031e9
Reviewed-on: https://chromium-review.googlesource.com/c/1335076
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610313}

Bug: 731021
Change-Id: I3a894b0c8e225ed031537a908cdc5a914293b4b7
Reviewed-on: https://chromium-review.googlesource.com/c/1345679
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610312}

Change-Id: I6187c15d04b5c1df5d3fc520a2647b2499d2720c
Reviewed-on: https://chromium-review.googlesource.com/c/1345711
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610311}

Expand the toast notification container to fit large font sizes

Custom link toast:
https://screenshot.googleplex.com/PUqoJ5kQzbt.png
https://screenshot.googleplex.com/E6u8dCk4YLM.png
Error toast:
https://screenshot.googleplex.com/Ky0XtvxYehd.png
https://screenshot.googleplex.com/any2UUBJR04.png
https://screenshot.googleplex.com/a4BLiXdUdre.png

Bug: 899607
Change-Id: Iee80b037e5494a15b2e0a261f1185b435fd1bbc8
Reviewed-on: https://chromium-review.googlesource.com/c/1337439Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610310}

ResourceFetcher::ClearContext() can actually queue microtasks; for
example, pending FontFace loads will be cancelled and reject the
associated promise.

Bug: 907270
Change-Id: I83b18924d494052dad021fb3d8bd427de1b9c40c
Reviewed-on: https://chromium-review.googlesource.com/c/1347095Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610309}

Bug: 783060
Change-Id: I02ab0eb7aa0f540a68be1ddfc34c1b4fc16de8e2
Reviewed-on: https://chromium-review.googlesource.com/c/1347060
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610308}

This callback allows Bluetooth clients on Chrome OS to listen for
connection state changes (i.e., when a device goes from connected to
disconnected or vice versa).

A follow-up CL will add handling for this event in the SecureChannel
service to prevent us from accidentally attempting to connect to a
disconnecting device (see https://crbug.com/898334).

Bug: 898334
Change-Id: Icc18f44106d12a881518f0ece3f0a6e9dd715c0b
Reviewed-on: https://chromium-review.googlesource.com/c/1347204Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610307}

Using wpt-import in Chromium cb59771b.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
jsbell@chromium.org:
  external/wpt/resources

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I9f69112f9257f086bc9c4b41945c4e483c6e27bf
Reviewed-on: https://chromium-review.googlesource.com/c/1347793
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610306}

descendants.

This was added in revision 548120 because at the time paint
offset baked in sticky position. This was since fixed in revision
590578 that factored sticky position into a transform paint
property node rather than paint offset.

All that is required is to re-compute paint properties for the
scroller and all sticky descendants, in order to update the scroll
offset and sticky transform offset. The latter is accomplished
by a call to PLSA::InvalidatePaintForStickyDescendants() in
PLSA::InvalidatePaintForScrollOffsetChange().

Bug: 895109

Change-Id: Ied7ef8fd15db4f5c3d546f0f06f1adf3cf1e26c8
Reviewed-on: https://chromium-review.googlesource.com/c/1345031Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610305}

This adds support to change the URL of a redirect by a URLLoaderThrottle. Similar to changing the
URL at the start of a request, the new URL is restricted to the same origin.

This new functionality is only supported when the network service is enabled. This is because the
only way to change the URL that is followed after a redirect is through
NetworkDelegate::OnBeforeURLRequest. When NS is disabled the NetworkDelegate
(ChromeNetworkDelegate) and the URLLoader implementation (MojoAsyncResourceHandler) are in
different layers (chrome and content). I didn't want this functionality that is in content/ to
depend on chrome/ to make it function correctly. Since the old path is already fixed by r608599 and
that code will be deleted once network service ships, I've left it as is.

A lot of files change because two core interfaces are changing:
1) URLLoaderThrottle::WillRedirectRequest gets a non-const net::RedirectInfo
2) URLLoader::FollowRedirect gains a "url.mojom.Url? new_url"
The interesting parts in this cl are url_loader.mojom, url_loader_throttle.h,
throttling_url_loader.*, loader_browsertest.cc, network_context.cc, url_loader.* and
google_url_loader_throttle.cc.

Bug: 899268
Change-Id: I512de64600500f7e7851aaa0b57f6e46f6cb8001
Reviewed-on: https://chromium-review.googlesource.com/c/1341002
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610304}

shortcut handling to work with RU keyboard.

Added tests to verify expected behavior for US, DV, RU keyboards.

Bug: 725869
Change-Id: I9b81f0bca5fed786fa5b152e25b646cd188ca2a4
Reviewed-on: https://chromium-review.googlesource.com/c/1341444Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610303}

Bug: 523292
Change-Id: I24c947f4d33e779ff5b278d855c262cdea87dc3e
Reviewed-on: https://chromium-review.googlesource.com/c/1347639Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610302}

Test: manual
Bug: 889848
Change-Id: I4f7c510e28541bc596c46b8ccd16623dea27fd2b
Reviewed-on: https://chromium-review.googlesource.com/c/1347645Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610301}

This CL fix the issue that Camera App don't launch when Play Store ToS
dialog is shown. Now GCA will only be launched when it is ready. Otherwise,
just fallback to launch CCA.

BUG=b/119152926
TEST=Tested by enabling/disabling Google Play Store in Settings App and it works as expectation.

Change-Id: I51c0a80a3eb6160429b98d40adaf5c56e28d6b61
Reviewed-on: https://chromium-review.googlesource.com/c/1339089Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610300}

Chromium sheriff.

TBR=wez@chromium.org

Bug: 907717
Change-Id: Id0a5bb81ed623572e87f19b9229048febdd3ff2c
Reviewed-on: https://chromium-review.googlesource.com/c/1347642Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610299}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: I1967c870d9f1f81f7629295a9481da8a2aedc359
Reviewed-on: https://chromium-review.googlesource.com/c/1347314Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610298}

Bug: 907673
Change-Id: I71a9bf1433ca7afce1d7482791e008ed809dc04e
Reviewed-on: https://chromium-review.googlesource.com/c/1347771Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610297}

Bug: 907403
Change-Id: Id300fd5dda6024fcb28d488a32dc13d44924b371
Reviewed-on: https://chromium-review.googlesource.com/c/1347637Reviewed-by: Leo Zhang <googleo@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610296}

Currently ServiceWorkerBrowserTest.CrossOriginFetchWithSaveData checks
if CORS-preflight requests have "Save-Data" header. This is existing
behavior, but new CORS stack does not add the "Save-Data" header for the
CORS-preflight. In terms of the fetch spec, it will be better not to
have the header in the preflight request.

Bug: 907389
Change-Id: Ic6906f5a9ce270a403b7be6f48274f78d2fce546
Reviewed-on: https://chromium-review.googlesource.com/c/1345685Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610295}

1. MetricsReporter records daily count of user screen brightness
adjustments. It uses local state prefs.

2. This CL also changes the histograms we record:
- Previously we record total number of user adjustments, split into
those with and without prior model adjustments.
- In this CL, we change the reporting so that we record daily counts
only. Also, we only record three types of histograms.
- Note, we are reusing the enum class, but for different histograms,
and the old histograms and its associated enum entry (in enums.xml)
are removed.

Bug: 881215
Change-Id: I5d5b37af18b1a365f64bd33b61f9f29bbb411962
Reviewed-on: https://chromium-review.googlesource.com/c/1338592
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610294}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ifab9496a837c590c6ca525402d0c24eed4aa0f9c
Reviewed-on: https://chromium-review.googlesource.com/c/1347081Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610293}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fe39a6f342f6..981763ec74fc


git log fe39a6f342f6..981763ec74fc --date=short --no-merges --format='%ad %ae %s'
2018-11-21 zoddicus@users.noreply.github.com Ensure correct Addressing and Memory model set for WebGPU (#2093)
2018-11-21 afdx@google.com Initial commit for spirv-reduce. (#2056)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@981763ec74fc

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I976c6dea5c97685247a4021e0814939fd5dc3810
Reviewed-on: https://chromium-review.googlesource.com/c/1347517Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610292}

https://webrtc.googlesource.com/src.git/+log/5eae1d994e20..e4cccae29941


git log 5eae1d994e20..e4cccae29941 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 benwright@webrtc.org Removed ability to set CryptoOptions through PeerConnectionFactory from bindings.
2018-11-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 92f8c5b2..5825fead (609994:610108)


Created with:
  gclient setdep -r src/third_party/webrtc@e4cccae29941

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I91443a26276d8cd8aaf0e840c59b84cdc17856fd
Reviewed-on: https://chromium-review.googlesource.com/c/1347516Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610291}

Icon generation and resizing is covered in
web_app_icon_generator_unittest.cc.

Bug: 901226
Change-Id: Ib6be6e5653792a18ef76daf63df70a81df9b7e3c
Reviewed-on: https://chromium-review.googlesource.com/c/1345698Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610290}

TBR=smut

Change-Id: I4b97610a59ffe4202f75b2673cf8247ed6bcc31c
Reviewed-on: https://chromium-review.googlesource.com/c/1347731Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610289}

To save space in release, instead of using org.chromium.base.natives.GEN_JNI
use a short package/class name, J.N. Proguard won't do this for us because
we can't obfuscate any class that contains native methods.

Bug: 898261
Change-Id: I84ad6914912b5b0e0d390d53a88dbcf41633edbf
Reviewed-on: https://chromium-review.googlesource.com/c/1347034Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610288}

strip_path_prefix is needed for Predator to work on ClusterFuzz.

R=ochang@chromium.org
CC=metzman@chromium.org

Change-Id: Ib800a54c5f95176ef4acd292f935d6405529cf8f
Reviewed-on: https://chromium-review.googlesource.com/c/1345570Reviewed-by: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610287}

Changes:
If the first available position for the newly installed app does not
exist when we are inserting between an app and a page break item with
the same position, we use the next available position.

Bug: 907637
Test: AppListSyncableServiceTest.InvalidFirstAvailablePosition
Change-Id: I8f1a7abad58ea838b452ac8a270c4a030df57a1e
Reviewed-on: https://chromium-review.googlesource.com/c/1347208
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610286}

Change-Id: I26e660eb8146a9f4aa856ba2f972b715ca25ce3a
Reviewed-on: https://chromium-review.googlesource.com/c/1347572
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610285}

The string is used to replace things in a json-encoded string, so it
needs to be json-encoded.

TBR=hans

Bug: 899438
Change-Id: Iababe77ed7f8c2dafd0d0443f28f480082bc72d0
Reviewed-on: https://chromium-review.googlesource.com/c/1347312Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610284}

Context menu 'New Folder' selection was causing the menu to jump
up and down (easier seen on captured video on the bug). This was
caused by a 'change' event fired that updated the state of the
context menu tasks-separator bar to visible despite there being
no items above it (which in turn, makes the menu taller temporarily).
That happened mid-animation of the menu and the bar is reset to
hidden after more event processing. Removing the fake data that
was passed into the updateContextMenuTaskItems_() method stops
it happening.

      offending code to visually check fix works. Ran test on
      desktop and real device to confirm.

Bug: 698176
Test: Ran all FilesApp browser tests. Single-stepped through the
Change-Id: Icd7a2c41ad85bf93e30fe90632d83a8890b294bf
Reviewed-on: https://chromium-review.googlesource.com/c/1347631Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610283}

File changes (e.g. file creation) within the current directory would
trigger a rescan. This causes file changes to disable "New folder". This
causes flickering of the new folder menu item and button for multi-file
operations in the current directory. Avoid this by allowing new folder
while scanning.

Bug: 618002
Change-Id: I5943deeb0186ab425824eeb70ed69414e702da42
Reviewed-on: https://chromium-review.googlesource.com/c/1347633Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610282}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: Ie237b994b8e871b1d3b6a999341847ad975a25a9
Reviewed-on: https://chromium-review.googlesource.com/c/1343581Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: DongJun Kim <djmix.kim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#610281}

This moves logic to handle LSAN leak warnings into ~BlinkFuzzerTestSupport.
Two related call sites are updated.

Bug: chromium:906425
Change-Id: I2b7c6d5145e67a3d9d919e5f17e51a28eacee7bc
Reviewed-on: https://chromium-review.googlesource.com/c/1341522Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610280}