- 28 Feb, 2020 40 commits
-
-
Anastasia Helfinstein authored
A recent change to how the Switch Access extension is loaded caused the Switch Access menu and Switch Access back button (both rendered in the SwitchAccessPanel) to stop showing up. This change fixes the string referencing menu_panel.html to match the new relative path. TBR=dtseng@chromium.org Bug: None Change-Id: I64d39e623c7d81ecf197ab9b5c35b83c2cecfd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079269Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#745662}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6bde393..2d7b0de1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1aa9271dc18460dce5956518e18325a581eded2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079645Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745661}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f489240742b..953278adbf3e git log 4f489240742b..953278adbf3e --date=short --first-parent --format='%ad %ae %s' 2020-02-28 sokcevic@google.com Print content of description backup on exit 2020-02-28 ehmaldonado@chromium.org Revert "my_activity.py: Run using vpython3 by default." Created with: gclient setdep -r src/third_party/depot_tools@953278adbf3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I974d539ca51c32bfaa01a359c8ed1b4f9e44619e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080722Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745660}
-
Lukasz Anforowicz authored
Synchronous invocation is desirable to retain the callstack and crash keys that have led to a mojo::ReportBadMessage call (see #c0 in https://crbug.com/1057149). Synchronous invocation should be safe, because mojo APIs should now be safe for reentrancy (see https://crbug.com/1057149#c5). Note that even before this CL the default error callback (see mojo::core::SetDefaultProcessErrorCallback) has been invoked synchronously (see how Core::ExtractMessagePipeFromInvitation doesn't wrap |default_process_error_callback_| in any task-aware wrappers). Bug: 1057149 Change-Id: Ie6848bbdf1e15e23c2f001b9d9a37f85a583acea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080090 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#745659}
-
Raymond Toy authored
When an AudioParam was selected to be k-rate, any inputs to the AudioParam were ignored, so the AudioParam only contained the effect of automation events. This is incorrect. Any inputs should be reflected in the AudioParam values. The case of connected AudioParams with a-rate automation was working fine. Handles ConstantSource, Gain, and StereoPanner since these have very similar AudioParam processing with only one simple AudioParam. Bug: 1015760 Change-Id: I29ec3d7b58248a96da911e03890b74f6fb1bf098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873392Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745658}
-
Devlin Cronin authored
A bit of cleanup: - Remove unused / duplicate includes - Remove unused enum - Remove unused methods - Remove unnecessary friending of RefCountedThreadSafe<> - Remove unused data members Bug: None Change-Id: I2fb0cecfdd93cfca76177ae391566e3e278f1622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079526Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745657}
-
Yann Dago authored
Bug: 1056657 Change-Id: I3ea9d3f013566c723c65a3c1e66cfaf329864193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080771 Auto-Submit: Yann Dago <ydago@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745656}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4f3c4fcb1f26..a08b2384a324 git log 4f3c4fcb1f26..a08b2384a324 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 45a3ae97..73a39687 (745356:745464) 2020-02-28 guidou@webrtc.org Add RTC_EXPORT to VCMEncodedFrame 2020-02-28 titovartem@webrtc.org Extract BWE stats collection. Created with: gclient setdep -r src/third_party/webrtc@a08b2384a324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7570f4bc1c7f3426443cc934a651d1a4a5dbbac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080721Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745655}
-
Tarun Bansal authored
Bug: 1039025 Change-Id: I04d0b6f0ac868a188d265213d4c0edaf95748a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080772 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#745654}
-
Piotr Pawliczek authored
This patch modifies CHECK condition in a function responsible for extracting hostname and port from given URI. The previous CHECK version was activated for some boundary cases like "://". BUG=none TEST=on my workstation with the fuzzer from CL:2079133 Change-Id: Ie5604128b1f5ae4e0ab97117421dd1f79f2f8b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080713 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#745653}
-
Sophie Chang authored
Previously, we would just not let anything in the queue if we exceeded the limit but it's probably more useful to just evict the oldest one Change-Id: Ic39f6c7e15f6d3c3ee0406b5e85469e8a1092e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071378 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#745652}
-
Owen Min authored
Because we are not going to do anything special for user level CBCM enrollment on Windows. This metrics is no longer needed. Bug: 1046000 Change-Id: I46deb70ece1b9ef3c5cf2bbb5c236e06091d7e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070830Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745651}
-
Tom Anderson authored
BUG=1056560 R=pkasting Change-Id: I125c671c54eaf07f9a00c244cc97e5e4fc3fe25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080691 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#745650}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=luum@chromium.org Bug: 1026641 Change-Id: Ic6135c8097475da7f2fa19c33b317156c424223d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078668Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745649}
-
Colin Pacitti authored
This has already been implemented for its Windows counterpart. It is a simple change for mac to just pass the DMG file path to InstallFromDMG() function. Bug: 1051763 Change-Id: Ia0858532e9c756210a1b5288bd347bd7dcd055d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065309 Commit-Queue: Colin Pacitti <copacitt@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745648}
-
Hailey Wang authored
A trace is uploaded via "slow reports" when a long navigation to first contentful paint is detected (for opted-in clients). This trace event will make it easier to identify the location of the long delay when analyzing the trace. Bug: 1055890 Change-Id: I8e58ada28976fcea2bd2a799021e90ddd0231567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076279Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#745647}
-
Chris Mumford authored
xrSession_requestAnimationFrame_getViewerPose.https.html is flakey and fails approximately 20% of the time. Also, fixed bug number in prior line disabling oopif-storage.js. TBR=tguilbert@chromium.org Bug: 1056879 Change-Id: I18739671f245c98fed28a2bc0d2329ee08f9c0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080555 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#745646}
-
Jeremie Boulic authored
Before this change, when there's a single user on a device, the storage handler immediately returns '0 B' as the "Other users" size. This change hides the "Other users" row entirely on the storage page instead. Test: browser_tests --gtest_filter="*OSSettingsDevicePageTest.StorageTest" Bug: 1056491 Change-Id: Ibbc587ff702c5cc419eab35e7c0129674a9f9897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076747Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745645}
-
Dave Tapuska authored
In the effort to move the ownership of compositing over to blink add a method for testing that will ApplyViewportChanges. Currently this method just calls ApplyViewportChanges but that method will eventually be removed. Change-Id: Iba3bcb2570eefe3cd321973f2647c1c214e6f681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080454Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#745644}
-
Scott Violet authored
A list implies a certain order. getTabs() does not return a particular order. This converts the return value to a Set to reinforce the order is not defined. This is an incomptible API change. The change is purely in the client library, so there is worry about compatibility with different implementation versions. This change was requested by Alihan, and they understand it is incomptible. BUG=none TEST=none Change-Id: I5c4777b6624ba501c0708eacc7d81217a17f253e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080478Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#745643}
-
Tom McKee authored
Change-Id: I496c377a48f560d3f7ed2cee5cd10376523c3db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080694Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#745642}
-
Zhenyao Mo authored
There are multiple reasons the info collection GPU process may not launch. Make sure certain DevicePerfInfo fields are collected. Otherwise the histograms could be biased. BUG=1039792 TEST=manual R=magchen@chromium.org,sky@chromium.org Change-Id: I2c0fee99935e55b6d1a65982bdbf5da38f95eef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079852 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#745641}
-
Felipe Erias authored
Export and adapt printing/page-rule-css-text.html to WPT, providing automated tests for the parsing of different uses and declarations of the CSS @page rule, including inside @media rules and for properties of HTML elements. R=rego@igalia.com Change-Id: I790370832d3a300f78da683481bb48ca5e53985b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074837Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#745640}
-
Noel Gordon authored
Bug: 763885 Change-Id: Id02e0e5223d305f4d61f9054e28e309281154809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079717Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#745639}
-
Collin Baker authored
Fixes the following: - Fractional part of drag updates was thrown away, causing the current height to lag behind the touch position. The error compounded the longer the drag was in progress. - Tab strip got stuck when dragged slowly to the fully open or closed position. Animations don't get run when they're at their target value, but I assumed otherwise. - Incorrect assumptions about ordering of ET_GESTURE_SCROLL_END, ET_GESTURE_SWIPE, and ET_GESTURE_END resulted in occasional DCHECKs. Changed to be more permissive. Bug: 1043374 Change-Id: Iedab85a33bf6c89b51f1a88e73864ba32e885781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076783Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#745638}
-
Collin Baker authored
The failure in init_simd() is benign and won't be fixed; see https://github.com/libjpeg-turbo/libjpeg-turbo/issues/87. Bug: 1056011 Change-Id: I2bc3827b4313371e00b46ba3362a9c98499f9450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076278Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#745637}
-
Wan-Teh Chang authored
Update callers of VideoDecoder::Reset() to ensure they are using a OnceCallback or BindOnce. Change-Id: I3560af2fd75dafc1ea1e4cc471b00b1cef2d17e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079781 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745636}
-
Nathan Zabriskie authored
With crrev.com/c/1888951 the display compositor initializes textures to a known state at draw time so we don't need to manually save/ restore this state after the texture is used by Skia. These calls are also potential causes of slowdown when copying WebGL/Canvas as discussed on crbug.com/1048896. Removing this usage of ContextGL also helps prepare for Canvas' transition to OOP-Rasterization, crbug.com/1018894. Bug: 1023270, 1048896 Change-Id: I80e070ec8d1210312ff6bd430c30cfdab2c4f9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078979 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#745635}
-
Fredrik Söderquist authored
AddURLRectsForInlineChildrenRecursively() is currently called from within LineBoxListPainter::ShouldPaint(), which seems like an odd place since that's sounds like (and otherwise is) a predicate function. Hoist the call out of ShouldPaint() and into the callers. Since PaintBackplate() is only called in the kForcedColorsModeBackplate paint phase we can drop it in that case. Also drop the paint phase check in PaintBackplate() since it's caller already checks it. Change-Id: I4e28b126138f884dd411d0ef44ef949371173421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080429 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745634}
-
Evan Stade authored
Bug: 1036028 Change-Id: If402bda0f6532f1254a710223ff66bb77e0cf15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079530Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#745633}
-
Eric Orth authored
This reverts commit ee60735b. Original commit f02f7639. Fix was just to rebase and made some minor compile fixes for the rebase. Bug: 1022059 Change-Id: I14181e1320cc3dd83392beb36213b91e76bc65af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079201 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#745632}
-
Caleb Raitto authored
Add the initial benchmark, which measures double privacy budget UKM serialization performance. Bug: 973801 Change-Id: I90403af701246cf8575681c0789b2344622b1261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075477 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#745631}
-
Mark Yacoub authored
This reverts commit b0806021. Reason for revert: Causes "this monitor is not getting along" notification using CableMatters DP2 dock with 1 display Original change's description: > Ozone: Implement Atomic Modeset > > If the device supports KMS Atomic APIs, Enable CRTC using Atomic Modeset > Commit instead of legacy SetCRTC. > > BUG=987274 > TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps > HardwareDisplayPlaneManagerAtomicTest.CheckPropsAfterModeset > > Change-Id: I116a2caf8602aa6470c9cf17a65fa12c045f8d6b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039752 > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Auto-Submit: Mark Yacoub <markyacoub@google.com> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740811} Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056900 Change-Id: Ia9641a5089afac272e7bb1299072b5dbac4ec304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080775 Auto-Submit: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#745630}
-
Lijin Shen authored
1. The language is not properly set as blocked. 2. Re-generate the list items after click actions to toggle the tick mark. Bug: 1057051 Change-Id: I860a3224b72f00badd1c5509086aa892a33cdf7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080447Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745629}
-
John Williams authored
The previous code was written using the mistaken assumption that only mirroring sessions should have a tab ID. This had the effect of making it impossible to re-connect to a casting session after refreshing the tab. Bug: 1054491 Change-Id: Ic8ec2946af8ad28c8cea8c0698c1644c46ff5a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078795Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#745628}
-
Ehsan Kia authored
Bug: 1055514 Change-Id: Icb49beb89520cf49e1676f0ef9a301a91a703332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080672Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ehsan Kia <ehsankia@google.com> Cr-Commit-Position: refs/heads/master@{#745627}
-
Caleb Raitto authored
This project was never finished, and we have no current plans to continue development. Bug: 973603,1055065 Change-Id: I929730aec39d84ea3c31e5d726d7b0af6d9f15cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079205Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#745626}
-
dpapad authored
Previously every member of that typedef was marked as potentially undefined. This required a type-casting whenever a !settings.Route was expected, which was tedious without producing any type-coverage benefits. As a result of this change a lot of typecasts like the following /** @type {!settings.Route} */ (settings.routes.FONTS) are no longer necessary and are removed. Bug: 1026426 Change-Id: I0becc11cc8a5479c4390d4499e4956f73126c8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078822 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745625}
-
evliu authored
Bug: 1056809 Change-Id: Ib787b4495a05a78a3e49bc00e4770d81a23fafec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080088Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#745624}
-
rbpotter authored
Bug: 1026426 Change-Id: I3a53c0d008e6b97f1a9574bf68ddab06981d7623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076087 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745623}
-