- 09 Apr, 2015 40 commits
-
-
wfh authored
BUG=101717 Review URL: https://codereview.chromium.org/1066203003 Cr-Commit-Position: refs/heads/master@{#324355}
-
kelvinp authored
Currently, remoting.Clipboard is exposed as a global, such that it can hook events across different files, e.g. remoting.js, client_plugin_impl.js, application.js This CL moves clean up the file by: 1. Only create an instance of the clipboard when a session is connected. This removes the startSession() method on the clipboard. 2. Hook all events (copy/paste/focus changes) from within remoting.clipboard, which eliminates the need to have a global and effectively makes all its methods private. 3. Style cleanups, use single quotes for strings, make sure private variables are post-fixed with underscores. BUG=475317 Review URL: https://codereview.chromium.org/1078563002 Cr-Commit-Position: refs/heads/master@{#324354}
-
xiyuan authored
ShowSigninScreenForCreds is used to automatically fill-in sign-in forms and submit it. WebviewLoginTest.Basic does that manually thus should not call it. Otherwise, /_/embedded/signin/challenge is called multiple times with wrong email (empty) and could trigger FakeGaia failures. BUG=472095 Review URL: https://codereview.chromium.org/1069423004 Cr-Commit-Position: refs/heads/master@{#324353}
-
mef authored
BUG=441441 TEST=build/android/test_runner.py gtest -s components_unittests --gtest_filter=HistogramManager* Review URL: https://codereview.chromium.org/1075503002 Cr-Commit-Position: refs/heads/master@{#324352}
-
dalecurtis authored
Discrete layouts will have a matching channel layout, but may have any number of channels. We were incorrectly skipping the channel mixer setup based only on layout. BUG=473688 TEST=new unittest. Review URL: https://codereview.chromium.org/1070923002 Cr-Commit-Position: refs/heads/master@{#324351}
-
vadimt authored
BUG=456354 Review URL: https://codereview.chromium.org/1068933003 Cr-Commit-Position: refs/heads/master@{#324350}
-
ananta authored
Ensure that the Windows system font information and the scrollbar metrics are synced with the ViewMsg_SetRendererPrefs IPC The patch to sync the font and scrollbar metrics from the browser to the renderer was sending these values only during RenderView creation and not along with the ViewMsg_SetRendererPrefs IPC which caused scrollbars to disappear and other bad things. BUG=474871 Review URL: https://codereview.chromium.org/1069683006 Cr-Commit-Position: refs/heads/master@{#324349}
-
shrikant authored
Also reenabled appcontainer for renderer and fixed policy use after free case. BUG=468922,473715 R=cpu,jschuh@chromium.org, wfh Review URL: https://codereview.chromium.org/1058373003 Cr-Commit-Position: refs/heads/master@{#324348}
-
jsbell authored
Remove some redundant number_(0) initializers. Also, for IndexedDBKey, use number_ for both number and date type to save memory. R=cmumford@chromium.org Review URL: https://codereview.chromium.org/1071683002 Cr-Commit-Position: refs/heads/master@{#324347}
-
cblume authored
Adding tests for diagonal scrolling to telemetry. BUG=466867 Review URL: https://codereview.chromium.org/999243003 Cr-Commit-Position: refs/heads/master@{#324346}
-
reddaly authored
BUG=451527 R=mfoltz@chromium.org,kalman@chromium.org Review URL: https://codereview.chromium.org/1040773002 Cr-Commit-Position: refs/heads/master@{#324345}
-
kojii authored
This patch adds two entreis to rappor.xml for Web Components usage. Blink CL is at: https://codereview.chromium.org/986583002/ Chromium CL is at: https://codereview.chromium.org/1014543003/ BUG=461671 Review URL: https://codereview.chromium.org/1071463003 Cr-Commit-Position: refs/heads/master@{#324344}
-
mikecase authored
The recipes need the ability to parse the test results. Adding support for the json-results-file option so we can tell what junit tests failed in the infra recipes. BUG= Review URL: https://codereview.chromium.org/1062403004 Cr-Commit-Position: refs/heads/master@{#324343}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/5b9a14f..b06aa90 TBR=cbiesinger@chromium.org,keishi@chromium.org Review URL: https://codereview.chromium.org/1076513004 Cr-Commit-Position: refs/heads/master@{#324342}
-
alexmos authored
This CL moves cross-process postMessage plumbing from RenderView to RenderFrame: - The renderer-to-browser RouteMessageEvent message is now sent through RenderFrameProxy rather than a swapped-out RenderView. - The bulk of WebContentsImpl::RouteMessageEvent is moved into RenderFrameProxyHost::RouteMessageEvent. Unfortunately, we still need to call up to WebContents for dealing with <webview> and on-demand creation of swapped-out RVs for the opener chain. This will be cleaned up as part of https://crbug.com/225940. - the browser-to-renderer PostMessageEvent message is now handled in RenderFrameImpl::OnPostMessageEvent, instead of RenderViewImpl. These changes make it possible to send messages between cross-process subframes when in --site-per-process mode. This is exercised in a new test, SitePerProcessBrowserTest.SubframePostMessage. More work will be needed to support postMessages involving subframes in cross-process openers (see https://crbug.com/225940 and https://crbug.com/423587). With this change, the RFHM::SupportCrossProcessPostMessage test now works in --site-per-process mode, so it is enabled on the Site Isolation FYI bots. BUG=389721 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1046933005 Cr-Commit-Position: refs/heads/master@{#324341}
-
cjhopman authored
Adds a colored title area. When the title is set, it will be exposed with a simple animation. Including the title in the original html is still supported. Fixes some issues with margins and line spacing. Review URL: https://codereview.chromium.org/1060623002 Cr-Commit-Position: refs/heads/master@{#324340}
-
brucedawson authored
For details see the STL Breaking Changes (VS14 CTP1) section of: http://blogs.msdn.com/b/vcblog/archive/2014/06/06/ c-14-stl-features-fixes-and-breaking-changes-in- visual-studio-14-ctp1.aspx In particular: "The Standard has always forbidden containers of const elements... ...elements must be Assignable, which const T isn't." Error message is: error C2338: The C++ Standard forbids containers of const elements because allocator<const T> is ill-formed. R=cpu@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/1066213002 Cr-Commit-Position: refs/heads/master@{#324339}
-
reillyg authored
I noticed while doing some refactoring elsewhere that observer_ was not being initialized and so early calls to OnDevicesChanged could branch on an uninitialized value and crash. Review URL: https://codereview.chromium.org/1075593003 Cr-Commit-Position: refs/heads/master@{#324338}
-
shess authored
This not working was preventing certain corruption-testing tests from being written. Also modified Does{Table,Index,Column}Exist() to reflect that these names are _not_ case sensitive. It is not possible to have distinct tables [Foo] and [foo]. BUG=none Review URL: https://codereview.chromium.org/1069313004 Cr-Commit-Position: refs/heads/master@{#324337}
-
eroman authored
This has the advantage of making cancellation of requests an O(1) operation rather than O(NumRequestsPerJob). BUG=455366 Review URL: https://codereview.chromium.org/1075563002 Cr-Commit-Position: refs/heads/master@{#324336}
-
rvargas authored
This allows handles created on the exe (or any other module) to be properly tracked. BUG=472362 Review URL: https://codereview.chromium.org/1045513004 Cr-Commit-Position: refs/heads/master@{#324335}
-
tfarina authored
Clients should now include webrtc/video_frame.h which is the right header for I420VideoFrame type, i420_video_frame.h is just a pass through header include. This should help fix pbos' TODO in the WebRTC repo and allow us to land https://webrtc-codereview.appspot.com/46819004/. BUG=None R=tommi@chromium.org Review URL: https://codereview.chromium.org/1067823002 Cr-Commit-Position: refs/heads/master@{#324334}
-
rdsmith authored
BUG=None R=ellyjones@chromium.org Review URL: https://codereview.chromium.org/1051933002 Cr-Commit-Position: refs/heads/master@{#324333}
-
sunnyps authored
This CL suppresses the test failures on the Win7 Release ATI GPU bot: WebglConformance.conformance_extensions_angle_instanced_arrays WebglConformance.conformance_rendering_more_than_65536_indices BUG=475095 Review URL: https://codereview.chromium.org/1075443006 Cr-Commit-Position: refs/heads/master@{#324332}
-
enne authored
In order to commit property trees to the compositor thread, they need to be stored on the LayerTreeHost/LayerTreeImpl. This change adds plumbing so that the PropertyTree computation is not entirely internal to CDP. BUG=386793 Review URL: https://codereview.chromium.org/1062403002 Cr-Commit-Position: refs/heads/master@{#324331}
-
mark authored
678baca8bd4a EXC_CRASH should never be wrapped in another EXC_CRASH ab2390619387 crashpad_database_util: add --new-report 1baff4ff92fe Accept non-fatal resource exceptions without generating crash reports BUG=475236,crashpad:35 TBR=rsesek@chromium.org Review URL: https://codereview.chromium.org/1071763002 Cr-Commit-Position: refs/heads/master@{#324330}
-
Haixia Shi authored
This prevents a double-close problem that arises when libva uses the same drm fd as gbm. TODO(hshi): refactor VAAPI wrapper's management of drm file (crbug.com/475250). BUG=462459 BUG=464628 TEST=verify that video acceleration works and the netflix hang is fixed R=jorgelo@chromium.org, piman@chromium.org Review URL: https://codereview.chromium.org/1073653003 Cr-Commit-Position: refs/heads/master@{#324329}
-
erg authored
Define a fill-paragraph-function which only fills in comments instead of everywhere. Previously, we would fill in other contexts, like lists. BUG=none Review URL: https://codereview.chromium.org/1071733002 Cr-Commit-Position: refs/heads/master@{#324328}
-
fsamuel authored
https://codereview.chromium.org/1033373003/ introduced lazily issuing updated GuestView attributes between create and attach. The AllowTransparency and AllowScaling attributes were defaulting to false if not available in the attach params and so they were getting reset on attach. This CL fixes the issue by only updating the attributes if they are passed along on attach. BUG=471997 Review URL: https://codereview.chromium.org/1065413002 Cr-Commit-Position: refs/heads/master@{#324327}
-
ajuma authored
Revert of cc: Re-use transforms from transform nodes when computing visible rects (patchset #2 id:20001 of https://codereview.chromium.org/1060413002/) Reason for revert: Causes css3/filters/effect-reference-hidpi-hw.html to have an incorrect visible rect. Original issue's description: > cc: Re-use transforms from transform nodes when computing visible rects > > This makes CalculateVisibleRects try to re-use the to_target and > from_target transforms stored in transform nodes whenever it needs to > compute a transform. Since these baked transforms incorporate the > target's sublayer scale, the fallback path now also includes sublayer > scale for consistency. > > Testing locally on a z620, this improves property tree computation time > by 7% on Gmail, and by 20% on rAF-driven poster circle. > > BUG=474725 > > Committed: https://crrev.com/992c398b2fb0e7ab9c7ba58a8eb36787e03962e4 > Cr-Commit-Position: refs/heads/master@{#324122} TBR=vollick@chromium.org BUG=474725 Review URL: https://codereview.chromium.org/1077433003 Cr-Commit-Position: refs/heads/master@{#324326}
-
hubbe authored
As usual, the RunUntilIdle() call causes problems. Calling stop() on the webrtc stream apparently doesn't propagate back to the capture, so make sure that we call stop() on the capture stream explicitly. Also, raise frame rate to 60 fps. Not entirely sure if this will fix the attached bug or not, but either way it's a problem that should be fixed. BUG=474808 Review URL: https://codereview.chromium.org/1076533002 Cr-Commit-Position: refs/heads/master@{#324325}
-
hush authored
BUG= Review URL: https://codereview.chromium.org/1076613002 Cr-Commit-Position: refs/heads/master@{#324324}
-
nednguyen authored
Move smooth_gesture_util from tools/perf/ to tools/telemetry/telemetry/web_perf/ BUG=468061 Review URL: https://codereview.chromium.org/1067883002 Cr-Commit-Position: refs/heads/master@{#324323}
-
joedow authored
BUG= Review URL: https://codereview.chromium.org/1070903002 Cr-Commit-Position: refs/heads/master@{#324322}
-
jvoung authored
BUG= https://code.google.com/p/nativeclient/issues/detail?id=4091 Review URL: https://codereview.chromium.org/1059423002 Cr-Commit-Position: refs/heads/master@{#324321}
-
jam authored
Review URL: https://codereview.chromium.org/1070933002 Cr-Commit-Position: refs/heads/master@{#324320}
-
mmenke authored
Previously, TCP keep alives were enabled on all desktop platforms, but the delay was not being set on OSX, resulting in not sending keep alives every 45 seconds, like on other platforms. This CL adds the code to do that. It does the same on iOS, though keep alives aren't enabled on mobile platforms, anyways. BUG=468764 Review URL: https://codereview.chromium.org/1065563006 Cr-Commit-Position: refs/heads/master@{#324319}
-
bmcquade authored
Disable logging of failed SPDY PINGs in a timemax bucket, and update histogram bucketing strategy for Net.SpdyPing.RTT to match the strategy of Net.TCP_Connection_Latency. * timemax is int64max, whereas histograms use int values, so this doesn't end up working well and can break certain analysis operations such as computing the average SPDY PING time. Additionally, counts for failed SPDY PINGs are recorded in the Net.SpdySession.ClosedOnError enum histogram, so there's no need for us to log them in a special bucket in the RTT histo as well. * Also change the histogram bucketing strategy for Net.SpdyPing.RTT to match the strategy of Net.TCP_Connection_Latency since these are measuring similar things and it's useful to be able to compare TCP RTTs with application-layer RTTs. BUG=475129 Review URL: https://codereview.chromium.org/1074523002 Cr-Commit-Position: refs/heads/master@{#324318}
-
Michael Moss authored
This doesn't force use of the SSL repo, but prevents overwriting the repo config if a user manually changes it to use HTTPS. R=thestig@chromium.org, thestig@google.com BUG=433450,474100 Review URL: https://codereview.chromium.org/1068323002 Cr-Commit-Position: refs/heads/master@{#324317}
-
maxbogue authored
TEST=For a manual test to exercise this code, see comment #2 in the bug. BUG=469890 Review URL: https://codereview.chromium.org/1025403002 Cr-Commit-Position: refs/heads/master@{#324316}
-