- 22 Jan, 2021 40 commits
-
-
Ken Rockot authored
This moves the presentation web tests into wpt_internal and adapts them to use the newer Mojo JS modules. Since this already produces quite a bit of churn in the tests, the tests here are also opportunistically modernized where feasible, particularly concerning asynchronous logic. Bug: 1004256 Change-Id: I5515325cfc808cd5f0e7dff51840a94c4078b4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634278 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846373}
-
Lijin Shen authored
Similar to crrev.com/c/2606874, add an extra check to avoid calling feature list before native is initialized. Bug: 1162510 Change-Id: I6f45bc0dbd7081abd41c105223f4b312d0af5ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645506 Commit-Queue: Lijin Shen <lazzzis@google.com> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#846372}
-
Mark Schillaci authored
This is a follow-up CL to add clearer dialog dismissal causes for the image descriptions dialog on Android. With this CL we now differentiate between dialogs that are dismissed by a user action on the dialog, vs dialogs that are dismissed due to changes in state, such as web contents being hidden or destroyed. This CL adds a new dialog dismissal cause for web contents destroyed. Original CL: crrev.com/c/2596417 AX-Relnotes: N/A Bug: 1057169 Change-Id: Id20d161d003dc9161fa9b3af792f6cc20b8aafe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630728 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Kevin Ellis authored
Animation times were change from Optional<double> to Optional<AnimationTimeDelta> in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2591488 This change eroded the numerical precision of calculations involving time; however, we only require a time precision down to 1 microsecond (https://drafts.csswg.org/web-animations/#precision-of-time-values). Thus, it is safe to relax fuzzy equality constraints at the upper bounds of an animation. This patch, also addresses a previous inaccuracy where it was possible to recognize that an animation was limited (i.e. finished) yet not set the hold time when updating the finished state. Bug: 1169674, 1169111 Change-Id: I0d7869cac8809eb118b09b740a35a0fee4655303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644740 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846370}
-
Emircan Uysaler authored
This CL adds the corresponding Scenic commands for the received gfx::OverlayTransform for Fuchsia. This allows us to flip or rotate the overlay video content. Bug: 1169182 Change-Id: I9a5689251f3a363cd88db0d9b0bcc1b550cf2133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644565 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#846369}
-
Aleks Totic authored
Preparation for turning on the flag Change-Id: I33f36367d3d408307c5a884b697d3cfff97780bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645033 Commit-Queue: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#846368}
-
Nina Satragno authored
debugger-ui/inline-scope-variables.js was timing out but were only marked as Failure. Marking as timing out as well. Bug: 1149734,1150458 Change-Id: I71c6333bcfc6bb015285479a2ada156884e4b472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645369 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#846367}
-
Cammie Smith Barnes authored
Removes '^chrome/browser/devtools/' from the _NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK list in src/PRESUBMIT.py, as the chrome/browser/devtools directory has now been fully converted. Bug: 1007635 Change-Id: I370bcca30d2869b46c6e407ea336fa78824f1b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645155Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#846366}
-
Toni Barzic authored
Records when the camera privacy switch state changes, when the "camera privacy switch on" notification is shown, and number of seconds between the time the notification is shown, and the time the user toggles the privacy switch off (using exact linear histogram to force the bucket size to 1 second). BUG=1165612 Change-Id: I435c2edbfba6844b2f7df91e9eb52062defe0799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634085 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#846365}
-
Brian Sheedy authored
Removes the Playstore version dimension from the AR tests running on Oreo. The Playstore version on the devices has changed, causing there to be no matching devices for testing, and the current version seems to work fine for the tests. Bug: 1168739 Change-Id: Id765b91a46b59789782d6e00593f49f0945c5ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645348 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#846364}
-
Katie Dektar authored
Had previously been re-enabled but appears to be flaking more frequently again. Bug: 1126876 Change-Id: Id3a6c5d50bb031b09646f9dddb6c5f5fe1960213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645466 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Hui Yingst <nigi@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#846363}
-
Henrique Nakashima authored
In builders, the path to dirmd needs to be passed as parameter. Add it preemptively so that when the recipe CL lands, this step doesn't fail due to the unexpected parameter. The parameter will be used when DIR_METADATA is parsed in getowners.py: https://chromium-review.googlesource.com/c/chromium/src/+/2645158 Bug: 1135347 Change-Id: Iee8ae9c653a8f41690ba357323f15294a2e91dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645062 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846362}
-
Brian Ho authored
This CL adds some more logging around scoped_skia_write_access_ since we suspect that it being null causes a rare crash on Chrome OS. The member can be null for a number of reasons, so let's add some LOGs after each. This crash also happens rarely on Android which also uses the BufferQueue output surface, so these logging statements can probably help there as well. Bug: 1169364 Change-Id: Ia61510da3b8fb92166aed1edbb3bd33a262378d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645151Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#846361}
-
Rakib M. Hasan authored
Also add myself as owner for the deps file for that script and fixes the email address used for the common wpt scripts. Bug: None Change-Id: I72eb3e2a6ad52287ac83111d1f456c40df6ac572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644380Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#846360}
-
Pete Williamson authored
Bug: 1165265 Change-Id: Id6a236cda259920b1e1069ebfaac646e68ed364f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644057Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#846359}
-
Elly Fong-Jones authored
This CL enacts the "class splitting refactor" (//docs/ui/views/class_splitting.md) on ColorChooserView, breaking it into: * A controller class called ColorChooser, whose lifetime is fully controlled by the client, and which is safe to call at any point in the lifecycle of the matching Widget/Views/etc * Two helper objects (instances of WidgetDelegate and View respectively) whose lifetimes are fully controlled by Views This CL serves as a prototype for how the class splitting refactor looks when applied to production code. Instead, have it use only the public API on WidgetDelegate. Bug: 1075649 Change-Id: I84655a9c204a9f5f88767ac792ce1abc846feda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622995 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#846358}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/display. Bug: 1148570 Change-Id: I707dd2dd440d2fbcc8a7fcad499cef29dc226a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645309 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#846357}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611316382-2d0f555a9d3aa5811a7e026e1b7c53cee9a9715c.profdata to chrome-win64-master-1611338398-0baf9b45acb8a7713920cc39901da599be0fc770.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic339793875e26f7e77b9d14c6e8097b414954a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645328Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846356}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/ownership. Bug: 1148570 Change-Id: Ic4d13d66bed7e6a14b952441de17d39f3dfc5618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645507 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1169404 Change-Id: I458dee6a73e071f9f4d99dabf3907e5afb45963d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642925Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b2a5204087d..57144c8685d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic1a97e37f9efe784bf2578d3abd5c09d1a312ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645109Reviewed-by:
-
Leonid Baraz authored
Fixes a serious bug in the StorageQueue found with the stress test. When records are enqueued fast (e.g. in multiple threads) it can cause the following: the sequence ids will always be strictly monotonic, but last record digest may refer to a wrong record: (1) Record1 gets last digest of previous record (2) Record2 gets digest of Record1 (3) Record2 gets seq id=1 and is written to the file (4) Record1 gets seq_id=2 and is written to the file. Upon uploading, server will get Record2[seq=1] uploaded first, Record1[seq=2] second, but last record digest from Record1 will not match digest of Record2 - it will match record before Record1. Add stress test too. Bug: b:177439641 Change-Id: I5b7e425ea6aa0f30b96248dcaebb22562c085613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641569Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846352}
-
Katie Dektar authored
This reverts commit 3fe154df. Reason for revert: Appears to have caused compile failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Builder%20(dbg)(32)/166101? [1052/1665] CXX obj/ui/base/x/x/selection_owner.o FAILED: obj/ui/base/x/x/selection_owner.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../ui/base/x/selection_owner.cc:46:10: error: no matching function for call to 'min' return std::min(size - 100, 0x100000l); ^~~~~~~~ ../../buildtools/third_party/libc++/trunk/include/algorithm:2532:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('int' vs. 'long') min(const _Tp& __a, const _Tp& __b) ^ Original change's description: > [X11] Split PutImage requests into multiple requests if necessary > > R=sky > > Change-Id: I1befaef494c74797333d6bf02e204bcdc721e752 > Bug: 1164669 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643711 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846344} TBR=sky@chromium.org,thomasanderson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I3989bb05bc58bfadf33f7b67bae0ac2c4a5402e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1164669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644744Reviewed-by:
-
Toby Huang authored
This CL * Refactors FamilyUserDeviceMetricsTest to use LoggedInUserMixin, eliminating a lot of duplicated code that's already encapsulated in LoggedInUserMixin and shortening the browser test class. * Breaks monolithic tests into smaller, modularized pieces to make them easier to understand and debug when they break. * Removes some unneeded includes, like UserActionTester and ScopedTestingCrosSettings. Bug: 1133856 Change-Id: I098a3028dd021379a46fa619e7f597717507e1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602701 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#846350}
-
Maria Kazinova authored
This helps in cases when the page is loading scripts that interfere with Symbols creation and unique ID setting process. Bug: 1169690 Change-Id: Iae3a9ce3eef72e3d9b3e8021c16ad24da03d3c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644957Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#846349}
-
Yulun Wu authored
This CL temporarily restores themed classic launcher. Themed classic launcher was incorrectly removed when adding theming for launcher as the theme-less default value was being used when light/dark mode was disabled. This CL themes the default color passed on by app_list_view. Bug: 1163594 Change-Id: I7db2484baf1e73b36602c2cc5e601f50af0b75fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638409Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#846348}
-
Rakib M. Hasan authored
This CL will make Android x86 M & 10 builder load the Webview Apk with the AOSP system package name while the Android x86 Pie & Oreo builder load the Webview Apk with the Google system package name. Bug: 1163652 Change-Id: Icbb032a173e5c9c11255c037368f5e242a0096fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643783Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#846347}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b745f6df8801..3c3b82abcf0a 2021-01-22 cnorthrop@google.com Tests: Add Hearthstone trace 2021-01-22 syoussefi@chromium.org Vulkan: Unconditionally expose OES_shader_io_blocks 2021-01-22 geofflang@google.com Roll Khronos headers. 2021-01-22 ynovikov@chromium.org Suppress headers includes privacy checks on iOS 2021-01-22 jmadill@chromium.org Capture/Replay: Allow testing with multiple versions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: angle_perftests --gtest_filter="*hearthstone*" Change-Id: I34637c4477a2bd29459efc91d42f3baf9d36ee93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644640Reviewed-by:
-
Nina Satragno authored
This reverts commit e48554ec. Reason for revert: breaks NotificationPlatformBridgeMacTest.TestIncognitoProfile on Mac10.12 Tests See https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.12%20Tests/41203/overview Original change's description: > Pass incognito flag when closing macOS alerts > > A macOS notification is identified with the tuple > {notificationId, profileId, incognito} and we have to pass these down to > the XPC service to close the correct notification. The same applies to > the notification id used in the UNNotification API where we need to > include the incognito flag in the id. Also updates some method names to > be more consistent. > > Bug: None > Change-Id: Ie45cb74eab182e0b495560110d8e6e32367c4bc7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642275 > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Commit-Queue: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846183} TBR=rayankans@chromium.org,knollr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I0d1344c1f61a8dc04a156a94810a8059ffa55e6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645156Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#846345}
-
Tom Anderson authored
R=sky Change-Id: I1befaef494c74797333d6bf02e204bcdc721e752 Bug: 1164669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643711 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
BUG=1064277 Change-Id: I48efb249b8b14eef85285e1590e586e9bf5383f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644821Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846343}
-
Gary Kacmarcik authored
The final release of macOS Big Sur removed CGSession, which we need to enable curtain mode on Mac hosts. This change adds an alternate search path for CGSession so that admins can copy the binary there and have Mac hosts with with curtain mode. Change-Id: Icd4e2d6c60b351c705197730341067caa41d8f09 Bug: 1169841 Change-Id: Icd4e2d6c60b351c705197730341067caa41d8f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645293 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#846342}
-
Olivier Yiptong authored
This change consolidates feature detection assertions in Local Font Access WPT tests in the test helper to diminish line noise. Change-Id: I9a95504c7ddc82c741ee5ca32d456b20f557905b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643794 Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#846341}
-
Henrique Nakashima authored
This is useful to see what classes and packages were added and removed from one version to another. For now the script just looks at nodes, but it can be easily augmented to print out edges and cycles. Bug: 1166855 Change-Id: Iab2a8f516d25524088c1eac27a5b5cd1f46fae51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630229 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846340}
-
Gavin Williams authored
Only recognize printer reasons with ERROR and WARNING severity as print job errors. Do not treat "low on supplies" reasons as print job errors as the print job can still succeed. Bug: 1027400 Change-Id: Iac0a00dd76be17219c10d0605218beb4970c9028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640925Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#846339}
-
Bo Liu authored
Before this, features::IsUsingVulkan is returning false on the Pie bot because of the android version check in IsUsingVulkan. This ends up causing testHardwareRenderingSmokeTestVulkanWhereSupported to use the interop path instead of the real vulkan composite path. Fix this by checking webview conditions before checking for android version, and verified test is using vulkan composite now. Bug: 1141687 Change-Id: Ida7e5ba778bdaf4cb04c00760598cf808647be46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644863Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#846338}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1dbdce5fbbcb..fa8efd973e40 2021-01-22 vidorteg@microsoft.com [Loc] Migrate color picker pane to Localization V2 2021-01-22 janscheffler@chromium.org [JSDOC2TS]: Migrate lighthouse If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I812f3d0e1847c73160db61d235036686d89f5bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643115Reviewed-by:
-
Xiaocheng Hu authored
The following two tests are already passing: - external/wpt/css/css-pseudo/selection-input-011.html - external/wpt/css/css-pseudo/selection-textarea-011.html So this patch removes their failure expectation lines. Bug: 1110495 Change-Id: Ieb06f9980af88484d3f7f2d659140603da749eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645305 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#846336}
-
Rakib M. Hasan authored
This CL makes builder's load compiled test APK's when running skew tests on a builder. This should fix issues with Client library test failures like WebLayer CookieManagerTest#testSetCookieNotSet since a change in the test was made to the main branch. Bug: 1155565 Change-Id: I569f574b5e1f6fadfd85c9a0d33e5a54f89403b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641304Reviewed-by:
-
chrome://nearby-internalsJuliet Levesque authored
Add a button that triggers the retrieval of Nearby-related state booleans and displays the result as messages on the UI Trigger Tab as follows: https://screenshot.googleplex.com/4NyiQsiPAocTMmY. Bug: 1093634 Change-Id: I28927f14eab542b41d950b553d0c779ecf22c940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637775Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#846334}
-
