- 01 Feb, 2010 26 commits
-
-
carol.szabo@nokia.com authored
Unreviewed. Add myself to list of committers. * Scripts/webkitpy/committers.py: git-svn-id: svn://svn.chromium.org/blink/trunk@54142 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. Structure not accounting for anonymous slots when computing property storage size https://bugs.webkit.org/show_bug.cgi?id=34441 Previously any Structure with anonymous storage would have a property map, so we were only including anonymous slot size if there was a property map. Given this is no longer the case we should always include the anonymous slot count in the property storage size. * runtime/Structure.h: (JSC::Structure::propertyStorageSize): git-svn-id: svn://svn.chromium.org/blink/trunk@54141 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
japhet@chromium.org authored
Rubber-stamped by David Levin. Add myself to reviewer list. * Scripts/webkitpy/committers.py: git-svn-id: svn://svn.chromium.org/blink/trunk@54140 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: Syntax highlighting in source view of Resources pane stops half-way. There were two problems here: (1) styles for html highlighter were not added into the css file (they used to be injected manually in the SourceFrame before). (2) 'Tag' needed to be lexer's state, not parser's. Otherwise unbalanced quotes in the text nodes were matching too match into the string tokens. https://bugs.webkit.org/show_bug.cgi?id=34359 * inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer.prototype._createLineDivs): (WebInspector.NativeTextViewer.prototype._lineHeight): (WebInspector.NativeTextViewer.prototype.initFontMetrics): * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createEditorIfNeeded): * inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.nextToken): * inspector/front-end/SourceHTMLTokenizer.re2js: * inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype.initFontMetrics): (WebInspector.TextEditor.prototype._registerShortcuts): * inspector/front-end/inspectorSyntaxHighlight.css: git-svn-id: svn://svn.chromium.org/blink/trunk@54139 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
benm@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=34335 Reviewed by Darin Adler. WebCore: * bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed. LayoutTests: Update layout tests that did not have source and line number information for their console messages, as this information is now available to the ScriptCallFrame and thus can be passed to the inspector, for example. * fast/js/console-non-string-values-expected.txt: Add console line number/source. * userscripts/script-not-run-for-fragments-expected.txt: ditto. * userscripts/script-run-at-start-expected.txt: ditto. * platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed as platform workarounds no longer necessary. * platform/mac/inspector/console-log-before-inspector-open-expected.txt: ditto. * platform/win/inspector/console-log-before-inspector-open-expected.txt: ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@54138 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
krit@webkit.org authored
Reviewed by Simon Fraser. Add back an AffineTransform class for use by SVG https://bugs.webkit.org/show_bug.cgi?id=33750 These are the first steps on reimplementing AffineTransform. Unlike the old affine code, this one is platform independent like TransformationMatrix. AffineTransform has the benefit, that it stores just 6 doubles instead of 16 in TransformationMatrix. The calculations of transformations are not that complex and can improve the memory usage and speed of SVG. AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at least for the moment). HTML Canvas is the first that makes use of the new AffineTransform. Next patches will introduce the affine code to SVG. No new tests. The new AffineTransformation code is tested by fast/canvas. * Android.mk: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw): * html/canvas/CanvasRenderingContext2D.h: * platform/graphics/GraphicsContext.h: * platform/graphics/Path.h: * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform): * platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t): * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform): * platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform): * platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform): * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform): * platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform): * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform): * platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix): * platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend): (WebCore::AffineTransform::toTransformationMatrix): * platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix): * platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform): * platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix): git-svn-id: svn://svn.chromium.org/blink/trunk@54137 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
philn@webkit.org authored
Reviewed by Eric Carlson. [GTK] set playbin mute property depending on volume value https://bugs.webkit.org/show_bug.cgi?id=31586 New API in MediaPlayer for mute control. 3 new methods are introduced: - bool supportsMuting() const; - bool muted() const; - void setMuted(bool); Platform MediaPlayer implementations can support it easily if the underlying sound daemon/API supports muting (eg. not only setting volume to 0) like PulseAudio for instance on Linux. At the moment the only player supporting this new API is the MediaPlayerPrivateGStreamer. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): (WebCore::HTMLMediaElement::mediaPlayerMuteChanged): * html/HTMLMediaElement.h: * platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::supportsMuting): (WebCore::NullMediaPlayerPrivate::setMuted): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::muted): (WebCore::MediaPlayer::supportsMuting): (WebCore::MediaPlayer::setMuted): (WebCore::MediaPlayer::volumeChanged): (WebCore::MediaPlayer::muteChanged): * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerMuteChanged): * platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsMuting): (WebCore::MediaPlayerPrivateInterface::setMuted): * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::notifyMuteIdleCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedCallback): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::supportsMuting): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::muteChangedCallback): (WebCore::MediaPlayerPrivate::muteChanged): (WebCore::MediaPlayerPrivate::createGSTPlayBin): * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: 2010-01-29 Philippe Normand <pnormand@igalia.com> Reviewed by Eric Carlson. [GTK] set playbin mute property depending on volume value https://bugs.webkit.org/show_bug.cgi?id=31586 New API in MediaPlayer for mute control * public/WebMediaPlayerClient.h: * src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::volumeChanged): (WebKit::WebMediaPlayerClientImpl::muteChanged): * src/WebMediaPlayerClientImpl.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54136 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
[Qt] Platform dependent expected file added for test introduced in r53868, because this test passes. Compared to png file and Mac expected file. * platform/qt/fast/lists/anonymous-items-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@54135 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hausmann@webkit.org authored
Patch by Henry Haverinen <henry.haverinen@nokia.com> on 2010-02-01 Reviewed by Simon Hausmann. Added missing #ifdefs for OpenSSL support and one null-pointer check for the socket. https://bugs.webkit.org/show_bug.cgi?id=34416 * platform/network/qt/SocketStreamHandlePrivate.h: * platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::send): git-svn-id: svn://svn.chromium.org/blink/trunk@54134 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: Fix rest of the NativeTextViewer (line numbers, conditional breakpoints, selection). * inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer): (WebInspector.NativeTextViewer.prototype._updatePreferredSize): (WebInspector.NativeTextViewer.prototype._registerMouseListeners): (WebInspector.NativeTextViewer.prototype._mouseDown): (WebInspector.NativeTextViewer.prototype._contextMenu): (WebInspector.NativeTextViewer.prototype._lineForMouseEvent): (WebInspector.NativeTextViewer.prototype._lineHeight): * inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._registerMouseListeners): (WebInspector.TextEditor.prototype._offsetToLine): (WebInspector.TextEditor.prototype._lineHeight): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._paint): (WebInspector.TextEditor.prototype._updateDivDecorations): (WebInspector.TextEditor.prototype._paintSelection): git-svn-id: svn://svn.chromium.org/blink/trunk@54133 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
steveblock@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=33953 Reviewed by Ariya Hidayat. No new tests, build fix only. * bridge/jni/JNIBridge.h: Modified. Include JavaStringV8.h for V8 * bridge/jni/v8: Added. * bridge/jni/v8/JavaStringV8.h: Added. (JSC::Bindings::JavaStringImpl::init): (JSC::Bindings::JavaStringImpl::UTF8String): (JSC::Bindings::JavaStringImpl::uchars): (JSC::Bindings::JavaStringImpl::length): git-svn-id: svn://svn.chromium.org/blink/trunk@54132 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Windows build fix, update exports file (again) * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: svn://svn.chromium.org/blink/trunk@54131 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Windows build fix, update exports file * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: svn://svn.chromium.org/blink/trunk@54130 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Maciej Stachowiak. JSC is failing to propagate anonymous slot count on some transitions https://bugs.webkit.org/show_bug.cgi?id=34321 Remove secondary Structure constructor, and make Structure store a copy of the number of anonymous slots directly so saving an immediate allocation of a property map for all structures with anonymous storage, which also avoids the leaked property map on new property transition in the original version of this patch. We need to propagate the the anonymous slot count otherwise we can end up with a structure recording incorrect information about the available and needed space for property storage, or alternatively incorrectly reusing some slots. * JavaScriptCore.exp: * runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::copyPropertyTable): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable): * runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::hasAnonymousSlots): (JSC::Structure::anonymousSlotCount): 2010-02-01 Oliver Hunt <oliver@apple.com> Reviewed by Maciej Stachowiak. JSC is failing to propagate anonymous slot count on some transitions https://bugs.webkit.org/show_bug.cgi?id=34321 Add test case for modifying DOM objects with anonymous storage. * fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added. * fast/dom/Window/anonymous-slot-with-changes.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@54129 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Darin Adler. Added compile time debug support for mathml layout (block boundary & baseline) * mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::stretchToHeight): (WebCore::RenderMathMLBlock::paint): * mathml/RenderMathMLBlock.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54128 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
philn@webkit.org authored
Rubber stamped by Xan Lopez. Fixed compilation warning about unsigned vs signed comparison. * plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint): git-svn-id: svn://svn.chromium.org/blink/trunk@54127 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
cjerdonek@webkit.org authored
Reviewed by Shinichiro Hamaji. Moved style error handler code to their own classes, and related refactoring. Increased unit test code coverage of style error handling. https://bugs.webkit.org/show_bug.cgi?id=34379 * Scripts/check-webkit-style: - Minor change: added error_count variable. * Scripts/webkitpy/style/checker.py: - Renamed ProcessorOptions.should_report_error() to is_reportable(). - In the StyleChecker class-- - Removed _default_style_error_handler(). - Added _increment_error_count(). - Refactored to use DefaultStyleErrorHandler and PatchStyleErrorHandler constructors. * Scripts/webkitpy/style/checker_unittest.py: - In the StyleStyleCheckerTest class-- - Removed write_sample_error(). - Removed test_default_style_error_handler(). * Scripts/webkitpy/style/error_handlers.py: Added. - Added DefaultStyleErrorHandler class. - Added PatchStyleErrorHandler class. * Scripts/webkitpy/style/error_handlers_unittest.py: Added. - Added unit tests for DefaultStyleErrorHandler and PatchStyleErrorHandler. * Scripts/webkitpy/style/unittests.py: - Added error_handlers unit tests. git-svn-id: svn://svn.chromium.org/blink/trunk@54126 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Unreviewed. Revert r54112 and r54124 because of Windows build error. * Android.mk: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw): * html/canvas/CanvasRenderingContext2D.h: * platform/graphics/GraphicsContext.h: * platform/graphics/Path.h: * platform/graphics/cairo/GraphicsContextCairo.cpp: * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: * platform/graphics/cairo/PathCairo.cpp: * platform/graphics/cairo/TransformationMatrixCairo.cpp: * platform/graphics/cg/GraphicsContextCG.cpp: * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: * platform/graphics/cg/PathCG.cpp: * platform/graphics/cg/TransformationMatrixCG.cpp: * platform/graphics/haiku/GraphicsContextHaiku.cpp: * platform/graphics/haiku/PathHaiku.cpp: * platform/graphics/qt/GraphicsContextQt.cpp: * platform/graphics/qt/PathQt.cpp: * platform/graphics/qt/TransformationMatrixQt.cpp: * platform/graphics/skia/GraphicsContextSkia.cpp: * platform/graphics/skia/PathSkia.cpp: * platform/graphics/skia/TransformationMatrixSkia.cpp: * platform/graphics/transforms/AffineTransform.cpp: Removed. * platform/graphics/transforms/AffineTransform.h: Removed. * platform/graphics/wince/GraphicsContextWince.cpp: * platform/graphics/wx/GraphicsContextWx.cpp: * platform/graphics/wx/PathWx.cpp: * platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::TransformationMatrix::operator wxGraphicsMatrix): git-svn-id: svn://svn.chromium.org/blink/trunk@54125 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54124 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Darin Adler. Buildfix for WinCE + style fixes (TLS_OUT_OF_INDEXES is not defined). https://bugs.webkit.org/show_bug.cgi?id=34380 * wtf/ThreadSpecific.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54123 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Darin Adler. Limit the scope of packing alignment to avoid MSVC C4103 warning. https://bugs.webkit.org/show_bug.cgi?id=34390 Use pack(push, 16) and pack(pop) to limit the scope of packing alignment change. * bindings/js/JSSVGPODTypeWrapper.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54122 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Reviewed by Darin Adler. [Windows] Fix a bug of round() with huge integral numbers https://bugs.webkit.org/show_bug.cgi?id=34297 Fix a bug that round() for huge integral numbers returns incorrect results. For example, round(8639999913600001) returns 8639999913600002 without this change though the double type can represent 8639999913600001 precisely. Math.round() of JavaScript has a similar problem. But this change doesn't fix it because Math.round() doesn't use round() of MathExtra.h. * wtf/MathExtras.h: (round): Avoid to do "num + 0.5" or "num - 0.5". (roundf): Fixed similarly. (llround): Calls round(). (llroundf): Calls roundf(). (lround): Calls round(). (lroundf): Calls roundf(). 2010-01-31 Kent Tamura <tkent@chromium.org> Reviewed by Darin Adler. [Win] Fix a bug of round() with huge integral numbers https://bugs.webkit.org/show_bug.cgi?id=34297 Add a test case to call round(8639999913600001). * fast/forms/input-valueasnumber-datetime-expected.txt: * fast/forms/script-tests/input-valueasnumber-datetime.js: git-svn-id: svn://svn.chromium.org/blink/trunk@54121 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Reviewed by Darin Adler. Fix valueAsNumber calculation for type=month. https://bugs.webkit.org/show_bug.cgi?id=34304 valueAsNumber calculation for type=month which was checked in as r53893 was the number of milliseconds since UNIX epoch, and it was wrong. The correct way is the number months since UNIX epoch. * fast/forms/input-valueasnumber-month-expected.txt: * fast/forms/script-tests/input-valueasnumber-month.js: 2010-01-31 Kent Tamura <tkent@chromium.org> Reviewed by Darin Adler. Fix valueAsNumber calculation for type=month. https://bugs.webkit.org/show_bug.cgi?id=34304 valueAsNumber calculation for type=month which was checked in as r53893 was the number of milliseconds since UNIX epoch, and it was wrong. The correct way is the number months since UNIX epoch. * html/DateComponents.cpp: (WebCore::DateComponents::setMonthsSinceEpoch): (WebCore::DateComponents::monthsSinceEpoch): * html/DateComponents.h: Declare setMonthsSinceEpoch() and monthsSinceEpoch(). * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): Switch to monthsSinceEpoch() for type=MONTH. (WebCore::HTMLInputElement::valueAsDate): Add code with millisecondsSinceEpoch() for MONTH because parseToDouble() changed its behavior. (WebCore::HTMLInputElement::setValueAsNumber): Use setMonthsSinceEpoch() for MONTH. git-svn-id: svn://svn.chromium.org/blink/trunk@54120 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Reviewed by Jeremy Orlow. [Chromium] Fix a bug that a selected word is not recognized as a spell-check source. https://bugs.webkit.org/show_bug.cgi?id=33660 * src/ContextMenuClientImpl.cpp: (WebKit::isASingleWord): Use wordBreakIterator(), and correctly check the return value of textBreakNext(). git-svn-id: svn://svn.chromium.org/blink/trunk@54119 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=34398 Reviewed by Timothy Hatcher. * inspector/front-end/inspector.css: Specify line-height: normal for ".console-message .bubble" and ".sidebar-tree-item .status .bubble". git-svn-id: svn://svn.chromium.org/blink/trunk@54118 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
Reviewed by Darin Adler. Implement CSSOM Range.getClientRects for collapsed selections https://bugs.webkit.org/show_bug.cgi?id=34239 Adds two cases to getClientRects test. * fast/dom/Range/getClientRects-expected.txt: * fast/dom/Range/getClientRects.html: 2010-01-28 Ojan Vafai <ojan@chromium.org> Reviewed by Darin Adler. Implement CSSOM Range.getClientRects for collapsed selections https://bugs.webkit.org/show_bug.cgi?id=34239 When getting the quads for a range on a text node, allow returning zero width quads. This leaves the case of collapsed selections inside elements still not fixed, but no worse. * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): * rendering/RenderText.cpp: (WebCore::RenderText::absoluteQuadsForRange): git-svn-id: svn://svn.chromium.org/blink/trunk@54117 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 31 Jan, 2010 12 commits
-
-
mrowe@apple.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54116 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrowe@apple.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54115 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric.carlson@apple.com authored
Revert r54095 because it caused many media tests to fail. * platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::setContentsToVideo): (WebCore::GraphicsLayerCACF::updateContentsVideo): * platform/graphics/win/GraphicsLayerCACF.h: (WebCore::GraphicsLayerCACF::): * platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::task): (QTMovieWinPrivate::setSize): git-svn-id: svn://svn.chromium.org/blink/trunk@54114 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Simon Fraser. Animated scaling of background-image is too slow https://bugs.webkit.org/show_bug.cgi?id=33808 Update checksum. * platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum: 2010-01-31 Oliver Hunt <oliver@apple.com> Reviewed by Simon Fraser. Animated scaling of background-image is too slow https://bugs.webkit.org/show_bug.cgi?id=33808 Implement a version of the RenderImage animated scaling optimisation for background images. Due to the possibility of arbitrary transforms being applied to containing elements we explicitly check the current CTM of the context for scaling or rotation. * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage): * platform/graphics/GraphicsContext.h: * platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer): (WebCore::RenderBoxModelScaleData::size): (WebCore::RenderBoxModelScaleData::setSize): (WebCore::RenderBoxModelScaleData::lastPaintTime): (WebCore::RenderBoxModelScaleData::setLastPaintTime): (WebCore::RenderBoxModelScaleData::useLowQualityScale): (WebCore::RenderBoxModelScaleData::transform): (WebCore::RenderBoxModelScaleData::setTransform): (WebCore::RenderBoxModelScaleData::setUseLowQualityScale): (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed): (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired): (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended): * rendering/RenderBoxModelObject.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54113 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
krit@webkit.org authored
Reviewed by Simon Fraser. Add back an AffineTransform class for use by SVG https://bugs.webkit.org/show_bug.cgi?id=33750 These are the first steps on reimplementing AffineTransform. Unlike the old affine code, this one is platform independent like TransformationMatrix. AffineTransform has the benefit, that it stores just 6 doubles instead of 16 in TransformationMatrix. The calculations of transformations are not that complex and can improve the memory usage and speed of SVG. AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at least for the moment). HTML Canvas is the first that makes use of the new AffineTransform. Next patches will introduce the affine code to SVG. No new tests. The new AffineTransformation code is tested by fast/canvas. * Android.mk: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw): * html/canvas/CanvasRenderingContext2D.h: * platform/graphics/GraphicsContext.h: * platform/graphics/Path.h: * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform): * platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t): * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform): * platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform): * platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform): * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform): * platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform): * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform): * platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix): * platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend): * platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix): * platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform): * platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix): git-svn-id: svn://svn.chromium.org/blink/trunk@54112 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Timothy Hatcher. Web Inspector: [REGRESSION] Breakpoint source line is not displayed in the breakpoint manager. * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addBreakpointToSource): git-svn-id: svn://svn.chromium.org/blink/trunk@54111 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: Introduce NativeTextViewer. This change handles rendering highlighted text, using browser's selection/drag/drop/click logic. Breakpoint decorations and program counter is working. Todo: line numbers are painted 'under' the text when scrolling horizontally, search is not yet implemented. https://bugs.webkit.org/show_bug.cgi?id=34391 * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/DivBasedTextViewer.js: Added. (WebInspector.DivBasedTextViewer): (WebInspector.DivBasedTextViewer.prototype._textChanged): (WebInspector.DivBasedTextViewer.prototype._createLineDivs): (WebInspector.DivBasedTextViewer.prototype._updatePreferredSize): (WebInspector.DivBasedTextViewer.prototype._scroll): (WebInspector.DivBasedTextViewer.prototype._registerMouseListeners): (WebInspector.DivBasedTextViewer.prototype._registerKeyboardListeners): (WebInspector.DivBasedTextViewer.prototype._registerClipboardListeners): (WebInspector.DivBasedTextViewer.prototype._paintSelection): (WebInspector.DivBasedTextViewer.prototype._positionDivDecoration): (WebInspector.DivBasedTextViewer.prototype._mouseDown): (WebInspector.DivBasedTextViewer.prototype._contextMenu): (WebInspector.DivBasedTextViewer.prototype._caretForMouseEvent): (WebInspector.DivBasedTextViewer.prototype._paintLine): (WebInspector.DivBasedTextViewer.prototype._createSpan): * inspector/front-end/Settings.js: * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype._createEditorIfNeeded): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype.resize): * inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._registerMouseListeners): (WebInspector.TextEditor.prototype._registerKeyboardListeners): (WebInspector.TextEditor.prototype._registerClipboardListeners): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype.revalidateDecorationsAndPaint): (WebInspector.TextEditor.prototype._updatePreferredSize): (WebInspector.TextEditor.prototype.resize): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._paintLine): (WebInspector.TextEditor.prototype._contextMenu): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._changeFont): * inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype._lex): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: * inspector/front-end/textEditor.css: git-svn-id: svn://svn.chromium.org/blink/trunk@54110 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Eric Seidel. [Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms https://bugs.webkit.org/show_bug.cgi?id=34168 Enable FAST_MOBILE_SCROLLING for Qt on Maemo 5, Linux embedded and Symbian * WebCore.pro: git-svn-id: svn://svn.chromium.org/blink/trunk@54109 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Make ScriptState destructor protected since all non-empty ScriptStates are managed by GC. Remove obsolete constructor. https://bugs.webkit.org/show_bug.cgi?id=34266 * bindings/v8/ScriptState.cpp: * bindings/v8/ScriptState.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54108 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simon.fraser@apple.com authored
Reviewed by Dan Bernstein. Use CGGradient on Leopard and later, since it's faster than CGShading https://bugs.webkit.org/show_bug.cgi?id=34384 Use CGGradient on Leopard and later, rather than CGShading, for performance. * platform/graphics/Gradient.h: * platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary): Utility method to sort stops. Did not call this from getColor() to avoid overhead of a function call. * platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformDestroy): Use CGGradientRelease() post-Tiger. (WebCore::Gradient::platformGradient): Create and return a CGGradientRef post-Tiger. (WebCore::Gradient::fill): Call new paint() method. (WebCore::Gradient::paint): New convenence method that avoids testing isRadial() in a bunch of other places. * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): Call the gradient's paint() method. (WebCore::GraphicsContext::strokePath): Ditto (WebCore::GraphicsContext::fillRect): Ditto (WebCore::GraphicsContext::strokeRect): Ditto git-svn-id: svn://svn.chromium.org/blink/trunk@54107 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simon.fraser@apple.com authored
Reviewed by Adele Peterson. Do color animations on premultiplied colors https://bugs.webkit.org/show_bug.cgi?id=34383 Convert colors to premultiplied alpha before interpolating them, then convert the result back to non-premultiplied. This gives better results when animating from transparent colors. Test: transitions/color-transition-premultiplied.html * page/animation/AnimationBase.cpp: (WebCore::blendFunc): git-svn-id: svn://svn.chromium.org/blink/trunk@54106 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kevino@webkit.org authored
Add a way to get the parse mode to wxWebKit API. https://bugs.webkit.org/show_bug.cgi?id=34341 git-svn-id: svn://svn.chromium.org/blink/trunk@54105 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 30 Jan, 2010 2 commits
-
-
kov@webkit.org authored
Build fixes needed for make distcheck. * GNUmakefile.am: git-svn-id: svn://svn.chromium.org/blink/trunk@54104 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrowe@apple.com authored
* WebCore.xcodeproj/project.pbxproj: git-svn-id: svn://svn.chromium.org/blink/trunk@54103 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-