- 08 Oct, 2020 40 commits
-
-
Risan authored
BUG=1134755 TEST=CQ Change-Id: Ic1a50d2e944d09d7795ea01609a5a56b2a5207ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460830 Auto-Submit: Risan <risan@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#815334}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I7906f4f164361c10b766a1e27d5a32baa11c5737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815333}
-
Bo Liu authored
Buffer queue may not change orientation on rotation, and the swap size would have the width and height swapped for code that expects the swap size to be in landscape. This fixes the surfaceRedrawNeededAsync timeout when rotating from portrait to landscape. This also fixes 1136033 where on initial launch in landscape, android side does not have a timeout for surfaceRedrawNeededAsync like it does for rotation. Bug: 1136033 Change-Id: I91b3d81252f3e02fb3d85bf1ac91d5d802544490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459569Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815332}
-
Dana Fried authored
This is a temporary fix while we hash out the attached a11y bugs. Bug: 1136185, 1136236 Change-Id: I8a5ab6584fb708112c4b27ecae643be5a09f6564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459056Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#815331}
-
Angela Yoeurng authored
This CL updates the background color of a hovered/selected suggestion if the refined-focus-state flag is enabled. It also made the focus bar visible only if the search suggestion is selected vs. if the aux buttons are selected as well. Bug: 1129612 Change-Id: Iba4287937a345123c5465cea2522e7462be1f93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459632 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815330}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9fb07662e436..823a6df243c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0b44962419e5a1c8f17dcf3b4d96804c2ea5d901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461713Reviewed-by:
-
Peng Huang authored
This reverts commit a49d219d. Reason for revert: Found a right way to fix it, so revert this workaround. Original change's description: > Use logic rotation with SurfaceControl on Android > > For some devices, the hardwarerotation doesn't work with SurfaceControl, > so disable it for now. > > Bug: 1136033 > Change-Id: Id1ed7971d50ec815fd315fb728315f05e6be9637 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461550 > Auto-Submit: Peng Huang <penghuang@chromium.org> > Commit-Queue: Jonathan Backer <backer@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815198} TBR=penghuang@chromium.org,backer@chromium.org Change-Id: Ib6f08d68ef4a99eeafd61dd01d8b5fbcb12a3a23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462377Reviewed-by:
-
Trent Apted authored
Git archaeology suggests callers of this method disappeared in r754621. Bug: 894447 Change-Id: I24a1818950be53131fd781d07c19a096d138db6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460071Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#815327}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 57ee92af. With Chromium commits locally applied on WPT: 5eb1a5d6 "[Sanitizer API] Remove creationOptions from Sanitizer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ieb89d7e42db7bdd47bde1f988c6a2868ae9bc07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461828Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815326}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d24d3c2bc1d7..2a472f6edd47 2020-10-08 michael.liao@microsoft.com [Issues Pane]: Fix focus regression where expanding tree elements would refocus first tree item If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136420 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2a89378b041258ec59ec510226cdd67f5b2fca87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462144Reviewed-by:
-
Chris Blume authored
Right now, we first check if the user is in the enabled feature group when enabling wide color gamut. After that, we check if they are on a version of Android that supports wide color gamut. This results in users in the enabled group who aren't actually seeing wide colors. This CL checks if the user is on a supported version of Android before checking which group they are in. That should give us more accurate results when looking at the effect of the experiment. Bug: 1136572 Change-Id: Ied060b1036bba67a0c90a45f1f8e1dc106af4aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462218 Commit-Queue: Chris Blume <cblume@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Dave Tapuska authored
With the removal of the RenderWidgetFullscreenPepper WebExternalWidget is only used inside tests. Move these tests inside blink. Add ability to override the WebViewFrameWidget with a custom implementation so that we can instrument it for tests. BUG=1097816 Change-Id: Id5cf6cea5d56f91aa6d7c0c5c05ff98f7ec9e19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460715 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#815323}
-
Kartik Hegde authored
Add GetRandomAndFixedHostsWithSchemeAndPort() which will be used by network diagnostics routines. TEST=none BUG=chromium:956783 Change-Id: Idca59b4f7c0a05043a8ce8b62465ce696d04be9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462275 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#815322}
-
Sven Zheng authored
In preparation for the win 1909 update. We should get new gold images caused by system update if there's any, and approve them. Change-Id: Id18d2d46d4280f1096e9659b1a5b421bbe5401fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453924Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#815321}
-
Clark DuVall authored
Also removes unused onBind() from SplitCompatIntentService. Review from Patchset 1 to get the right diffs on the changes in CustomTabsConnectionServiceImpl. Bug: 1126301 Change-Id: I21fa9e948030ace8377dc1fac24bc6ddcca16cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462176 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#815320}
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: I235a973162915dc7e6ca817c82f7caa7c001b579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453807 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815319}
-
Xing Liu authored
Keep metric "Download.Database.IsAvailable" which is helpful to detect critical issue in download sqlite db. Bug: 1088728 Change-Id: I63be65de5529a1666dd3edfde9a545279da711b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363668Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815318}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6dfd855a10fb..887b1346d5af 2020-10-08 syoussefi@chromium.org Vulkan: Add resolve/unresolve counters 2020-10-08 syoussefi@chromium.org Pass in Command::Clear to framebuffer syncState If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I66993196aeb5e016b1bb6402ce5b113dab2b324a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461974Reviewed-by:
-
Rune Lillesveen authored
In order to store tree-scoped names/references in ComputedStyle we need to keep track of which TreeScope the MatchedProperties came from during selector matching. We do this by pushing TreeScope pointers for each scoped to MatchResult which maps to the tree_order number stored in each MatchedProperties entry. This mapping will be used during cascading and stored with the name to create a tree-scoped reference on ComputedStyle. Bug: 336876 Change-Id: I416d9b12276917cb17c368909d3d5fd1b9f4f5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453392Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#815316}
-
Peter Kvitek authored
It was previously required to prevent chromium_browsertests from crashing, however, that does not seem to be the case anymore. Change-Id: Ibff440948fe268db0cc0e0f635a5766beb032da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454372 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Auto-Submit: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#815315}
-
Malay Keshav authored
This patch adds UMA metrics to track the stages of HaTS that users go through. This helps keep track of number of users who view the UMA survey. Since Chrome OS uses client side logic to roll dice for survey, UMA metrics is required. Test: Manually Bug: 1134413 Change-Id: Ic4981ab97ba3f1b99a588b5a32279bfca03009d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444511 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815314}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/fc5c5ab60b22..1a63c49b4e86 2020-10-08 dsinclair@chromium.org Update structs to allow multiple decorations 2020-10-08 dsinclair@chromium.org [type-determiner][spirv-writer] Add arrayLength support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: kainino@google.com Change-Id: I6661c8561b9b2e511761cf4e0a5c4322389173bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462139Reviewed-by:
-
Nina Satragno authored
Wire up the WebAuthn largeBlob extension `write` parameter for navigator.credentials.get. At the moment, no compression for the data takes place. This patch also modifies the code that obtains a PUAToken with UV to pass custom permissions so we can request lbw when needed, and has the virtual authenticator DCHECK that the permissions requested are supported. It is also now possible to obtain a PUAToken using the virtual authenticator even if client pin is not supported. This enables using large blobs on uv-enabled virtual authenticators. Finally, the parameter validation is moved from CredentialsContainer to AuthenticatorCommon so they run in the browser process. This feature is guarded behind the WebAuthenticationLargeBlobExtension feature flag. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I390d9e1ef0e378ef28054b168f01e1b9f78e3a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453875 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#815312}
-
Andrey Kosyakov authored
Revert "[Paint Preview] Split PaintPreviewCompositor memory metrics from the general Utility process metrics" This reverts commit 8711fb9a. Reason for revert: broke Cast Audio Linux bot, https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/87604 Original change's description: > [Paint Preview] Split PaintPreviewCompositor memory metrics from the general Utility process metrics > > Change-Id: I6067aad3959c054181389c1e1b82e464eacd9a4b > Bug: 1135217 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441263 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Yashar Dabiran <yashard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815285} TBR=yfriedman@chromium.org,fdoray@chromium.org,rkaplow@chromium.org,ckitagawa@chromium.org,yashard@chromium.org Change-Id: Iba7597dd7f400b21f3e464c7849d4852a69c1b9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461900Reviewed-by:
-
Garrett Beaty authored
No-op jobs no longer exist for dummy builders that are named as mirrors for trybots. Those builders can now appear as mirrors in a trybot config but can't specify a parent builder, so they won't be triggered. No-op jobs continue to exist for tester builders where for whatever reason we do not want to run them on the branches. Change-Id: I0a0f5ac5213ff7aef9e1c7e73730428756f3f2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462236 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#815310}
-
John Lee authored
Bug: 1110405 Change-Id: I6de7525fa89373a5d2be46028865cef06b9508f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454393 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815309}
-
Joon Ahn authored
https://screenshot.googleplex.com/6FwB36oBkNRFgnJ Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Id812443e5df2121af05e4ab140fca2b31943d9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457590Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#815308}
-
Rouslan Solomakhin authored
Before this patch, multiple locations in Web Payment, e.g., PaymentAppServiceBridge, contained WebContents and RenderFrameHost pointers that could become invalid and be used after free. This patch makes Web Contents store GlobalFrameRoutingId and always retrieve and null check the RenderFrameHost from it. If WebContents is needed and the RenderFrameHost is current, then WebContents is retrieved from the RenderFrameHost. After this patch, Web Payment holds a GlobalFrameRoutingId, so the RenderFrameHost and WebContents can be checked for validity before use. Bug: 1125614 Change-Id: I084a062c2a7cad100a6d2d0994c1b0cc9b9efc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422178 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815307}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/823a6df243c3..02a7aa75bb24 2020-10-08 fmayer@google.com Merge "Do not abort profile if main thread stack grows." 2020-10-08 primiano@google.com Merge changes Ic7aa1265,I4d418aac 2020-10-08 treehugger-gerrit@google.com Merge "perfetto-ui: Improve record page" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5ef2f250416c30e105339578935f00f32fbc8eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462140Reviewed-by:
-
Anders Hartvoll Ruud authored
When parsing a simple selector, we currently check after-the-fact whether we followed a pseudo-element, and whether or not the simple selector was allowed to follow that pseudo-element. If the simple selector was _not_ allowed to follow a pseudo-element, then parsing failed altogether. This does not work well for nested <forgiving-selector-list>s, which requires partial failure. For example, ::part(foo):is(.a,:hover) shall behave as ::part(foo):is(:hover) (instead of failing). This CL instead checks for simple selector validity in ConsumeSimpleSelector, by storing a "restricting pseudo element" during parsing of the compound containing the pseudo-element. This makes it possible for deeply nested selectors to fail at the appropriate time and trigger the forgiving behavior. Bug: 568705 Change-Id: Icfb20416c008e37279866a688a525b9419437086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450191 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#815305}
-
Daniel Hosseinian authored
crrev.com/782283 caused a regression which caused tracked remote instances of PrintRenderFrame to linger after the completion of a print composite request. Consequently, printing the same WebContents with cross process subframes more than once would cause the compositing to never finish. Bug: 1136431 Change-Id: Id0670905d1b4acb7b55f7a043d5a4bfb584ccfa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462178Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#815304}
-
Ken Rockot authored
We generate Equals() methods for struct and union wrapper classes. There's not really a good reason to do this instead of operator==, and operator== plays nicely with gmock matchers. This adds operator== to do the same thing as Equals. Bug: 735302 Change-Id: I4ab8c70aa4ba0276aec7a2f64734c710a090d6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456148 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#815303}
-
Akihiro Ota authored
Promote createMockKeyEvent to avoid redeclarations in multiple files. Also use KeyCode where possible. This change is a pure refactor. Bug: N/A Change-Id: I300c3cc0e02fd5610092dd8b39672acb7f96c9b6 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459631 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#815302}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test cases no longer need to be parameterized. Bug: 1065748 Change-Id: Iff9b0c04df28b7fe87fb6a3ba1bc131c73cb018a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459512 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815301}
-
Stefan Zager authored
This feature is required for isInputPending. The change to compositing_inputs_updater.cc fixes a bug that snuck in via this CL while the feature was disabled: https://chromium-review.googlesource.com/c/chromium/src/+/2283630 The web_test changes are mostly cases where a test has a cross-origin iframe which was not previously composited, and making the iframe composited caused anti-aliasing differences. The mhtml/ test changes are needed because chromium treats the iframes in the encoded-html test files as cross-origin; to ensure consistent text rendering, this CL forces everything in both the test files and the ref test expectations to be composited. BUG=930987 Change-Id: I8f54eeacd333e46f394c08e9bf8366f0e9e2e57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443630 Commit-Queue: Stefan Zager <szager@chromium.org> Auto-Submit: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Collin Baker authored
The thumbnail scheduler implementation introduced a bug: each time a ThumbnailImage is observed, ThumbnailCaptureDriver will recapture the thumbnail even though it already has a good final capture. This CL fixes the regression. Fixed: 1136247 Change-Id: I825632157802eda70656f9fdb4376942b5febe15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459627 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#815299}
-
Will Harris authored
This histogram was no longer being looked at, and had already expired. BUG=1130738,1066103 Change-Id: I9c49879315d8b3296adea1571460f2d68e4befb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458887Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Wei Li authored
Bug: 772945 Change-Id: I8b5af781812a7baaae83cd59371d67528a3c1a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458812 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
-
Daniel Libby authored
This adds configs for a manually-triggered trybot that runs release blink_web_tests with --force-renderer-accessibility, in order to start stabilizing serialization/deserialization code for all the content tested by the entire web_tests suite. See corresponding tools/build cl landed here: crrev.com/c/2454398 Bug: 1135251 Change-Id: Ic9db4673a3bf580225864f1aa6b1da6a6e682793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453446Reviewed-by:
-
ckitagawa authored
Improve detection of if a true cold start is happening. If start surface is shown then we should omit cold start metrics as in that case these metrics don't accurately reflect performance regressions. See bug for UMA histograms showing the effect. Bug: 1135566, 1135651 Change-Id: I99bab63f4e4fa3e34133bbe73718520164ff6355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450921 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815295}
-
