- 17 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9eeb00431109..316b70a0e9bb 2020-12-17 sigurds@chromium.org Update protocol 2020-12-17 wolfi@chromium.org Remove "blackbox" - refactor DebuggerPlugin If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152082 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic6b0ee2ef70b6f221f93306c8f8e440735240352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595216Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838006}
-
Clemens Arbesser authored
Some trigger sites will not directly navigate to the desired target domain, but will instead use a redirect to eventually arrive at the target domain. This resulted in an early error for trigger scripts. This CL removes the initial domain check. This should be a safe change because we own and trust the trigger sites. The result is that the initial redirect (if any) is ignored. All subsequent navigations are handled as before. Bug: b/175132318 Change-Id: Ie52271eb0bf70b8372d3290c9e6c174f3404a6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593102 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#838005}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ee7c8ce1be5..d89a80298292 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC koerber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: koerber@google.com Change-Id: Id2c4c556ad5ec950685946b0d3e6ec5c695bed59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596752Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838004}
-
Rahul Goyal authored
The goal is to add a second implementation further downstream. This CL is a refactoring only and should not have user-facing changes. Bug: b/174445633 Change-Id: I9d0fc65daf53c968557a79dd6db0bdfc7c03bf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573138Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Rahul Goyal <goyalrahul@google.com> Cr-Commit-Position: refs/heads/master@{#838003}
-
Markus Handell authored
Bug: 1157617 Change-Id: Idc38ef3c6fe98a59a839c1fd5b9c4711302be032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593117 Auto-Submit: Markus Handell <handellm@google.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#838002}
-
Matt Menke authored
These tests were setting a NetworkIsolationKey for a simulated received alternative service header, but not on the request that it was intended to affect. Bug: 969893 Change-Id: Id7eaa270e48db4303aca58b0536f7463398cc507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595827Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#838001}
-
Mario Sanchez Prada authored
Since there might be more than one mojo Remote for this mojo interface in the browser process at a given time (e.g. one for the regular media session and another one for a PiP session), it would be good to make sure we don't unnecessarily end up with unbound receivers in the set owned by HTMLMediaElement when only one of those remotes are removed. Thus, this CL adds the extra plumbing required in HeapMojoReceiverSet to allow setting disconnect_handlers on the wrapped mojo::ReceiverSet and uses it to make sure that unbound remotes on the browser process for the media::mojom::MediaPlayer interface result in the associated mojo receiver being removed in the renderer process. Bug: 1039252 Change-Id: I7140345658d1b5c30b5aee437285b55251452390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595047Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#838000}
-
Camillo Bruni authored
Pass the base URL for modules as member ModuleScriptCreationParams to JSModuleScript::Create. Bug: 1154943 Change-Id: I7c5fb214a638c4808d5412199ad093797e4cb451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572097 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#837999}
-
Ernest Galbrun authored
Read the bundle path and version from the latest GetScriptsForUrl call, and store it in the service's state. Forward them in the Initial request's ScriptStoreConfig. Change-Id: I80aef768ea893146af42f6671a03379356bdcf67 Bug: b/174227808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582118 Commit-Queue: Ernest Galbrun <galbrun@google.com> Reviewed-by:
-
Luciano Pacheco authored
JS modules for: - //ui/file_manager/file_manager/background/js/ - duplicate_finder.js - duplicate_finder_unitetst.js - //u/file_manager/externs/background/duplicate_finder.js Because Closure doesn't deal well importing the same namespace from different files, I started splitting the "importer" namespace so each file will have its own namespace. Files in the "externs" directory will have the suffix "Interface" on their namespace. I'll use this logic for all files related to "importer" namespace. Bug: 1133186 Change-Id: I10240cb6d3083daf4bbc53773c391feb9d66c693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596473 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837997}
-
Richard Stotz authored
After https://crrev.com/c/2588910 introduced a NativeIOManager in content/browser, this CL renames Blink's NativeIOManager to NativeIOFileManager to avoid future confusion. No functional changes are introduced. Bug: 1137788 Change-Id: I190ec89ac33864ce347374a33a0d6e57cb21f434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593374Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Richard Stotz <rstz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837996}
-
dpapad authored
Bug: 1132403 Change-Id: Ice9c1a005017378b0e215c19cec44aa8e2868630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595516Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837995}
-
Ryan Keane authored
Change-Id: If0b1a475873d886f36d3ed1a6231f881ec73d30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596112Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Auto-Submit: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#837994}
-
Mohamed Amir Yosef authored
to be aligned with the latest mocks. Basically we will show a static string and the user email. This is reverting most of the code in https://crrev.com/c/2550821 and doing minor modifications Screenshot: https://screenshot.googleplex.com/9zuD5cB5UhSiCDc Bug: 1139263 Change-Id: Ib6adbf8d49e80b07dcb74e98d4fd27b0a97237a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595531Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#837993}
-
Wojciech Dzierżanowski authored
MediaSessionPictureInPictureWindowControllerBrowserTest.PreviousTrackButtonVisibility (and a few similar tests too) didn't test the exact scenario it was meant to test. If it had, it would have _always_ failed when trying to verify the button bounds at the end: the button size is set to 0x0 upon hiding, so bounds comparison of a hidden and visible button should always fail. The reason it didn't fail most of the time is because the button size was, unintentionally, 0x0 throughout the test. The size was kept at 0x0 because never throughout the test was OverlayWindowViews::OnUpdateControlsBounds() called with `show_previous_track_button_` true. The test didn't execute the intended paths because RunUntilIdle() is misleading here. Seeing it used after setMediaSessionActionHandler('previoustrack') and video.play(), we were inclined to think the previous track button was now visible and the layout had been updated. What really happened was we would become idle even though the delayed OnUpdateControlsBounds() task had been posted. As the mouse was hovered over the window the button became visible, but the layout was still pending. And so a plausible explanation for the flaky failures is: when executing under heavy load sometimes the 1-second delayed layout did happen early enough to store the 20x20 size in `previous_track_bounds`. In this CL, we rework the test to wait for the desired events explicitly instead of calling RunUntilIdle(). Other tests checking control visibility are mirated as well. The tests that add/remove buttons with the controls hidden are moved to the unit test because it's hard for a browser test to know when it's the right time to make assertions about layout if all the controls are hidden. Once fixed, the test uncovered two issues with the implementation which were subsequently fixed: - When creating the window, UpdateControlsVisibility(false) was called too early. The operations in OnRootViewReady() would override its effect. - Control visibility must be updated along with their layout. Otherwise, a change in control visibility has no effect on the views::View visibility if it happens while the controls are shown (during hover). With that done, we can enable MediaSessionPictureInPictureWindowControllerBrowserTest.PreviousTrackButtonVisibility again. Bug: 985303 Change-Id: I411cdd2d0a55489ec5b7eb82bab95e05d84d323d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587053Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#837992}
-
Luciano Pacheco authored
JS modules for: - //ui/file_manager/file_manager/background/js/ - media_scanner.js - mock_media_scanner.js - media_scanner_unittest.m.js - //u/file_manager/externs/background/media_scanner.js Because Closure doesn't deal well importing the same namespace from different files, I started splitting the "importer" namespace so each file will have its own namespace. Files in the "externs" directory will have the suffix "Interface" on their namespace. I'll use this logic for all files related to "importer" namespace. Bug: 1133186 Change-Id: I55b14aaa58a140e1e754ceaf15c51219df19578a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596281Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608152110-c6b8168a74d771ecb9159dac1f934f7c3a6ae962.profdata to chrome-win64-master-1608163120-d054357d6971f45c660f6ad6c7bb434a3b74b3d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifcbc8313e43fb0edcf535deb6b85fb46458a6124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597017Reviewed-by:
-
Alice Wang authored
This CL improves Android Studio support for javatests after modularization. Since with the new clank structure, we are going to have javatests and java files in one folder, we can list both of them in one gradle target as well. Bug: 620034 Change-Id: I48f6a376c87cb368ded662f868c1c1767755267e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594770 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837989}
-
Side Yilmaz authored
After enabling Incognito CCT, offline pages starts to use it because of passing EXTRA_OPEN_NEW_INCOGNITO_TAB true for incognito mode. Although this is an intended behavior, Incognito CCT fetches downloaded page from web, instead of fetching it from the disk. This CL disables Incognito CCT use for offline page and makes offline page behavior for incognito same with prior Incognito CCT is introduced. After there will be support for fetching downloaded pages from disk for incognito, this CL will be reverted. Bug: 1148275 Change-Id: I30cdc6486fb1725bec5c4f6bb6edb1c97be78782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588911Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837988}
-
Frédéric Wang authored
Per [1], mmultiscripts can only have one in-flow <mprescripts/> child so this CL fixes IsValidMultiscript() to align with the specification. It also makes similar adjustment for the corresponding fatal checks in NGMathScriptsLayoutAlgorithm::GatherChildren (rather than just checking the index of a previous <mprescripts> is nonzero, which does not work if there is no post-scripts). This fixes an assertion about node not being laid out due to the fact that the mmultiscripts algorithm only performs layout of at most one <mprescript>. [1] https://mathml-refresh.github.io/mathml-core/#prescripts-and-tensor-indices-mmultiscripts Bug: 1158375, 6606 Change-Id: I26964b2ef287585392db7f1854251b4b21075aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593643 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837987}
-
Shik Chen authored
Bug: b/172879638 Test: Manually Change-Id: I157453bc4d743f43a26531f60dbe53952ff4d827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596896 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#837986}
-
Rune Lillesveen authored
SelectorFilterParentScopes are added to the stack in the flat tree order, but the SelectorFilter were still assuming shadow-including ancestors constituted the filter stack. This fixes the performance issue in 1159206 by correctly rejecting the expensive indirect adjacent selector based on the bloom filter. Bug: 1159206 Change-Id: Iddfeb78b78567de8fa19be8c923219fa738ff303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595379Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#837985}
-
Frédéric Wang authored
This CL adds tests for the following functions: SecurityOrigin::IsSecure network::IsUrlPotentiallyTrustworthy network::IsOriginPotentiallyTrustworthy They cover various cases of [1] as well as existing support in Blink. There is no behavior change, the expectations are just set to make the tests pass with the current implementations. This will make easier to compare and unify them. [1] https://w3c.github.io/webappsec-secure-contexts/#is-url-trustworthy Bug: 1153336 Change-Id: I40b6b8aaabd8ae7d0f97ceaa5ab4462eebfff585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593629Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#837984}
-
Fredrik Söderqvist authored
LayoutSVGPath is now the only user of this function. Currently the set of elements that should have markers applied equals the set of elements that create/use LayoutSVGPath, so just DCHECK() this in the constructor (as future-proofing) and drop the actual check. Change-Id: Icb3b8aab1dd1b569e16bb14dfade43232d442ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595378Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#837983}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee505470..448c4502 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id350bd525b45593caacd53624403649e04d8c19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837982}
-
Jin Young Hur authored
The info would be useful for debugging. For example, print format is like below. password: 2051817934, type=password, renderer_id = 207, SERVER_PREDICTION: ACCOUNT_CREATION_PASSWORD, PASSWORD_REQUIREMENTS: {priority: 10, symbols: {character_set: "!@*^#.~?$-_+&%/)`(", min: 1, max: 4294967295, }, } Bug: 1068549 Change-Id: I1a791201962e36658160555d2aadf83f03b8c598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586297Reviewed-by:Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#837981}
-
Kinuko Yasuda authored
Looks like following tests are still frequently failing on Win 7 fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl.html fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl.html https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 Bug: 1043488 Change-Id: I8d4c645528ee72ec2c5e031437838ac8358e5650 Tbr: masonfreed@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596905Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#837980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e35dcb0515eb..7ee7c8ce1be5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kinuko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kinuko@google.com Change-Id: I88a057db30c1e50a851e3584b28b7bec03ef8b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596505Reviewed-by:
-
Camillo Bruni authored
Instead of mutating the const ref, we copy the params object in JSModuleScript::Create when clearing the source text. Introduce ModuleScriptFetcher::NotifyFetchFinishedError and ModuleScriptFetcher::NotifyFetchFinishedSuccess to make it clearer which arguments are used. Bug: 1154943 Change-Id: I4ed2ca75e56c8cbefb8d49c11e77d1846ce43f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571877 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL moves SigninHelper to signin.services target. Bug: 1158799 Change-Id: I53e5efda1d18b3233de01d11fde3e67d479fea2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595408Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/20f1b3462878..b64da3907f76 2020-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6bcd4aceef10 to b31cd871ad10 (17 revisions) 2020-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cdbef3e3 to 09282fd5 (484 revisions) 2020-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 328f72ae21cb to 909ea88b5e6d (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I15e385015c89ee59a580ee7de8d40954b5a14401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597096Reviewed-by:
-
Anastasiia N authored
Bug: 1158450 Change-Id: I6531f36a6e9fe8eb4b0aa29211d1ecf9f6a0f481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593089Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#837975}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608163120-6c9e93d828b8e2586093ed8c8e6e7f26f6a53c36.profdata to chrome-mac-master-1608184288-cb58ee992bc6f0c310a42c0975312525970a8ab7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6ab68b458b34dac24aee0f6cb2b0ae5bfa91fb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596748Reviewed-by:
-
Nazerke authored
This CL changes the width of the tabs in the tabstrip according to the number of visible tabs. Bug: 1154121,1128249 Change-Id: Ia06af6ac7971fa413d00b7cf7e1e54aa4966126b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580071Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#837973}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608163120-124e90d18fac2bedecb2b27b978f1959d49c27fb.profdata to chrome-linux-master-1608184288-1281f0d86ddb8ecec434b137fd8cebeb5fab6875.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id39421cfe7b2774961de046cb760d957e5899da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596749Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1608141458-c308516ff1ef658b0966cc17b391babeaf39cbb5.profdata to chrome-win32-master-1608163120-4986bcffa849ffffd428f29082c0e0792a369cda.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4d063b0f89cff65493c101f944bce959b20f3d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596006Reviewed-by:
-
dpapad authored
In this CL addressing Mocha test files that did not already use test_loader.html. - Serve test_loader.html/js from TestDataSource - Replace chrome://test?module= URLs with chrome://test/test_loader.html?module= URLs - Stop using |extraLibraries| for mocha.js and mocha_adapter.js from affected tests. Note: chrome://test?module= URLs are still used by a few none Mocha tests and can't be removed from TestDataSource. Bug: 1158471 Change-Id: Ic49ea31a875ae066ea0d3981724db45e3ba697ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593233Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837970}
-
Juan Mojica authored
Also adds feature flags for lens prewarming. Bug: 1098431 Change-Id: Iae61ec71d6ab2f7d40f1231823cddc8b00ceabb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500525 Commit-Queue: Juan Mojica <juanmojica@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#837969}
-
Joel Hockey authored
Rearranged ProfileManager::GetPrimaryUserProfile() to be able to run in unit tests. The early check of g_browser_process->profile_manager() is not relevant for IS_CHROMEOS_ASH with a logged in user and it causes unit tests to fail unnecessarily. This has resulted in a few places where the code is duplicated which can now be removed and use ProfileManager::GetPrimaryUserProfile(). Change-Id: I164b5c20dbc54cbd59c22bf7f84b5376af1b88c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596903 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#837968}
-
Yuta Hijikata authored
The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Unlike other patches with similar changes, //build changes are done manually following similar rules outlined in http://go/lacros-macros. Bug: 1052397 Cq-Depend: chromium:2581632 Change-Id: Ieda2c12eafa2e3f1a75ca024ecda60362fb2515e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581183Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#837967}
-
