- 24 Jun, 2020 40 commits
-
-
Li Lin authored
Based on feedback, update the notice which better represents the functionality of the feature and includes relevant information about the user's selection. Mock at: go/quick-answers(slide 28) Bug: b/159167345 Test: manual tests Change-Id: I28df28fb025e42292ccdf5eb4d273c5b78a056d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250586 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782145}
-
Chris Cunningham authored
At default of 80, we're seeing regular timeouts for the swarming task. Bug: 1099049 Change-Id: I9b1c2a66fc15cad0ef3e5382780b95015d8c7ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265454Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#782144}
-
Chris Blume authored
CC has an ImageType to indicate the difference between Jpegs and Pngs, for example. I believe that name then became used in other places where it isn't quite right. When MIME types are being used, the functions named with *ImageType* aren't the correct fit. This CL renames those functions to *MimeType*, leaving *ImageType* in place when it is appropriate. Change-Id: I23cb4d0917459cb070f2ed88f0e9ffe6219124f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264024Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#782143}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/75fd127640bd..1b485322085d 2020-06-24 sprang@webrtc.org Revert "Allows FEC generation after pacer step." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0462d655dc1cd341d7e39902ea5eebbc26c957f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264920Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782142}
-
Thomas Guilbert authored
To adjust the playback rate of audio, we use two algorithms: resampling, which shifts the audio's pitch, and WSOLA, which doesn't. At rates close to 1.0, WSOLA can introduce undesirable artifacts for certain types of, audio content, so we use resampling instead. However, this pitch shift is noticeable can be less desirable than the WSOLA artifacts to some users. This CL implements the preservesPitch flag, which is already present in Firefox and Safari. The flag allows web developers to choose between pitch preserving and pitch shifting time stretch algorithms (resampling and WSOLA in our case). This will allow users to chose the algorithm that suites their needs at playback rates close to 1.0. It will also allow users to use resampling at lower or higher playback rates, when pitch shifting is desirable for aesthetic or performance purposes. Bug: 1072067, 1096238 Change-Id: Ie0e7ff337da77c902a12259c30c33125104101ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255179 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f8393bee83f1..d626fbec817d 2020-06-24 rwkeane@google.com Code Coverage: Force Full Repo Coverage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I5bfba72245c68c33fc9e33eabd0b4ef2e6f7d8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264924Reviewed-by:
-
Yang Guo authored
This reverts part of 5abacc3b and restores the query param 'debugFrontend', which makes the frontend load resources locally rather from remote URL. R=caseq@chromium.org, paulirish@chromium.org, tvanderlippe@chromium.org Fixed: chromium:1098505 Change-Id: I61330d4f679fb280245e98122ac23d0031e89e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263733 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#782139}
-
Mitsuru Oshima authored
Bug: 1090616 Change-Id: I4d42843663c63bc57d7c2c5d6c92c1232c5f9455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250474Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#782138}
-
Eric Roman authored
* Exclude un-triaged bugs with Needs-Feedback * Add sorting by number of stars Change-Id: I600faa5f3f9b48a38b4e75c7874357dbc22c4b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265183Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#782137}
-
Stephanie Kim authored
Bug: 1072012 Change-Id: I3df4b4fc8b89b20e54339c2c1c802e7737282dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261704Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#782136}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/55c5fa2666a8..054aeeed3b4c 2020-06-24 cclao@google.com Vulkan: Batch vkUpdateDescriptorSets calls 2020-06-24 ianelliott@google.com Vulkan: Fix glBlitFramebuffer() for pre-rotation 2020-06-24 cwallez@chromium.org Suppress TextureTest failure on NVIDIA Shield. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Test: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_\*Test: Test: angle_end2end_tests --gtest_filter=*EGLPreRotationLargeSurfaceTest.OrientedWindowWithBlitFramebuffer Change-Id: Id3c8b10a5d0230375e70441b02c95f90647be77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264836Reviewed-by:
-
Bruce Dawson authored
Adding a SegmentHeap entry to the chrome.exe manifest will tell recent-enough versions of Windows (20-04 and beyond) to opt chrome.exe into using the segment heap instead of the legacy heap. Details are in the bug but it appears that the default Windows heap is tuned for server workloads where throughput is what matters most, and Chromium (especially due to its multi-process architecture) also has to care about memory footprint. Experiments with per-machine opting-in to the segment heap for chrome.exe suggests that this could save hundreds of MB in the browser and Network Service utility processes, among others, on some machines. Actual results will vary widely, with the greatest savings coming on many-core machines. In order to avoid build warnings this change depends on switching to building with the Windows 10.0.19041.0 (20-04) SDK. The initial investigation of this is in crbug.com/982452. Bug: 1014701 Change-Id: I217d045ee0d365ac57f7a73b0f5ed456469214c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163163 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#782134}
-
Bo Liu authored
There is no change on the renderer side. Just hook into the existing RenderFrameMetadata::new_vertical_scroll_direction and bubble up that to the embedder. Compute the scroll ratio in RWHVA. The API is specifically made to be extensible, and new types such as scroll start or end may be added in the future. Bug: 1076473 Change-Id: I8c539588468d39da9095b0eb23bb61249d06b7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264760Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782133}
-
Joe DeBlasio authored
This CL does three things to the target embedding heuristic. It: 1. detects embeddings with multi-label eTLDs (eg. google.co.uk), 2. allows finer-grain matching against engaged sites, so that if a user has engaged with foo.bar.com, and that entire domain is embedded, it can recommend the full domain (not just the eTLD+1 bar.com), and 3. removes support for cross-TLD matching. This is a significant re-write, and the cross-TLD ("enhanced protection") matching was removed because it kept the implementation simpler, and we've decided that we couldn't ship that capability without further tweaks anyway. I may re-add it in a future CL. Bug: 1092570, 1098473, 1087636, 1075659 Change-Id: Ia30bd2025ca938c8431ab22300c6e2e8de2a658c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261424Reviewed-by:Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#782132}
-
Dan Harrington authored
On first run, when the user signs in, we were making a signed-out FeedQuery request. This happened because the IdentityManager hadn't yet gotten any signals about the sign-in process before the feed surface was opened. This change waits to attach the feed surface (to native) until after ChromeTabbedActivity reaches the right initialization step. Bug: 1044139 Change-Id: Ia55096e8720bb2289ccddef14533caff4cb0c25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261217Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#782131}
-
Mei Liang authored
http://crrev.com/c/2149626 converts the LayoutTab to a PropertyModel and uses the constant start and end animation value when creating the CompositorAnimator for the shrink tab animation. The use of the constant values causes the shrinking tab animates to a wrong position, since the targeted Rect can be changed after the CompositorAnimator is created. This CL fixes the issue by using the Supplier to supply the start and end value. Change-Id: Ife607faa06aadd508816179ad856eadacc3e1e90 Bug: 1096718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254715Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782130}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I52d90c494d13f4e9bb9aeb0ee516a96077d7c63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264941Reviewed-by:
-
Li Lin authored
We decided to defer the translation use case to future milestone. Added a feature flag to gate translation intent. Bug: b/159472031 Test: unit tests Change-Id: I5772750202c2a3862f6efc437db7c82ef58a7652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261877Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit f384aa73. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 782049 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2YzODRhYTczYWJmMmE5NDg2YjFkNTU2NjA0MzhmNGRkZTdiZGZmMjgM Sample Failed Build: https://ci.chromium.org/b/8876578106556883360 Sample Failed Step: compile Original change's description: > Secure DNS UI for Android > > This replicates the desktop UI, with platform-appropriate adjustments. > > Bug: 1040146 > Change-Id: I33cea7dd37086d87580e149404ed3619a828ee45 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240456 > Reviewed-by: Peter Conn <peconn@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Commit-Queue: Ben Schwartz <bemasc@chromium.org> > Auto-Submit: Ben Schwartz <bemasc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782049} Change-Id: I1abb9d420a08bab8476728e1f0ab3a36d298dfbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265358 Cr-Commit-Position: refs/heads/master@{#782127}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: Ia396cc134a5f3edb09fb148066e60bfcee077855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265235 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782126}
-
Khushal authored
The swap acks from the platform for SurfaceControl arrive on the binder thread and are posted directly to the GpuMain thread's message loop. Since the gpu::Scheduler doesn't have visibility into these acks, they don't take advantage of the scheduling policy that would allow prioritizing running these acks over other lower priority raster work. Hook up the async task posting mechanism in GLSurface to the gpu::Scheduler to fix the above. R=sunnyps@chromium.org,vasilyt@chromium.org Bug: 1009282 Change-Id: I5b23e08679cadb249164183c35709aaf6929fd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263233Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#782125}
-
Zhenyao Mo authored
If an entry specify a device without revision number, then any revision numbers should be considered a match. Currently we always compare the numbers. When unspecified, revision defaults to 0, so all devices end up as no match. BUG=1093625 TEST=gpu_unittests R=liberato@chromium.org Change-Id: I146b0e725ebf3bf8aa22998011d98e77c773160f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265237Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782124}
-
David Munro authored
We currently wait for polymer updates by flushing then by continuing after Polymer.async. This doesn't actually wait for everything, since it's a Polymer microtask, so it preempts macrotasks and will run before nested microtasks (e.g. a Polymer update triggers an attached event which kicks off its own promise, we'd run between the attached event and the promise). Instead use test_util.flushTasks which has macrotask timing. Test: browser tests Bug: chromium:1082027 Change-Id: I5d35b0c61570913d7a36e89600dce597703c2aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263634Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#782123}
-
David Dorwin authored
This log statement can occur when adding/removing supported arguments, so reduce it to a WARNING and provide context. Bug: 1032439 Change-Id: I500c5ff5d64268b1557da18724ad9c061c216936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261066Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782122}
-
Renjie Tang authored
Also remove 0-RTT for tests that don't actually need it. Change-Id: Ia33016ee631f288b7d3aa3c619b6f31b148e7f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261268 Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#782121}
-
Mike Dougherty authored
This class is no longer used nor referenced from any BUILD files and can be removed. Fixed: 925207 Change-Id: I8da4b3c8889bd7b595790c2ecd445c2eeb1d5bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264602 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#782120}
-
Jarryd authored
Change-Id: Idf1b887e4936fad34eef27dd7de74946e4225aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264600 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#782119}
-
Josh Nohle authored
The private and public certificates store encrypted user and device metadata. Private certificates are for the local device and are only stored locally. Public certificates are uploaded to the Nearby Share server and distributed to user's whitelisted contacts. Certificates are used to authenticate a channel between the local device and a remote device before the actual payload is exchanged. These classes handle all of the crypto operations surrounding certificates: * Private cert: signing a token * Private cert: encrypting the metadata key before advertising it * Private cert: encrypting the device metadata * Private cert: converting to a public certificate * Private cert: managing the set of consumed salts * Public cert: verifying a signed token * Public cert: decrypting an advertised metadata key * Public cert: decrypting its metadata See http://go/nearby-chrome-cert for more details. The test vectors from that document are used in the unit tests here, as well as in the GmsCore implementation, to ensure cross-platform consistency. Fixed: b/154862766 Change-Id: Ifd24decf4e896667797add3c292c69ebd312f232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157285 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#782118}
-
Tom Anderson authored
BUG=1066670 R=msisov CC=sky,nickdiego Change-Id: I31c3972ad51ccad320abd3554eec9cd8396aff1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262113 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#782117}
-
Nico Weber authored
Doesn't build at all, but hey, it's a start. Bug: 1098899 Change-Id: I63500b3650b315c47219614cc9ae9a3ddbcf42c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264499 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#782116}
-
Vladimir Levin authored
This patch ensures that when we have a find-in-page target, we keep it unlocked for two frames, so that the visibility detection can take place and if needed keep the context unlocked. The root problem here is that sometimes our contain-intrinsic-size is too small, so that when we find a match and scroll it into view, we actually scroll past the locked size by enough distance that the container remains locked, so we never see the match. With this patch, the container is unlocked for two frames which is the least amount needed for visibility to kick in and start being unlocked. This patch also cleans up the previous focus-clearing bug to use the same mechanism of unlocking-until-lifecycle. R=chrishtr@chromium.org Change-Id: I75a2d8b2f41335d5d6fb7a4ec0f42d93438807e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264756Reviewed-by:
-
rbpotter authored
Fix a race condition where if the download button is clicked while a form field is still focused, the plugin may not have yet notified the UI that the document has edits. This results in the "Edited"/"Original" menu not appearing, and the original document being directly downloaded instead. Check before saving the original document if a form field is focused, and if so, wait for the form field focus to change, which gives the plugin time to send the edit status update. Bug: 1098082 Change-Id: Ib11aa2ca9c06d06b9d05041272b070a674b316f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261188Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#782114}
-
Andrew Grieve authored
Android does not use it, so we shouldn't build it. When looking at a ninja trace on the android-binary-size trybot, this target showed up on the critical path and taking ~2 minutes to build. TBR=agrieve # Mechanical BUILD target renames. Bug: 1078460. Change-Id: I645277778762cd5e30cd81ce84a5776d38c3fdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258469 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Christian Biesinger authored
The in-flow version of abspos-007 Bug: 1045668 Change-Id: I9c33eea25b5378e39e8a9b4f57016cf17828588c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261169Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#782112}
-
Patrick Noland authored
TBR: szager@chromium.org Bug: 1096612 Change-Id: I598cbcf55ff97a453b714759e458915030355a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264768Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#782111}
-
Lei Zhang authored
For extensions, instead of having a per-extension last-saved location, use the browser downloads location. Adjust some file_manager tests to pass with this change. In production, file_manager is not affected by this because it is an app and not an extension. However, some of its tests use a test extension, so the tests are affected. Bug: 1011587 Change-Id: I62d08a9b1855ee8e5454098d37ca5a8a685f9d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245686Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#782110}
-
Tommy C. Li authored
UX folks suggested 8dp instead for aesthetic reasons. Bug: 1078415 Change-Id: I56ab151c4147b10b8853ebf1b9ae22cf1f4af90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265180 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#782109}
-
Albert J. Wong authored
This allows APIs, such as DOM gettings, to take a StringView instead of an AtomicString. On platforms where externalization isn't supported for short strings, this will yield a speed benefit as there will be no AtomicString created. This can especially affect (questionably useful) microbenchmarks like blink_perf.binding get-attribute.html which can hammer the non-externalized path on some platforms. Usages of this API will come in a follow-up CL. This is partially broken out of https://chromium-review.googlesource.com/c/chromium/src/+/2204539 which in turn is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 Bug: 1083392 Change-Id: I44d36dadcb341042e7eaf84395be7cc4a069b392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261270 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#782108}
-
Robert Ogden authored
Leaves the command line flag for use in browsertesting and in the about:flag. Note: The browser tests can't set features with params because of this: http://shortn/_ZytN1SHiqN Bug: 1082505 Change-Id: I474fe012c6a00b15f38d70334d677a29815b24b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265178Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#782107}
-
Clark DuVall authored
WebLayer now has support for opening in a new tab since http://crrev.com/c/2228365. We can now fix the TODO about captive portals opening in a new tab. Bug: 1047130 Change-Id: I1d2bf894caef6d0cc8f536db6d687fce0397ce0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264879Reviewed-by:
-
