- 25 Mar, 2020 40 commits
-
-
Khushal authored
SurfaceControl relies on transaction acks from the framework to manage pipelining/backpressure for frames sent by display compositor to SurfaceFlinger. These are not getting dispatched when Chrome is rendering on an external samsung dex display due to a platform bug which stalls the rendering pipeline. This change adds a workaround to disable SurfaceControl while the Chrome activity is associated with a samsung dex display. R=boliu@chromium.org Bug: 1042581 Change-Id: I38c067f6f7f48cf04c192cc59efe95a4c21fa4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099602 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753118}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ccb5f29c. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If7bb23043d037fa4e57429cbd8c979041d39083d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119551Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753117}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9a378addafad..81c8f4b8027e git log 9a378addafad..81c8f4b8027e --date=short --first-parent --format='%ad %ae %s' 2020-03-25 brianosman@google.com Revert "Switch sRGB color filter to use GrColorSpaceXformEffect" 2020-03-25 brianosman@google.com Switch sRGB color filter to use GrColorSpaceXformEffect Created with: gclient setdep -r src/third_party/skia@81c8f4b8027e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I982cf30d910a65409681f48ccb0829f507e8a4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753116}
-
nancy authored
Launch_service will be integrated to AppService, and launch_service will be removed. So modify related components to use app_service/launch_utils. BUG=1061843 Change-Id: If767a4e91e50cdbc0ec0e5805b88f979a0acfcab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115856Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753115}
-
Martin Kreichgauer authored
The kU2fCryptotoken{Register,Sign} WebFeature counters record when a page makes a request to the CryptoToken component extension via the U2F API in order to register or sign with a security key credential. Change-Id: I2ea19f46da9028da000e0e5564a7ade242d9d3ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118851 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#753114}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e3a49aa40576..7c5efb2a7e2b git log e3a49aa40576..7c5efb2a7e2b --date=short --first-parent --format='%ad %ae %s' 2020-03-25 tiborg@chromium.org Add format string option to git cl archive 2020-03-25 ehmaldonado@chromium.org Revert "git-cl: Remove unused and duplicate functions." Created with: gclient setdep -r src/third_party/depot_tools@7c5efb2a7e2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie6a5e5ee15f382f4013ed7dcc7db787b096b7f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119197Reviewed-by:
-
John Chen authored
Change-Id: I16aaa1acdbb1cade2bb2f1d579dee77d4c9b7e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118393Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753112}
-
David Tseng authored
TBR=dtseng@chromium.org Fixed: 1033649 Change-Id: I713ef317499a7ae027ddf63594ee5e8948ede8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119265Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753111}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia61ce947694855b305fa92b2070abbe67f3c1eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119152Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753110}
-
Peter Kasting authored
This also gets rid of event_sink() entirely, since callers can easily get it from the root window. This is in preparation for making AshTestHelper a subclass of AuraTestHelper, which will require these to be virtual. I did not rename the transitive closure of caller getters to ensure everything everywhere was renamed -- that would have required hundreds and hundreds of changes and didn't seem worth it. Bug: none Change-Id: Ief901ed0ffd733a553bfccb445c96e920be53499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117348 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753109}
-
Luciano Pacheco authored
Change FilesTooltip to hide the tooltip when the window is resized. Fixes issue 989456, where the tooltip could be misplaced after the window resizing. This patch is due to Giovanni Panaro and his work to resolve this issue, see CL:1743090. Test: browser_tests --gtest_filter="*filesTooltipHidesOnWindowResize*" Bug: 989456 Change-Id: I1a78b047e2c18ff79fa54e6e2ad58d4a1e804315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119290 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#753108}
-
Simon Que authored
Previously reverted: http://crrev.com/c/2098851 Relanding because of changes to iOS build that may have fixed the previously observed build failures. We no longer see intermittent failures in the Chromium WebRTC FYI builders that were migrated: https://ci.chromium.org/p/chromium/g/chromium.webrtc.fyi See crbug.com/1060666 In addition, some builders have been removed from this CL since it was previously landed. Those builders have been migrated by jeffyoon@ to mb_config in http://crrev.com/c/2071293. They will be migrated to Goma RBE in a separate CL: - chromium.fyi/ios-webkit-tot - chromium.fyi/ios13-beta-simulator - chromium.fyi/ios13-sdk-device ============================ These are the remaining iOS builders in Chromium. They are expected to have under 150 QPS at peak: https://docs.google.com/spreadsheets/d/1-XKh-CqSoUcXEqCETVywjmIo1C18P0qEBDCY50ozBb0/edit#gid=555424423 Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 R=agable@chromium.org, smut@google.com Bug: 950413 Change-Id: Ia8447eae2409eb616c4ca4b9dcb921baf35fa468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117552 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#753107}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e39d055d085a..d0800d29473f git log e39d055d085a..d0800d29473f --date=short --first-parent --format='%ad %ae %s' 2020-03-24 ianelliott@google.com Vulkan: Fix crashes/failures in array-of-struct uniforms 2020-03-24 jmadill@chromium.org Speculative fix for assertion failure with samplers. Created with: gclient setdep -r src/third_party/angle@d0800d29473f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I99f7ef8a4627091c1a3d162469627451d736de9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119193Reviewed-by:
-
Maggie Cai authored
This CL adds one extra unit test for delete preferred app from preferred app list. BUG=853604 Change-Id: Ia3ee053e6ff20240d795823105ab6da321ade86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117597 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753105}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c35af7d1d041..46fdad4eca63 git log c35af7d1d041..46fdad4eca63 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 btolsch@chromium.org Fix discovery e2e test deadlock warning Created with: gclient setdep -r src/third_party/openscreen/src@46fdad4eca63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I6f61c83a1a407da567bc3c5721efafdb09568fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119194Reviewed-by:
-
Anand K. Mistry authored
This change moves the process of creating a basic smbfs instance, with no authentication, into a helper function. This will allow for simpler tests that don't need to test the mount process itself. Bug: 1054704 Change-Id: I53404f767b47453ff3e92102cb7be354afe066cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116167 Commit-Queue: Anand Mistry <amistry@chromium.org> Auto-Submit: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#753103}
-
Jochen Eisinger authored
Launch target moved, so I need the histogram a little longer. Bug: 1061964 Change-Id: Ib261455ad6d2d3c22f00de6f467b7a41f74e095d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116175 Auto-Submit: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#753102}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b7bdc932613d..7fdb9a49a600 Created with: gclient setdep -r src-internal@7fdb9a49a600 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1056962,chromium:1060280 Tbr: jbudorick@google.com Change-Id: I0a505815e2b725f19cbfc31ca8594b90f090a220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118468Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753101}
-
Steven Bennetts authored
The UI>Shell>Networking component has been replaced with OS>Systems>Network. This updates OWNERS files accordingly and includes a couple of additions where obvious owners are missing. Bug: None Change-Id: I74764ce7b5f7f11495685c531ff6bd9fd4de9440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116572Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753100}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cd1f1eb24f50..7bb6613a0b68 git log cd1f1eb24f50..7bb6613a0b68 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 tsepez@chromium.org Avoid CHECK() in CFXJSE_FormCalcContext::Replace() 2020-03-24 tsepez@chromium.org Improve tests for {Byte,Wide}String::Replace() Created with: gclient setdep -r src/third_party/pdfium@7bb6613a0b68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1064149 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1dd7b8fff6421d9c6926e245de4c786f724f9891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119141Reviewed-by:
-
Dominic Battre authored
The experiment is not launched so we still need the metircs. Bug: 1053276 Change-Id: I2d96f5b3c61e32f7168c27e86dcbd9706bbccf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117119 Auto-Submit: Dominic Battré <battre@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
nancy authored
Modify ExtensionApps to call UI Extensions application_launch API OpenApplication directly to launch apps. Add extension enable flow to LaunchAppWithIntent. Move RecordUninstallCanceledAction after construction and deconstruction functions following coding convention. BUG=1061843 Change-Id: Iee27aecd57d4c0cf955bafb4085cad01fe94fe8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114596 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
David Rees authored
Bug: 152233113 Change-Id: I5a4a55c9e9bee40ca29b1089757a2eee4a5d2a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118691Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: David Rees <drees@google.com> Cr-Commit-Position: refs/heads/master@{#753096}
-
Shakti Sahu authored
This CL adds the JNI conversion methods for the query tiles. Change-Id: Ie8bfedc262d26885b925d45c0530da08dc9b3511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117061 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753095}
-
Peter Kasting authored
More simplification. GetScreenWinDisplayNearestDIPRect() calls SquaredDistanceBetweenRects() up to twice as often as before, but since the number of displays is small and this function is cheap, that won't have any meaningful performance effect, and this was the simplest, clearest way to write the code. (The previous patch set used a longer form that involved transform() to avoid calling this function more times than necessary, but if we cared about perf, that would probably be worse on net, given the cost to allocate/deallocate an extra vector and read/write different objects in the loop.) There is one behavioral change here: previously, IsWindowUnderCursor(nullptr) would return true if GetCursorPos() failed. This seems incorrect (if unlikely). The current version returns false in this case. (If WindowFromPoint() returns nullptr, IsWindowUnderCursor(nullptr) will still be true.) Bug: none Change-Id: I0f051a6f0da23eff37ecfb24f1057f4b1fb4e3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104369 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753094}
-
Maria Villarreal authored
This change moves STYLE_HINT from chrome/ to ui/ to be used as textfield placeholder text color constant. The current color used for the placeholder fails the contrast ratio. For enabled state, this placeholder would have a color similar to #8F9091 with a contrast ratio of 3.2. For disabled state, the color would be similar to #B8BBBD with a ratio of 1.93. With this change, the placeholder will have a text color constant with a value similar to #5F6368 and a contrast ratio of 6.05. Bug: 1056950 Change-Id: I66133508491fc79b2e91f1d8cb3013683d088722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113796Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753093}
-
Gyuyoung Kim authored
This CL moves anonymous-block.html test from css/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs and a ref test link. Bug: 1063749 Change-Id: Ie3ec6c8f4e6b2f096137d4a28f3519ffecaf9891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116161 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753092}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e9013eeb3d1d..e3a49aa40576 git log e9013eeb3d1d..e3a49aa40576 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 ehmaldonado@google.com git-cl: Remove unused and duplicate functions. 2020-03-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e3a49aa40576 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Iec672b834ee990b6c61c8232f743e2b9293405a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119192Reviewed-by:
-
Scott Violet authored
This adds 'android_weblayer' to nearly all places that have 'android'. The only places I did not add weblayer are ones that are defined in chrome. I did not check every feature, so that it's entirely likely some of these features aren't triggered at all in weblayer. BUG=1049426 TEST=test only change Change-Id: I75514fbf5c2f471f9dd8449395e288aa4cb896fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116786 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#753090}
-
Toby Huang authored
In response to the global COVID-19 crisis, many schools have closed. Many supervised users are also students. We want to temporarily enable supervised users to install extensions from ExtensionInstallWhitelist user policy without parent approval. This way, supervised users can install extensions such as Zoom for video conferencing and distance learning. We plan on back porting this change to M80. We will revert this change after the parent permission dialog launches. This CL improves upon the solution in crrev.com/c/2111055 by removing the hard-coded client side allowlist. Bug: 1063099 Change-Id: I7633b2a5e945cdfb9db61a0aac0ee85c6a58e0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109977Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#753089}
-
Toby Huang authored
We're reverting the extensions light solution with a hard-coded allowlist because we're proceeding with a better solution with a policy allowlist. Bug: 1063099 Change-Id: Ie13c3477540913d1076d03e3ce0a4b55820a63be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118877Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Evan Stade authored
This consists of enabling the protected media id permission and hooking up MediaDrmStorageImpl. Chrome's ProtectedMediaIdentifierPermissionContext is not reused because the majority of it is Chrome OS specific and the rest of it is functionality WebLayer doesn't need. The default for Android M+ is allow, so no prompt is shown. See GetInitialDefaultContentSettingForProtectedMediaIdentifier() Test: https://shaka-player-demo.appspot.com/demo/ > Sintel video should play (widevine) Bug: 1062474 Change-Id: I0e68cb78b9d88ad97d272253b62c3722fd7e3f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116550Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#753087}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0113d29ea0c4..9a378addafad git log 0113d29ea0c4..9a378addafad --date=short --first-parent --format='%ad %ae %s' 2020-03-24 mtklein@google.com refactor apply_transfer_function() Created with: gclient setdep -r src/third_party/skia@9a378addafad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I0ea29c9d83d7828021ab8b72b25345e4c698961e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119190Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4c6c40d47dc5..b867e14cac14 git log 4c6c40d47dc5..b867e14cac14 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 enga@chromium.org Add DAWN_NO_DISCARD to ErrorData Created with: gclient setdep -r src/third_party/dawn@b867e14cac14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1063810 Tbr: cwallez@google.com Change-Id: Ib146fb30ea49b6244cb2b171de12ea84428a56ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119191Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6d61ce6edb195f7c2159970a8c02a2c4dc6e5973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119133Reviewed-by:
-
Rohit Rao authored
The PolicyTest fixture supplies PrefServices that are managed by policy. It also supplies a MockConfigurationPolicyProvider that can be updated with test-specific policy values. Individual tests (to be written in the future) can use this infrastructure to verify that preferences are properly set based on policy data. BUG=1024115 Change-Id: I5ad4e9ae0089eb55253701806e371680f608d81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117317 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#753083}
-
Alex Moshchuk authored
This CL re-enables six previously disabled tests for how password-triggered isolation and strict origin isolation interact with field trials, memory thresholds, and manual overrides. These include *PasswordSiteIsolationFieldTrialTest* and *StrictOriginIsolationFieldTrialTest*. These tests were previously disabled due to runtime usage of ScopedFeatureList (see https://crbug.com/846380). This is a problem for browser tests, but less so for unit tests, where such usage is still allowed. This CL converts these tests to unit tests in site_isolation_policy_unittest.cc. This makes more sense anyway, as the tests purely check the state of site isolation policy in different configurations, without relying on any browsertest support. An added bonus is that they now also run on Android try bots, whereas previously there was no Android coverage (browser_tests don't run on Android). For that same reason, this CL also converts and moves the SitePerProcessMemoryThresholdBrowserTest* tests. This uncovered four bugs in the tests when run on Android bots, also fixed in this CL. Bug: 1009828 Change-Id: I10218fcac47284f84d102f6bf3ec1ae3893f3ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116150Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#753082}
-
Chris Hall authored
Removing usage of unsigned integer types in language detection to comply with style guide. R=dmazzoni,meredithl CC=thestig Change-Id: Ibeed71088a0ed4239f4d3c0aab8acc34b55687a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096603Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#753081}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4e09751d83cc..3685fb977e15 git log 4e09751d83cc..3685fb977e15 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 treehugger-gerrit@google.com Merge "Add vts10 suite to existing vts tests" Created with: gclient setdep -r src/third_party/perfetto@3685fb977e15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I83d3fcdb530409738cab6e4337ef9f87f28eaa90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117883Reviewed-by:
-
David Black authored
For now, timers will render in a label displaying their times remaining (in seconds) but this will be updated to match the spec in a later CL. Note that this UI element is dynamic, it will update itself in response to updates to the underlying timers. Bug: b:149570650 Change-Id: I6288bba8664b702ef8e21ef96a9f58f6159ee88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109823 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#753079}
-
