- 22 Sep, 2020 40 commits
-
-
Rob Buis authored
Add helper methods to NGLayoutInputNode to test whether the input node is MathML and to get the DOM node for the wrapped layout object. Bug: 6606 Change-Id: I4b12e81b2c044e9bd98479c1ab0cf8f0c7cea898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424183 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#809398}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac231dd664d0..899ea244a8db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: lgrey@google.com,rsorokin@google.com Change-Id: If311234950ce6fa90f4f711d681c8cbc21b736aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423978Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809397}
-
Michael Thiessen authored
Migrates NavigationHandle to use GURL internally and adds getUrlString for callsites that still need URLs to be a string (to be fixed in followups). Some unit tests needed to be moved to Instrumentation tests, one requiring a change to CriteriaHelper to allow checking for a condition after every task. QualityEnforcerUnitTest was too difficult to migrate to Instrumentation tests, so it now uses JUnitTestGURLs to use GURL in junit tests. Bug: 783819 Change-Id: I1283d5d7d1946e666e964f8d24aeaf0352eb8805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419140Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#809396}
-
Victor Hugo Vianna Silva authored
Since the CallbackHelper was removed in crrev.com/c/2414194, there's no need for throwing TimeoutExcpetion in tests anymore. Bug: None Change-Id: I6eb4fea62e642840befb3461cb184a13e5198cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424308 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#809395}
-
ckitagawa authored
paint_preview::BuildResponse() shows up a fair amount in stack scans. Often times these are OOMs I want to try to understand if this is a material issue or if identical code folding is mangling BuildResponse with other symbols. This change does a few things 1) Try to reduce memory usage in FinishRecording() to reduce OOM risk. Mainly by freeing/reseting memory expensive objects earlier. 2) Log when paint_preview::BuildResponse() is legitimately called. 3) General refactoring/cleanup. I hope to revert 2 once we know if the issue is actually paint_preview::BuildResponse() at fault. Change-Id: I14d99f1fb733565f984fc93fc131ee448fd642f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423408Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#809394}
-
Raymond Toy authored
Basically add a mutex to protect access to allow_pulling_audio_graph_. The main thread waits until it has the lock before setting this. This prevents the main thread from deleting things while the audio thread is pulling on the graph. A try lock is used so as not to block the audio thread if it can't get lock. This is applied to both real time and offline contexts which required moving the original real-time-only implementation to audio_destination_node so we can use the same methods for the offline context. Tested the repro case from 1125635, and the issue does not reproduce. We're assuming this will fix 1115901, but I've not been able to reproduce that locally. Bug: 1125635, 1115901 Change-Id: I1037d8c44225c6dcc8fe906c29a5a86740a15e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410743Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#809393}
-
Alex Newcomer authored
Just add basic tests. This will eventually contain histogram tests as well. Bug: 1130770 Change-Id: I160ef8e520f75a04d9d4c280f3c6b8b89504ddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422267Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809392}
-
Gang Wu authored
Bug: 1120273 Change-Id: I599b51cab1d6b61c47f98cb85c4c935adcf58d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423354Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809391}
-
Polina Bondarenko authored
Add parsing/syncing to local state arc.snapshot pref of snapshot related info. Add blocked UI mode Chrome start up along with clearing outdated snapshots flow. Currently, ArcDataSnapshotdManager functionality is disabled for testing. BUG=b:161221001 TEST=components_unittests Change-Id: I6ccfe44c3b85a6dc864914609fa41c071e81e4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385396 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#809390}
-
Mohamed Amir Yosef authored
As per the attached bug, here is the logic for changing the header image - The illustration should change when the user switches between "Save to device" and "Save to account". - In the Update bubble, the illustration should change based on where the update will go. - If the update will go to both locations, use the "account" image. Screencast: Light mode: https://screencast.googleplex.com/cast/NjQxNjYzNjU3MzY0Njg0OHw0NTg2MTgzYy1kMw Dark mode: https://screencast.googleplex.com/cast/NTY4MTQ3NTYxMTUyNTEyMHwzOTI4Y2JkYy1mZQ Bug: 1115936 Change-Id: Iaa3256fa1ff6dde3019da6a6da96940e577697b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421674 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#809389}
-
Sinan Sahin authored
This CL refactors ChromeContextMenuPopulator#buildContextMenu to return a ModelList for each group instead of a list of ContextMenuItem structures. This way, the context menu coordinator will not have to convert the items into MVC models. Bug: 971513 Change-Id: Ic99dccde290e617076116df1e16732f147f84cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419010Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Austin Eng authored
This reverts commit 4ca48383. Reason for revert: Failing on Win10 FYI x64 Exp Release (Intel HD 630). See crbug.com/1131041 Original change's description: > Re-enable DirectComposition tests for HD630 > > Unsuppress the DirectComposition info_collection_test and > trace_test for HD630(0x5912). > > Bug: 1079393 > Change-Id: I6cdd7c146c69b7154dde27b10e9b18b5f989950a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413291 > Commit-Queue: Jie A Chen <jie.a.chen@intel.com> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809210} TBR=zmo@chromium.org,jie.a.chen@intel.com Change-Id: If6c2335d318581573da583c038feda89ef575960 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1079393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424526Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#809387}
-
Patrick Noland authored
The process of supplying OverviewModeBehavior is now async to prevent re-entrancy in OneshotSupplier (as of https://crrev.com/c/2321067). Since observer notification in LayoutManager is synchronous, this creates a race condition where observers miss an update because an event (e.g. a touch event, as in the linked bug) queued before the call to set() can trigger synchronous observer notification before observers can add themselves. Bug: 1129783 Change-Id: Ia482a109576539d54f171950468e490972e72bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418981Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#809386}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I3c0c19c021b7b3aadfafbabe486aeee4cbda6dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423977Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809385}
-
Patrick Monette authored
StartInspectingModule() was being called regardless of the state of the queue in the event of a connection error with the UtilWin service. This was wrong because the connection error can happen even if the ModuleInspector is idle. Bug: 1100982 Change-Id: I715a9014e54e143d37ed94a07925fd70d3caf456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422259Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#809384}
-
dpapad authored
Bug: None Change-Id: I825907f08eb3aed09e95a551338d9bbb3141ec7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423356 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809383}
-
dpapad authored
The target was failing, because it was pointing to a wrong dependency. Moreover, it was not properly included in its parent directory's :closure_compile target, causing it to execute only if one built all targets, and not as part of the chrome/browser/resources/settings/chromeos:closure_compile target. Fixed: 1130048 Change-Id: I21c06f206b24fe524757a3b4ff571835fa9d010f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424027Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809382}
-
adoneria authored
This is an end-to-end PoC on running py integration tests on CI/CQ bots. Bug: 1122196 Change-Id: Ib91ca45853d3cecbbb490a8e09fe5641e888e8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412628Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#809381}
-
Alexander Surkov authored
AXValue is used to serialize as a generic object which generates bulky output like <AXValue 0x7fcfd5d12ac0> {value = w:1324.000000 h:714.000000 type = kAXValueCGSizeType}. It's nicer to have a shorten and readable format like {x: int, y: int} Bug: 1124366 Change-Id: I7a19604baa8f860f1a6bbfe144ec4c0d4f4d923d AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418472 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#809380}
-
yiyix authored
Add new fontBoundingBoxAscent/Descent test with Ahem font. Firefox and Chrome follow different table to calculate the fontBoundingboxAscent and descent. Ahem is one the font that has the same information across the tables. In this cl, I add a new test using Ahem font, so that the test can work for all browsers. Bug:1129621 Change-Id: I8ef0d7c5788e79f215d763e8494c3db8941b95d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416261Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#809379}
-
Jesse Schettler authored
Add GetScannerCapabilities() to the ScanService to allow clients to get capabilities for a selected scanner. Bug: 1059779 Change-Id: I40af92cef6f767a08be9851f1fe5c3cb200ac408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404662 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809378}
-
Nate Fischer authored
No change to logic. This enables ServiceWorkerClientTest.testServiceWorkerClientInterceptCallback for N and O. This test was fixed in http://aosp/1129272. Fixed: 675809 Test: android_webview/tools/run_cts.py -f ServiceWorkerClientTest#testServiceWorkerClientInterceptCallback --repeat=1000 Change-Id: Ibd8a8bc4f6653fc99e3a5a240cca74ad79f9093c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422248 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#809377}
-
Thomas Lukaszewicz authored
This CL creates a new file for TabSearchButton browser tests. These tests run for both the fixed and regular entrypoints. Existing tests for the TabSearchButton have been moved from the tab strip into the TabSearchButton browser tests. Bug: 1099917 Change-Id: I0b1d57826768705316b9bed814dac7af96ce52e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422730 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#809376}
-
Xiaodan Zhu authored
This CL change the reverse scroll gestures including - Swipe up with three fingers to enter overview and down to exit overview. In M87, the old gestures also work and a notification shows up. In M88, the old gestures fail. In M89, remove notification. -For each user, the notification will only show 3 times - Swipe right to switch to the next desk and left to switch to the previous desk. The old gestures fail immediately. Bug: 1107183 Change-Id: I815c308c1fee4cf5152227064c5f8fec61f67b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418015 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
-
Roman Sorokin authored
go/coil Bug: none Change-Id: I1e67b34b177affa44a753500a56ca114bbcf34ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424343Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809374}
-
Egor Pasko authored
This is often necessary on Android to read /proc/self/pagemap. Without prctl(PR_SET_DUMPABLE) opening this file fails in 94% of cases on Canary. This potentially leads to bias in reporting MappedAndResidentMemoryFootprint2. What happened since it last landed as http://crrev.com/808298: * Setting the process back to non-dumpable was often returning an error and hitting a (P)CHECK * In crash dumps logcat started right at the failure, so it is not possible to see whether prctl(PR_SET_DUMPABLE, 1) succeeded prior to the failure, my guess is that it failed too * In the reland, avoid prctl(SET_DUMPABLE, 0) if prctl(SET_DUMPABLE, 1) failed before that Bug: 1070618 Change-Id: Ic9bfbdad6c72a1388eb80c3b6c9e6c772c8e431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421730Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#809373}
-
Tim van der Lippe authored
This requires https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2422960 to land in Chromium first. R=szuend@chromium.org Bug: 1011811 Change-Id: Ib2488a082456ad1cb4a0f7e77ec4a14a5a410ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423846Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#809372}
-
Nick Harper authored
Removal was requested via email to hstspreload@chromium.org and domain control was verified via DNS challenge. Change-Id: I32776a8f1b61c9d3dd19c7d1af6f83f6484f19ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421636 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#809371}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9cf7a56afbcf..ada5d5129f48 2020-09-22 taylori@google.com Merge "ui: Don't show reload toast" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie0095286c821cfb6f255e8423214c6715986059d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423975Reviewed-by:
-
Peter Wen authored
Add ignores for EditText elements that do not need autofillHints. Remove ButtonOrder suppression as it's no longer needed. Bug: 1073966,1116130 Fixed: 1073966 Change-Id: I80c97528c3558379d43677b78bbbc2f290d5105e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419593 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809369}
-
Colin Blundell authored
When BrowserViewController sets/clears its active Tab, it notifies the Tab in question. This is currently done via TabImpl#onDid{Gain, Lose}Active callbacks. As boliu@ pointed out on the bug linked below, this is confusing as there would be a natural expectation that these callbacks are invoked when the *BrowserImpl* is setting and clearing its active Tab. These flows are not identical; for example, when the BrowserImpl is moved between Activities BrowserViewController clears its active Tab as part of its destruction but the actual active Tab in the BrowserImpl doesn't change. This CL updates the relevant method names for clarity. Bug: 1129077 Change-Id: I04fd58d6bcd69abfdc7cdde3a3c0186d83d67b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421309Reviewed-by:Bo <boliu@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Hide strings for zero blocked cookies. Always show cookie section. Remove "cookies in use" on main page. Some code cleanup. Bug: 1077766 Change-Id: I892373fdbd62a6a95c253a293ac125dd7bf3a1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416068Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#809367}
-
Mark Yacoub authored
1. |should_modeset| should never be true when committing using legacy API. 2. Use emplace_back instead of push_back (modernize-use-emplace) BUG=987274 TEST=enable and page flip legacy devices. Change-Id: I78615163191a5ba537d4136702fc50452fc503d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418617Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#809366}
-
Collin Baker authored
Creating a new window for a tab playing media shows the medial toolbar button immediately. With a recent change, it would then attempt to get the window's BrowserView. But BrowserView::GetBrowserViewForBrowser() returns nullptr when called during BrowserView construction resulting in a crash. This CL changes MediaToolbarButtonView to take the BrowserView on construction instead. Fixed: 1130921, 1130897 Change-Id: Ica879fe9825c4ef1af2789169bffb49da28370b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423551Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#809365}
-
Olya Kalitova authored
Changes description of the NewTabPageLocation policy. Bug: 1097727 Test: None Change-Id: I53e58906a54adeb0280b9a5b2c43bc9deb7ad916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421745Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#809364}
-
Shakti Sahu authored
This CL adds the JNI glue for all the public methods from Java to all the way till native TutorialServiceImpl. Also glued TutorialManager and TutorialFetcher to the service. Bug: 1130460 Change-Id: I1e62d419b0883b2d02c4da9a83fc2c8c8abc3f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421248 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809363}
-
Erik Chen authored
This CL adds a stub for Profile::IsDefaultProfile. This is required for Lacros since exactly 1 browser profile will be associated with the chromeOS device's signed in profile. Bug: 1129543 Change-Id: I74566593fc60d887a20c7f10974687619588e3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416816Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809362}
-
Mohamed Adel authored
This CL creates a base class for notification builder mac and extends it to build UNNotifications. It also groups shared methods between the NPBs for macOS platforms together to avoid redundancy. Bug: 1129987, 1129988 Change-Id: I41ef920aafed94a0ac8e9851c5884112f0a30aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418446Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#809361}
-
Mohsen Izadi authored
As of r783010, this method is only there to be used in tests. Renaming to make this explicitly clear. Bug: 1079116 Change-Id: I655950e6c9c7a9b2834f1500eaa6754c8a373a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420532Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809360}
-
Xiaoqian Dai authored
It looks like CursorManager::GetDisplay() can return an invalid display, which then cause Shell::GetRootWindowControllerWithDisplayId(display_id) to be a nullptr, when then cause ash::SetBoundsInScreen() crash. Bug: 1068018 Change-Id: I8d590e146755330c94cb0934ccb57085af135e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422731Reviewed-by:
-
