- 28 Aug, 2020 40 commits
-
-
Richard Knoll authored
This adds notification actions and a preview image for successfully received incoming transfers. Single image payloads can be copied to the clipboard or the download folder can be opened. Other file types only show the open folder action. Text payloads show a copy to clipboard option. Bug: 1102348 Change-Id: Iec9128e2273b5f67ce750f1726c1bb2e28bdfee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382313 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#802821}
-
Andrew Xu authored
Bug: 1112888 Change-Id: Ia3707fa7f5889bde4c8fa503660563af41b819d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381059Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802820}
-
Joe DeBlasio authored
Change-Id: I9e2c41718c280377018dd7f6d6c27ee8643a4696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382674 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#802819}
-
nuwanda authored
Add TBMv3 metrics calculated based on histogram samples that are traced when histogram_samples category is enabled. See: https://chromium-review.googlesource.com/c/chromium/src/+/2363747 Bug: 1119834 Change-Id: I7bb2a33c5123eea0e85a7f8fdc3dd135922d30cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379832Reviewed-by:
Deep Roy <dproy@google.com> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Julia Semavina <nuwanda@google.com> Cr-Commit-Position: refs/heads/master@{#802818}
-
Anastasia Helfinstein authored
Also adds a test for stopping promptly when asked. AX-Relnotes: n/a. Bug: None. Change-Id: Id0dc61f10a7c08aa01658b98c0b429eb95ef753b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380585 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802817}
-
Peter Boström authored
Adds a DCHECK to CreateBubbleWidget (for BubbleDialogDelegate::CreateBubble) that there exists a parent. This policy-enforces that a bubble should always have a parent. It also effectively fixes the case where NativeWidgetAura would DCHECK that a bubble has either a parent or context on buildbots, whereas Mac would not. In non-test code this wasn't a problem because Chrome would create a non-NativeWidgetAura when there's no parent. With this fix the same problem can be detected locally. Bug: 1064663, 1121567 Change-Id: I65ef85f074e2dc6ee822894c2599162a9e3e170f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372817Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#802816}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6568e4b2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I1b4a40d5818ea89a3841c7a82144183bb1f3bcd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382331Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802815}
-
Nick Harper authored
This reverts commit 4f9f1598. The CL being reverted causes cronet_test_instrumentation_apk to crash on builder "android-cronet-marshmallow-arm64-rel". Bug: 1115229 Change-Id: I2b177353b00a57befe488e0bbef242a2b585162c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376316 Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#802814}
-
Thomas Guilbert authored
CreateAcceleratedVideoEncoder() returns a nullptr on failure. We need to check |media_encoder_| before initializing it. Bug: 1123080 Change-Id: I244c29f85602097a8348c037a0a2a3555c1f12f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382012 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#802813}
-
Scott Violet authored
and OnNavigationCompleted. This patch differs from first in so far as some autofill classes needed to be destroyed as they keep a reference to a class owned by TabImpl. Here's the bug that has the stack trace of the crash: https://bugs.chromium.org/p/chromium/issues/detail?id=1123021 Content does not allow WebContents to be deleted from WebContentsObserver::DidFinishNavigation(). Unfortunately we keep seeing crashes because of this restriction, so I'm inclined to provide some mitigation. This patch takes the approach of detecting this scenario and delaying deletion of the WebContents. All the surrounding WebLayer classes are deleted/destroyed and ownership of the WebContents is passed to the Profile and deleted from a post-task. Doing this may introduce it's own set of problems. For example, if a callback/notification is still in flight from content that gets processed before the deletion, and the code assumes there is a Tab associated with the WebContents, then there will be problems. My preference is still to fix this in content, but in the mean time this should work. BUG=1111127 TEST=covered by test Change-Id: Ifdd07aab1303fa0ff1ab28e9736d24cd2bf2b042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381260Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#802812}
-
Chanyong Moon authored
add css for displaying focus state to customize dialog of ntp. we can see focus state as outline. Bug: 1119748 Change-Id: Ib2ad19ac421b61c3945d94e53ce36a6136bd9701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377180Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#802811}
-
Dominic Mazzoni authored
Changes to how the HTML select element accessibility works internally from bug 1110367 caused some of ChromeVox's feedback for HTML select elements to regress. Fix this in Blink by exposing the posinset, setsize, and collapsed/expanded state on the pop up menu node. Tweak the posinset code to expose it on a collapsed pop up menu. Finally update ChromeVox to provide similar feedback as before, and rebaseline tests. Possible follow-ups needed: * Fix one options test that tried to check the options of a select without opening it, which isn't possible anymore * Change the role of options from list box option to menu list option Bug: 1122618 Change-Id: Ifd50de4c81702549b4b4aceb6639a12ce458fb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380136 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#802810}
-
Tim Judkins authored
Adds several user actions for interacting with the site access section of an extensions setting page, for extensions which requested a list of specific hosts in their permissions. For descriptions of each user action, check the changes to actions.xml Bug: 1102658 Change-Id: I627d91f3166647f4bfc581e8c9ecab96414c04fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317819 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802809}
-
Jonah Ryan-Davis authored
Historically, CGL on Mac always requests TEXTURE_RECTANGLE for GL textures. However, ANGLE's new SwiftShader and Metal backends request TEXTURE_2D to be used. This needs to be forwarded to the video decode accelerator on Mac. Bug: chromium:1122647 Bug: angleproject:4846 Bug: chromium:1099978 Bug: chromium:1099979 Bug: chromium:1119939 Change-Id: Ic9696046eda29c4b86ce09d7b36c3c81eddae828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380097Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#802808}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/167a0f22e2ee..9100465414a9 2020-08-28 lehoangq@gmail.com Metal: Implement ANGLE_robust_resource_initialization. 2020-08-28 reveman@google.com Vulkan: Use 4 MB as preferredLargeHeapBlockSize for allocator. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1122718 Tbr: courtneygo@google.com Change-Id: I864c37bba3e32a7612b1d1f78bf224eee787db3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382494Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802807}
-
Alexander Alekseev authored
This CL adds grid to the Ash HUD graphs. CPU grid: https://screenshot.googleplex.com/5Jvuietcs7bkTT3.png RAM grid: https://screenshot.googleplex.com/5sSsanj52BGPkKN.png Bug: 1121868 Change-Id: Id25754c6b7b2525caca518eb48693f400899ab75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377232Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#802806}
-
Tibor Goldschwendt authored
+ Use this helper to embed images into the dummy module. Fixed: 1110064 Bug: 1087011 Change-Id: Ifb2f20ee085f547f8b55cd3b18cfd4cc3b05153d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380147 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
This change enables Refine button to announce also the text that will replace the Omnibox content, if the user presses the button. This change updates accessibility description of an already existing component. There are no user-visible changes - only talkback announcement is updated. Skip-Translation-Screenshots-Check: True Bug: 1096131 Change-Id: Ib07149b42e6216a0091592aa2dafd60c587672b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382190Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#802804}
-
Gary Miguel authored
This makes the test pass when run by `run-test-component`. Previously it would only pass when run by `run`. The manifest being used before was build/config/fuchsia/tests-with-exec.cmx Bug: 1118202 Change-Id: I7993cced15856f1f8094fbcd30d733450a364368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373404 Commit-Queue: Gary Miguel <garymm@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Gary Miguel <garymm@google.com> Cr-Commit-Position: refs/heads/master@{#802803}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d7c4e9418e36..b1e3f57ef7c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I78d9c792f7f7db236af60db95729bca11d1a84ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382302Reviewed-by:
-
Karandeep Bhatia authored
This fixes an existing TODO. The current name doesn't clearly specify what the function does. BUG=1113513 Change-Id: Id08cd8e56e72abc0ad1059aacf20f989bb99d8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342754 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Yann Dago authored
Bug: 1103814 Change-Id: I75ba3682f6bbff424b26269a9bb65ca479b8be31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372810Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#802800}
-
Aaron Leventhal authored
Use kMenu for views submenus, so that NVDA announcements are correct. Fixes regression from CL:2369252 Test: JAWS/NVDA with main menu, context menus, views combo boxes Bug: 1122424 Change-Id: I2ccc28c30dd225c0ec53f89f8547810d2f2d7dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381258Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#802799}
-
Nate Fischer authored
No change to production logic, this only impacts the WebView shell test app. This disables StrictMode for some manufacturers, as our test team has been blocked from using the WebView shell on those devices. This links to bug comments with stack traces pointing to the relevant vendor code. This also changes existing code to re-assign to the Builder variable, since CTS and docs don't actually guarantee Builder methods mutate and return the same instance. Bug: 1090841 Test: I verified the drag and drop crash is gone Change-Id: I6dfd4c417563706b25187e1de21918f27553598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378725Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802798}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8aa817bf..fb7c6ea5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieb5cb0cf89b19b6dc55c1e83d84737ea3f36926a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802797}
-
Victor Vasiliev authored
Also, update flags. https://quiche.googlesource.com/quiche.git/+log/e447bc609047..79b266156ffb $ git log e447bc609..79b266156 --date=short --no-merges --format='%ad %ae %s' 2020-08-28 fayang Add missing connected checks in QuicConnection. 2020-08-28 fayang Convert bytes_left_for_batch_write_ to unsigned integer array. 2020-08-27 renjietang Remove tests that are testing on sending only STOP_SENDING. Created with: roll-dep src/net/third_party/quiche/src R=dschinazi@chromium.org Change-Id: Ie9034fdbf73e505d7d18d91c7f2c5151fa724398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382651 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#802796}
-
Dylan Sleeper authored
Add two subclasses: ClipboardSvgReader and ClipboardSvgWriter. When SVG is read and written it is "sanitized" which means that all script objects are removed from the SVG. SVG sanitization is done on the main thread, because SVG DOM nodes can generally only be used on the main thread. Bug: 1110511 Change-Id: Ic5d593bc518afa4809446e8247a7d0deb495a297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315220 Commit-Queue: Dylan Sleeper <dsleeps@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802795}
-
Weilun Shi authored
We should normalize histogram paths in the validate_histograms_index.py before checking whether they are the same. This is to fix the issue that the path separator is different between Windows and Linux. Change-Id: I5806886a192b3a15512f76631e324d9f1cc9bc46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381092 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#802794}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7bc80aa34110..a745d8886808 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tinazwang@google.com,mek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106626 Tbr: tinazwang@google.com,mek@google.com Change-Id: I93e37c2e37ee8b1d1e44df35e58f06ca8da18e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381949Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802793}
-
Xiaodan Zhu authored
Bug: 1116234 Change-Id: Ie21f6e0ea2fdb4098bcd1fa2f2632207ccd185ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378536 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#802792}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fc1eb95f39a3..1e87a9ab4a13 2020-08-28 mtklein@google.com second guess swizzler avx-512 opts 2020-08-28 reed@google.com Only expose isConvex on path publicly. 2020-08-28 johnstiles@google.com Remove fProgram member from ProgramVisitor. 2020-08-28 mtklein@google.com create a sample to demonstrate a timing attack 2020-08-28 johnstiles@google.com Add helper function for making temp variables in inlineCall. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1088224 Tbr: mtklein@google.com Change-Id: I8ab94e27350db84183dd65880d88837598f7487f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381945Reviewed-by:
-
Regan Hsu authored
This ensures that all links in os_settings_strings.grdp include the following: <ph name="LEARN_MORE_LINK_BEGIN">..</ph> <ph name="LEARN_MORE_LINK_END">..</ph> or a variant so that translators will know explicitly how to format the link. Previously, in Czech, the string was formatted like <a href=".."></a href="..."> instead of <a href="..."></a>. This was not caught in crbug/1095590 because when the string was changed, it tested correctly in English instead of the translated Czech version, which happened after the strings were uploaded. Screenshots: https://screenshot.googleplex.com/9o9LUcssZfhHdKq https://screenshot.googleplex.com/3WyzTChH8UjTmsG Bug: 1120339 Change-Id: I0f9ac9bb72b1a206a1bc5e6f18d81d8b982e4c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382062Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802790}
-
Emily Stark authored
Change-Id: Ic873b7df02124db730d689c3f82b8a06feb0f8d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382770Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#802789}
-
Matt Menke authored
When diving up the input into 4 chunks, it was skipping over the final character of each chunk. This happened even if a chunk included all remaining characters, resulting in a StringPiece that started beyond the end of the string. This resulted in a 0-length StringPiece, and things worked fine for years, until a CHECK was added catching this this brokenness. This CL switches the fuzzer over to using FuzzedDataProvider, which doesn't have this issue. Fixed: 1123036 Change-Id: If17e26d065a157f8d401a7e4afc06c769c8670f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382063Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#802788}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1e3f57ef7c0..af2dca5c5320 2020-08-28 fmayer@google.com Merge changes Ifdb4b002,I8c0d63c9,Ic64bb6d9 2020-08-28 taylori@google.com Merge "perfetto-ui: Add exception logging" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic238798d09af06f17fb300ff56a2c1f5824b136f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381946Reviewed-by:
-
Aaron Leventhal authored
This code in AXNodeObject::InsertChild() to clear the inserted child's children, was added in WebKit, to support a use case that no longer exists. Specifically, an aria-hidden=false descendant of aria-hidden=true is no longer exposed. The spec may change again to allow that, but it would better to find an implementation that does not require reworking entire subtrees whenever a node changes. Performance improvement for dynamic changes in large subtrees. Also required for CL:2192752 to land. AX-Relnotes: n/a Bug: 1107988 Change-Id: I43f1fc880e7740cb937f273db76c6429e43e8d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204154Reviewed-by:
-
Wez authored
Bug: 1120914 Change-Id: I712e0f02f28eaeb9e51bf260aa1fa5bfcdbd5f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377876Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#802785}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.11-r1 to 86-4183.59-1598262024-benchmark-86.0.4240.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I47b06187fddc0b423ec23642c988c405e7c7a5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382694Reviewed-by:
-
Bailey Berro authored
Bug: 1123074 Change-Id: I3cc11088dd8ae2e17e1a6f6f6c3a083a3ffe8e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382218 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#802783}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.11-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8f6cb5b425bd07e39ee2e6346414bf4f15447d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382691Reviewed-by:
-
