- 01 Jul, 2020 40 commits
-
-
Fergal Daly authored
These tests are sensitive to RD's type of changes and several of them needed fixing already. Bug: 1100745,1068965 Change-Id: I1bd93ebac207c502d0dda7f749a4c5f25f4e506b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275459Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#784274}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c75547d598c4..c1b825219eae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rakina@google.com,davidbienvenu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046369 Tbr: rakina@google.com,davidbienvenu@google.com Change-Id: I1d1b253e244fee3efeb83d92decc744e2bd79930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276329Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
David Bienvenu <davidbienvenu@google.com> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784273}
-
Dale Curtis authored
Due to threading issues with SilentSinkSuspender and the fact that unlike WebAudio we actually have a known volume: just use the volume value instead of trying to detect silence. I.e., start using a fake sink when playback is muted. Only switch to a real sink once playback is unmuted. This does not affect WebAudio or MediaRecorder because they always get the audio data after volume has been applied, so in these cases they will just continue to get silence. This should result in less actual audio output device creations as well as less real physical streams opened; thus saving ~200-300mW of power per measurements by Intel. As part of this change it's necessary to change where we tell the media::Renderer about the volume change. Previously it was done after Initialize() completes, but now is done before Initialize() starts like several other properties that affect Initialize(). Bug: 764133 Change-Id: I4f6e608ab25238e02da24e302bb781e219d12dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268377 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784272}
-
Alice Boxhall authored
This is a proof of concept at this stage. Written cooperatively with meredithl@ and chrishall@ Bug: 1099069 Change-Id: Ib2c7cf94145bf7080973f7f619cc60dc89124931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264176 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784271}
-
Peter Kasting authored
This will allow changing the observation method in the future without affecting the callers. This does require changing the pointer type in PageActionIconParams to a concrete type, but that's OK for now; if we really need to later, we could introduce a new abstract class that simply exposes an ObserveButton() method. Bug: none Change-Id: I540905bf89d0d05ecb69806495d9a3618b21a19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274842 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#784270}
-
Rakina Zata Amni authored
This reverts commit 87f410b6. Reason for revert: Causes compile failures on windows Original change's description: > Public side of Windows fix > > BUG=1099250 > > Change-Id: Ia73ff41012a1e4d9a7a524339ea30e0c327f1fe4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269510 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784168} TBR=beccahughes@chromium.org,steimel@chromium.org Change-Id: I4cc36628a32ecc17062e912264a0385db5108ffd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099250, 1101155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275160Reviewed-by:
-
Noel Gordon authored
Test helper fakeDragAndDrop has an option to hover the drop target and skip the drop and dragend event sending part. The browser thinks drag- drop operations are still active on the page in that case. Add fakeDragLeaveOrDrop helper to terminate drag-drop operations: send a dragleave or drop event to the target, and then send a dragend event to the source. Tbr: adanilo Bug: 1062902 Change-Id: Id2ff6d8addbdcb0bce8625ff3e59b0d28712b94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275974Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784268}
-
John Z Wu authored
These protocols are moved into components/password_manager/ios to be shared with other objc embedders of PasswordManagerDriver and PasswordManagerClient. Also renamed them to XXXBridge to make it clear the these @protocols are simply used to bridge C++ methods into ObjC methods. Change-Id: I13c11d7abf49482fe1355e6b48d54ec9a90d9483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252856 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#784267}
-
Xing Liu authored
The location dialog title is changed to "Choose where to download" to match the download later dialog's "Choose when to download". The file size is kept, the text could be "Choose where to download 15Kb" when the file size is available. Also does layout polish to make the title and subtitle to match the new download later dialog. Bug: 1101010,1078454 Change-Id: I08c4965ca007afa74b5c23e019d615fbb8fcbc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276347 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#784266}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68e60a92ae92..2761f01d68a7 2020-06-30 etienneb@chromium.org Disable the use of chromium worker threads 2020-06-30 lexa.knyazev@gmail.com Fix blendable FP32 texture caps on ES2 contexts 2020-06-30 ianelliott@google.com Vulkan: Fix off-by-1 180/270-rotated CopyTexImage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1091259 Tbr: ianelliott@google.com Test: Test: Test: angle_end2end_tests --gtest_filter=*CopyTexImageTestES3.2DArraySubImage*Vulkan*Test: Test: Test: angle_end2end_tests --gtest_filter=*WebGLReadOutsideFramebufferTest.CopyTexSubImage2D*Vulkan* Change-Id: Ibd94d829cda3aadaf17bec66f1f66bdb3431fcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784265}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/91904cdfde76..268fe254ec50 2020-06-30 tommek@google.com Added constraints for too large uniform buffer bindings 2020-06-30 bryan.bernhart@intel.com D3D12: Limit QueueWriteBufferTests.ManyWriteBuffer 2020-06-30 cwallez@chromium.org dawn_native: Use correct integer width for SetSubData. 2020-06-30 cwallez@chromium.org dawn_wire/client: Add ToAPI and FromAPI helpers. 2020-06-30 cwallez@chromium.org dawn_wire: Remove client/ApiProcs_autogen.h 2020-06-30 cwallez@chromium.org dawn_wire: Make ApiProcs call into objects directly. 2020-06-30 cwallez@chromium.org dawn_wire/client: Encapsulate all queue/fence-related logic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1099621 Tbr: cwallez@google.com Change-Id: Ia2ab319bf2efa8604c14abde6a9a92ce0e163fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276185Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593539505-1242fb6afac1e074d04c68b7772a687abe4506af.profdata to chrome-mac-master-1593561487-f93d00b844fcb3a1b3a03cdb0ab1966b81282397.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2b2b394231be77ffafad3d3b05595c8889c77b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276766Reviewed-by:
-
danielng authored
instead Removing the prefs for camera and microphone permissions, as they are now being handled by the Plugin VM manager instead (to remove persistency). Testing: Ran "*PluginVm*" unit tests and tested on DUT locally Bug: 1071872 Change-Id: I9d2aed1715541f2d584349bb411d254a1384ff7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275580 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#784262}
-
David Bienvenu authored
TBR=dfried@chromium.org Bug: 1101156 Change-Id: Ie75cfc36621166578a014b5e8290adf87bfe41dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277181Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784261}
-
Xing Liu authored
This CL does the following: 1. Implements the checkbox. 2. Implements the edit location text, which triggers location dialog. 3. Make download later dialog owns a date time picker, so other callers can share the glue code between later dialog and date time picker. 4. Lots of tests added, lots of code refactored. TBR=dtrainor@chromium.org Bug: 1099989,1078454 Change-Id: I3dd53c0a0694c91789398382c6deb11fbfe8006d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268467Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |ComputeNGCaretPosition()| to return valid |NGCaretPosition| for inline boxes in RTL and pass the test[1] for enabling EditnigNG. Before this patch, |ComputeNGCaretPosition()| to return position relative to left of inline box of specified DOM position. Example: <div dir=rtl><bdo id=box1 dir=rtl>ABC</bdo>><bdo id=box2 dir=rtl>DEF</bdo> => ComputeNGCaretPosition("ABC"@3) Before: "DEF"@0 After: "ABC@3" [1] editing/caret/caret-height-multi-line.html Bug: 707656 Change-Id: I785f87ca7b18f05a55bd809b6b390d68dac89c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275742 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#784259}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3778c0ae..d0779351 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3014156923af78117858521fa52a0baf98b861e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276483Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784258}
-
David Van Cleve authored
Currently, fetch's request_conversion.cc swaps out the initiators from files and opaque origins, replacing the initiator with a new opaque origin. Switching this to derive an opaque origin will preserve precursor information so that subsequent decisions can be based on, for instance, whether a request came from a file (or whether a request came from an opaque frame with an HTTPS precursor). Bug: 794098 Change-Id: I4f3d6d85e60afd9dda283a54501459705d52d958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242635Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#784257}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ifa946ad268b0197368d6f9694a69976eb14d752a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276817 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#784256}
-
Ali Juma authored
This adds SafeBrowsingAvailableOnIOS as one of the features enabled by IOSSSLCommittedInterstitials, to match the way that the features are being rolled out together. Bug: 1034113 Change-Id: If7bd5abadf32277ea8a13c24daee949c2236b3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275486Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#784255}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 92ce1bbe. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I69e5b8d9b83fadd871b89c78e3e7cbe4a25a3f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275104Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784254}
-
Ian Wells authored
Bug: 1044139 Change-Id: I73e3ba8f9fa53af65a4246dc239d3181d88a2210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270851 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#784253}
-
chrome://flagsFrancois Doray authored
To facilitate assessing the impact of intensive throttling on a page, this CL exposes an option in chrome://flags to enable intensive throttling as soon as a page is hidden. Bug: 1075553 Change-Id: I2507674186294f1ec8e23a9d93f17c5d23a7e2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276294Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#784252}
-
Xiaohan Wang authored
This class adapts Media Foundation IMFContentDecryptionModuleSession to a class that uses Chromium CDM types. It also handles setting session ID which isn't available when the session is created. This makes it easier for MediaFoundationCdm (to be uploaded in the next CL) to manage multiple sessions. NOPRESUBMIT=true Bug: 999747 Change-Id: Id966915d8bebb97406a412c4d2e958f2e2529576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265099 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#784251}
-
Thomas Guilbert authored
This CL saves the last AverageDuration() value from DecoderStream on the correct thread, to be used in IsBeforeStartTime(), which can be called from a different thread. Bug: 1096280 Change-Id: Ia098cb282d61a5ac610df4a32eccebab6742310a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274845 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784250}
-
Lindsay Pasricha authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/f971ef807cdc..b0d1c3d5f6ac $ git log f971ef807..b0d1c3d5f --date=short --no-merges --format='%ad %ae %s' 2020-06-30 tirodkar Fix UITouch compilation issues on iOS 14+ in GREYTouchInjector. Created with: roll-dep src/ios/third_party/earl_grey2/src Bug: 1101083 Change-Id: Ic74eb69f613e289aa5d5ebc76004ae7d5ea8c30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275470Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#784249}
-
Trent Apted authored
Code was removed in r544472. Fixed: 1089534 Change-Id: I344e62c88f92c7ae1aa71b13177e020f75315215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275141Reviewed-by:
-
Miguel Casas authored
ChromeOS has an "old" video decoder and a "new" VideoDecoder. ToT has two flags to decide which one to use: 1. A chrome:flags kChromeosVideoDecoder. 2. A command-line flag kForceDisableNewAcceleratedVideoDecoder passed by the ChromeOS command line builder. After careful deliberation we think the "new" should be called "direct" because it implements the media::VideoDecoder interface directly, as opposed to the "old" VideoDecodeAccelerator, that needed an adapter (the trusty VdaVideoDecoder). This CL refactors these flag names to: - A chrome:flags kUseChromeOSDirectVideoDecoder, intended for user debugging/finching (equivalent to 1. above, but renamed for clarity). - A kPlatformDisallowsChromeOSDirectVideoDecoder passed by the ChromeOS command line builder (equivalent to 2. above, renamed for clarity). - A new kUseAlternateVideoDecoderImplementation that is used by the CrOS Tast test infra to instruct Chrome to use the "other" video decoder implementation. This is needed to have a set of tests verifying the new decoder implementation pre-launching. All these flags only apply to OS_CHROMEOS, otherwise we should not use the direct video decoder (see crbug.com/1099172). The first two flags also only exist when BUILDFLAG(USE_CHROMEOS_MEDIA_ACCELERATION). (Note that those two only overlap partially: USE_CHROMEOS_MEDIA_ACCELERATION can be enabled on e.g. Linux and Chromecast). TBR=alemate@chromium.org for chrome_restart_request.cc trivial rename. Bug: b:159825227 Change-Id: I3b9878abed1fd71a2f435d348256e713d800404f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268540 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#784247}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If4b0eff33d6e2f5f526f18d74273b61857c715f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276615Reviewed-by:
-
Noel Gordon authored
Setup the event.relatedTarget when creating drag drop test events that will be sent to the target element. The browser initializes the event.fromElement from that .relatedTarget value (use the source element) and is only really needed for dragenter events to better simulate a dragenter event. Use null for the dragover and drop events (just like chrome). Bug: 1062902 Change-Id: I899e704f3026cc1f1cdbce2ed7436fc14be2e74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274885 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784245}
-
Noel Gordon authored
The test drag and drop test helper sends a 'dragEnd' event but nothing responds to that event in files app, nor is it defined in the spec. Make it spec-conformant: change 'dragEnd' => 'dragend' and the browser will properly handle it and files app will correctly process it. Bug: 1062902 Change-Id: I3ed0ba7c7e5f586132dcb88f34e5537ff7587a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276163 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Yi Xu authored
In canvas, we are trying to move tests from perf_tests/canvas to rendering benchmark so that our tests can take advantage of the existing rendering benchmark infrastructure. I moved tests in this cl, https://chromium-review.googlesource.com/c/chromium/src/+/2214750. And now I would like to delete them from perf_tests/canvas directory. Bug: 1077148 Change-Id: I3fa3a1aa7bb46316fce698950fbdf0747e718e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268397 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#784243}
-
Xida Chen authored
This CL converts base::Bind to base::BindRepeating in the bookmarks/ folder. This is a code health CL, no behavior change. Bug: 1007635 Change-Id: I67cb9491fa8bc275e4df16221a428a8e226f0711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274159 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#784242}
-
Aleks Totic authored
I am uploading minor fixes in parallel. Change-Id: If4ff1a5047f4b652249c83cba28073a7a9e30b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276707 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#784241}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/64b2c2e83ae6..947260e25933 2020-06-30 fawazm@google.com Enable adding of authenticators If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1034663 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9228577ce094f5f9a19ada45ecf0840c9e398b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277019 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I8bc8108bd79ba098b9221ee275890702163faae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256845 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#784239}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Id239923d74d88eddac5c06339c91fea6faff4c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276482Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784238}
-
Jack Lynch authored
This CL adds all of the existing DevTools actions to the DevToolsKeyboardShortcutAction enum so that we'll get a clearer picture of which shortcuts are being used. The corresponding frontend enum is updated in this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2276745 Custom shortcuts design doc: https://docs.google.com/document/d/1oOPSWPxCHvMoBZ0Fw9jwFZt6gP4lrsrsl8DEAp-Hy7o/edit# Bug: 174309 Change-Id: I203bc9364c571685f92b770e6de7bcf0ebc7e0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276498 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#784237}
-
David Bertoni authored
These tests were disabled for various reasons, but passed 3000 iterations on bots for all platforms. Note that sub-tests that checked for permissions failures were removed, since the <all_urls> permission is now needed for this API, and that was added to the manifest for other tests that weren't disabled. Bug: 80212, 117927, 367695 Change-Id: I074f78626cac1fa4c8be6e020ea77b7e8ca3d65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267929Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784236}
-
David Bienvenu authored
Restoring the session should obviate the need for retaining the initial url argument. Also remove the flag switches and their sentinels, because the flag switches will be added by Chrome on restart. Bug: 964541 Change-Id: I70d32c630565ce6f636d18e09b784016eef14d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249379 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#784235}
-
