- 27 May, 2020 40 commits
-
-
Sam Sebree authored
This change adds new color values to support high contrast for scrollbars. Color values for scrollbars are now selected using GetControlColor() in order totake advantage of existing code paths for selecting unique colors based on dark mode or high contrast color schemes. Bug: 1081921 Change-Id: I141aacbe4830544594626cc777f0183394e8c3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207981Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772412}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/65dd291c8da7..0ee4ee85ddf2 2020-05-27 handellm@webrtc.org RtpSender: remove lock recursions. 2020-05-27 handellm@webrtc.org PacketBuffer: remove lock recursions. 2020-05-27 ivoc@webrtc.org Add UMA histogram for native audio buffer size in ms 2020-05-27 tommi@webrtc.org Remove locks and dependency on ProcessThread+Module from NackModule2. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9226f524010d5d8575770251de18dd7684153349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218734Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772411}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590594916-60e361b5828c3c2c59992f70098f83fe3dce39a9.profdata to chrome-mac-master-1590609462-0a980a885be44e446b55c280ee660f43e0ab11a0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifd152d28bb5274f3f845449e8b41ef4ccaedff6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218953Reviewed-by:
-
Frank Liberato authored
This CL causes D3D11VideoDecoder to listen to the video decoder's config for whether it prefers one Texture2D with multiple array slices, or multiple Texture2Ds with one array slice eacy to hold decoded output. Previously, we would always do the former. Also, this CL adds a workaround to force multi-texture / one slice mode for some Intel drivers which require it. Bug: 971952 Change-Id: I4f12ead43aec2d35f463cc46d9a3bfc61500dc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191157Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#772409}
-
Erik Staab authored
TBR=sky@chromium.org Change-Id: I228a7ec684eafc907147a7e761fdb501a567e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218052Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772408}
-
Joe Mason authored
* boundaryForce now updates node velocities to pull them back across the boundary instead of teleporting them, which causes jitter as other forces continue to act after the teleport. * Rescale targetYPositionStrength to a max of 1 so that boundaryForce can match its strength without increasing oscillations. * Add a linkStrengthScalingFactor so that some link strengths can be rescaled along with targetYPositionStrength. * Add a 20-pixel border to the bottom edge of the graph so that the boundary force doesn't cram process nodes against the edge of the screen. Bug: 1086231 Change-Id: Idb4fe5acc05c4a8c0a7cfa7b5143c4f2d4f78f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215403 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#772407}
-
Charlie Hu authored
Most image policies can report multiple violations for a single cause(same image not following the rule) during layout, e.g. An unoptimized-lossless-image's bpp(byte per pixel) value can change multiple times if the image is being scaled in an animation. To avoid unnecessary duplicated reports being generated. This CL adds Hash method for DocumentPolicyViolationReport to uniquely identify each report and avoid the duplication by remembering these hash values in LocalDOMWindow and filter out reports that are in record. Some existing web tests rely on the fact that multiple copies of same report generated in same document. This CL also worked around that to either help make reports generated unique or isolate test cases to different documents(iframes). Bug: 924684, 926199 Change-Id: I230e32801c77980573b5ed55064d46f94aed3060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078837 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#772406}
-
Sammie Quon authored
I forget why i put the extra check in the first place, I think did it in case the displays are stacked vertically and dragging i thought maybe dragging from the bottom to top display would trigger a maximize. But we pass the display as well, so that is not a problem. Removing the extra check allows for touch dragging on bezel. Test: manual Fixed: 1081985 Change-Id: I5a58eb7874b109f7403a9fe383f27e5bf9fa87e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218506Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#772405}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1443c9df589b..7135239769de 2020-05-27 johnstiles@google.com Line-wrap comments to fit the 100-character limit. 2020-05-27 michaelludwig@google.com Store float value for SkSL settings 2020-05-27 bungeman@google.com [infra] Add iOS 13.4 2020-05-27 johnstiles@google.com Remove misleading comments that implied big-endian support in Skia. 2020-05-27 ethannicholas@google.com Revert "Revert "SkSL function inlining"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ie902897b6560e2880235c7cc2daf4b1ad9ba1e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218855Reviewed-by:
-
Steven Bennetts authored
This allows users to view and toggle the Metered property for WiFi and Cellular networks. (See issue for more details). Bug: 971704 Change-Id: I6ad441b4781d65875d4d6a44184e9287a789f230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216854 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#772403}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=pmonette@chromium.org Bug: 1026641 Change-Id: I828d0534b9b7fb7c988994a07e3e762500e934b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215915 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#772402}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/800891e5ad60..9129f940933f 2020-05-27 caseq@chromium.org Allow extensions while inspecting NTP in OTR mode 2020-05-27 duongn@microsoft.com [wasmparser] Update to 0.16.1 2020-05-27 janscheffler@chromium.org Enable TypeScript in DOMModel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1066386,chromium:1079233,chromium:1085228 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I591f7f5448aa3e88b9ca6592e090d2645408677f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218573Reviewed-by:
-
Matt Wolenetz authored
Updates FrameProcessor to: 1. Understand if it is currently handling a codec for which nonkeyframes are supported (specifically, only AAC with xHE-AAC profile in this CL.) 2. Enforce parse failure if a supported audio nonkeyframe sequence does not increase in PTS monotonically (as a major simplification to related buffering logic, and coherent with the supported underlying codec's restriction on decode order matching presentation order.) 3. Disallows an audio nonkeyframe from becoming a possible audio preroll buffer in HandlePartialAppendWindowTrimming. Updates SourceBufferStream and SourceBufferRange to: * Trust the upstream FrameProcessor to enforce (1) and (2), above. In particular, SourceBufferRange::GetBuffersInRange() and SourceBufferStream::TrimSpliceOverlap() no longer require all audio frames to be keyframes. This simplifies tracking whether or not each buffered frame is allowed to be a nonkeyframe (e.g. if it's AAC:xHE-AAC), since changeType uses the same SourceBufferStream and SourceBufferRanges across the bytestream or codec type changes. * Trivially make TrimSpliceOverlap a no-op if the beginning of the new buffers is a nonkeyframe. Otherwise, it would be infeasible to determine if the new buffers are coherently decodable when fed to the decoder after a possibly end-overlapped, previously buffered, frame. Includes (and tests) a further simplification: if an audio keyframe is fully outside the append window and the next continuous frame processed is a nonkeyframe, that previous audio keyframe is not used as preroll; it's dropped instead, and a keyframe at least partially within the append window is required to continue buffering. If this is an oversimplification, later CLs can attempt to more precisely handle this case. TEST=Includes new FrameProcessorTests. Manually tested with a private stream on Android P+ that seeking in a mixed keyframe/nonkeyframe MP4 xHE-AAC stream no longer caused decoder to emit logs about silence. BUG=1079034,1081952 Change-Id: I41010079041a14dca90e23660350d4cf2469bf2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186205 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#772400}
-
Ben Joyce authored
Bug: 1060721 Change-Id: I6fe5e9189fae6944859fbb3a99aa5c65c2d4f558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218753Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#772399}
-
Hongbo Song authored
2. Stop observing FSD when the local_root_ or the client of local_root_ is null. Once |LayerTreeView::Disconnect()| is called to shutdown the compositor, the delegate_ will be null. We should not observe FSD after that. Change-Id: Ia0d0e27f6d7db0d2c452b8951191424884f5585a Bug: 922980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218230 Commit-Queue: Hongbo Song <hbsong@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772398}
-
Samuel Huang authored
SuperSize requires GN flag generate_linker_map = true, but previously the flag is available only for Android or Linux. This CL makes the flag usable for ChromeOS builds as well, to enable SuperSize usage. Bug: 1084580 Change-Id: Ibfd13e7433a6b4cc6af43a8fddcb7510ea757e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218699 Commit-Queue: Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Sigurdur Asgeirsson authored
It's an eyesore that we're instantiating and describing this data on non-renderer process nodes. Bug: 1080647 Change-Id: I00ac8f6fc8732b66ffb42516c7d140113c7aa84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218556Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772396}
-
Xianzhu Wang authored
We already have the following logic which renders the original special handling of compositing of the root layer redundant: - We'll composite a LayoutView with the same rules as normal scrollers in PaintLayerScrollableArea::ComputeNeedsCompositedScrollingInternal(); - Any compositing in a frame will trigger compositing of the LayoutView and the PaintLayerCompositor. Change-Id: I15ad83095185defadb1c780a9444acfa1828bb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216858Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772395}
-
David Van Cleve authored
This CL adds metrics timing Trust Token operations, bucketed by operation type and success or failure. They record: - the duration of each Begin (outbound) operation part, and of each Finalize (inbound) part - the "server time" between the end of a Begin and the start of the corresponding Finalize; in order to bucket this by success or failure, it uses the success or failure of the subsequent Finalize part - the total duration of each operation (the time elapsed between the beginning of Begin and the end of Finalize), for operations that make it all the way to the end of Finalize R=csharrison Fixed: 1078541 Change-Id: I1e3541007616b971941aa7deef8a094f76ce3f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216599Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772394}
-
Andrew Grieve authored
* Use "Short Name" as fallback for "Name" * Download files concurrently * Generate .info files concurrently * Increase thread count for CIPD * Improve logging around missing licenses (and adds a missing one) * Remove less-used (never-used?) flags * Make --update-all be the default * Always overwrite all files (crbug/1078529) * Don't clobber non-committed local modifications to BUILD.gn * Show gradle output (so it's clear things are happening) The script now runs in < 10 seconds (for a no-op) on my machine. Bug: 1078529 Change-Id: I4eefb7e1442d647854ffa6bbedbf371382fa3cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218561 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#772393}
-
Sinan Sahin authored
There is a NullPointerException in OfflineIndicatorControllerV2 that seem to be caused by a posted ConnectivityDetector#performConnectivityCheck(). While we can't repro the crash, this CL adds a call to from the Handler. It also removes any posted runnables in OfflineIndicatorControllerV2#destroy() that may otherwise cause similar issues. Bug: 1085567 Change-Id: I548dbe4b0c54d382cd9e5684f5e252565f9fc337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216388 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#772392}
-
Mike Frysinger authored
The style guide says to put spaces after colons in JSDoc types: https://google.github.io/styleguide/jsguide.html#jsdoc-whitespace Bug: 469920 Change-Id: I579fd028bd5b55419ae82adcb9de633967a6f911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209535Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#772391}
-
Olivier Li authored
The new behavior (back-end dispatches to the ThreadPool) has been the default on stable since 81.0.4028.0. This CL includes some cleanup of base::Thread specific mechanisms now that a base::Thread is never explicitly instantiated. Bug: 661143 Change-Id: I65bf7af5682025dddf99ea431e2e02f2b525b8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201876 Commit-Queue: Oliver Li <olivierli@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772390}
-
Yuly Novikov authored
TBR=kbr Bug: 1060024 Change-Id: Ifaa67a559d54df54749d387b73a89f258dfa35e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218693Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772389}
-
Lukasz Anforowicz authored
Fixed: 1087072 Change-Id: I6c88a67575e08df76849b48a338462ddc4689475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218909 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Mike Wittman authored
Moves typedefs for function types exposed by the stack_unwinder DFM into the public feature interface, and shares them across internal feature code and public module code. This enables inconsistencies in function signatures to be detected at compile time, rather than causing strange issues at runtime. Bug: 1004855 Change-Id: Ib292f53a77d4731108a7aa862c6f531c3a041189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209298 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#772387}
-
cfredric authored
Bug: 973801 Change-Id: I04853197445f0a2686a7d5703d4b80287719df54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194331Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#772386}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=anqing@chromium.org Bug: 1026641 Change-Id: I89a068370f65f68feb17379b74031c7f8011f289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216734 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#772385}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=zmo@chromium.org Bug: 1026641 Change-Id: I96280e6c82a78a76b838b6d15d92b5b7aab42708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217207 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Tom Anderson authored
This CL uses the special reader/writer added by [1] to check that it's working. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2209961 BUG=1066670 R=msisov CC=sky Change-Id: I09c83827145916366f283e2bac93ed03d5db113a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212976 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#772383}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=avi@chromium.org Bug: 1026641 Change-Id: I00577ff6e5b1883bbdb62f9e2dfb95e8f8758841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215914 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772382}
-
Sujie Zhu authored
fieldtrial_testing_config Flag AutofillEnableSurfacingServerCardNickname is introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2138154/. This change is corresponding to cl/252708499. Will launch to Desktop + Mobile. Bug: 1059087 Change-Id: Iadcbe4f232fbe31e53c9950dfd65085ed974c04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210091 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#772381}
-
gogerald authored
Screenshots: Incognito mode: https://drive.google.com/file/d/1Dt28k02QOq2aB0a2Oc3VVK10ScaSfwmF/view?usp=sharing Dark mode: https://drive.google.com/file/d/1ke4Aa8DG2SQ4X77CIsxODvacEAJB2P7Y/view?usp=sharing Normal mode: https://drive.google.com/file/d/1-L4G1POaYiYSIweRxRBFrpD1QDEmRI1x/view?usp=sharing Bug: 1083853 Change-Id: I6e00a511b72c384b217a10dcbdf0e0c3c83399e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208609 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#772380}
-
Sujie Zhu authored
Previously we use IsAsciiDigit(char) to check whether nickname is valid. In i18n languages, the language scripts/alphabet are encoded in Unicode. IsAsciiDigit will mistakenly treat some i18n language scripts as digits because Ascii is encoded in 7 bits and meant for English only, while UTF-8 is encoded in minimum 8 bits. The influence of previous implementation is for some of the i18n user, we won't show nickname even if the nickname is valid (same as control group user, won't affect user experience). We use IsAsciiDigit(char16) instead, to check whether nickname contains digits. Bug: 1082013 Change-Id: I08dc77047d46225aa2f4645554e0443a800a480d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216888 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Jon Mann authored
This change fixes a few places that caused loops of updating sync: * When sync is applying an update, we now record the network id in a map and check before uploading changes from the device. Previously there was only a bit in the metadata store which tracked this, but it's not necessarily updated in time. * When the Network Details page is open and an update is applied, avoid re-saving the network from js. * When applying an update that doesn't include fields that were modified by another user, this prevents sync from overwriting the existing values (and kicking off another update). This required adding a new option to the proto to leave DNS unspecified. Bug: 966270 Change-Id: I7a89c0e97b51fbcfd8dea81499fce075a18570eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209892 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#772378}
-
David Black authored
In v1, the notification title is static "Time's up". In v2, the notification title is the string representation of time remaining. Bug: b:156641714 Change-Id: Iefd3d42ed4f8c81499971d313db3fe81cc73a741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216597Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#772377}
-
Jan Wilken Dörrie authored
This change adds implementations of the range-based non-modifying sequence operations to //base/util/ranges. Furthermore, it adds implementations of required helpers such as std::invoke, std::identity, std::ranges::begin, std::ranges::end, std::ranges::equal_to and std::ranges::less. Future CLs will add overloads for the remaining algorithms. Reference: https://eel.is/c++draft/alg.nonmodifying Bug: 1071094 Change-Id: I0cab296f3937de205583408638e9be2f79473768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944358Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772376}
-
Matt Menke authored
Bug: 1065927 Change-Id: If3b9b94c5886f05646d0f8887cc8955d2ae10437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208302Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#772375}
-
Tommy Nyquist authored
TBR=arbesser@google.com Bug: 1087042 Change-Id: I002fcf0cb005d9c31e4e16fc1fecf9321c4f1dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218714Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#772374}
-
Andrew Grieve authored
Also adds distributionUrl=, which my Android Studio told me is now necessary :/ Also enables warnings via gradle.properties. Without this, I just get a warning saying: "There was a warning, but to see it you need to enable warnings". Bug: None Change-Id: I7064ee3a82666866a56d2d69e04563fb7c7e44d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216323 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
