- 08 Oct, 2020 40 commits
-
-
Marc Treib authored
Bug: 991510 Change-Id: I447e99f11c322478f007557ab268823ed2616042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455446 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#815355}
-
ckitagawa authored
Found out that setMatrix() is broken, but concat() is a viable alternative. https://stackoverflow.com/questions/17100355/canvas-is-offset-by-setting-identity-matrix-in-ondraw-of-custom-view Bug: 1126541 Change-Id: I30f4e37dd488385c2f024ac9ae8aa0de8277aa6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461214Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#815354}
-
Xi Han authored
The bug happens when the instant start startup code path is called in a warm start, i.e., ChromeTabbedActivity is recreated when the dark/light theme is changed. We add a check of warm start to prevent this from happening. Bug: 1117226 Change-Id: I65b48afd03137c33b5ed1a726aac23f9dffd7e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454254Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815353}
-
Wez authored
Bug: 1038786, 1132032 Change-Id: I1c78e60428604cc7c9d720e69cb4cb9175fa6593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461735 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815352}
-
David Van Cleve authored
We're investigating some failed Trust tokens Issuance operations executed via the Fetch API. We previously landed logging to get a better understanding of why these fetches fail, but the logging groups together fetches that fail for a couple of distinct reasons that can make ResourceError::GetResourceRequestBlockedReason() return ResourceRequestBlockedReason::kOther: (1) Explicit ResourceRequestBlockedReason::kOther returns by logic in Blink (2) net::ERR_BLOCKED_BY_CLIENT and net::ERR_BLOCKED_BY_RESPONSE errors from downstream services that do *not* have associated network::mojom::BlockedByResponseReasons. (If they had associated BlockedByResponseReasons, these reasons would be mapped to non-kOther ResourceRequestBlockedReasons.) This CL adds some additional logging for failed Trust Tokens operation-bearing fetches' net errors, which will help resolve this particular ambiguity as well, in general, provide richer information than just the ResourceRequestBlockedReason. Bug: 1128174 Change-Id: I84cd9e4f3551a364d1b80179a2c8f6b4085f8a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451729Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#815351}
-
Eugene But authored
The uptime is only estimate and updated when app gets backgrounded, battery level changes or similar system notification is posted. It might be useful to add a timer, which updates up time every few seconds, but that change will be done in a separate CL. Bug: 1103752 Change-Id: Ie12af0a259f915181199bd58aa1dbc57758ab60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459307 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815350}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ff30c3d43096..daef088d069f 2020-10-08 thestig@chromium.org Rename core/fxge/win32/fx_*.cpp. 2020-10-08 thestig@chromium.org Remove core/fxge/win32/win32_int.h. 2020-10-08 thestig@chromium.org Split CWin32Platform into its own file. 2020-10-08 thestig@chromium.org Split CGdiDeviceDriver into its own file. 2020-10-08 thestig@chromium.org Make more XFA attribute data truly read-only. 2020-10-08 thestig@chromium.org Make more XFA element data truly read-only. 2020-10-08 thestig@chromium.org Make more XFA element data truly read-only. 2020-10-08 thestig@chromium.org Avoid relocations in struct XFA_FMHtmlReserveCode. 2020-10-08 tsepez@chromium.org Better encapsulate CXFA_MapModule members. 2020-10-07 tsepez@chromium.org Rename struct XFA_MAPMODULEDATA to class CXFA_MapModule. 2020-10-07 tsepez@chromium.org Remove CJX_Object::SetUserData(). 2020-10-07 nigi@chromium.org Roll v8/ 88d84cce1..e1e716fb8 (67 commits) 2020-10-07 tsepez@chromium.org Deduplicate one line in CJX_Object::GetMeasureInUnit(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Iaf34ae3288eee016e6c1f79da00a7fc5139ba277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815349}
-
Zentaro Kavanagh authored
- Currently only includes simple routines Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I1b16a83136a56a757bb8fed11d603997de01f145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462337Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#815348}
-
Xinghui Lu authored
This CL is for pure refactoring. This is a follow up of https://crrev.com/c/2337390. Rename SecuritySettingsFragment to SafeBrowsingSettingsFragment. Rename kSafeBrowsingSecuritySectionUIAndroid to kSafeBrowsingSectionUIAndroid. Rename SAFE_BROWSING_SECURITY_SECTION_UI to SAFE_BROWSING_SECTION_UI. Note the value of this parameters is not changed because that will affect finch config and chrome flags. Bug: 1097310 Change-Id: I73512055f0d986e3d6af68ab205f084c6c2bc608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364952Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815347}
-
Lucas Radaelli authored
This change refactors parts of the Accessibility Bridge to solve the following bugs: * Previously, it was deleting nodes that were marked as reparented or a subtree that was reparented. This assumed that nodes marked this way would appear in the list of updates sent by the AxTreeObserver in the final atomic update, but this assumption is not correct. This fixes the problem where parents were pointing to children no longer in the tree. * Allow trees of size 1 to be sent. Previously, the loop that dealt with sending updates started from the second item, which would not send anything if the tree had only one element. * Simplifies the order of updates: first deletions and then updates. Because atomic updates always finish with the list of nodes added / changed, we can use this property to simplify the code to always follow this order. Todos: There are some todos left in the code which I opted to follow-up in a future cl so that I can split work among people and parallelize. Test: AccessibilityBridgeTest.* Bug: 1134384,fuchsia:58989,fuchsia:50187,fuchsia:61155 Change-Id: I6ec09a5d6fa5d5ad37fb42a059d0d0f122d39d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446358 Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#815346}
-
Thomas Lukaszewicz authored
Bug: None Change-Id: I1e7118ab0a6be7859ff47f8217449f1aa502d1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459061Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#815345}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I2cf43694a465270320ee608940f8e3a1339c3c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461707Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#815344}
-
Regan Hsu authored
TetherController implementation which utilizes MultiDeviceSetupClient and CrosNetworkConfig in order to interact with Instant Tethering. If Instant Tethering is user disabled, AttemptConnection() will first enable the feature via the MultiDeviceSetupClient, then scan for an eligible phone via CrosNetworkConfig, and finally connect to the phone via CrosNetworkConfig. If Instant Tethering is enabled, but there is no visible Tether network, AttemptConnection() will first scan for an eligible phone via CrosNetworkConfig, and connect to the phone via CrosNetworkConfig. If Instant Tethering is enabled and there is a visible Tether Network previously fetched from observing CrosNetworkConfig, AttemptConnection() will just connect to the phone via CrosNetworkConfig. Disconnect() disconnects the Tether network if one exists. Bug: 1106937 Change-Id: Ibb3eb92483a721cc5be38d1bf8e3ff5f89e0e1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441123 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815343}
-
Adam Barth authored
These methods are the same as the old method, just with a different argument order that matches the underlying C syscall. Change-Id: I707cf9da491b5fca79fb1d99ca055f90ada0ec1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461980 Auto-Submit: Adam Barth <abarth@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#815342}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602158210-2b3a542037c8eff782f3f4efb30eab1c7f804d13.profdata to chrome-linux-master-1602179909-9d7f0b29438414a4f2265cc4ee2a14492d697def.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I50e95dc448902a10e0d2aff18bce7303e2d3c315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462148 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815341}
-
Michael Hansen authored
Increases the margin between the radio buttons on the data usage dialog to match the UI specs. Spec: carbon.googleplex.com/cros-ux/pages/nearby-share/settings-approach Screenshot: https://screenshot.googleplex.com/8patFRrV2S2u2mw.png Bug: b:162328100 Change-Id: I7f0096500822cbe7fd0d43c35d2e753b31517f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461712Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#815340}
-
Jazz Xu authored
Add two metrics tracking repeat usage on shelf and in quick settings. Add one metric to track user actions in quick setting media controls. Bug: 1136254 Change-Id: I7da5afc7146a841c52b8adaedf0bd92242479957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458855Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815339}
-
Xinghui Lu authored
The plan for this two-sided patch is: 1) Add the new class under feedback/ and AppHooks method upstream with no reference. 2) Extend the new class downstream and add the new AppHooks method. 3) Update upstream references to point to the new AppHooks method. 4) Cleanup in downstream repository. 5) Cleanup in upstream repository. 1) was done in https://crrev.com/c/2364581. 2) was done in https://crrev.com/i/3227761. 3) was done in https://crrev.com/c/2414779. 4) was done in https://crrev.com/i/3274398. 5) is done in this CL. Note that the change in SigninUtils was a miss from step 3). Ideally all references to HelpAndFeedback should be removed in 3), but there is one left in SigninUtils. The consequence is that after step 4) is landed, this reference can only be pointed to the upstream implementation. Bug: 1117343 Change-Id: Iafe729908040925ab5a6c7fb4caf61194a5653e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415383Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815338}
-
Peter Kasting authored
Bug: 772945 Change-Id: I580a79f0141bad0dfacbdc6d8c999605fceec029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458809 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#815337}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7868692b9df0..e1589a1e19da 2020-10-08 johnstiles@google.com Add line breaks to make dehydrated files more merge-friendly. 2020-10-08 senorblanco@chromium.org Dawn: implement mipmap generation. 2020-10-08 adlai@google.com Migrate more Android & SkSurface API off GrContext 2020-10-08 kjlubick@google.com Fix debugger to work with new emsdk 2020-10-08 michaelludwig@google.com Adjust w0 clipping plane distance 2020-10-08 robertphillips@google.com Rename GrThreadSafeUniquelyKeyedProxyViewCache 2020-10-08 kjlubick@google.com [pathkit] update to build with emsdk 2.0.6 2020-10-08 ethannicholas@google.com moved SkSL Setting data into IRNode and fixed its dehydration/rehydration 2020-10-08 mtklein@google.com tidy up SkTHash special methods 2020-10-08 johnstiles@google.com Use SkTHashMap to implement DefinitionMap. 2020-10-08 ethannicholas@google.com moved SkSL FunctionDeclaration data into IRNode 2020-10-08 kjlubick@google.com [canvaskit] Update emsdk to 2.0.6 2020-10-08 johnstiles@google.com Implement assignment and copy-construction for SkTHashSet/Map. 2020-10-08 kjlubick@google.com [canvaskit] POC bindings for testing gms If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: jvanverth@google.com Change-Id: Ibe36143b50070f899f8410efb915678965cba0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462143Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815336}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/31b44b3a70ed..823a6df243c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I436245e187e29323ea52ab6f27772f005ef959ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461671Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815335}
-
Risan authored
BUG=1134755 TEST=CQ Change-Id: Ic1a50d2e944d09d7795ea01609a5a56b2a5207ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460830 Auto-Submit: Risan <risan@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#815334}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I7906f4f164361c10b766a1e27d5a32baa11c5737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815333}
-
Bo Liu authored
Buffer queue may not change orientation on rotation, and the swap size would have the width and height swapped for code that expects the swap size to be in landscape. This fixes the surfaceRedrawNeededAsync timeout when rotating from portrait to landscape. This also fixes 1136033 where on initial launch in landscape, android side does not have a timeout for surfaceRedrawNeededAsync like it does for rotation. Bug: 1136033 Change-Id: I91b3d81252f3e02fb3d85bf1ac91d5d802544490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459569Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815332}
-
Dana Fried authored
This is a temporary fix while we hash out the attached a11y bugs. Bug: 1136185, 1136236 Change-Id: I8a5ab6584fb708112c4b27ecae643be5a09f6564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459056Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#815331}
-
Angela Yoeurng authored
This CL updates the background color of a hovered/selected suggestion if the refined-focus-state flag is enabled. It also made the focus bar visible only if the search suggestion is selected vs. if the aux buttons are selected as well. Bug: 1129612 Change-Id: Iba4287937a345123c5465cea2522e7462be1f93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459632 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815330}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9fb07662e436..823a6df243c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0b44962419e5a1c8f17dcf3b4d96804c2ea5d901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461713Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815329}
-
Peng Huang authored
This reverts commit a49d219d. Reason for revert: Found a right way to fix it, so revert this workaround. Original change's description: > Use logic rotation with SurfaceControl on Android > > For some devices, the hardwarerotation doesn't work with SurfaceControl, > so disable it for now. > > Bug: 1136033 > Change-Id: Id1ed7971d50ec815fd315fb728315f05e6be9637 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461550 > Auto-Submit: Peng Huang <penghuang@chromium.org> > Commit-Queue: Jonathan Backer <backer@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815198} TBR=penghuang@chromium.org,backer@chromium.org Change-Id: Ib6f08d68ef4a99eeafd61dd01d8b5fbcb12a3a23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462377Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#815328}
-
Trent Apted authored
Git archaeology suggests callers of this method disappeared in r754621. Bug: 894447 Change-Id: I24a1818950be53131fd781d07c19a096d138db6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460071Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#815327}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 57ee92af. With Chromium commits locally applied on WPT: 5eb1a5d6 "[Sanitizer API] Remove creationOptions from Sanitizer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ieb89d7e42db7bdd47bde1f988c6a2868ae9bc07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461828Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815326}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d24d3c2bc1d7..2a472f6edd47 2020-10-08 michael.liao@microsoft.com [Issues Pane]: Fix focus regression where expanding tree elements would refocus first tree item If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136420 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2a89378b041258ec59ec510226cdd67f5b2fca87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462144Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815325}
-
Chris Blume authored
Right now, we first check if the user is in the enabled feature group when enabling wide color gamut. After that, we check if they are on a version of Android that supports wide color gamut. This results in users in the enabled group who aren't actually seeing wide colors. This CL checks if the user is on a supported version of Android before checking which group they are in. That should give us more accurate results when looking at the effect of the experiment. Bug: 1136572 Change-Id: Ied060b1036bba67a0c90a45f1f8e1dc106af4aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462218 Commit-Queue: Chris Blume <cblume@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#815324}
-
Dave Tapuska authored
With the removal of the RenderWidgetFullscreenPepper WebExternalWidget is only used inside tests. Move these tests inside blink. Add ability to override the WebViewFrameWidget with a custom implementation so that we can instrument it for tests. BUG=1097816 Change-Id: Id5cf6cea5d56f91aa6d7c0c5c05ff98f7ec9e19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460715 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#815323}
-
Kartik Hegde authored
Add GetRandomAndFixedHostsWithSchemeAndPort() which will be used by network diagnostics routines. TEST=none BUG=chromium:956783 Change-Id: Idca59b4f7c0a05043a8ce8b62465ce696d04be9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462275 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#815322}
-
Sven Zheng authored
In preparation for the win 1909 update. We should get new gold images caused by system update if there's any, and approve them. Change-Id: Id18d2d46d4280f1096e9659b1a5b421bbe5401fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453924Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#815321}
-
Clark DuVall authored
Also removes unused onBind() from SplitCompatIntentService. Review from Patchset 1 to get the right diffs on the changes in CustomTabsConnectionServiceImpl. Bug: 1126301 Change-Id: I21fa9e948030ace8377dc1fac24bc6ddcca16cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462176 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#815320}
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: I235a973162915dc7e6ca817c82f7caa7c001b579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453807 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815319}
-
Xing Liu authored
Keep metric "Download.Database.IsAvailable" which is helpful to detect critical issue in download sqlite db. Bug: 1088728 Change-Id: I63be65de5529a1666dd3edfde9a545279da711b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363668Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815318}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6dfd855a10fb..887b1346d5af 2020-10-08 syoussefi@chromium.org Vulkan: Add resolve/unresolve counters 2020-10-08 syoussefi@chromium.org Pass in Command::Clear to framebuffer syncState If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I66993196aeb5e016b1bb6402ce5b113dab2b324a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461974Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815317}
-
Rune Lillesveen authored
In order to store tree-scoped names/references in ComputedStyle we need to keep track of which TreeScope the MatchedProperties came from during selector matching. We do this by pushing TreeScope pointers for each scoped to MatchResult which maps to the tree_order number stored in each MatchedProperties entry. This mapping will be used during cascading and stored with the name to create a tree-scoped reference on ComputedStyle. Bug: 336876 Change-Id: I416d9b12276917cb17c368909d3d5fd1b9f4f5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453392Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#815316}
-