- 21 Jul, 2020 40 commits
-
-
Toby Huang authored
This CL adds an enterprise segment to the MetricsLogSegment enum in PolicyData to better distinguish between EDU and enterprise users in ChromeOS. Bug: 1103077 Change-Id: If7f8e15bc2460e2fed65eeee469cf604824109e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305017Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790487}
-
Marijn Kruisselbrink authored
Matching the changes from https://github.com/WICG/native-file-system/pull/177 Since the bindings layer doesn't support async iterables yet, this CL does this in a bit of a hacky way, that isn't entirely web-idl compliant. It is much closer to the desired API than what we had though, so seems an improvement until bindings properly support async iterables. Bug: 1011539, 1087157 Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#790486}
-
David Bokan authored
This reverts commit 23d79be2. Reason for revert: Crash dumps are no longer needed Original change's description: > [Reland] Add DumpWithoutCrash for slow Mac KeyPress events > > [Reland] - This is effectively a reland, first patchset is unchanged > https://crrev.com/74f12a609316ba81 so compare to that for changes. That > iteration provided some interesting data but used a triggering time of 5 > seconds. I've since learned that there's a myriad of known edge-cases in > which events might have delays of 1-20 seconds (!). In our case, we're > specifically looking for issues at the upper end of the UMA metric (60+ > seconds) so this caused some unrelated noise. This CL relands with a > higher threshold and some minor changes to the crash keys. > > Add a DumpWithoutCrash to KeyPress events where the timestamp of the OS > differs from the current time by more than 60 seconds. We see in UMA > that we often see events in the 95% percentile reaching many seconds of > difference. Hopefully the crash stacks will reveal something about > what's causing this. > > A previous iteration of this investigation in > https://crrev.com/c/2111782 showed that we sometimes redispatch events > that have been reinjected back from the renderer. This should never > happen. This CL adds crash keys to dump some of the related app state > to help explain how this happens. > > However, not all such stack traces showed reinjection so that can't be > the cause of all these bad timestamps. This CL also adds some timing > information to the existing crash key in NSApp:sendEvent which might > reveal something. > > Bug: 1039833 > Change-Id: If49b7b8a918f880ed00a7adf219e589ed66daf6e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210867 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771059} TBR=avi@chromium.org,bokan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1039833,1070998 Change-Id: Ia8ba77a1ee95d033f7626055013d15422da32b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310390Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790485}
-
Emily Stark authored
This CL is for an omnibox URL display field trial in which the full URL is shown on page load but elided to just the domain once the user interacts with the page. The bug is that modifier keys / keyboard shortcut combinations count as user interactions, which is visually awkward and distracting. For example, if a user presses Ctrl+Tab to switch tabs, we don't want to treat that as a user interaction and animate the URL to the elided form. To allow the omnibox to filter out modifier keys, we now plumb the full WebInputEvent through WebContentsObserver::DidGetUserInteraction (previously this method just exposed the event type). This allows OmniboxViewViews::DidGetUserInteraction to ignore modifier keys when deciding whether to animate the URL to an elided form. Bug: 1096849 Change-Id: I02be4b9e3cbf98e02d91016c4edea67232821c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302948 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#790484}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 36 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-01-17. TBR=chromium-metrics-reviews@google.com Change-Id: Ic48c569b79c76b241daf0512266f80c9f424c5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310331Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#790483}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86079a48c157..b4a89393df3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tmartino@google.com,andruud@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tmartino@google.com,andruud@google.com Change-Id: I892e84228edfc8e363d7aa2348112dab2c314e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310312Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790482}
-
Eugene But authored
Current session restoration can not restore more than 75 items per tab. There is no value in storing more than 75, so this CL stores only 75 to reduce the memory usage. This should help the users who reuse 1 tab for all their navigations. Chrome for iOS also need other fixes, but this one is simple and does not change the behavior. Bug: 1082279 Change-Id: Ibc0bf7b64339af5936155b6c5cf4e6743c64aa7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295804 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790481}
-
Sorin Jianu authored
This has been detected by the static analyzer in another CL. Change-Id: Ia10576bb78429ffd979dbe9ea262960ee823d497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310432Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790480}
-
Sebastien Marchand authored
- Disable AFDO when using PGO - Don't try to use PGO on NaCl. Bug: 1107531 Change-Id: Ia2b161834c6467b648513c49527d881df79c9af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308170Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#790479}
-
Kalvin Lee authored
This change allows the CreateProvider() method of the test fixture to propagate the browser locale directly to the metadata manager. This facility is not actually used in this CL. Bug: chromium:888189 Test: autoninja ... chrome{,os_unittests} Change-Id: I815ac34b37f8b8068b6640cff1cdbe152b86c02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296371Reviewed-by:Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#790478}
-
Tommy Martino authored
This test is failing quite often on Mac. Will try to find an appropriate owner to follow up. TBR=katie@chromium.org Bug: 1107923 Change-Id: I377a4d3f5e0424e8ba39bd610609aa7a5f3b2d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310154Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790477}
-
Nick Harper authored
Domain removal request verified via DNS challenge. Change-Id: I4bf5ad919b5480d4de5c9cfa8fe04b600c46f826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308861 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790476}
-
Matthew Wang authored
This is essentially a revert of 34f59cac. This property was never used and is on by default. We're planning on removing it in shill, so remove it here too. TBR=stevenjb@chromium.org for networking_private.idl Bug: b:158665656 Test: chromeos_unittests Change-Id: I75729bc58eb33d1b455b4577622bd05c9909a73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303460Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790475}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=caitkp@chromium.org Change-Id: Ib9762f206c2c8f7456159d5058ecd7257a57a1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298861 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#790474}
-
Himanshu Jaju authored
IncomingShareTargetInfo is an additional data structure used to store and retrieve remote device info such as connection and endpoint_id. It will be used by future CLs for establishing incoming connections. Bug: 1085068 Change-Id: Id7265fb16da494737b76531b08c8cbc21ddb7c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307241 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#790473}
-
Leszek Swirski authored
Fixed: 1089625,1089626,1089627,1089628,1089629,1089630 Change-Id: I9509519c941fc5207df5bcd5185b9a277bffd411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308712 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790472}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I58096591126401be9e4780369fbf61206f571dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310326Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790471}
-
Olesia Marukhno authored
Buttons in the dedicated row has the pill form. Installing pill path generator on buttons fixes the ink drop and the focus ring being square. Because of that there is no need to set path generators for the focus rings separately. Bug: 1104264 Change-Id: Idf90a3d1c3ede551d3acae05112a902934195b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302700Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Alex Chau authored
Bug: 1107414 Change-Id: Ib5319dd5a970be5237a7940721fe634161df5b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309702 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#790469}
-
Alexey Baskakov authored
web_applications:common subsystems are common for web_applications:web_applications and web_applications:extensions. Bug: 1098027 Change-Id: I61ae6777459dd58c389cd0f716dfc067c5de2824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309491 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#790468}
-
Matthew Denton authored
And also add sanitizers/OWNERS to gwp_asan/OWNERS. Change-Id: I9900915a5c1708dc85cdf51a582dfdb33129e7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308357 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#790467}
-
Katie Dektar authored
This reverts commit 6e52cf21. Reason for revert: Speculative revert: A related test has begun failing since this landed. Failing test: external/wpt/html/cross-origin-opener-policy/reporting/access-reporting/property.https.htm First failing build (with this change in blamelist): https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/16841 Original change's description: > [COOP] access reporting [5/N] Plumb report type. > > All of this is put behind a flag disabled by default. > This is mostly based on the initial prototype: > https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24 > > Define, plumb and use the "report-type" for COOP access reporting. > > COOP access reporting: > [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 > [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 > [3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 > [4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 > [5/N] this patch. > > Bug: chromium:1090273 > Change-Id: I5e51b3da6a20c85c073ea1fd84ea74557760a42f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309433 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790420} TBR=clamy@chromium.org,mkwst@chromium.org,arthursonzogni@chromium.org,pmeuleman@chromium.org Change-Id: I88a01f1dc601205b2344c4251747cf75ef5a84d0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1090273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310769Reviewed-by:
-
Becca Hughes authored
BUG=1053599 Change-Id: I97a1c1b62bd70fbdbc989b90a014971071876b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309227Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790465}
-
Eugene But authored
UTE is Unexplained Termination Event, which is detected when Chrome started after a non-clean shut down. When chrome app is foregrounded a special flag is written on disk to mark the session start. That flag is cleared when Chrome enters background. The app checks the flag on each start and records UTE if flag was not cleared. UTE is unexplained by definition and provides no information about the termination. This CL generates synthetic crash log without minidump, so developers could have at least some basic info about terimation. Synthetic crash log can include breadcrumbs, and some info from the previous session. But for now this CL only adds a bare crash report with device name and app version. Crash report consists of 2 parts: config file understandable by Breakpad and empty minidump (Breakpad does not upload crash report without minidump). These 2 files are places to Breakpad directory for upload. Bug: 1103752 Change-Id: I10caaf40742711413c1cd659c55b3a7c8aeff9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290153Reviewed-by:
-
Liquan (Max) Gu authored
Changes: * Move SettingsAutofillAndPaymentsObserver.Observer from PRImpl to UIsManager, which includes these methods: - onMethodDataInitiated - onCreditCardDeleted - onCreditCardUpdated - onAddressDeleted - onAddressUpdated * Create PRLifecycleObserver in CPRImpl * Create PRParams and let PRImpl implement it. * Since some methods depend on mMerchantSupportsAutofillCards, this CL refactor the code that set merchantSupportsAutofillCards with PRLifecycleObserver.onPaymentRequestParamsInitiated * Change mCanUserAddCreditCard to boxed type so that we can assert they are used after defined. mMerchantSupportsAutofillCards is not changed to boxed type because an existing used-before-defined issue crbug.com/1107039. Bug: 1102522 Change-Id: Ib1354e9a3b53f2ce82ce760a70dfa00d46f80813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304772 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790463}
-
Henrique Nakashima authored
It is a chore to control DEPS so finely - most allowed deps are shared between implementation, unit tests, and instrumentation tests. Change-Id: I899c472fd1bba595b9428ebedfaf2af2809eb3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304539Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#790462}
-
Lachlan Ford authored
In OpenXR, the aim ray is not static. Thus it must be recomputed regularly in order to support devices with dynamic aim ray poses. This change removes the check that prevented the recomputation of the aim ray pose. Change-Id: I4c3fdf423387a784ce92c8658e8462dd3e598592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308947Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#790461}
-
Becca Hughes authored
Mark a Media Feed and its contents as being displayed when it is shown in the UI. This will shuffle the feeds to show new content. BUG=1053599 Change-Id: Ibf48d01e10a010e07177a54ea2f0b3400b68867f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309800Reviewed-by:
-
Andrew Grieve authored
This reverts commit 561b40b5. Reason for reland: Other culprit CL reverted: https://chromium-review.googlesource.com/c/chromium/src/+/2310131 Original change's description: > Revert #2 of "Android: Updates to warnings-as-errors when building" > > This reverts commit 3a98cccc. > > Reason for revert: The reland also broke the tree. > > Original change's description: > > Reland "Android: Updates to warnings-as-errors when building" > > > > This reverts commit 57deecbb. > > > > Reason for reland: Suppressed cast lint warning > > > > Reverted in: 339e6581. > > > > > Original change's description: > > > > Android: Updates to warnings-as-errors when building > > > > > > > > * Delete java_warnings_as_errors > > > > * Use treat_warnings_as_errors for android rules > > > > * warnings-as-errors is now default true for debug builds > > > > * Add --warnings-as-errors to proguard.py, dex.py, bytecode_processor.py > > > > so that these warnings can all be turned off locally. > > > > * Made build_utils.CheckOutput fail by default when stderr or stdout is > > > > printed. This should prevent build logs from creaping in. > > > > * Added "you should use treat_warnings_as_errors=false" into error > > > > message when builds fail due to warnings. > > > > TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org > > > > Bug: 1029357 > > Change-Id: I56c1349c6e823737aa8a59a8e961e5a518667ba0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308868 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790410} > > TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org > > Change-Id: I4721f016821d3675e389740d7d2d59e787ff9304 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1029357 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310392 > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Commit-Queue: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790453} TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,tmartino@chromium.org,andruud@chromium.org Change-Id: Ib19547f2099ec59b9b00b43a9f9ae5d9ea23e28e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309813Reviewed-by:
-
Sven Zheng authored
Bug: 1104291 Change-Id: I741cc87519f105aafad4671ab837acaaa652f1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308130 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#790458}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/62ab4833a6a1..84d986f9a16a 2020-07-21 jacktfranklin@chromium.org Rename `NewElementsBreadcrumbs` => `ElementsBreadcrumbs` 2020-07-21 aerotwist@chromium.org Changes ninja hardlink copy for file copy 2020-07-21 aerotwist@chromium.org [TypeScript] disallow explicit any If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I61b5347a2b239a87b18d1f556893df45ab051f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309987Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b0b5891ddfac..921d95386ccd 2020-07-21 miu@chromium.org Fix scaling default recommendation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106140 Tbr: jophba@chromium.org Change-Id: I92fb5fdb167e9f82828b674e8d14e7cb43adbccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309120Reviewed-by:
-
Livvie Lin authored
Before: https://drive.google.com/file/d/1D9OunuuOxV5O9FWTnU0MKMpn6hkeop8_/view?usp=sharing After: https://drive.google.com/file/d/1R-O4UNXMCG-e_wHnN4sH3M92QhvLhpKj/view?usp=sharing Change-Id: Ia2a96b5eeb977ef58479ac6ebfc9106d7dd62304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304093Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790455}
-
Hidehiko Abe authored
On chromeos-chrome on Linux for development purpose, if XDG_RUNTIME_DIR is set, but it is missing, create it. Bug: 1107789 Test: Ran locally. Change-Id: I42086e71fed05976f40508c86f2c5644dd565a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310030 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#790454}
-
Tommy Martino authored
This reverts commit 3a98cccc. Reason for revert: The reland also broke the tree. Original change's description: > Reland "Android: Updates to warnings-as-errors when building" > > This reverts commit 57deecbb. > > Reason for reland: Suppressed cast lint warning > > Reverted in: 339e6581. > > > Original change's description: > > > Android: Updates to warnings-as-errors when building > > > > > > * Delete java_warnings_as_errors > > > * Use treat_warnings_as_errors for android rules > > > * warnings-as-errors is now default true for debug builds > > > * Add --warnings-as-errors to proguard.py, dex.py, bytecode_processor.py > > > so that these warnings can all be turned off locally. > > > * Made build_utils.CheckOutput fail by default when stderr or stdout is > > > printed. This should prevent build logs from creaping in. > > > * Added "you should use treat_warnings_as_errors=false" into error > > > message when builds fail due to warnings. > > TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org > > Bug: 1029357 > Change-Id: I56c1349c6e823737aa8a59a8e961e5a518667ba0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308868 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790410} TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org Change-Id: I4721f016821d3675e389740d7d2d59e787ff9304 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310392Reviewed-by:
-
Stephanie Kim authored
Setting this to 6 concurrent links because linux64-beta/stable/trunk uses 6. Bug: 1072012, 1103490 Change-Id: I20a32e90e43719823f903d498b10895d0cf17a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298288Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#790452}
-
Bence Béky authored
Log a newly added HTTP2_SESSION_SEND_GREASED_FRAME event every time an HTTP/2 frame of reserved type (as defined in [1]) is sent. This happens after sending a SETTINGS frame, and also before each DATA frame. The ones sent before DATA frames are generated in SpdyStream::QueueNextDataFrame(). The DATA frame is generated earlier by SpdySession::CreateDataBuffer() but only enqueued later. In order for the greased frame to be logged before the DATA frame (corresponding to the order in which they are sent), DATA frame logging is moved from SpdySession::CreateDataBuffer() to SpdyStream::QueueNextDataFrame(). [1] https://mikebishop.github.io/http-misc-extensions/draft-bishop-httpbis-grease.html Bug: 1106652 Change-Id: Icaa8e874e48a85d93d5920d75d9e0bb0caa43949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309350Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#790451}
-
Rakib M. Hasan authored
Updates wpt_update_expectations.py so that it can mark tests as flaky by adding pass expectations for tests with unexpected passes. Bug: 1050754 Change-Id: I071c21d574763b9fa5d7d3f1637ad2236933941f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303869 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#790450}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c1eb58de32c0..09357ccfa85a 2020-07-21 herb@google.com split out GrDirectMaskSubRun from GrMaskSubRun 2020-07-21 kjlubick@google.com [skottiekit] Initial npm files 2020-07-21 bsalomon@google.com Rename GrMipMapped GrMipmapped 2020-07-21 fmalita@chromium.org [skottie] More masking fixes 2020-07-21 fmalita@chromium.org [skottie] Add RenderFlag::kDisableTopLevelClipping If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I4b59f82c225ad5aba57e87abc77477d9fc68235f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309984Reviewed-by:
-
Ali Juma authored
This disables SafeBrowsingTestCase/testRestoreToWarningPagePreservesHistory since it is flaky. Bug: 1106498 Change-Id: I0953c8c0f2c36ea01a7e1f0ff738db6c842df94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308867 Auto-Submit: Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#790448}
-
