- 14 Oct, 2019 40 commits
-
-
Lei Zhang authored
Due to an issue in RenderProcessHostImpl, this test is failing flakily. Disable to make the tree greener. TBR=achuith@chromium.org Bug: 1010866 Change-Id: Idf0309e3ca569cef1116f8ddd2aeaed5cb088c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859878Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705716}
-
Siye Liu authored
Root cause is that if |DirectManipulationHelper::Initialize| returns false, then DirectManipulationHelper hasn't been properly initialized, and it's member |event_handler_| may still be nullptr. In destructor of DirectManipulationHelper, |DirectManipulationHelper::Destroy| is called which references |event_handler_| without a null check result in AV. Fix is to add null check before referencing |event_handler_|. Bug: 1001325 Change-Id: I815583413cb3e4c545568ea4ccba3b29366dedce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857546Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705715}
-
Christian Dullweber authored
Enable this DCHECK independently of flags. All current call sites seem safe and new ones shouldn't be added. Bug: 967668 Change-Id: Id9fcbfbbd2d76dcc7ac5cfecedc8c15add95741c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819499 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705714}
-
Evan Stade authored
Registration for NOTIFICATION_PROFILE_ADDED is replaced with User::AddProfileCreatedObserver. Note that before this patch, the NotificationRegistrar was never actually used because it was broken by d5f8becb. Thus, this patch also fixes the (relatively minor) bug that while a profile was loading, GetNotifiers would no-op, rather than perform a delayed op. Bug: 268984 Change-Id: I3c68b5bb9610e486088e3e0c5cb23255453dab3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857538Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#705713}
-
Lei Zhang authored
LayerTreeHostTestSurfaceDamage.RunSingleThread_DelegatingRenderer is flaky and causing a lot of CQ runs to fail. TBR=ajuma@chromium.org Bug: 1014263 Change-Id: I229b53eceb6b239cce5d1615780b98c78833af98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860113Reviewed-by:
-
Eric Lawrence authored
The StartupObserver class monitors the startup of the browser and is used to defer BEST_EFFORT tasks until after the browser has completed startup and the active tab's page has finished loading. The StartupObserver previously failed to detect the case where the browser as launched to the url of a file download; it would then wait for an additional navigation in the first tab or would wait until a failsafe timeout was reached before indicating startup was complete. This change signals completion in the scenario where a file download takes place in the first tab. The failsafe timeout remains set at 3 minutes. Bug: 1006954 Change-Id: Ia1e056f1a54ccc561d1dcf306161470beefe42e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846099Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
David Schinazi authored
Change-Id: I30891b73e8ecdc36e223e2df03d7ae4ae5c8ec16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860476 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#705710}
-
Peter Boström authored
During refactoring in r703138 I forgot to install the new highlight-path generator. Bug: chromium:1013983 Change-Id: If39953bff877bf69066d954d1e7c04b042289636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860152Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705709}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b6acae6d353d..ba9e1ff86fa4 git log b6acae6d353d..ba9e1ff86fa4 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 cwallez@chromium.org Fix compilation in MSVC that was missing a <utility> include Created with: gclient setdep -r src/third_party/dawn@ba9e1ff86fa4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Id6de729831fbe4977bf362c5ccec30117ca0fb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859819Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705708}
-
Jack Lynch authored
This CL adds an axe accessiblity test for the Performance panel Event Log pane. Bug: 963183 Change-Id: Ibd3a63379e6baf65bd6ec7af9787dad620eeff1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721680 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705707}
-
Thanh Nguyen authored
This CL adds a Chrome flag to control the aggregated model search ranker Bug: 1006133 Change-Id: I255f0bf215ec2bb4e52aa3586dbdaf5717caf644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858061Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1c462ebc904c..fb632b91110c git log 1c462ebc904c..fb632b91110c --date=short --no-merges --format='%ad %ae %s' 2019-10-14 digit@google.com [linux]: Remove linux namespace. Created with: gclient setdep -r src/third_party/swiftshader@fb632b91110c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:140419396 Change-Id: I9140d644516ac8de0588312d43df32aee0bfe185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859820Reviewed-by:
-
Brian Sheedy authored
Simplifies the process of running the GPU pixel tests locally by making them attempt to automatically detect if they are being run on a workstation instead of on a bot, as well as automatically determining the build revision. This removes the need to pass either --local-run or --build-revision when running locally. Bug: 1013358 Change-Id: Ie3fd2171d94fa4452b7f334c7bcdd5ab42705414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860677Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705704}
-
Charles Zhao authored
This is the first CL of hindsight which creates the CrOSActionRecorder (1) CrOSActionRecorder is a singleton, (2) CrOSActionRecorder has one public function RecordAction. (3) CrOSActionRecorder writes action history periodically to disk. Bug: 1012936 Change-Id: Ie364e98cc5eb099a5743b27134ec3bc10363d142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846612 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8dda56311c7d..624e60f81111 git log 8dda56311c7d..624e60f81111 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 eseckler@google.com processor: Fix incorrect interned event name lookup Created with: gclient setdep -r src/third_party/perfetto@624e60f81111 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:123864183,chromium:130786981 Change-Id: I20e0a75181886184ded7e7eb34f6fcd4a0ceb1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859824Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1ab0a72d103d..e16ffffc28f3 git log 1ab0a72d103d..e16ffffc28f3 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 erikchen@chromium.org Add logging to bot_update.py and gclient_scm.py Created with: gclient setdep -r src/third_party/depot_tools@e16ffffc28f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1014216 Change-Id: Ifd7c563630ddff64ef151b33371f024bbeddcfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859827Reviewed-by:
-
Lei Zhang authored
Make it more obvious that recursive file deletion, AKA rm -rf, is happening. Add a note that base::DeleteFile(path, true) will be removed eventually, and convert existing callers in base/. Bug: 1009837 Change-Id: I5d2c3d73025653b14a81fb2c8584bd314c792a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832470Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#705700}
-
David Vallet authored
Change-Id: I229fe8012c5ec1c9fac5f540f3d0ed68284adb99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860196Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#705699}
-
Marijn Kruisselbrink authored
This refactors the blob interactions to either be behind a PostTask to the IO thread, or in the case of writes eliminates the direct interaction with the blob system entirely by reading the blob through its mojo interface instead. Also migrates one remaining FileSystemContext call to be behind a PostTask to the IO thread. This, combined with a previous CL, eliminates all code that required running on the IO thread, paving the way for moving most of the native file system API implementation to the UI thread. Bug: 1011534 Change-Id: I8ef3ce97a77efb42bd12b020e98d7c1430ca3292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845914Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705698}
-
Scott Violet authored
BUG=none TEST=covered by various layout tests Change-Id: I13bf6bed0b7e9e2590ad2e8bc21adefcb8438997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860330 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#705697}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e20a46d9..a6ff36bd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I937ee0c93dab7a986faca36b561a8b16edc10be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860156Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705696}
-
Tommy Li authored
Currently, ZeroSuggestProvider adds a verbatim match at the very top so that if the user focuses the omnibox, gets on-focus suggestions, and presses Enter, it triggers a reload. The problem is that ZeroSuggestProvider assumes the verbatim match is a URL, when that is no longer true for both On Focus Query Refinements / Query in Omnibox, as well as ZeroSuggest on NTP. This CL sends the verbatim match through the normal match classification system instead of forcing it to be a URL match. The way it does it is kind of counterintuitive - by no longer passing a reference to the HistoryURLProvider to VerbatimMatch, it will actually classify the text instead of just assuming it's a URL. More cleanups still need to be done, but I'm keeping the CL minimal for now. Bug: 1013271, 963173 Change-Id: I5b01734fcf5c068cc17e4110913c16de8d2824c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854501Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#705695}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a4828a13c27a..7d7aaf46aeb4 git log a4828a13c27a..7d7aaf46aeb4 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 robertphillips@google.com Slim down GrFragmentProcessor::TextureSampler and GrPrimitiveProcessor::TextureSampler 2019-10-14 jcgregorio@google.com Fix usage of depot_tools in containers. 2019-10-14 jvanverth@google.com Reland "Minimal iOS app: Perform present subsequent to flush" 2019-10-14 benjaminwagner@google.com [infra] Retry failed pushes in Android flavor 2019-10-14 mtklein@google.com insist SkPngEncoder's input is initialized 2019-10-14 senorblanco@chromium.org Dawn backend: update to Skia API changes. 2019-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms e9158fd9e492..8c5dee1e7fe2 (4 commits) 2019-10-14 jvanverth@google.com Revert "Minimal iOS app: Perform present subsequent to flush" 2019-10-14 csmartdalton@google.com Allow fullscreen clears when generating blurs 2019-10-14 jvanverth@google.com Remove fake SDK #defines for Metal backend. 2019-10-14 jvanverth@google.com Minimal iOS app: Perform present subsequent to flush 2019-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ed9daeb11a98..e9158fd9e492 (1 commits) 2019-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms a52db47aa53f..ed9daeb11a98 (1 commits) 2019-10-14 robertphillips@google.com Reduce usage of GrProgramDesc::KeyHeader Created with: gclient setdep -r src/third_party/skia@7d7aaf46aeb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:1013368,chromium:None,chromium:1008192,chromium:None,chromium:None Change-Id: I68ce3cf812306bd59ca42f9d6742be8785620c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859821Reviewed-by:
-
chrome://safe-browsingXinghui Lu authored
Screen shot: https://screenshot.googleplex.com/My1OamJqnYy The CL only includes web UI logic, the code that triggers this UI will be included in a follow up CL. Bug: 1013370 Change-Id: I2b785ea711a0c62c9b7fa3c3dcac811307289d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856804 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#705693}
-
Xianzhu Wang authored
The code had a bug that the same transform was dumped multiple times if it was referenced by multiple layers. Also dumping scrollPosition is not meaningful because we rely on transform/scroll property trees for scrolling. Change-Id: I7ca08ecd2db392e5f8a13ed866321b70d6545f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860681 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705692}
-
Kristi Park authored
LocationIconView overrides WidthMultiplier() in order to remove the shrinking animation. However, IsShrinking() will still return true during the shrinking phase due to |open_state_fraction_|, causing GetSizeForLabelWidth() to briefly return a non-offset width. Therefore, call a new function, SetUpForAnimation(), which will only animate the label in. Bug: 1012107 Change-Id: I2757003690d12edd6b24e0ea30d03d4ba622eba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850968 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#705691}
-
Lei Zhang authored
The test times out in a flaky manner on several platforms, so disable them there. TBR=mlamouri@chromium.org Bug: 1014229 Change-Id: I2d030a0e26f207e07f1c9a4e4a9b174e1b46e78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860309Reviewed-by:
-
liberato@chromium.org authored
It seems like CodecImages are sometimes being used for drawing after they have been marked as unused for the MCVD shared image pool. It is likely that this happens when the renderer is torn down before receiving returns from viz (e.g., renderer crash). This CL causes CodecImage to handle these cases gracefully, rather than crash. Bug: 1010621 Change-Id: Ibd25fd13dc477f1702df2b11a3c4ff46413f0f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853113Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#705689}
-
Steven Bennetts authored
Same fix as: https://chromium-review.googlesource.com/c/chromium/src/+/1834203 except for the details dialog. TBR=khorimoto@chromium.org Bug: 1014200 Change-Id: Idc6a7c63ec72995d78dec38497904290197a22f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860874Reviewed-by:
-
Manas Verma authored
Whenever card suggestions are shown, and the user has server cards and is eligible for FIDO authentication, a preflight call is made to retrieve authentication details. Logging the latency of this call. Bug: 949269 Change-Id: I53a9f00c9427ad26906a927e6a2a97bb4bf4f4e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808481 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#705687}
-
Sidney San Martín authored
Bug: 1014155 Tbr: kinuko Change-Id: I073800ae1c4b5494844798d6615e75032d9f100b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860311Reviewed-by:
Sidney San Martín <sdy@chromium.org> Reviewed-by:
-
Lei Zhang authored
TBR=jityao@google.com,voit@google.com Bug: 1014239 Change-Id: Ic49689798f3c44816c537e2bf26c05c702e5a480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859581Reviewed-by:
-
Alexander Timin authored
Also send the event to the RenderFrameHostImpl. In the future we can use this to store the theme_color in the RenderFrameHostImpl instead of doing it in the WebContentsImpl, which will make it easier to persist the color when the page goes into the BackForwardCache TBR=mtklein@google.com Bug: 1001087 Change-Id: Ifdb81f8b7e71f41801b7bb32a8d1544eed9ed302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821903 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705684}
-
Lei Zhang authored
ServiceWorkerTest.FetchFromContentScriptShouldNotGoToServiceWorkerOfPage is flaky. TBR=horo@chromium.org Bug: 1014222 Change-Id: I8571373c1a7478b6719de10f062b9191866041aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860478Reviewed-by:
-
Daniel McArdle authored
New fuzzers are update_client_protocol_parser_fuzzer and update_client_protocol_serializer_fuzzer. Corpuses were generated by taking examples from protocol_parser_json_unittest.cc and protocol_serializer_json_unittest.cc and then minimizing. Bug: 1012898 Change-Id: Iddab1c9158e2886270930e25045b33506bfe166b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850316 Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705682}
-
Asanka Herath authored
Based on Justin Tervay's https://chromium-review.googlesource.com/c/chromium/src/+/1731617 Adds a feature flag to //chrome/common that controls whether the browser process enables FTP support when constructing the network service. The feature is enabled by default. Blink I2D: https://groups.google.com/a/chromium.org/d/msg/blink-dev/e1hkwUL4p3w/11sdjpuMAgAJ Chrome feature status: https://chromestatus.com/feature/6246151319715840 Original-Author: Justin Tervay Bug: 333943 Change-Id: Ib1a79809d733345fc80a47a9a4b5e3ee253771a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860693Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705681}
-
Lei Zhang authored
This reverts commit e0dffd84. Reason for revert: Broke Windows archive bots. (Slightly speculative) https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/6444 https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/6062 Note, the error comes from headless/, where the build config to handle multi-DLL is very fragile. Original change's description: > Set is_multi_dll_chrome to false by default > > This change sets is_multi_dll_chrome to false by default thus merging > chrome.dll and chrome_child.dll to a single dll. This saves disk space > and improves startup performance. It is also consistent with all other > platforms (windows was the only platform the split was enabled by > default). > > Bug: 726150 > Change-Id: Iade2c7f1bbe696d45ebac7483072f7e2e7e84ab4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850272 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705667} TBR=gab@chromium.org,thakis@chromium.org,brucedawson@chromium.org,wfh@chromium.org,chrdavis@microsoft.com Change-Id: I8dd4c4c075c855e1ce68e08c766eab34374ed3e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860903Reviewed-by:
-
Dmitry Gozman authored
This moves history navigation virtual time pauser from RenderViewImpl to Page, which has two benefits: - slimming down RenderViewImpl; - encapsulating virtual time inside Blink. Most of changes are moving virtual time pauser creation from thread scheduler to page scheduler. Bug: none Change-Id: I9fc2683e974e005d8cea35ced0f5f82931215b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856929Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/033004652faf..1ab0a72d103d git log 033004652faf..1ab0a72d103d --date=short --no-merges --format='%ad %ae %s' 2019-10-14 raphael.kubo.da.costa@intel.com Make upload_to_google_storage.py and tests work with Python 3. 2019-10-14 raphael.kubo.da.costa@intel.com Make download_from_google_storage_unittest.py work with Python 3. 2019-10-14 raphael.kubo.da.costa@intel.com upload_to_google_storage_unittest.py: Make StringIO usage Python 3-compatible 2019-10-14 raphael.kubo.da.costa@intel.com Use assertEqual() rather than assertEquals() in Python tests. 2019-10-14 raphael.kubo.da.costa@intel.com Make the queue module work with both Python 2 and Python 3. 2019-10-14 bsheedy@chromium.org git-cl: Add yapfignore support to git cl format Created with: gclient setdep -r src/third_party/depot_tools@1ab0a72d103d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:984182,chromium:1009819,chromium:984182,chromium:1007872,chromium:1009819,chromium:984182,chromium:1007872,chromium:1007872,chromium:1009819 Change-Id: Ic50960cb2c7dc316da056b23942fd2588671367b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860451Reviewed-by:
-
Qingsi Wang authored
Bug: None Change-Id: Ifadf8f15b4a50a16a11d53f6c499636ec0845420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860145Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705677}
-
