- 13 Apr, 2018 40 commits
-
-
Miguel Casas authored
This CL corrects the initialization value of |display_id| from -1 (which is bad) to what it used to have before the CL reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/970085/23/ui/ozone/platform/drm/common/drm_util.cc#b385 The -1 it breaks (at least) amd64-generic-tot-chromium-pfq-informational (see bug). TBR=dnicoara@chromium.org since it's a trivial fix and has been verified. Bug: 832136 Change-Id: I3c1db741979f20877483880b87f2d052b2a02cf9 Reviewed-on: https://chromium-review.googlesource.com/1010517 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550495}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/20586d941c23..d2c34b35c8b1 $ git log 20586d941..d2c34b35c --date=short --no-merges --format='%ad %ae %s' 2018-04-04 cmtice [clang-tidy-builder] Fix some issues with builder not finding logs. 2018-02-28 phobbs cidb: Remove status arg from latest build requests Created with: roll-dep src/third_party/chromite BUG=chromium:831200,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8b28b7da1eaa3ffaf2f4053403ac9c80b5a1e2bf Reviewed-on: https://chromium-review.googlesource.com/1011219 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550494}
-
Yunchao He authored
Removes the suppression for: conformance2/textures/image_bitmap_from_image/ tex-3d-r16f-red-float.html Bug: 679695 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifec56d01e4cf903f827a09a1aa176275912c8f0c Reviewed-on: https://chromium-review.googlesource.com/1010022Reviewed-by:Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550493}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bf1af11228f..130fd7666d42 $ git log 6bf1af112..130fd7666 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:None The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I59c7b196f5cc9369305cb4cdf81e65a96b6e1a7c Reviewed-on: https://chromium-review.googlesource.com/1011559 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550492}
-
Scott Little authored
Bug: 635105 Change-Id: Ic1d61399cf3b1f5aafeed64238c25250849d43a4 Reviewed-on: https://chromium-review.googlesource.com/1011386Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#550491}
-
James Hawkins authored
R=khorimoto@chromium.org, tbarzic@chromium.org Bug: 829039 Test: none Change-Id: I25c885d2bbed34146dc313e2298384e90b00e425 Reviewed-on: https://chromium-review.googlesource.com/1011345Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#550490}
-
Andrey Kosyakov authored
Just moving & renaming classes, no logic changes yet. Change-Id: Ic736feeef5524d6145e1c505fbfa50538b041732 Reviewed-on: https://chromium-review.googlesource.com/1011503Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#550489}
-
Hiroshige Hayashizaki authored
Bug: 827415 Change-Id: Ia1d57357525366f1c07a6fd1d87b4f604072cb7a Reviewed-on: https://chromium-review.googlesource.com/1000720 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#550488}
-
Becca Hughes authored
Update preload=none state based on the new mocks. Also adds ShouldShow[Audio/Video]Controls to MediaControlsImpl to simplify the logic around which set of controls we should show. BUG=818659 No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ide3bed15161aa5e1e1096275212c718eacb24a77 Reviewed-on: https://chromium-review.googlesource.com/993757 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#550487}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: Ia95e37e8d28d41fbf56ece38fedda14da6a64060 Reviewed-on: https://chromium-review.googlesource.com/1009683Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550486}
-
Ian Vollick authored
Too many issues close to branch. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I464cb04328684ff1888821465a394a0c0d983e32 Reviewed-on: https://chromium-review.googlesource.com/1011353 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#550485}
-
Peter Boström authored
More functionality is about to be added into this button so it's no longer appropriate to bundle it into ToolbarView. Doing this as a separate step to avoid large patches. Bug: chromium:822070 Change-Id: I07f690ebeefa29f4ac4177cb59785bab01a56f0b Reviewed-on: https://chromium-review.googlesource.com/1008628 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#550484}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I55f6ffafa1cc11c0199ab9ef9076cbc8b06ffd92 Reviewed-on: https://chromium-review.googlesource.com/1011782Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#550483}
-
Jianpeng Chao authored
This reverts commit 6c5c219b. Reason for revert: buildbot failed Original change's description: > [Extensions] Stop loading manifest v1 extensions > > Manifest v1 extensions have been deprecated for a long time. > Stop loading these extensions unless a special (existing) commandline > flag is present. There are a few straggling tests (which rely on > packaged extension resources, like .crx files) that still need to be > updated; use the commandline flag (or a runtime variant) in those tests. > These will be cleaned up in follow-up CLs. > > Bug: 831909 > Change-Id: If2323829cd75f826d54a34b713eecf7c28973667 > Reviewed-on: https://chromium-review.googlesource.com/1009070 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550426} TBR=stevenjb@chromium.org,pastarmovj@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org,qinmin@chromium.org Change-Id: I5a0a4c7f90421d139dce7cdc27d1affa2059c5a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831909, 832488 Reviewed-on: https://chromium-review.googlesource.com/1011710Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550482}
-
Hiroki Nakagawa authored
This reverts commit fef93a84. Reason for revert: This seems to cause compile failures on multiple bots: https://ci.chromium.org/buildbot/chromium/Win/66061 https://ci.chromium.org/buildbot/chromium/Linux%20x64/62330 Original change's description: > Extensions: Rename DictionaryBuilder::SetBooean -> Set. Same for ListBuilder. > > The overload resolution failure isn't any issue anymore after > https://chromium.googlesource.com/chromium/src/+/723fb47254fc5f49bda577df447303dc3554beb9, > so bool overload can be provided for DictionaryBuilder::Set and ListBuilder::Append. > > Bug: None > Test: Internal only change. > Change-Id: Id55283aeaa8868cf533f206b006c3c909a835df1 > Reviewed-on: https://chromium-review.googlesource.com/1009489 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550475} TBR=avi@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org Change-Id: I90a4d81ee507212f829c85c6aba77334ce3bb97c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/1011763Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550481}
-
Jianpeng Chao authored
This reverts commit e192695d. Reason for revert: Buildbot failed. Original change's description: > [media] VdaVideoDecoder > > This adds VdaVideoDecoder, an adapter that implements the media::VideoDecoder interface using a > media::VideoDecodeAccelerator. VdaVideoDecoder expects to run in the GPU process, with access > to a command buffer stub, as will be the case for decoders created by MojoVideoDecoder. > > VdaVideoDecoder runs on the (mojo) IO thread as much as possible, but the VDA interface is > inherently tied to the GPU thread. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I23f81c92b9ad72a5f0141c2eec2a528de1ffa9d3 > Bug: 522298 > Reviewed-on: https://chromium-review.googlesource.com/940336 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550471} TBR=xhwang@chromium.org,sandersd@chromium.org,liberato@chromium.org Change-Id: I706bf6a9b8b31d430b5facd0151e7e20dc73bcfb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 522298, 832484 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1011709Reviewed-by:
-
Nico Weber authored
We accidentally passed -T to the static archive tool on mac and ios. The static archive tool on mac and ios is not ar but a mac-specific tool called libtool, and its -T flag means something completely different. Bug: 801925 Change-Id: I44dacbb8696cceb26ac7a5de86a2e8a0de638c00 Reviewed-on: https://chromium-review.googlesource.com/1010513 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550479}
-
Jeffrey Kardatzke authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/51c84139d960..7aaece4a0870 $ git log 51c84139d..7aaece4a0 --date=short --no-merges --format='%ad %ae %s' 2018-04-10 derat system_api: Add type field to PowerSource message. 2018-03-16 allenvic smbprovider: Add auth params for MountOptionsProto 2018-04-06 jkardatzke Constants for D-Bus server for opening URLs with Chrome 2018-04-06 timzheng Add D-Bus call to concierge for getting icons. 2018-03-18 claudiomagni Add main mojom files for the ML Service API. Created with: roll-dep src/third_party/cros_system_api R=jkardatzke@chromium.org Bug: None Change-Id: I89147d8d0f92f8968f117789296578db637b8867 Reviewed-on: https://chromium-review.googlesource.com/1011124Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#550478}
-
Helen Li authored
Bug: 821030 Change-Id: Iec0c32ba9cc7cb0335e7c320179e2689ab59bba6 Reviewed-on: https://chromium-review.googlesource.com/957918Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550477}
-
Tetsui Ohkubo authored
Different from the current notification center, UnifiedSystemTray will shrink its area when notifications are removed. UX spec: http://shortn/_U7QSE9nhSk TEST=manual BUG=828752 Change-Id: I5c793d39f88aa81fb7a2fa90366e62fc5dc9af2d Reviewed-on: https://chromium-review.googlesource.com/1011522Reviewed-by:
-
Istiaque Ahmed authored
The overload resolution failure isn't any issue anymore after https://chromium.googlesource.com/chromium/src/+/723fb47254fc5f49bda577df447303dc3554beb9, so bool overload can be provided for DictionaryBuilder::Set and ListBuilder::Append. Bug: None Test: Internal only change. Change-Id: Id55283aeaa8868cf533f206b006c3c909a835df1 Reviewed-on: https://chromium-review.googlesource.com/1009489Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550475}
-
Daniel Nicoara authored
If the output surface is displayed as an overlay plane and there is a video underlay, make the primary plane blend with the underlay such that the transparent video hole in the primary plane allows the video to show. Bug: b/74998539 Test: Ran on device and verified video shows Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I01fd6c325dd2e93f7781fbbf1619bca402998217 Reviewed-on: https://chromium-review.googlesource.com/1005808Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#550474}
-
Erik Luo authored
Around M63, logs from OOPIFs contained invalid scriptIds that led to linkifier failure, preventing users from seeing their logs. A fix [1] landed to make JSPresentationUtils not throw when linkifier fails. This CL adds a test. [1] https://chromium.googlesource.com/chromium/src/+/060e1aacae0500e12dbb746ef4242dc3ec49eadb Bug: 826210 Change-Id: Ie343b7927ee15c0def8fc28723b2d763ecad875a Reviewed-on: https://chromium-review.googlesource.com/1011453Reviewed-by:
-
Bret Sepulveda authored
On Windows the system menu is expected to appear on a single left-click to the top-left corner of the window, and a double click is expected to close the window. The Views window icon added by custom titlebar was intercepting the click and so the WM_NCLBUTTONDOWN message was not getting DefWindowProc'ed. This patch fixes this by disabling event handling on that icon, as it isn't supposed to do anything. Bug: 828429 Change-Id: I1ee0cfe38707479948b51eed48da83639964a7ae Reviewed-on: https://chromium-review.googlesource.com/1011544Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#550472}
-
Dan Sanders authored
This adds VdaVideoDecoder, an adapter that implements the media::VideoDecoder interface using a media::VideoDecodeAccelerator. VdaVideoDecoder expects to run in the GPU process, with access to a command buffer stub, as will be the case for decoders created by MojoVideoDecoder. VdaVideoDecoder runs on the (mojo) IO thread as much as possible, but the VDA interface is inherently tied to the GPU thread. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I23f81c92b9ad72a5f0141c2eec2a528de1ffa9d3 Bug: 522298 Reviewed-on: https://chromium-review.googlesource.com/940336Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#550471}
-
John Rummell authored
Permission check no longer requires the origin, so no need to pass the WebSecurityOrigin to SelectConfig(). BUG=349201 TEST=media_unittests pass Change-Id: I8d5242338b4a93577920e0211112c3ee8eb23790 Reviewed-on: https://chromium-review.googlesource.com/1011456Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Moves out-of-scope initial navigations, which are popups from one of the app's windows, into regular popups without the parent's theme and icon. Bug: 806654 Change-Id: If679a6ecee79068e94975ae317126ac3c05f9ba5 Reviewed-on: https://chromium-review.googlesource.com/1011463Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#550469}
-
Raymond Toy authored
When the context is closing, the nodes that were processing their tails need to be stopped. This disables the output of the node, which might cause other nodes to disable their outputs, and these nodes are placed on |finished_tail_processing_handlers_|. These also need to be handled when finishing tail processing. So loop around processing |finished_tail_processing_handlers_| and |tail_processing_handlers_| until disabling of outputs no longer adds anything to either of these. Bug: 832043, 828826 Test: run-webkit-tests --enable-leak-detection no longer detects leaks Change-Id: I6ca195352b240d343095c208c9b70b0c5553c925 Reviewed-on: https://chromium-review.googlesource.com/1010833 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550468}
-
Steven Holte authored
This will help with migrating off of UkmEntryBuilder, which relies on whitelisted access for recording metrics. TBR=charleszhao Change-Id: If8bc2becedb7bdabd9216e0b03427bb69483f9db Reviewed-on: https://chromium-review.googlesource.com/999264 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#550467}
-
Lutz Justen authored
Enables variable expansion for the NativePrinters policy on Active Directory managed devices. The expansion exchanges ${machine_name} by the Active Directory computer name for all JSON fields. Also supports substrings, e.g. ${machine_name,6,4} = 4 chars from pos 6. Cloud managed devices usually don't have a human-readable device name, so expansion isn't supported yet (although there's a machine_name field in PolicyData that one might use). More variables and policies can be easily added in the future. BUG=chromium:829279 TEST=chromeos_unittests --gtest_filter=VariableExpanderTest.* Set NativePrinters (aka 'Native Printing') policy in Active Directory GPO with display_name = '${machine_name}' for some printer. On AD managed device, get policy from the AD server and print a page. Select printers. A printer with the name of the Chromebook should appear. Also check device name shows up on chrome://policy under NativePrinters. Change-Id: I5fe6185b6bb48bf5d28a7ab4f53be1553fca18b5 Reviewed-on: https://chromium-review.googlesource.com/1001576 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Dan Erat <derat@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#550466}
-
Becky Zhou authored
Add an item in settings to turn on/off contextual suggestions. Bug: 822953 Change-Id: I9533b6afcc21c23ee580e8d7008b6dc3ca1e74d3 Reviewed-on: https://chromium-review.googlesource.com/1006232 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550465}
-
Kenneth Russell authored
If two different test expectations for the same test apply on the current browser configuration, fail hard. This has happened a couple of times already in the pixel test expectations and it has led to confusion. Added verify_all_expectations_unittest which checks for collisions in all of the GPU test expectations subclasses in this directory, taking into account configurations on the waterfall. This is automatically run during presubmit, along with all of the other GPU unittests, to make life easier on developers. Removed expectations for Pixel_CSS3DBlueBox, which should be passing on macOS reliably now. Bug: 533690, 706016, 796558, 830228 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I64a604d38a4b21729cf0e5b969328d2b051bddbb Reviewed-on: https://chromium-review.googlesource.com/1002032 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#550464}
-
Ian Clelland authored
Currently, policy-controlled features do not work as expected in frames with opaque origins, such as isolated sandboxes and data: URLs, because the eventual opaque origin of the frame is not known when the HTMLFrameOwnerElement builds the container policy, and so has no way to tell the browser that a particular origin should be allowed. This CL adds a new member to the ParsedFeaturePolicyDeclaration, which indicates that the iframe policy is expected to apply to the origin of the frame, and is used when that frame has an opaque origin. This can be triggered with an iframe of the form <iframe sandbox allow="feature"> or <iframe sandbox allow="feature src"> This flag is checked when building the feature policy in the new frame, and ensures that the new feature policy will allow the feature in that origin. This is the first part of the eventual solution -- currently this has the effect of allowing the feature even if a sandboxed frame navigates to a new page (causing a new opaque origin to be created for it). Subsequent CLs will add a unique identified to each such origin, and ensure that the generated policies are properly tied to the specific origin of the frame. Bug: 690520 Change-Id: Ie18b9bc3c36be6550baf5a03e355871b9589fd40 Reviewed-on: https://chromium-review.googlesource.com/963382Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550463}
-
Amirhossein Simjour authored
VR supports html select element, so the corresponding page popup doesn't need to be suppressed. Bug: 819876 Change-Id: Iac3cf7fbd7437cce27f3a265e95e3f0eb76c3e2c Reviewed-on: https://chromium-review.googlesource.com/1010782Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#550462}
-
Rouslan Solomakhin authored
This patch adds the ability for implementers of PaymentInstrument interface to determine whether skipping the payment sheet into this instrument should require a user gesture. By default, the user gesture is required for the skip UI flow. Bug: 828427 Change-Id: Id6878c7d0d9bef71da7734d2efec3fd6002fe282 Reviewed-on: https://chromium-review.googlesource.com/1010975Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550461}
-
Yoshifumi Inoue authored
This patch changes "innerText-inline-table.html" to utilize w3c test harness for ease of maintenance. Since pixel differences are not significant of this test, this patch removes entry from LayoutNG test expectation. Change-Id: I958bd07b05bcea49b502261dc7db0fb3e0caed03 Reviewed-on: https://chromium-review.googlesource.com/1009510Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550460}
-
Patrick Noland authored
Add ReportFetchMetricsCallback Plumb a ReportFetchMetricsCallback from proxy through to fetch Add metrics reporting logic in fetch Bug: 830639 Change-Id: Ic278bb7955101b02c3e01d7657339810d9ba9d3f Reviewed-on: https://chromium-review.googlesource.com/1011259Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550459}
-
Jacob Dufault authored
Also rename UserSelectionScreenProxy to UserBoardViewMojo. The backend is a mojo client; the browser-side code should not know that the implementation is in views. Bug: 784495 Change-Id: I1f3933e7191a9be8f1d73720a27c747391763737 Reviewed-on: https://chromium-review.googlesource.com/1008843 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#550458}
-
Steven Bennetts authored
This CL: * Moves pref names used by DisplayPrefs to ash_pref_names.cc * Moves DisplayPrefs to src/ash * Moves ownership of DisplayPrefs to ash::Shell. NOTE: This change causes DisplayConfigurator::SetInitialDisplayPower to be called asynchronously when OnLocalStatePrefServiceInitialized is called. Support for this was added in crrev.com/c/994282. NOTE: This does not move display_prefs_unittest.cc because of a dependency on DisplayConfigurationObserver which needs to be moved separately because it breaks a number of ash_unittests expectations. See crbug.com/831379 for details. For trivial code removal from browser_prefs: TBR=bauerb@chromium.org Bug: 678949 Change-Id: I078a0f52a38f493d592c92b291c53d6815ccf336 Reviewed-on: https://chromium-review.googlesource.com/1003379Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550457}
-
Emircan Uysaler authored
This CL seperates real time video use case from regular video for GpuMemoryBufferVideoFramePool usage. Additionally, it enables the usage on Windows for real time video because the tests showed that GMBVFP is much faster than CreateForSoftwarePlanes() resulting in a reduced latency. Bug: 829524 Change-Id: Icf387eecb3c7240e3ed52b22bff45a6da1f6ac01 Reviewed-on: https://chromium-review.googlesource.com/1003230 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
