GitLab

https://pdfium.googlesource.com/pdfium.git/+log/c3daaa87ec17..5a88d16b87f5


git log c3daaa87ec17..5a88d16b87f5 --date=short --no-merges --format='%ad %ae %s'
2018-11-29 thestig@chromium.org Build pdfium_diff for coverage tests.
2018-11-29 thestig@chromium.org Remove some useless calculations in fxbarcode.
2018-11-29 tsepez@chromium.org Squeeze some more 0s out of wide font names.
2018-11-29 tsepez@chromium.org Squeeze out some 0s from cxfa_node_statics.cpp wide strings.
2018-11-29 thestig@chromium.org Roll third_party/freetype/src/ fb0d66d04..3dd4e76b1 (14 commits)
2018-11-29 thestig@chromium.org Add a pixel test for a CPDF_CMapParser bug.


Created with:
  gclient setdep -r src/third_party/pdfium@5a88d16b87f5

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:909762
TBR=dsinclair@chromium.org

Change-Id: I144d909b776d173a9c24f2ac29bf0dca3fb80ccb
Reviewed-on: https://chromium-review.googlesource.com/c/1355623Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612397}

TBR: sdefresne@chromium.org,sebsg@chromium.org
Bug: 910216
Change-Id: Ia88cb0d9352ac4867921919d98c019c80f80dee9
Reviewed-on: https://chromium-review.googlesource.com/c/1355778Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612396}

... and adjust clients to pass in the proper configuration for that.
Rather than using URLRequestContextGetter-based ChromeAsyncSocket,
which may not always work right with network service on.

Bug: 875032
Change-Id: I3f2c19f35c97d770eb63da94755f9d1d42b58bc9
Reviewed-on: https://chromium-review.googlesource.com/c/1315948Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612395}

The base class convoluted the inheritance structure and it is simpler to
directly derive from InProcessBrowserTest.

Bug: 899777
Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6
Reviewed-on: https://chromium-review.googlesource.com/c/1345244
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612394}

This CL changes the way zombie prefetch items are expired to be based on
an expidation time, 7 days after changing to this state. Before they
would be deleted when a new set of suggestions was received which didn't
include their URLs. That didn't work well with the way the Feed provides
suggestions hence the need for this change.

Bug: 841516
Change-Id: I74c53e491cb6442ad71a2d9a275506677fdf813d
Reviewed-on: https://chromium-review.googlesource.com/c/1351594
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#612393}

Adding egregious glFlush calls fixed this issue when GPU Raster was
going through the command buffer (in issue 863817). Adding a flush
here to see if it will fix the issue.

If this does not fix the issue, then the next steps are to
* Flush in DoRasterCHROMIUM (far more frequent) to see if that fixes
  the issue.
* Add crash instrumentation to see which commands are being issued when
  we do crash.

Bug: 906453
Change-Id: I7d88ea2d74b52751f641faaf8b848e9a1358a770
Reviewed-on: https://chromium-review.googlesource.com/c/1352508
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612392}

$ sed -i s/Feture/Feature/ android_webview/{browser/aw_feature_list_creator.*,lib/aw_main_delegate.cc}

BUG=887468

Change-Id: I531c027f857f35d1dda91684dc2a5b56403dc1e2
Reviewed-on: https://chromium-review.googlesource.com/c/1355940Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612391}

Add a custom ActivityTestRule for DownloadActivity which can turn off animation scales during tests.

Spinner is removed in Download Home V2

Bug: 904030
Change-Id: If00ea1400b17bdbbc49fe2414d0c80a5ec47885b
Reviewed-on: https://chromium-review.googlesource.com/c/1278207
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612390}

This deletes all code supporting the deprecated ServiceTest framework
and also cleans up a bunch of superfluous dependencies on service stuff
around the tree.

TBR=sky@chromium.org

Bug: 906239
Change-Id: I56db6c5a4c1d0ffab1be5dde08692383c424d5b6
Reviewed-on: https://chromium-review.googlesource.com/c/1354507
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612389}

Allows the metric to appear on the dashboard.
We're indexing by form factor because virtual keyboard usage depends
heavily on the form factor.

Bug: 752657
Change-Id: I7d32135c45fee05d86c3ce96b43831cc1ba648e3
Reviewed-on: https://chromium-review.googlesource.com/c/1353043Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612388}

InkDropGestureHandler is now InkDropEventHandler and handles mouse and
gesture events.
https://chromium-review.googlesource.com/c/chromium/src/+/1344262

Bug: 910050
Change-Id: Iab91ca41f100cf3d0ba34b54112bc1fecf49406d
Reviewed-on: https://chromium-review.googlesource.com/c/1355490Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612387}

RenderWidgetHostViewMac explicitly sets NeedsBeginFrames upon startup.
This was setup to address some race condition.

However this is not handled by the browser process when Viz Display
Compositor is enabled. DelegatedFrameHost is spamming debug logs with
NOTIMPLEMENTED messages as a result.

All other paths to this is already checking the Viz status and not
calling in. Once Viz has launched we'll remove this legacy path.

This change updates RenderWidgetHostViewMac to not explicitly set
NeedsBeginFrames upon startup when Viz Display Compositor is
enabled.

Bug: 907246
Change-Id: I9a584c4bedcdb1da897f8155eb151ff63ef3c8b2
Reviewed-on: https://chromium-review.googlesource.com/c/1355479Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612386}

https://swiftshader.googlesource.com/SwiftShader.git/+log/8f20452..a972758

BUG=chromium:904265

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: I6b5a14c70cc6f3324542923b95bf2f1a87b336cc
Reviewed-on: https://chromium-review.googlesource.com/c/1355524Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Nicolas Capens <capn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612385}

Not working on chromium anymore, so probably not interested in doing
any more code reviews.

Bug: none
Change-Id: I5dd7adbba724fb9e33803a2a3478d32c9926506f
Reviewed-on: https://chromium-review.googlesource.com/c/1355128Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612384}

Bug: 906214
Change-Id: I6e8b74c892535143e0d25709e6e170152acaa2e5
Reviewed-on: https://chromium-review.googlesource.com/c/1355337
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612383}

mahmadi@ made a number of codereviews and direct contributions to this
directory. Additionally mahmadi@ is an owner on Autofill on iOS.

Bug: None
Change-Id: I96e269a06691351376644d0c0e984d597dd7a63a
Reviewed-on: https://chromium-review.googlesource.com/c/1354236
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612382}

Simple browser test for time limits that signs in a child user, sets a
LOCK override, and verifies that the screen becomes locked.

Adds test clocks to ScreenTimeController so browser tests can trigger
a variety of scenarios in a deterministic way.

Follow-up tests should expand on this, adding common test helpers to
child_account_test_utils.h.

Bug: 895816
Change-Id: Ibbfff2c20cb8829138fad7a94f7db922742d6b56
Reviewed-on: https://chromium-review.googlesource.com/c/1352031
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612381}

AllowStartingServiceManagerOnly already gates starting the service
manager early in the native code. Make the Java code check the flag
too.

Bug: 899225,899226
Change-Id: Iadc7d03b4e3b559815a72de66ff249f2ad36bbbb
Reviewed-on: https://chromium-review.googlesource.com/c/1318362Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612380}

In https://codereview.chromium.org/2674002, Google code was put into
the third_party/mozilla/NSPasteboard+Utils.h|mm files. This was not
imported code from Mozilla and did not belong there.

This utility code is moved into a Chromium file (with slight
modernization.)

The lawyers have approved this.

BUG=none
TEST=no visible change intended

Change-Id: Icf3a91d10d7d52757b7dd220b2703acf3ff45b4d
Reviewed-on: https://chromium-review.googlesource.com/c/1355525Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612379}

Previously, we used 6 satic methods to render each type of table cell:
3) renderBooleanProperty_
5) renderKeyValueTuples_
2) renderJsonProperty_
4) renderLinkProperty_
1) renderTextProperty_

This CL replaces those static methods with classes:
1) OutputBooleanProperty
2) OutputKeyValueTuplesProperty
3) OutputJsonProperty
4) OutputLinkProperty
5) OutputTextProperty

This refactor serves two purposes:

1) By having an object own the rendered HTML instead of directly injecting it into the DOM, we can later reference and manipulate these cells. E.g.:
  - When filtering, currently, we highlight entire rows if any of the cells contain a match. This change allows highlight the specific cells which matched.
  - Currently, when the user toggles `show details`, we must re-render the entire table, because we have no way of retrieving cells and toggling their visibility after we render them. This change allows toggling cell visibility after they've been added to the DOM, and, therefore, avoiding the re-rendering.

2) Supporting more intensive cells without relying on a network of static helper functions.
  - Currently, JSON content is stringified and displayed as text. This change allows more elegant, colored, tabular display of JSON property.
  - Currently, boolean cells have values true & false, making it hard to search for a specific column value. This would change allows filtering; e.g. 'is bookmarked'.
  - Currently, our cells contain mostly single text values. This change makes it easier to display multiple properties, images, and other formatted content in cells.

Bug: 891303
Change-Id: I89d75798943e135cda53a898a4b8c1f26dd869a1
Reviewed-on: https://chromium-review.googlesource.com/c/1354308
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612378}

This creates a basic FileOperations interface for use with file
transfers that should be relatively straightforward to proxy over IPC.

It also creates a ThreadedFileOperations implementation of the
FileOperations interface using FileProxy, which will eventually replace
FileProxyWrapper. This implementation should be platform agnostic. A
future CL will add an IpcFileOperations implementation for Windows, which
will proxy operations from the network process to a ThreadedFileOperation
instance in the desktop process.

Bug: 679313
Change-Id: Ic7d6ce35f498e469f86f9ed7a8fbcc8bd0cafda9
Reviewed-on: https://chromium-review.googlesource.com/c/1325213Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612377}

Adjust the permissions packing code in the chrome.permissions extension
API to include scriptable hosts, as well as explicit hosts. This will
result in permissions.getAll() returning origins that are specified in
the content_scripts section of the manifest, in addition to the hosts
specified in the permissions key.

Update tests for the same.

Bug: 889654
Change-Id: I5dba0bc225bdcb30b969f48f9405f92b1ec8bd58
Reviewed-on: https://chromium-review.googlesource.com/c/1347441Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612376}

TBR=dtseng@chromium.org

Bug: None
Change-Id: I44586a8093970ece1ffe7a4e42171c594af38ab6
Reviewed-on: https://chromium-review.googlesource.com/c/1355605
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612375}

https://helpx.adobe.com/security/products/flash-player/apsb18-44.html

BUG=412078
TBR=jschuh@chromium.org

Change-Id: I515c0945b0191056022e00ae9b1a79869b3471f2
Reviewed-on: https://chromium-review.googlesource.com/c/1355608Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612374}

We now will group tile quads with different SharedQuadStates.

This is done by using per-image alpha in experimental_drawImageSetV1 and
by applying the matrix and scissor to the rendered rectangles when the
transform is positive scale and translate.

Bug: 811523
Change-Id: If9f5f7fe045b7e0170159a90c1694e664a569ae8
Reviewed-on: https://chromium-review.googlesource.com/c/1352669Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#612373}

There are certain requirements wrt. how sync should behave when a tab
is closed. This patch introduces the first related integration tests,
which reflect current behavior and most notably include the need to sync
history for navigations issued immediately before closing a tab.

Bug: 882489
Change-Id: I255a5082f4a75a24d91ef4be443324094427bd1e
Reviewed-on: https://chromium-review.googlesource.com/c/1355127
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612372}

This CL adds the required pathways to support double-tap-zoom for OOPIF.

1) Modifies WebFrameWidgetImpl to get the box_bounds of the double-
   tapped element, and
2) sends the tapped point and box_bounds to the browser, where
3) RenderFrameHostImpl transforms them into root-view coordinates, and
4) sends them to the renderer via the main-frame's RenderViewHostImpl.
5) From there RenderViewImpl invokes WebViewImpl's
   AnimateDoubleTapZoom.

Bug: 734209
Change-Id: Ic55afb6154356d676872ced93f64a243190cf289
Reviewed-on: https://chromium-review.googlesource.com/c/1298081Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612371}

R=drubery

Bug: 867518, 750327
Change-Id: Id6ce3502a99a19767d0056a30cf626bc825ff56d
Reviewed-on: https://chromium-review.googlesource.com/c/1355134Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612370}

The proxyType string should be handled case-sensitively in W3C mode.
Resolves 2 WPT test failures in
webdriver/tests/new_session/invalid_capabilities.py.

Bug: chromedriver:1997
Change-Id: If931b4d1d982aae8646e9b5783cbf7ee52fa4b60
Reviewed-on: https://chromium-review.googlesource.com/c/1355437Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612369}

Such that the tests no longer depend on BleConnectionManager.

* Remove as much simulation using dependent objects as possible.
* Directly call methods under test.
* Remove irrelevant tests.

R=khorimoto@chromium.org

Bug: none
Test: ConnectTetheringOperationTest.*
Change-Id: I7f6c69e90dfe2f4d3006067de92db0973486c4d4
Reviewed-on: https://chromium-review.googlesource.com/c/1351478
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612368}

GetCatalogTask execution.

Bug: 908476
Change-Id: I5459d7fdfe8e5eaf2cd9c42e39c1606710cec838
Reviewed-on: https://chromium-review.googlesource.com/c/1355489
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612367}

Extensions.BackgroundContentsServiceStartupTime has expired. Stop
recording it and mark it as obsolete.

Bug: 878109
Change-Id: I7701d2320b61d57f367b28fe61fc95cd3db738d9
Reviewed-on: https://chromium-review.googlesource.com/c/1354577Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612366}

This is to prevent failures like https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel/141038

I'm tired of playing catch-up with all the additional gtest args we
keep adding to test retries.

Change-Id: I86e1180b62a8f47264c47c0bcb8c2d24a589928d
Reviewed-on: https://chromium-review.googlesource.com/c/1353996Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612365}

Once a local profile enters a synthetic trial for on-boarding, it will
remain in it forever. This is not a problem because local profiles
should not be running the on-boarding process more than once. If a user
creates a new profile, it will be assigned into a synthetic trial based
on the experiment at the time of onboarding.

Bug: 874153
Change-Id: I4f3b9aea39e75fd01ae7dabd7895ea8aa00e633a
Reviewed-on: https://chromium-review.googlesource.com/c/1344990
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612364}

https://chromium.googlesource.com/webm/libvpx.git/+log/615922dfb531..932f8fa04dc1

$ git log 615922dfb..932f8fa04 --date=short --no-merges --format='%ad %ae %s'
2018-11-29 marpan vp9-svc: Add num_encoded_top layer counter
2018-11-28 marpan vp9: Fix condition for disabling noise estimation
2018-11-28 jianj vp9 denoiser: force copy block when last not a reference.
2018-11-27 jingning Remove ineffective condition from rc_pick_q_and_bounds

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: Ieeb11b4d376312700c558aa9ecc6ecae6ac9db76
Reviewed-on: https://chromium-review.googlesource.com/c/1355432Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Marco Paniconi <marpan@google.com>
Cr-Commit-Position: refs/heads/master@{#612363}

1. use ResourceResponse::ExpectedContentLength to get image file size.
2. merge image policy violation check into one place.
    Note: ValidateImagePolicies will later be called through the
    pipeline described in here:
https://docs.google.com/document/d/1B_GnzEItUXsUUQXtB1zMiiov86_U1BCFo1F8g5F_yOY
    to unload unoptimized images as early as possible.


Bug:910195

Change-Id: Iab2fc2fee4f2963c308ca1cc585259021a86b3f2
Reviewed-on: https://chromium-review.googlesource.com/c/1355330
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612362}

WelcomeBackStandardNoPolicy and UpdateWithTwoProfiles were disabled
because they were falky on Linux. After some minor fix, they are now
ready to be re-enabled.

BUG=379579

Change-Id: I2e2a79761b4ab6e0f5c9fb18daa3ae80ed9c282a
Reviewed-on: https://chromium-review.googlesource.com/c/1354681Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612361}

The current Perfetto backend splits _COMPLETE trace events into
separate _BEGIN and _END pairs, as it's not very feasible to modify
existing events after they're written into the Shared Memory Buffers.

This is causing some issues with the trace-viewer which has some
assumptions about the ordering of begin/end events vs. async events,
and is also bloating the sizes of traces and adding extra
overhead for the perf infra.

Instead, we now keep the _COMPLETE events in an internal stack in
TLS and only emit them when we have their duration.

R=eseckler@chromium.org,skyostil@chromium.org

Bug: 909728,888558
Change-Id: I80e37264de66d8bbcb6c9095d21047957fd6eb9f
Reviewed-on: https://chromium-review.googlesource.com/c/1354503
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612360}

This went through a couple of simplifying revisions, however this now
simplifies where we calculate if an inline level box can contain
something that is out of flow.

There is also a couple of small fixups left over when I was simplifying
this code.

Bug: 636993
Change-Id: I5b660df11ff26d3a7aaf72fdd087a13be65739cf
Reviewed-on: https://chromium-review.googlesource.com/c/1351262
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612359}

TODO: Currently a mouse click on any windows outside (e.g. chrome browser
      window, feedback window) will be recorded as kUnspecified instead of
      kOutsidePress for Assistant exit point. A further investigation is
      needed to figure out how to solve this.

Test: local compile and manually test.
Change-Id: Ic616a9704a89d40e8f07e0ce20e6669b5976ec76
Reviewed-on: https://chromium-review.googlesource.com/c/1324850
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612358}