- 09 Sep, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium b89dec94. With Chromium commits locally applied on WPT: 9d7721df "Strip the fragment directive and update scroll-to-text WPT" ae8fff2b "Fix duplicate value of client hint headers on asynchronous validation requests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I97e0317e442bf6cc26014815ddc1a46bf0d463a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792848Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694812}
-
Hitoshi Yoshida authored
A Web IDL file idb_transaction_options.idl contains an invalid extended attribute [inline_doc]. This CL removes the attribute, and have no behavior change. Bug: 999690 Change-Id: Ia297d5ddf568a617640d363d1f1dda857e11b814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792215Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#694811}
-
Andrii Shyshkalov authored
This is to ensure that CQ's default can be switched to "cancel" for all other projects w/o affecting (negatively or positively) chromium. R=martiniss Bug: 959436 Change-Id: I25be0b99ad179a3847c141056beb295ec1c7ca88 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791901 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#694810}
-
Friedrich Horschig authored
When talkback is turned on, there would be a deferred focus event. This triggered hiding autofill suggestions which is wrong for the keyboard accessory. This CL ensures that the keyboard accessory relies fully on its own logic to decide when to hide autofill suggestions. Bug: 969202 Change-Id: I88d2c1456990d4e4ed8e292d37b7c8eb10d29797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790889Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#694809}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26505d54..03038a48 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icce3a596b6ce518ec4cad790fa0cb0f346cfb7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792847Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694808}
-
Richard Knoll authored
This replaces the default animation, slide-in from right to left, with a custom one that slides in the device list only from the bottom. Also used the correct background color instead of hardcoding white to support dark theme. Bug: 1001104, 1001550 Change-Id: Icffa16ea07250bf0f34ef1c8be2a5f6ff4b1db37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789239Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#694807}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: Id6dfbd2c58e76f01c45975f767ccffd24b51a945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790888Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694806}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e67138c9836d..a0b94071e6bd git log e67138c9836d..a0b94071e6bd --date=short --no-merges --format='%ad %ae %s' 2019-09-09 primiano@google.com Merge "Fix chrome roll: update protoc host toolchain rules" 2019-09-09 primiano@google.com Clean up headers dependency on inode file scanner 2019-09-09 primiano@google.com Add benchmark for PacketStreamValidator 2019-09-09 primiano@google.com Merge "generators: Remove dependency on protos strutil.h" 2019-09-09 primiano@google.com Merge "Make trace_processor a host-only target" Created with: gclient setdep -r src/third_party/perfetto@a0b94071e6bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:140126865,chromium:132880619 Change-Id: Ic05aac584d2ccd16025cfac304ffa1e204f9ec13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694805}
-
Andrew Xu authored
In new specs, we only add the end padding under tablet mode. Bug: 973481 Change-Id: I1e4c8d52dba19b7951495d7e562fa30b4dd065f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790738Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#694804}
-
Tao Bai authored
This reverts commit 9e9cf806. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable AwContentCaptureTest#testSingleFrame() due to flakiness > > TBR: ntfschr@chromium.org > Bug: 1001499 > Change-Id: I9bcd4dd17b46485c9ff0ac788438059fcd281a39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791153 > Commit-Queue: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694740} TBR=msramek@chromium.org,ntfschr@chromium.org Change-Id: I56ca855a00fc89cd4cb816cc1e8a7b7b7b938ed1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792454Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#694803}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.IDBFactory interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I85739fd95ecca31f9ac20757bd53c5ccdf42d12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776021 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#694802}
-
Jacob DeWitt authored
Send the full head-from-eye transformation matrix that includes both the offset and rotation through mojo from the device process to blink. Previously, the transformation matrix was constructed only from the offset component. There aren't WMR headsets yet with significantly angled screens, but this change should make them compatible if any are made in the future. Bug: 980791 Change-Id: I1ae4bc43ee31e4e0203252a1ce1924a1fb2194c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790467 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#694801}
-
Dominic Farolino authored
This CL introduces a new |preload_header_token| member to ResourceResponseInfo; it optionally holds an UnguessableToken set by the PrefetchURLLoader on cross-origin-main-resource prefetch responses. The response and token are sent to the renderer, and passed to PreloadHelper. PreloadHelper associates this token with link header preload ResourceRequests, via a new |preload_header_token| member on ResourceRequest. The preload headers are then marked as prefetches, and sent to the PrefetchURLLoaderService. The service re-associates the token with the parent prefetch's NetworkIsolationKey, so that the preloads are fetched with the correct NetworkIsolationKey, and can be reused by the destination origin. Bug: 939317 Change-Id: I6a589846b804fcb9b90f7b7bb381808f860cca4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772896Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#694800}
-
Moe Ahmadi authored
Adds a new feature and a chrome://flags entry to control the zero-prefix suggestions in NTP Realbox. This allows omnibox::kZeroSuggestionsOnNTP to be used for zero-prefix suggestions in omnibox on Desktop. This is more consistent with how the feature is used on Android (including its flag's description of what it does). Bug: 996516 Change-Id: Ib578be22fbe1703b5e3a213328eb31994c9056cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786251Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694799}
-
Roman Sorokin authored
Bug: 1001455 Cq-Depend: chromium:1782809 Change-Id: I290bab94267ea7106c3e8f2130b9b52791df5fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791149 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#694798}
-
Tetsui Ohkubo authored
On sarien device, lock key has VKEY_SLEEP. As ARC does not expect VKEY_SLEEP to be delivered, it enters bad state after receiving it. (See #1 of the bug.) Similar to VOLUME_UP/DOWN and POWER, SLEEP key should be considered as a system key, and should not be forwarded to ARC. In the long term, we may have to fix ARC side as well. This is M77 ReleaseBlock-Stable. TEST=manual(On sarien device, open Play Store and press lock key. Close and open Play Store again, then Close and open Play Store again and confirm it confirm it works as intended.) BUG=b:140127435 Change-Id: I9e238b39dd283fd4148cdafeff2da05adde8dda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792213 Auto-Submit: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#694797}
-
Alison Maher authored
This change moves forced colors web tests to external/wpt. Having separate reference files in wpt is not possible, so the tests are written assuming the virtual flags are used, with the expectation that the tests will fail in the non-virtual case. Tests that used layout test APIs, such as testRunner and internals, were not able to be moved to external/wpt and remain in fast/css. Bug: 970285 Change-Id: Id7410f7d4e9f009e848807b811611051320f23ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789923 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694796}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /net. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. Edit: Reverted unintended changes to http_network_transaction_unittest.cc R=mattm@chromium.org Bug: 891670 Change-Id: Id402d28fb6411eab633d6697da771e5f7baab079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786849 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694795}
-
Roman Sorokin authored
Put it behind a Feature. See bug for the instructions Bug: 999090 Change-Id: I3674ad57a5b3f10f5abe2e1eb52aa75401551a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782809 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#694794}
-
Pâris MEULEMAN authored
This moves clients of SigninManager.isSignedOnNative to IdentityManager.hasPrimaryAccount. Bug: 934688 Change-Id: Ifbcc4c5647f4d2ea1dfd4197e35e136cf1d94fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742346Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694793}
-
Adithya Srinivasan authored
Disable tests on ASAN. Bug: 1001421 Change-Id: Id6060b463e07d2e7c97bde31d25eb65392f39135 Tbr: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791535Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#694792}
-
Pâris MEULEMAN authored
SigninManager uses IdentityManager's observer (onPrimaryAccountSet/Cleared) through IdentityManager.java instead of signin_manager_android. Bug: 934688 Change-Id: I037906b6c59254a9c205d615284c503af268ecd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751245 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694791}
-
rajendrant authored
Image with 0 height in sub-pixel layout is a special case for intersection observer that causes it not fire. This CL adds a test for that. Bug: 999019 Change-Id: I3b95a46eebcc534a22af42dc9c47f2d40a201606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780060Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#694790}
-
Ali Juma authored
This adds the file as an EG2 target, and updates #includes. This also adds a displayTitleForURL method to ChromeEarlGrey and ChromeEarlGreyAppInterface. This provides the functionality of web::GetDisplayTitleForUrl. The logic of parsing a URL in this manner cannot be moved to the test process, since it depends on app-process-specific logic; for example, it depends on ChromeWebClient::AddAdditionalSchemes for registering the "chrome:" scheme in order to correctly parse chrome:// URLs. Bug: 987646 Change-Id: I2ef13336dae4dad1b9a774713c35f8c08e680233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790602Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#694789}
-
Koji Ishii authored
This patch adds a quirks for atomic inline+nbsp defined in CSS Text, saying: > for Web-compatibility, introduces a soft wrap opportunity > between itself and any adjacent U+00A0 NO-BREAK SPACE > character. https://www.w3.org/TR/css-text-3/#line-break-details This is resolved at: https://lists.w3.org/Archives/Public/www-style/2015Mar/0187.html > zcorpan: I checked httparchive for nbsp before/after an > image, and there were 16k matches. About 130k pages in the > set, so about 12% of all the pages match the query. Bug: 993893, 1001793 Change-Id: I24c30b43f282c2005abccf5be4de68262875b87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792465 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#694788}
-
Koji Ishii authored
This patch fixes NGLineBreaker not to go to an infinite loop when `break-word` and `nowrap` appear in specific combinations. Bug: 1001359 Change-Id: I0fb282e96eb29cd65033232329aaa5dc5be3da49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792040 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#694787}
-
Takuto Ikuta authored
This is preparation of OS upgrade. Bug: 1002055 Change-Id: Ica90a0b953fa0dc4a5b9822ade28884a018b1fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792663 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#694786}
-
John Delaney authored
Add a constructor to TestNavigationObserver that takes a target net:Error, and will wait until a navigation with that error finishes. This simplifies the testing of error pages in the browser process. Prevents racing with other navigations when registering an observer for an error. This is a precursor to crrev.com/c/1783300 which introduces tests that have many subframe navigations which eventually cause an error page to load. Change-Id: I7ad301c1d4999e79b6590cd4d5d2d4dccaf3aeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789427Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#694785}
-
Scott Violet authored
No functional changes, just fix ordering. BUG=none TEST=none TBR=jam@chromium.org Change-Id: I829b10760523f9e4d059912a769e9476417ae7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790761Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#694784}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ee3d995091da..2aaf66e4644a git log ee3d995091da..2aaf66e4644a --date=short --no-merges --format='%ad %ae %s' 2019-09-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 82910f73..75cf3925 (694601:694706) 2019-09-09 perkj@webrtc.org Check input parameter in RemoteEstimatorProxy::IncomingPacket without lock Created with: gclient setdep -r src/third_party/webrtc@2aaf66e4644a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:NONE Change-Id: I28cce11ae4a3d7d51b2578bf3088505b67ff67fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792445Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694783}
-
Robbie Gibson authored
Bug: 1002077 Change-Id: I24b4209c99ae56e1e8aa3671aa89d6642511b7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790110Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#694782}
-
Adithya Srinivasan authored
Disable test on chrome os. Bug: 1002066 Change-Id: Ie8306b18777ed33dee10e6bf8c9f1f9d61b0328f Tbr: pmarko@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793004Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#694781}
-
Jonathan Backer authored
Each call to SharedContextState::MakeCurrent takes about 1% of CPU time in RendererPerfTest/1.TextureQuads5x5. These calls are on the fast path with context virtualization (e.g. time is mostly from eglGetCurrent). We always call CopyOutput or SkiaSwapBuffers right after drawing to the framebuffer. This CL defers the draw on GPU main until one of those occurs to eliminate a MakeCurrent call. Bug: 974359 Change-Id: I0047318ddb04dbe81d14065e40685269c2db3272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787356 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#694780}
-
Koji Ishii authored
This patch will prevent crashes in |HarfBuzzShaper::ShapeSegment| probably caused by |ShapingLineBreaker| or |ShapeResult|, but I could not come up with a good explanation how this happens. A case I looked at was LTR Arabic, trying to break a |ShapeResult| for range 0-28. When we found a break opportunity at 20, |last_safe| becomes 25. Shaping a range 25-20 causes OOM in |HarfBuzzShaper::ShapeSegment| because start > end. Checked if any possibilities to accidentally move |last_safe|, and possibilities where |ShapeResult::CachedPreviousSafeToBreakOffset| can return larger value than the given argument, but could not find how it computes such value. This is a speculative fix. Bug: 1000560, 1002061 Change-Id: Ieb9c2c988b5a116a49d5de407d1c269106c52dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787026Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694779}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/78fb80a2b328..73b8376b302a git log 78fb80a2b328..73b8376b302a --date=short --no-merges --format='%ad %ae %s' 2019-09-09 ethannicholas@google.com Fixed skslc assertion failure discovered by fuzzer 2019-09-09 brianosman@google.com Remove legacy flag: GrContextOptions::fDisallowGLSLBinaryCaching Created with: gclient setdep -r src/third_party/skia@73b8376b302a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Ic3f4a8bbc8b88cdf083591e080543dbfcecd7e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694778}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f5102cee4165..4273c0b00841 Created with: gclient setdep -r src-internal@4273c0b00841 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I31386ba6604c86fea2f616889f29894bd054d2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792446Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694777}
-
Peter Boström authored
Bug: None Change-Id: I4b552e6c712efaf31bbdf184e9b2d2ec5c9ecdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789682Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#694776}
-
Dave Tapuska authored
Keep the lifecycleState on the client but remove the ability to filter. Spec change: https://github.com/WICG/page-lifecycle/pull/39 BUG=968417 Change-Id: I0dcfd6bfee0746e5a405f82d6a3009a663ec7a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789693Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#694775}
-
Fredrik Söderquist authored
Seems like that these flakes aren't platform dependent. Tbr: schenney@chromium.org Bug: 1001936, 1002046 Change-Id: Ie62882630c56e72e5edcbb6e4a8003da703dd38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790109Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#694774}
-
Anton Bikineev authored
Before this CL the rules for GarbageCollectedFinalized were diverging from standard C++ std::is_trivially_destructible because heap collections had a destructor that would be ignored because the classes were not required to be GarbageCollectedFinalized. After the CL, std::is_trivially_destructible can be used as replacement for GarbageCollectedFinalized. Benchmarks (blink_perf.dom, blink_perf.bindings, speedometer) show no regressions. Bug: 990913 Change-Id: I62de9fd28238ea02ee440f3244007f1d26a97b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742147 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#685557} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789809 Cr-Commit-Position: refs/heads/master@{#694773}
-