- 21 Jul, 2017 40 commits
-
-
pkotwicz authored
BUG=734131, 734136 Review-Url: https://codereview.chromium.org/2962783004 Cr-Commit-Position: refs/heads/master@{#488641}
-
tzik authored
The wrapper function is no longer useful as WTF::Bind no longer needs explicit unbound parameter types. Change-Id: I64e00f1065ce397b1491c71470a62801208f530c Reviewed-on: https://chromium-review.googlesource.com/580452 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#488640}
-
Bernhard Bauer authored
Bug: 718925 Change-Id: Ie11a88d9864bf6e4a4e85f7dc15c4e4e01bb00fe Reviewed-on: https://chromium-review.googlesource.com/574856Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#488639}
-
Alex Clarke authored
It shouldn't be quoted. Bug: Change-Id: Ie0bbc1cc3ce9c4807f0465da93642939a72120b1 Reviewed-on: https://chromium-review.googlesource.com/578333 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488638}
-
Gustavo Sacomoto authored
Bug: 741709 Change-Id: I7ecf2621d51b6ddb1824608007f3b20514652d6b Reviewed-on: https://chromium-review.googlesource.com/576040 Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#488637}
-
Justin Schuh authored
Disables the __builtin_adc intrinsics on GCC. Bug: 746420 Change-Id: I1b16eaba85ca93c2d04dc25755565cd9e0386320 Reviewed-on: https://chromium-review.googlesource.com/580787Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#488636}
-
Olivier Robin authored
This reverts commit 1cb215be. Reason for revert: Problem should be fixed. Reenable tests. Original change's description: > Disable SigninInteractionControllerTestCase EG tests. > > Those tests are consistently timing out on iPad, disabling them > on iPad until the root cause is fixed to turn the bots green. > > Bug: 745798 > Change-Id: I5f0dab981cae4fbef9f81d144ffa0492a16cfa12 > Reviewed-on: https://chromium-review.googlesource.com/576171 > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487506} TBR=sdefresne@chromium.org,jlebel@chromium.org Change-Id: I5ea0342aa4b6d0c2b1227e52c4f0c0f272695d63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 745798 Reviewed-on: https://chromium-review.googlesource.com/577542Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#488635}
-
Ondrej Skopek authored
Reverting the revert that supposedly broke waterfall tests here: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44127/. However, successive builds: * https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44128/ * https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44129/ passed *without* containing the revert commit, which means our original commit most likely was not the root cause of the broken tests in the first place. Original CL: https://chromium-review.googlesource.com/c/567925/ Original change's description: > Pin the Home Page Tile to the first row in the UI. > > Calculates the number of columns tiles are layed out in > at initialization and reorders the home page tile so that > it is pinned to the first row. > Follow-up issue: https://crbug.com/746274 > > BUG=732913 > > Change-Id: Ieeddf88e8262827c7a22787230c386fe3b43cc17 > Reviewed-on: https://chromium-review.googlesource.com/567925 > Commit-Queue: Ondrej Škopek <oskopek@google.com> > Reviewed-by: Chris Pickel <sfiera@chromium.org> > Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488203} BUG=732913 Change-Id: I359fdb6ca03a31626b41626e01731f2970bcb454 Reviewed-on: https://chromium-review.googlesource.com/579907Reviewed-by:
Chris Pickel <sfiera@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Ondrej Škopek <oskopek@google.com> Cr-Commit-Position: refs/heads/master@{#488634}
-
Ramin Halavati authored
Three fields in traffic annotation proto are updated and all fomer annotations required update. In proto3, we cannot specify default value for fields. Enum fields get their first choice by default and boolean fields get false by default. This way if one does not specify the value for one field, we cannot distinguish it from the case that the default value is given as input. To overcome this problem, the semantics::destination field and policy::cookies_allowed are updated. Also an extra field named comments is added for possible extra required human readable comments. Bug: 656607 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ib6ac74f2abafb16e18283f1b2559f866f0539eea Reviewed-on: https://chromium-review.googlesource.com/579188 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#488633}
-
Nicholas Verne authored
static methods previouly in WebViewImpl.cpp are now available in WebViewBase.cpp. These classes will eventually merge and the schism will be repaired. Usages of base::SingleThreadTaskRunner in WebLocalFrameImpl are replaced by the alias in platform/WebTaskRunner to satisfy our PRESUBMIT. Bug: 712963 Change-Id: I76ba9b1d7f15180b8d2dfeaed8cdc93ff9ac091f Reviewed-on: https://chromium-review.googlesource.com/577429 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#488632}
-
Peter E Conn authored
Make the render tests fail if the rendered bitmap does not match the golden. Bug: 641973 Change-Id: I432111296893bafab18dc65bfb62b12a8212d68e Reviewed-on: https://chromium-review.googlesource.com/565399 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Daniel Bratell authored
A variable wasn't given the right name inside the ATK support when a patch consolidated 3 AX properties into single restrictions property for accessibility objects. R=aleventhal@chromium.org, jochen@chromium.org Change-Id: I0c82e055e39614110cfc4f7a7299d226bd4e6ad2 Reviewed-on: https://chromium-review.googlesource.com/580927Reviewed-by:
-
Olivier Robin authored
This check was initially added to avoid overscroll actions on the terms page of FRE. But the terms page does not use BVC at all and is presented by the WelcomeToChromeView, so the check is not needed. Bug: 746415 Change-Id: I30c74c0283dc63a88d8233287cf130af70e84ab2 Reviewed-on: https://chromium-review.googlesource.com/580929Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488629}
-
Kent Tamura authored
Change-Id: I4709561d23a03bb4e76219a99520541ad17ec927 Reviewed-on: https://chromium-review.googlesource.com/580177 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#488628}
-
Yoshifumi Inoue authored
Move same conditional expression of while-statement AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries() to a function This patch moves same conditional expression of while-statement in |AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries()| into |IsNonEditableContentInsideTheSameLowestEditableAncestor()| to share code and simplify if-statement for improving code health. This patch is similar to the patch[1]. [1] Tree is open (suspected flake, https://crbug.com/743069) Reply More Move same conditional expression AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries() to a function Change-Id: I3662b9bcc78add3c465987b370bde82e7b38008f Reviewed-on: https://chromium-review.googlesource.com/580114 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#488627}
-
Koji Ishii authored
HarfBuzzShaper calls ShapeResult::InsertRun() for each run RunSegmenter segmented. This patch fixes ShapeResult::InsertRun() to compute ShapeResult::glyph_bounding_box_ when there are more than one run. Before this fix, it computes glyph bounding box of each run from (0,0) then unite all bounding boxes. So if input text is "englishARABIC", RunSegmenter creates 2 runs and each InsertRun computes: Run 1: "english", width 70, bounding box (0,0,70,10) (x,y,w,h) Run 2: "ARABIC", width 80, bounding box (0,0,80,10) then the united result would be (0,0,80,0) while the total width is 150. This patch fixes InsertRun() to compute bounding box from the current point, so that: Run 1: "english", width 70, bounding box (0,0,70,10) Run 2: "ARABIC", width 80, bounding box (70,0,80,10) and the united result would be (0,0,150,0). This patch also removes incorrect fix made to ShapeResult::CopyRange(). This was done to pass tests in a previous CL[1], but turned out that the original glyph bounds is incorrect and the fix was wrong. [1] r487410, https://chromium-review.googlesource.com/c/574508/ BUG=746904, 636993 Change-Id: Iec147e5e9b9853a60489e23355ede730ce918c36 Reviewed-on: https://chromium-review.googlesource.com/577970Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#488626}
-
arthursonzogni authored
In content/, this CL replace every renderer-initiated navigations started with TestRenderFrameHost::SimulateNavigationStart() with a navigation using the NavigationSimulator. Bug: 728571 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Change-Id: Ibe7bf13c645d202af1a7bb1dd9aecdc20a50d288 Reviewed-on: https://chromium-review.googlesource.com/574865 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#488625}
-
Jérôme Lebel authored
If the setting view controller is being reloaded while being dismissed, a new SigninPromoViewMediator is created. This new one is not properly released. -[SigninPromoViewMediator signinPromoViewRemoved] has to be called before dealloc. stack trace: -[SettingsCollectionViewController loadModel] ... -[SettingsCollectionViewController didFinishSignin:] ... -[SigninInteractionController cancel] -[SettingsCollectionViewController settingsWillBeDismissed] ... Bug introduced with crrev.com/2883093002 DCHECK introduced with crrev.com/c/567923 Bug: 747121 Change-Id: Ida6847e0942c5145ddc8fbd6c4681bfcc87a8904 Reviewed-on: https://chromium-review.googlesource.com/580408 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Daniel Vogelheim authored
This introduces a separate task queue for 'control' loading tasks. That is, very short task used to coordinate work between different loading tasks. These are scheduled separately as these tasks would typically unblock other, larger tasks. Bug: 557466 Change-Id: Id2de6b73f24e550fe00efa19f4c898866ed0a1cb Reviewed-on: https://chromium-review.googlesource.com/500147Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#488623}
-
Felix Ekblom authored
This CL will reland / revert revert 2 commits and add a non-Mash guard for listening to DeviceDataManager. A TODO has been added about using InputDeviceClient in Mash, but it's not super urgent as the reaction to the event is a NOP in Mash further down the call chain. Revert "Revert of Remove confusing keyboard test & focus on input device" commit 8a2f3aa1 Revert "Revert "Listen to changes to touch input devices"" commit 0cd134a5 Bug: 738885 Change-Id: Ic805ca3966df2969d8444b2c441eac24f75dce62 Reviewed-on: https://chromium-review.googlesource.com/575138 Commit-Queue: Felix Ekblom <felixe@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#488622}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4d02e904b015..89e6562f31f2 $ git log 4d02e904b..89e6562f3 --date=short --no-merges --format='%ad %ae %s' 2017-07-20 drgage Change CFX_Edit::GetSelText() to CFX_Edit::GetSelectedText(). Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I20eb6dc38f461a9a19a59164e8f3b0543c3e972b Reviewed-on: https://chromium-review.googlesource.com/580847 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488621}
-
Yoshifumi Inoue authored
This patch introduces no parameter variant of |FrameSelection::SelectAll()| to avoid default parameter for a preparation of moving declaration of enum class |SetSelectionBy| to another file[1]. [1] http://crrev.com/c/569662: ALL-IN-ONE Introduce SetSelectionData for FrameSelection::SetSelection() Change-Id: I5860c9f2cb72bb052727dc1dbd0546dc561bb3f1 Reviewed-on: https://chromium-review.googlesource.com/580175Reviewed-by:
-
Irmak Kavasoğlu authored
Created the edit button and added it to the pending password bubble for mac platform. Clicking the button does not do anything. Screenshot is added to the bug as comment #19. Bug: 734965 Change-Id: Iaf424fc8a9964543995a6ef321b9a33af596a594 Reviewed-on: https://chromium-review.googlesource.com/570440 Commit-Queue: Irmak Kavasoğlu <irmakk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#488619}
-
wutao authored
Using foreground blur make it possible to cache the render surface and provide good performance. Bug: 738185 Test: tested locally. Change-Id: I838c072ecd4deeb9e181e08644d215877616f0ef Reviewed-on: https://chromium-review.googlesource.com/578713 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#488618}
-
Marti Wong authored
In bookmark_home_handset_view_controller and bookmark_home_tablet_ntp_controller, prevent primaryView's content position from mistakenly reset to zero at viewWillLayoutSubviews(). Bug: 608777 Change-Id: Ifa6a4c075866509171180614cd0d5916a30a9466 Reviewed-on: https://chromium-review.googlesource.com/578693 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#488617}
-
Changwan Ryu authored
The previous fixing attempt for multiline insertion (http://crrev.com/2680733002) only worked for two-line text, and this CL allows for incremental insertion of three or more lines of text. Since selection is shifted after insertion, we need to update the selection start offset that will be used in adjusting selection for incremental insertion. BUG=712380 Change-Id: Ibb3212bd78fc7e30232aaa6b780c0c1182b63d1c Reviewed-on: https://chromium-review.googlesource.com/580496 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488616}
-
Ryo Hashimoto authored
Currently, ObjectProxy::CallMethod is implemented by creating ErrorCallback from ResponseCallback. This does not work with OnceCallback because it's not allowed to create two callbacks from one OnceCallback. To solve this, this change introduces CallMethodCallbackInternal to ObjectProxy which takes either Response* or ErrorResponse*, and dispatches the response to the appropriate callback. Also, Gmock does not allow directly mocking functions which take move-only arguments. https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#mocking-methods-that-use-move-only-types To workaround this, add DoCallMethod to MockObjetProxy. BUG=740015 TEST=build Change-Id: I1a98b5fd1d6d70f69674102a3d66bcec0c13214c Reviewed-on: https://chromium-review.googlesource.com/578541 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Cr-Commit-Position: refs/heads/master@{#488615}
-
tzik authored
This CL makes base::{Thread,Sequence}CheckerDoNothing noncopyable, so that they are consistent to base::{Thread,Sequence}CheckerImpl, and an accidental copy of SequenceChecker causes a compile error even on DCHCEK-disabled build. Change-Id: I3ac37d87302712ab3decf693d056376c0c2abb91 Reviewed-on: https://chromium-review.googlesource.com/578751 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#488614}
-
Bugs Nash authored
Rewritten from https://codereview.chromium.org/2897833004, this version does not use the memory optimisation which has since been removed from the code. This patch - Split property specific parsing logic for background components into the case statements in CSSPropertyParser::ParseSingleValue, using the general ConsumeCommaSeparatedList template instead of ConsumeCommaSeparatedBackgroundComponent so that CSSPropertyID no longer needs to be passed. - Delted ConsumeCommaSeparatedBackgroundComponent (now unused). NB - ConsumeBackgroundComponent is still currently used in ConsumeBackgroundShorthand and so cannot be deleted. - Some bool literals are passed in this patch, violating the style guide. These arguments were not introduced in this patch and so will not be fixed in this patch. They will be converted to enums when the APIs are implemented. Bug: 668012 Change-Id: Ie364b810e10f0df3b3053e337d47fd60118cc985 Reviewed-on: https://chromium-review.googlesource.com/575253Reviewed-by:
Renée Wright <rjwright@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#488613}
-
Jeremy Roman authored
The argument is always equal to the |this| pointer. We can just use the latter. Change-Id: Ia14c0858b18c61bc500e3f276e36dc270a8e8232 Reviewed-on: https://chromium-review.googlesource.com/579961Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488612}
-
Yuki Shiino authored
MutationCallback holds a ScriptState and accesses it assynchronously. So, MutationCallback should check the context if it's alive before the uses. Bug: 738299 Change-Id: Ib16b37b2e90e5ba87117d7c6e1218f9df6d69a41 Reviewed-on: https://chromium-review.googlesource.com/574509 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Kent Tamura authored
Rebaseline calendar-picker-appearance-zoom125.html and calendar-picker-appearance-zoom200.html for Mac10.9. TBR=qyearsley@chromium.org NOTRY=true Bug: 743068 Change-Id: I6b7e9bae599f22c80bdb420d76d2f238408e37af Reviewed-on: https://chromium-review.googlesource.com/579902Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488610}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/d60609d3a12f..4d02e904b015 $ git log d60609d3a..4d02e904b --date=short --no-merges --format='%ad %ae %s' 2017-07-20 drgage Change "Sel" abbreviation to "Selection". Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Icc508c39f951b785e5475611f484e38cd8539efd Reviewed-on: https://chromium-review.googlesource.com/580316 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488609}
-
Koji Ishii authored
Following bot results are included. 769 775 781 782 785 788 789 790 791 792 795 796 798 799 155 lines were removed by consecutive passes since 753. TBR=eae@chromium.org NOTRY=true BUG: 591099 Change-Id: Ib343eeaf4540ed94747f68724adedcecc175dac4 Reviewed-on: https://chromium-review.googlesource.com/580732 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#488608}
-
Mike Dougherty authored
The manual layout of the toolbar items for ios_web_view_shell is outdated and no longer works with iOS 11. Update the UIButtons to UIBarButtonItems and automatically lay them out with setItems: instead of adding items as subviews to the UIToolbar. Bug: None Change-Id: I800ade863253ac244cb8705a4afec0b09a0a2198 Reviewed-on: https://chromium-review.googlesource.com/578239Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#488607}
-
yhanada authored
Test: It builds. No behavioral change. Change-Id: I786bc492ff79fd3220bd1974d72f0e9703a1ccc2 Reviewed-on: https://chromium-review.googlesource.com/580453Reviewed-by:
Keigo Oka <oka@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#488606}
-
Adam Rice authored
Maximum stack space exceeded exceptions within the WritableStream and ReadableStream implementations can lead to slots being undefined that are expected to contain Promises. This in turn leads to CHECK failures. Protect all calls to V8 Promise intrinsics with checks that the expected Promise is present, and throw an exception if it isn't. Also add a test to verify that a CHECK failure does not occur. Bug: 743082 Change-Id: Iaf89aa2a694600d129021e7e902c6bc02401c8b4 Reviewed-on: https://chromium-review.googlesource.com/579628 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#488605}
-
Patricia Lor authored
Since a driving factor behind releasing the "Site Details" page as part of MD Settings is to replace default permissions in the Page Info bubble, the list of permissions shown in "Site Details" should include all permissions shown in the Page Info bubble. Add MIDI-SysEx to match it. and check one of the permissions listed there is "MIDI devices". Bug: 656758 Test: With #enable-site-details turned on, navigate to Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic111c09c17aef557990ae4f522151b294ab84842 chrome: //settings/content/siteDetails?site=https%3A%2F%2Fpermission.site Reviewed-on: https://chromium-review.googlesource.com/578758 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#488604}
-
Naina Raisinghani authored
This patch reduces the tree size for slower performance tests ensuring they don't time out. Bug: 747001 Change-Id: I3e87f1b68b3effcd04c8da2e673bd3e05f2374ed Reviewed-on: https://chromium-review.googlesource.com/580011Reviewed-by:
-
Yoshifumi Inoue authored
This patch introduces enum class |SelectionModifyDirection| as replacement of |SelectionDirection| since it is used as a parameter of |SelectinModifier::Modify()| for improving code readability. Change-Id: Ib249d01106503138811214895c7e8018e48758c5 Reviewed-on: https://chromium-review.googlesource.com/579248 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
