- 19 Aug, 2020 40 commits
-
-
Renato Silva authored
PIN auto submit is only available on Chrome OS and the feature should be in the chromeos namespace. Bug: 1075994 Change-Id: Idd199abb2baf6ac88d10762e22735fe42d46e656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362965 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799851}
-
Lei Zhang authored
Remove deprecated macro usage and use explicit deletions instead. Also remove some unnecessary includes for base/macros.h. Bug: 1010217 Change-Id: I8d1e4d03e93933262f184b7802de4ef1b94ab1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363630Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799850}
-
Leonid Baraz authored
Bug: b:153364303 Change-Id: Idb13d9993a6301cda0ca7514a7c0fc457c7e90a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364060Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799849}
-
Dylan Cutler authored
Bug: 973801 Change-Id: Ie2de8e36520d28ea0063ab6c54695786eb1de5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353028 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#799848}
-
Brian Malcolm authored
This is intended to replace the NativePrintersBulkWhitelist policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1098047 Change-Id: Ib863ff1f2244dcd832826883c0dfa7f167865908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342049 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799847}
-
Yicheng Li authored
If the submitted password looks like PIN, try authenticate the user with PIN. On failure, submit the password as normal password. This fallback to password auth is because the user may type the PIN into the password textfield (though admittedly this is a less valid use case). This behavior is consistent with ScreenLocker. Bug: b:156258540 Change-Id: I23bf097a35c6458e8f341ae105679d6d42a83c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364756Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799846}
-
Tomasz Wiszkowski authored
This change allows Search-Ready Omnibox to be shown on SRP effectively removing the need to manually clear the Omnibox field ahead of typing in new search query. Bug: 1118222 Change-Id: Ie36029b38ed54bb63de1db66eef9457dec6d86ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364048 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799845}
-
Evan Stade authored
Bug: 738196 Change-Id: Ibc6ab965ba80cbc76f7e89230da7c20bf7dc9392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364957Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#799844}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: I5aedb1ceaad41242f4a51d450704027dcb0c046e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352022 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#799843}
-
Michael Bai authored
Record the task delay to see how often the short delay is triggered. Bug: 1114819 Change-Id: Ia1368fd354dea1af196b6f5ff14f7d073b73da9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363557 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#799842}
-
Evan Stade authored
Bug: 1057100 Change-Id: I57cff2406fa4d11420dbbb3e450dc189f5dd97a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364740 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
-
Yi Chou authored
Add ordinal value in the mojom would increase the compatibility between different builds. Change-Id: I88c455f092035ffd0d9b6164e83babf39957fb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319088Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: joe Chou <yich@google.com> Cr-Commit-Position: refs/heads/master@{#799840}
-
Chong Gu authored
Adds ~5 mins of runtime and bot time per build. Bug: 1058255 Change-Id: If3bea9834a4c2894fe333d57b19dba68451f8d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364061 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799839}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008190800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/2mC2HAs3wr9lkv-fO7paccSOBACAv2EXtzFGg-sY7ukC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162466284,b/163420424 Tbr: help-app@grotations.appspotmail.com Change-Id: Ifded1470451b18602cb561f452fa5368a2037899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362979Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799838}
-
James Hawkins authored
This reverts commit e2c7dc67. This relands the below change after fixes to the underlying components to support unoptimized builds. cr_components/network: Convert NetworkListItem to Polymer 3. Also convert the types in NetworkListTypes as well since they are trivial and NetworkListItem depends on them. Bug: 1045266 Test: NetworkNetworkListItem* Change-Id: Ic607a49efa874fde2bf18459dc9a351db6fd49f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364815Reviewed-by:
-
Xiaocheng Hu authored
This follows from a discussion that 'advance-override' more accurately summarizes what the descriptor does. Bug: 1098355 Change-Id: Ib497288f9e824ee33adb77b2e1b76e8aed709f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363857 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#799836}
-
Juan Mojica authored
Bug: 1092713 Change-Id: I8e0d7c2d18dcaac7ab930452c57907f1c31ab449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363393 Commit-Queue: Juan Mojica <juanmojica@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
John Lee authored
Bug: 1117652 Change-Id: If097acd73096be0b1b36e94088361a9715f53936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360344 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#799834}
-
Xing Liu authored
This CL removes metric "GoogleUpdate.Notification.LaunchEvent". Bug: 1084148 Change-Id: I95d3eb2f42fb77219d4cbcdf6a593545f7d15026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363647Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#799833}
-
David Roger authored
Bug: 1063856 Change-Id: Icbfc8643e34c358421d6cf200269726ff2dc4537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364616 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799832}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53effa99e255..9b259fd1b84c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com,mcnee@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419,chromium:1103274,chromium:1111893,chromium:1116656,chromium:1118189 Tbr: alexmos@google.com,mcnee@google.com Change-Id: I8035267520474439deabbc3dade009f4d3ed2930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364576Reviewed-by:
-
Steven Bennetts authored
There is an edge case where the netmask can be undefined, causing an exception which breaks the UI. This handles that edge case. Bug: 1091567 Change-Id: I40eb7e8b57670fd9582a28fa5723ac221cdf550c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364002 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#799830}
-
Elly Fong-Jones authored
This method is only implemented on the base class, which always returns false. Delete the method, its implementation, a wrapper around it in DesktopWindowTreeHostWin, and the only call to it in HWNDMessageHandler. Open question: is WidgetDelegate::HandleWorkAreaChanged() now dead? It can only be called in HWNDMessageHandler::OnSettingChange() when GetParent(hwnd()), but under what circumstances is that true? Bug: None Change-Id: Ib00d0b67597ded401c624786b54051bdf2373769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364212Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#799829}
-
Anatoliy Potapchuk authored
Change-Id: I51abb949970bd03810144b033dcc8bb7a51c18b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363753 Auto-Submit: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#799828}
-
Raymond Toy authored
Add a CHECK before we break out of the loop in ComputeIndices. This has never happened in my testing, so this is just a guess. If we do get crashes, perhaps we can get better information about what's happening. This is important because if we do exit the loop early, we're not telling ComputeOutput about it and the read indices may not be set up correctly for that. Also, update frames_processed to tell ComputeOutput how many values were computed so ComputeOutput doesn't compute more outputs than needed. I think letting this bake for a week or so will be enough to gather enough information if this is the case. Bug: 1116104 Change-Id: Id0ab1d3ca801196fc49b878349f469cbd4f6e11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358815Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799827}
-
Anupam Snigdha authored
Added a new method to initialize a mocked version of TSFBridge when |InitializeInputMethodForTesting| is called from test code. This change also adds a call in the views unittest base to initialize the |MockTSFBridge| by calling |InitializeInputMethodForTesting| and enables some disabled tests. Bug: 968222 Change-Id: Ib25dcefd53a2b6e11ea6dfa713efe37052b24be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364034Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799826}
-
Charlene Yan authored
The height of the TabStrip was being incorrectly set when Tab Scrolling was turned on leading to an invisible tabstrip. height() is 0, potentially because TabStrip does it's own layout? Bug: 1093529 Change-Id: I45745b8d3ff0cdbcaf1b5ba99e2e16bc2c23c69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364698Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799825}
-
Aleks Totic authored
LayoutNGCaptions can be created in both Legacy and NG tables. Only Legacy tables require AddCaption/RemoveCaption calls. Bug: 958381 Change-Id: I43131f66b794dc43bea41d6b39fdf66eac72aa86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363556 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#799824}
-
Dana Fried authored
Requested by PM to be symmetric with "Add to new group" menu. Bug: 1117460 Change-Id: I4c1047e076b889cd122e18da74187324419ed391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363394Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#799823}
-
Noah Rose Ledesma authored
This change hides the MediaNotificationAudioDeviceSelectorView when there is only one unique device. Bug: 1116113 Change-Id: Ie5799b29a691ead0b0225751e18e4019452f38e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354831 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799822}
-
Emily Stark authored
This CL factors out some common code from OmniboxViewViews unit tests that test simplified domain field trials: * Stepping through an animation * Setup code that sets the display URL * Simulating a navigation and checking that the URL is elided or unelided afterwards Bug: 1102572 Change-Id: If388d8174cdbaa822478ed93b7ec7782bfec2c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363368 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#799821}
-
Carlos IL authored
Bug: 1118208 Change-Id: Ice40f115737480b0f45f9188164e3ce39a421ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363720 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#799820}
-
Avi Drissman authored
task_manager::WebContentsTag::CreateTask returns ownership in a raw pointer. Fix that. WebContentsTaskProvider::WebContentsEntry then has to juggle those raw pointers. Fix that. Bug: none Change-Id: Ie19f3f67365b8f1ff22079949a6148f058d7ffd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361204 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#799819}
-
Jianhui Dai authored
This CL supports native input video frame from user media video track. The video frame is converted to I420 by libyuv for software encoder. Bug: 1045248 Change-Id: I2afb1a3c9c9fdf2c8b15312120c430f8e898d2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359715 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#799818}
-
David Bertoni authored
A number of SetUp overrides were calling the parent override before doing the setup for that class. This doesn't work because any code following the call to the parent override is executed after the current test fixture executes. The code in WebrtcLoggingPrivateApiTest to set up the extension_ data member was also moved to SetUpOnMainThread. Building the extension in SetUp crashes because the global ExtensionsClient instance is not yet created. Bug: 1117287 Change-Id: Ifd82c782b7f012cd0225766030fac2574ef68937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361004 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799817}
-
Rachel Carpenter authored
It would be good to be consistent in the logging of our release notes entry points for now as we have an experiment running on this as well as the swap from PWA to help app in M86. Will clean up to have better logging of the various pages HelpApp can be opened to/from at a later date. Bug: b/165421480 Change-Id: Ia6a128aaeed139694f39421abb9ebe1f86c30827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362240Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799816}
-
Evan Stade authored
This prepares it for componentization and re-use by WebLayer. Some PhotoPicker glue code is moved from UiUtils to SelectFileDialog because UiUtils can't depend on WindowAndroid. SelectFileDialog is the only client that calls showPhotoPicker, so it seems like a good place to hold the delegate code. Bug: 1110930 Change-Id: I21afcaf0bcccc739f63f75ee745d0c519331e763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361123Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#799815}
-
Kartik Hegde authored
Fix the logic to append correctly. BUG=chromium:956783 TEST=unit_tests && ./out/Default/unit_tests --gtest_filter=DnsLatencyRoutineTest.* Change-Id: I08d7434c2816c696c08d6fedcdd3d522ef3a7edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358598 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#799814}
-
Mohamed Heikal authored
We should ensure that no new usages of the real targets can be added. Change-Id: I4999c2257f9aedef38809c4f182f419c8bed058c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357452 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#799813}
-
Tibor Goldschwendt authored
This data source allows embedding external images into WebUI pages via the URL chrome://image?<image URL>. No-try due to broken traffic annotation check. See crbug/1119509. No-Try: true Bug: 1087613 Change-Id: If7e6af0a90ce5032832eb3cc883999b5bc9ffb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352517 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#799812}
-
