GitLab

Store the output of View::OnPaint as a PaintCache object, and when the
view has not been invalidated, use that cache output instead of doing
work to build a recording.

Performance data as follows when the loading spinner is going:

Before impl-side (TOT): 0.13ms / paint
With impl-side (no slimming paint): 0.22ms / paint
With impl-side and slimming paint (this patch): 0.17ms / paint

So this gets us some of the way there. I need to investigate why it's
not doing more.

R=piman@chromium.org, sky
BUG=466426

Committed: https://crrev.com/7f686cdcff81d6779b962e98e529a7360be2809c
Cr-Commit-Position: refs/heads/master@{#326592}

Review URL: https://codereview.chromium.org/1101783002

Cr-Commit-Position: refs/heads/master@{#326976}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/be357282..d3c652f0

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1103963002

Cr-Commit-Position: refs/heads/master@{#326975}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8e71d38..130444f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1107643003

Cr-Commit-Position: refs/heads/master@{#326974}

This was broken in #326948; NaCl doesn't build in component debug yet ...

TBR=sigbornf@opera.com
BUG=

Review URL: https://codereview.chromium.org/1104913002

Cr-Commit-Position: refs/heads/master@{#326973}

This CL has just two files which got some extra "while I'm in there" cleanup while doing mechanical fixups across the codebase.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

BUG=417463

Review URL: https://codereview.chromium.org/1106043002

Cr-Commit-Position: refs/heads/master@{#326972}

IsOriginSecure() implements web platform feature [1] and it'd be
more natural to provide this at content-layer.
Also ServiceWorker actually wants to call this in content layer
for browser-side security check.

https://www.w3.org/TR/powerful-features/#is-origin-trustworthy.

This CL moves IsOriginSecure() from
chrome/common/origin_util.{h,cc} to
content/{public/,}/common/origin_util.{h,cc}

and adds a following method to ContentClient so that ChromeContentClient
can add chrome-level schemes (and whitelisted origins, this is to be
implemented in crbug.com/441605).

  // Gives the embedder a chance to register additional schemes and origins
  // that need to be considered trustworthy.
  // See https://www.w3.org/TR/powerful-features/#is-origin-trustworthy.
  virtual void AddSecureSchemesAndOrigins(std::set<std::string>* schemes,
                                          std::set<GURL>* origins) {}

BUG=362214, 441605
TEST=content_unittests:URLSchemesTest.IsOriginSecure

Review URL: https://codereview.chromium.org/1101033003

Cr-Commit-Position: refs/heads/master@{#326971}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9432a893..be357282

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1092973005

Cr-Commit-Position: refs/heads/master@{#326970}

BUG=430156,345874
TBR=inferno@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1103023003

Cr-Commit-Position: refs/heads/master@{#326969}

Instead build our own simplified version, so we don't need to depend on
webkit/common/gpu.

This should help ease the transition of
https://codereview.chromium.org/920443003.

Tested on Android (with Nexus 5 device) with the following command
lines:

$ ./build/gyp_chromium -DOS=android -Goutput_dir=out_android
$ ninja -C out_android/Debug android_webview_apk android_webview_test_apk
$ export CHROMIUM_OUT_DIR=out_android
$ build/android/adb_install_apk.py --apk=AndroidWebView.apk --debug
$ build/android/test_runner.py instrumentation --test-apk=AndroidWebViewTest \
  --test_data webview:android_webview/test/data/device_files --debug

BUG=338338
TEST=see above
R=boliu@chromium.org

Review URL: https://codereview.chromium.org/1083843002

Cr-Commit-Position: refs/heads/master@{#326968}

BUG=470984
TEST=

Committed: https://crrev.com/163a4a63af5e56801395eed067a69e501e7b51a5
Cr-Commit-Position: refs/heads/master@{#326691}

Review URL: https://codereview.chromium.org/1097663003

Cr-Commit-Position: refs/heads/master@{#326967}

Cr-Commit-Position: refs/heads/master@{#326966}

Cr-Commit-Position: refs/heads/master@{#326965}

BUG=480980

Review URL: https://codereview.chromium.org/1097353004

Cr-Commit-Position: refs/heads/master@{#326964}

Please take look at
https://codereview.chromium.org/1090213002/patch/40001/50001

for details

BUG=

Review URL: https://codereview.chromium.org/1106503003

Cr-Commit-Position: refs/heads/master@{#326963}

media_cast_mode.{cc,h}
A cast mode represents one way that the current WebContents (i.e., tab) may be presented to a media sink.

media_sink_with_cast_modes.{cc,h}
Contains information on a MediaSink and the set of cast modes it is compatible with.

Also includes strings, unit tests and .gyp/.gn updates.

BUG=464208

Review URL: https://codereview.chromium.org/1066683008

Cr-Commit-Position: refs/heads/master@{#326962}

Previously, telemetry read the whole '/proc/timer_list' file just to parse the
first occurence of "jiffies". In case the file is big and telemetry is run
against remote device, this can create a big delay for transferring the file
to host device.

This patch modify it so that telemetry just use
'grep jiffies /proc/timer_list' to get the only lines that contain 'jiffies'.

Context: https://groups.google.com/a/chromium.org/forum/#!topic/telemetry/SblQqF0tHbc

Try job runs:
./tools/perf/run_benchmark --browser=trybot-all-android page_cycler.top_10_mobile --also-run-disabled-tests
https://codereview.chromium.org/1100233003

./tools/perf/run_benchmark --browser=trybot-all-mac page_cycler.intl_ja_zh
https://codereview.chromium.org/1106833004

./tools/perf/run_benchmark --browser=trybot-all-linux page_cycler.intl_ja_zh
https://codereview.chromium.org/1102673005

Review URL: https://codereview.chromium.org/1106043003

Cr-Commit-Position: refs/heads/master@{#326961}

If the out-of-process v8 pac resolver crashes, ProxyResolverMojo
returns ERR_PAC_SCRIPT_TERMINATED as its error. This changes
ProxyService to discard its ProxyResolver when that error is returned,
and if other requests were in progress, start reinitializing a new
ProxyResolver.

This also changes ProxyResolverMojo to correctly handle being deleted
while running a CompletionCallback.

BUG=467832

Review URL: https://codereview.chromium.org/1069483003

Cr-Commit-Position: refs/heads/master@{#326960}

This cl:
* Adds file list support to build-webapp.py
* Update teh GN webapp build rules to build/pass a filelist
* Enable the GN webapp build for Windows

This change is motivated by enabling the remoting webapp build on
Windows, which has a limit on the size of the command line. This
limit was encountered with the Windows GN build.

The corresponding GYP build files are not updated (even though GYP
has support for building filelists via the <| syntax) because our
files have GYP paths in them that get written into the file rather
than being expanded. Fixing this is not worth the time since we're
moving away from our GYP builds.

BUG=

Review URL: https://codereview.chromium.org/1107483002

Cr-Commit-Position: refs/heads/master@{#326959}

BUG=481305
TBR=emircan@chromium.org,hanxi@chromium.org

Review URL: https://codereview.chromium.org/1085323004

Cr-Commit-Position: refs/heads/master@{#326958}

This CL introduces a new protobuf to store encrypted
CertLoggerRequests. Serialized certificate reports are encrypted with an
AES-CTR-128-HMAC-SHA256 AEAD (from BoringSSL, thus encrypted reports are
only supported on BoringSSL platforms) before being uploaded to HTTP
endpoints. |CertificateErrorReporter::IsHttpUploadUrlSupported| allows
users of the class to set an HTTP URL if supported.

BUG=461590

Committed: https://crrev.com/0a3351c2a7c81284f82e6531380a21d079f55056
Cr-Commit-Position: refs/heads/master@{#326876}

Review URL: https://codereview.chromium.org/1083493003

Cr-Commit-Position: refs/heads/master@{#326957}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8440baa..8e71d38

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1078383005

Cr-Commit-Position: refs/heads/master@{#326956}

We can actually build a lot more targets, but the full
component build doesn't work yet. This patch reverts
the changes in #326948 for just this configuration in
the meantime.

TBR=phajdan.jr@chromium.org
BUG=461019, 480643

Review URL: https://codereview.chromium.org/1055403009

Cr-Commit-Position: refs/heads/master@{#326955}

Download dictionaries via https instead of http, preventing MITM
attacks against dicts. Plus, HTTPS 4 LYFE!

BUG=479162

Review URL: https://codereview.chromium.org/1056103005

Cr-Commit-Position: refs/heads/master@{#326954}

R=kalman
BUG=424661

Review URL: https://codereview.chromium.org/1106653002

Cr-Commit-Position: refs/heads/master@{#326953}

BUG=481297
TBR=hidehiko@chromium.org,mdempsky@chromium.org

Review URL: https://codereview.chromium.org/1104813008

Cr-Commit-Position: refs/heads/master@{#326952}

BUG=481290
TBR=chirantan@chromium.org

Review URL: https://codereview.chromium.org/1107733007

Cr-Commit-Position: refs/heads/master@{#326951}

BUG=481286
TBR=davidben@chromium.org

Review URL: https://codereview.chromium.org/1100563003

Cr-Commit-Position: refs/heads/master@{#326950}

Looks like C++ compiler is able to figure out that this function is on
base namespace by deducing this from the dependent type base::MD5Digest.

For more reference on ADL:
http://en.wikipedia.org/wiki/Argument-dependent_name_lookup
http://stackoverflow.com/questions/8111677/what-is-argument-dependent-lookup-aka-adl-or-koenig-lookup

I found this while doing https://codereview.chromium.org/1099453002/.

The error is like the following:

../../chrome/browser/drive/drive_api_util.cc:171:10: error: use of
undeclared identifier 'MD5DigestToBase16'; did you mean
'base::MD5DigestToBase16'?
  return MD5DigestToBase16(digest);
           ^~~~~~~~~~~~~~~~~
           base::MD5DigestToBase16

Log:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/81070/steps/compile/logs/stdio

BUG=None
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/1088593005

Cr-Commit-Position: refs/heads/master@{#326949}

Previously most of the GN bots were explicitly building
"all", which is a lot more than we build on the (non-clobber)
GYP bots.

This patch syncs the lists so that we build the same targets the
GYP bots build as much as possible (in some cases the targets
don't work yet for GYP).

This also will workaround a bug in MB where building "all" bypasses
analyze.

R=phajdan.jr@chromium.org
BUG=461019,480643
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1106853002

Cr-Commit-Position: refs/heads/master@{#326948}

the same method that sends the request.

BUG=471928

Review URL: https://codereview.chromium.org/1049873007

Cr-Commit-Position: refs/heads/master@{#326947}

At the moment it CHECKs on false return from base::i18n::InitalizeICU.
Try to locate it to a particular failure in that function to have a
better idea what's failing.

R=jshin@chromium.org
BUG=445616

Review URL: https://codereview.chromium.org/1076623004

Cr-Commit-Position: refs/heads/master@{#326946}

When users pinch in Reader Mode, the page would zoom in or out as if it
is a normal web page allowing user-zoom. At the end of pinch gesture, the
page would do text reflow. These pinch-to-zoom and text reflow effects
are not native, but are emulated using CSS and JavaScript.

In order to achieve near-native zooming and panning frame rate, fake 3D
transform is used so that the layer doesn't repaint for each frame.

After the text reflow, the web content shown in the viewport should
roughly be the same paragraph before zooming.

The control point of font size is the html element, so that both "em" and
"rem" are adjusted. Accordingly, font size of body is no longer specified
in CSS in unit of pixel.

Some CSS styles and animations are updated to fix issues specific to
resizing.

BUG=445632

Review URL: https://codereview.chromium.org/1009703002

Cr-Commit-Position: refs/heads/master@{#326945}

Tasks without initial URLs weren't being counted as legitimate Tabs,
preventing them from being restored properly.

BUG=481109

Review URL: https://codereview.chromium.org/1109543003

Cr-Commit-Position: refs/heads/master@{#326944}

Try NtDuplicateObject instead of DuplicateHandle on Windows 8/8.1 for debugging AppContainer related failures.
This patch should be reverted as soon as we get some confirmation that NtDuplicateObject is working better compared to DuplicateHandle.
Theory behind this patch is that it might be possible that on machines which reporting this find of failure have some software like AV which might be intercepting calls to DuplciateHandle and may be failing somewhere in intercepted code path due to AppContainer.
Looking in IDA error code that we are receiving 0xC0000023 (Which translates INSUFFICIENT_BUFFER (0x7a) in win32 language) doesn't seem to be in NtDuplicateObject code path (At least not found easily.).

BUG=468922
R=jschuh@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/1101913002

Cr-Commit-Position: refs/heads/master@{#326943}

Prior to this CL, if there were multiple targets ina GN build
with the name 'unit_tests', we would not generate a top-level
phony ninja target for them; you would have to specify either
the full path to the output or the label name.

This is confusing for things like 'browser_tests' and 'unit_tests',
where in Chromium we might have multiple targets with that name,
but only one of those is an executable (at least in the default
toolchain).

This CL adds logic to handle that case (so that 'unit_tests' does work).

R=brettw@chromium.org
BUG=480042

Review URL: https://codereview.chromium.org/1101323005

Cr-Commit-Position: refs/heads/master@{#326942}

This patch initializes one of the variables that is used in the fake
tiling client.

R=danakj

Review URL: https://codereview.chromium.org/1102133002

Cr-Commit-Position: refs/heads/master@{#326941}

base::ResetAndReturn() makes code shorter and simpler. Also in several
places callbacks were Reset() after Run(), which is dangerous for
callback that are allowed to delete the caller. base::ResetAndReturn()
helps to avoid this issue.

Review URL: https://codereview.chromium.org/1064863004

Cr-Commit-Position: refs/heads/master@{#326940}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d8992d97..9432a893

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1095203009

Cr-Commit-Position: refs/heads/master@{#326939}

Chromium provides PowerObserver and PowerMonitor objects to allow
subsystems to react to power suspend and resume events. On iOS this
actually tracks app lifecycle events for backgrounding.

The patch adds a power observer that destroys the compression session
on power suspend events and re-initializes the compression session on
power resume events. This allows the encoder to properly transition to
the background on iOS and resume when the app comes back to the
foreground.

Note that for this to work overall, the sender client must create a
background task to allow networking to continue. Otherwise the receiver
will timeout per spec.

R=miu@chromium.org
BUG=477895

Review URL: https://codereview.chromium.org/1094403002

Cr-Commit-Position: refs/heads/master@{#326938}

The native parts of dom_distiller will try to register jni methods on
startup. This fails if the apk doesn't contain the corresponding java
bits. So, even though chrome_shell_apk doesn't actually use the java
stuff in dom_distiller_content_java, it still needs to depend on it and
include it in the apk.

Review URL: https://codereview.chromium.org/1090153007

Cr-Commit-Position: refs/heads/master@{#326937}