- 10 Jan, 2020 40 commits
-
-
Vasilii Sukhanov authored
TBR=eirage@chromium.org Bug: 1040874 Change-Id: Iec6b2cc5a72e1b3256d66b8acf09f515e8a0b250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995164Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#730126}
-
Richard Knoll authored
The P2PSocketManager resolves host names in GetHostAddress and responds with the supplied callback. That callback is dropped in the destructor which can happen if there is a mojo connection error. We need to close the pipe to the mojom::P2PSocketManager before doing that as mojo will check if the connection is still active when dropping a callback. Bug: None Change-Id: I2a1e411f5aba21a375e33bd242b67f64c9362a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991560Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#730125}
-
Alice Wang authored
This CL tests and refactors the SignOutDialogFragment. Bug: 967374 Change-Id: Ibe0af76022877305b38513d5855e238465635469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982557 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#730124}
-
Vasilii Sukhanov authored
This reverts commit d140b7a4. Reason for revert: Broke crashpad_tests reliably https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/12597 Original change's description: > Enable init_stack_vars for non-official Debug Windows builds > > Debug build is fixed with: crrev.com/c/1973353 > > Bug: 977230, 1030261 > Change-Id: Idcb24d092247f6bc7438c74b6405b4b93539507d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970852 > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728840} TBR=hans@chromium.org,vitalybuka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 977230, 1030261 Change-Id: Iad7d92e12299365b4a45a5237c3bc5e371e33dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993964Reviewed-by:
-
Richard Knoll authored
The latest beta of 10.15.3 fixed the issue where an XPC service could not show notifications. This removes the workaround we put in place in https://crrev.com/c/1883648 for macOS 10.15.3+ but keeps it for earlier versions of 10.15. Bug: 1007418 Change-Id: I928dac7366c9e7faee793dd72d282b031e535092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991637 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#730122}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9dbcda838560..a104a789f873 git log 9dbcda838560..a104a789f873 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 dberris@chromium.org Fix dispatch routing Created with: gclient setdep -r src/third_party/catapult@a104a789f873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1035930 Tbr: crouleau@google.com Change-Id: I895bd006cf70d17e86fc254e5382c50f708cbe76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730121}
-
Eric Seckler authored
Replaces SyncChannel::Send, RenderProcessHostImpl::Send, and GpuChannelHost::Send trace events with typed trace events. Also adds a utility to convert the IPC class ID to a corresponding protobuf enum. Corresponding proto buffer definitions for these events were added in aosp/1180211. Typed trace events will allow inclusion of the event arguments in slow reports data in the future. The trace format is protocol-buffer based under the hood already (see docs.perfetto.dev for details), this patch adds strong typing for the arguments of the respective events only. TBR: sunnyps@chromium.org Bug: 644264 Change-Id: I91c71230e62161b08faec889bf9eb70639ae0b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950986 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#730120}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c83d5e24..72ee5754 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa8b427cf8b0d55d57713ff008eca12ecf809f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993762Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730119}
-
Stepan Khapugin authored
Since UIRefresh had long been the only option, remove references to it in constant names. Bug: none Test: none Change-Id: Ifb3cdb5fec82ad4ea015014c098685010b04e81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991455 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#730118}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9b289b2c2973..4b6df1777cba git log 9b289b2c2973..4b6df1777cba --date=short --first-parent --format='%ad %ae %s' 2020-01-10 thomasanderson@chromium.org Update Linux documentation links Created with: gclient setdep -r src/third_party/webrtc@4b6df1777cba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6d041aea175da5de05ec33c24756cce67befcaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995141Reviewed-by:
-
Anders Hartvoll Ruud authored
BUG=545324 Change-Id: Ic90b7e417accdbf64b110f70db41369e2edec0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986831Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#730116}
-
Steve Anton authored
Linux limits the thread name to 15 characters which was cutting off the signaling/worker distinction. Bug: None Change-Id: Ibbbfdf1cedd0add91a8c3aa5c5b5cac6a06d4168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994050 Auto-Submit: Steve Anton <steveanton@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#730115}
-
Raphael Kubo da Costa authored
web-platform-tests has recently gained the ability to set the permission associated to a permission type via test_driver.set_permission(), in a similar fashion to Blink's testRunner.setPermission(). This is CL #1 of a few, and the ultimate goal is to add an implementation of set_permission() to testdriver-vendor.js, so that we can replace uses of testRunner.setPermission(), and consequently move more Blink-specific tests to WPT. This CL adds a new .mojom file to third_party/blink/public/mojom/permissions that allows setting the permission associated with a given permission type, in a similar fashion to testRunner.setPermission(). This API is only intended for use in tests, so the new PermissionAutomation interface is added to a separate file that is part of the blink.test.mojom module, and it is only implemented by content_shell. It then plugs it into the internals object. While in the short term it adds another way to achieve the same thing in layout tests, this was done for a couple of reasons: * test_driver.set_permission() takes a PermissionDescriptor (from the Permissions API) rather than a string that does not necessarily match the permission name as specified in the Permissions API. It makes sense to use standardized APIs, so rather than adding code to convert a PermissionDescriptor into a string accepted by testRunner's setPermission(), internals.setPermission() also takes a PermissionDescriptor. * Since testRunner is implemented entirely in //content/shell, we cannot have its code call Blink to convert a JS value representing the descriptor into a blink::mojom::PermissionDescriptorPtr. By Onion Soup'ing the code to set permissions, we can do all the PermissionDescriptor parsing in Blink and just call the PermissionAutomation implementation in content shell's browser side. For this, we change the internals object in Blink and bypass testRunner altogether. * The new API also gives us more flexibility: it returns a promise so that we can be sure the permission changes really have an effect before executing the rest of the code in a test. A few layout tests have been converted to the new API to show it works. Once existing uses of testRunner.setPermission() are converted, we can remove it altogether, and have internals.setPermission() be part of the implementation of testdriver.js' set_permission() call. Bug: 1030663 Change-Id: I3f40a9facd521ac41c4506b4043ecd5c831586fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958117Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#730114}
-
Jérôme Lebel authored
Removing SigninAccountSelectorViewController class. It was used to select an account before Unity UI. This class should have been removed with crrev.com/c/1778868. And renaming -[ChromeSigninViewController signinCompletedWithUnity] into -[ChromeSigninViewController signinCompleted]. Bug: 951313 Change-Id: I7012595fdd6de754ed60ac4bb17d0dd9951affbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991454 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#730113}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.18-1577705382-benchmark-81.0.4013.0-r1 to 81-3987.18-1577705382-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2f7962cd02def14c638147afcb8c3e0610c89536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995144Reviewed-by:
-
Takashi Toyoshima authored
cors::CheckAccessInternal() ensures if the HTTP response status is set to a non-zero value. This code was originally introduced in Blink side, but it's out-of-spec implementation. CORS preflight response expects an ok status for CORS checks and our implementation implicitly rejects the status 0. Actual response does not have such CORS specific status code check, and fetch() or XHR can receive an error status as long as the response has a right access control headers. But since 0 is not used in HTTP, we don't need such check in CORS code. So, let's remove this stale check and relevant test, WebAssociatedURLLoaderTest. CrossOriginWithAccessControlFailureBadStatusCode. This was added by https://codereview.chromium.org/110273006/, but the original change's intention does not help developers today. Also note that usual server applications such as Apache converts this kind of invalid status from CGI to 500 to assume such situation as an internal server error. This patch also integrate the ok status check into the cors::PreflightAccessCheck so to minimize exposed functions. Bug: 1039174 Change-Id: Ib8f8d84e200a01884daab9d726ac52b38e36a591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983696 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Ionel Popescu authored
*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not *** revert this CL. Instead, please disable the offending test(s) and *** add them to the crbug.com/1035582 section of TestExpectations. I *** will then take care of them as I fix up the remainder of these *** tests. Feel free to cc me if you create a bug. Thanks. This CL updates the focus ring to be made of two borders which have a 2:1 ratio. The new width of the focus ring is 3px: 2px nearly black (#101010), followed by 1px white. If the element has a border large enough to have an inset outline (width >= 1px) then we are going to inset the focus ring by 1px as we want it to be partially drawn over the border to avoid clipping or strange alignment issues caused by increasing the width to 3px. For elements that have not been styled and that have an appearance, the border radius of the focus ring is updated to be the same as the one used for drawing the element. For all other cases the current behavior is maintained: border radius = outline width. Tests are added to validate the new focus ring for multiple scenarios (see controls-refresh/focus-rect) Bug: 1026553 Change-Id: Ibe05cf6b7336198bd9513174493f51da5108339a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975072 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#730110}
-
Takuto Ikuta authored
chrome_public_test_apk passes now. https://luci-milo-dev.appspot.com/p/chromium/builders/ci/Android%20N5X%20Swarm/10131 This was introduced in crrev.com/3400947e Bug: 955013, 731759 Change-Id: I4b73a7efcf5052d83df66021580a233ece3e66fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993002 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#730109}
-
Renato Silva authored
Clicking/Tapping on the 'Learn More' link on the EULA screen will now change the focus to the link itself. Fixed: 1025176 Change-Id: I12ce9c5c4d7d07d9634a2bda66f44441b439c7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991480 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#730108}
-
sandromaggi authored
This CL makes the box around the poodle bigger, such that the animation inside does not clip. This requires an adaption of AnimatedPoodle.java, see https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2396454/ Before: https://screenshot.googleplex.com/RKTuHnfqAUT After: https://screenshot.googleplex.com/Nh1CExNGP14 Bug: b/146418409 Change-Id: Ia15cff2f7d680c0a1fcc92d02fe6bb9e1a691c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991427Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#730107}
-
Mikel Astiz authored
One TODO has already been addressed in https://chromium-review.googlesource.com/c/chromium/src/+/1969582 and the other TODO should be linked to a more appropriate bug. Bug: None Change-Id: Ib2b1da6f68c2dc43a9e892100864b5888cb6996b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992432 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#730106}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/12ce8f687d23..dcc57015f892 git log 12ce8f687d23..dcc57015f892 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 77c89ff847b6..110236f3ce70 (5 commits) Created with: gclient setdep -r src/third_party/angle@dcc57015f892 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I734c7f03cc823c9a374acb6d9cb8a598bbde7514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994256Reviewed-by:
-
Simon Zünd authored
For the V8 CL https://crrev.com/c/1350790 two web tests were temporarily disabled. This CL re-enables them and rebaselines one of them. The rebasline is necessary as the CL https://crrev.com/c/1971832 that changed the ordering of properties also modified the expectations. R=petermarshall@chromium.org Bug: chromium:924308 Change-Id: Idf57e2525480828da44b0e6dfb43a07b39af65ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993803Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#730104}
-
Swapnil authored
This is to get a better idea for failure of Force installed extensions through UMA statistics by reporting error codes. Earlier we used to report the network error codes to Extensions.CrxFetchError histogram, but that accounts for all the extensions. Now in addition to Extensions.CrxFetchError histograms, we will have new histograms which will report only in case of Force Installed Extensions. In addition we also report Http error codes, and the number of fetch retries made in case of CRX_FETCH_FAILURE error. Following histograms are added: Extensions.ForceInstalledFetchTries -> Reports the number of fetch retries made in case of CRX_FETCH_FAILURE. Extensions.ForceInstalledHttpErrorCode -> Reports the Http Error Code in case of CRX_FETCH_FAILURE. Extensions.ForceInstalledNetworkErrorCode -> Reports the Network error codes in case of CRX_FETCH_FAILURE. Error codes are received in the ExtensionDownloader, and then they are passed to ExtensionUpdater through the ExtensionDownloaderDelegate. ExtensionUpdater reports the error codes to the InstallationReporter. Bug: 1030224 Change-Id: Id9762df857483edaa008a2f2c718a425ead3f25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955726Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#730103}
-
Robbie Gibson authored
Before, these methods were required, but many classes that conformed to the protocol had them as no-ops. It is simpler to mark them optional and remove the no-ops. Change-Id: I1b71f15f8574742fc92e5bf599e37530f9ac5229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991629Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#730102}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Idb55f2410f440addd41543cfb2483f7b7dec7347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994257Reviewed-by:
-
Mikel Astiz authored
This is a reland of d35a5b72, which includes a fix to prevent the issue of the BookmarkModel being modified while iterated, which can invalidate iterators due to how GUID reassignment is implemented. Original change's description: > Bookmark sync: use GUID as temporary server ID during commit > > This patch effectively relands the logic reverted in > https://chromium-review.googlesource.com/c/chromium/src/+/1864800 which > caused crashes in the past (CHECK failures). > > In this new form, the underlying issue is addressed: for users that > don't use GUID-based merging of bookmarks, local GUIDs are reassigned > randomly to avoid GUID collisions in the local bookmark model. > > Bug: 978430,1004205 > Change-Id: I812d1cfe1c12b766799e6c5ec238f95fd16139ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983231 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729405} Bug: 978430, 1004205 Change-Id: Ie86f42a1d8985e325fca5741d43aefc6ef0955c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993295 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#730100}
-
Yuta Kitamura authored
Bug: 1040450 Change-Id: I80fa1ff683706760207e37c00e22b66375cce23e No-Try: true Tbr: vasilii@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995104Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#730099}
-
Matt Falkenhagen authored
This histogram expired: * Worker.TopLevelScript.OriginType.RequestUrl.DedicatedWorker Bug: 867302, 960042 Change-Id: If44ab380b6da4ad61b5343182294e4c400406b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686861 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#730098}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e70b009b0f1e..fb2e819819ef git log e70b009b0f1e..fb2e819819ef --date=short --first-parent --format='%ad %ae %s' 2020-01-08 dneto@google.com Fix GN build for OpenCL.DebugInfo.100 update (#3134) 2020-01-08 bclayton@google.com Fix bad parameter names in error message (#3129) 2020-01-07 alanbaker@google.com Revert PR #3093 (#3131) 2020-01-07 alanbaker@google.com Disallow forward references in arrays (#3093) 2020-01-07 afdx@google.com spirv-fuzz: Add fuzzer pass to perform module donation (#3117) 2020-01-06 dneto@google.com GetOperandConstants operand can be const (#3126) 2019-12-27 dneto@google.com Avoid pessimizing std::move (#3124) 2019-12-27 kburjack@googlemail.com Fix typo in validation message (#3122) 2019-12-27 greg@lunarg.com Change default version for CreatInstBindlessCheckPass to 2 (#3119) 2019-12-21 greg@lunarg.com Fix convert-relax-to-half invalid code (#3099) (#3106) 2019-12-19 dneto@google.com Support OpenCL.DebugInfo.100 extended instruction set (#3080) 2019-12-19 afdx@google.com spirv-fuzz: Always add new globals to entry point interfaces (#3113) 2019-12-19 afdx@google.com spirv-fuzz: Transformation to add a new function to a module (#3114) 2019-12-19 afdx@google.com spirv-fuzz: Avoid passing access chains as parameters (#3112) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fb2e819819ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I832222314f0eaf0dd778311e48bc7921dee3baee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994255Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d41d8be6..c83d5e24 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9b2cef40998e4d159581b2b91ca27bcecbb483c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994901Reviewed-by:
-
Gauthier Ambard authored
This CL cleans a bit more the collection view. Bug: 894800 Change-Id: I3211f9afa8af578323bec1a2a13ca8842d91c42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991449 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#730095}
-
Eric Seckler authored
Utility services are now started in a slightly different way by UtilityThreadImpl. In the past, their TraceLog process names were set in UtilityServiceFactory, which is no longer involved for most services. So, also set the process name in the new service binder. Bug: 1040525 Change-Id: Ib8900350460ee2711303519d705de3de361fb3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993349Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#730094}
-
Hitoshi Yoshida authored
Defines an almost empty class. Bug: 839389 Change-Id: Ide0536992f1247d7e53aa8109083519d41db7892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990894 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#730093}
-
Yuta Kitamura authored
Bug: 1040054 Change-Id: Iea5bfbcec4710b766b4b5117c188aa870869266e No-Try: true Tbr: vasilii@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995081Reviewed-by:
-
Francois Buergisser authored
Currently, it is necessary to guarantee request references are valid before creating decode surfaces, apply the controls, apply the buffers or submit a request. Since the requests queue only can create request references, it is assured only valid requests can be returned. Also, since only valid request references are returned, it is assured controls and buffers are applied to a valid request. Instead of returning an invalid request reference when a request creation or submission fails, use base::Optional and return empty optional argument. BUG=chromium:1009921 TEST=ran tast with video.DecodeAccelVD.vp8_resolution_switch on veyron_minnie. TEST=ran tast with video.DecodeAccelVD.h264_resolution_switch on veyron_minnie. TEST=ran tast with video.DecodeAccelVD.vp8 on veyron_minnie. TEST=ran tast with video.DecodeAccelVD.h264 on veyron_minnie. TEST=ran tast with video.DecodeAccel.vp8 on veyron_minnie. TEST=ran tast with video.DecodeAccel.h264 on veyron_minnie. TEST=ran tast with video.DecodeAccelVD.vp8_resolution_switch on kevin. TEST=ran tast with video.DecodeAccelVD.h264_resolution_switch on kevin. TEST=ran tast with video.DecodeAccelVD.vp8 on kevin. TEST=ran tast with video.DecodeAccelVD.h264 on kevin. TEST=ran tast with video.DecodeAccel.vp8 on kevin. TEST=ran tast with video.DecodeAccel.h264 on kevin. Signed-off-by:
Francois Buergisser <fbuergisser@chromium.org> Change-Id: Ia7c8a25a335a6f49ca121aa1766d094d62e29176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982330 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#730091}
-
Omar Morsi authored
Subject alternative name match is used by the WPA Supplicant to be matched against the alternative subject name of the authentication server certificate. It is sent from chrome to shill to WPA supplicant. It is sent to shill in a serialized form to be able to store it permanently on disk. Because StoreInterface used in chromeOS to save EAP data permanently doesn't support saving dictionaries. Shill implementation that uses this CL:1897535 System API implementation that uses this CL:1893872 chromeos-base/shill and chromium on my chromebook and checked the flow of the subject alternative name match and found that it is serialized correctly, transferred to shill, translated to WPA Supplicant format correctly. Tests: chromeos_unittests and built and deployed chromeos-base/system-api as well as Bug: 1004261 Cq-Depend: chromium:1897535 Change-Id: I8226e18591db89e783c450863ab6691be0ea0470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892955 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#730090}
-
Francois Buergisser authored
Currently, the same number of requests as the number of input buffers are created before starting to decode surfaces. To manage resources more efficiently, this patch creates requests only when there are no free requests available in the requests queue. BUG=chromium:1009921 TEST=ran tast with video.DecodeAccelVD.vp8_resolution_switch on veyron_minnie. TEST=ran tast with video.DecodeAccelVD.h264_resolution_switch on veyron_minnie. TEST=ran tast with video.DecodeAccelVD.vp8 on veyron_minnie. TEST=ran tast with video.DecodeAccelVD.h264 on veyron_minnie. TEST=ran tast with video.DecodeAccel.vp8 on veyron_minnie. TEST=ran tast with video.DecodeAccel.h264 on veyron_minnie. TEST=ran tast with video.DecodeAccelVD.vp8_resolution_switch on kevin. TEST=ran tast with video.DecodeAccelVD.h264_resolution_switch on kevin. TEST=ran tast with video.DecodeAccelVD.vp8 on kevin. TEST=ran tast with video.DecodeAccelVD.h264 on kevin. TEST=ran tast with video.DecodeAccel.vp8 on kevin. TEST=ran tast with video.DecodeAccel.h264 on kevin. Signed-off-by:
-
Yuzu Saijo authored
This CL changes CHECK to DCHECK back in ServiceWorkerVersion:: RestoreControlleeFromBackForwardCacheMap, as the fix is verified now. Bug: 1021718,1034141 Change-Id: I18b3a46e0dade359f34389eabddf6473e2f0775e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994029 Auto-Submit: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#730088}
-
Li, Hao authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d253f41e17e2..172e39f0398b $ git log d253f41e1..172e39f03 --date=short --no-merges --format='%ad %ae %s' 2020-01-09 post HLSL: Add a resource remapping API similar to MSL. 2020-01-09 post MSL: Deal with sign on wave min/max. 2020-01-09 post HLSL: Deal with casting for WaveActiveMin/Max. 2020-01-09 post GLSL: Deal with sign in subgroup Min/Max operations. 2020-01-08 post Run format_all.sh. 2020-01-08 post HLSL: Fix bug when reading and writing structs from SSBO. 2020-01-08 post HLSL: Implement stores for complex composites in ByteAddressBuffers. 2020-01-08 post HLSL: Support loading complex composites from ByteAddressBuffer. 2020-01-08 post Run format_all.sh. 2020-01-07 post MSL: Deal with padded fragment output + Component decoration. 2020-01-07 post MSL: Explicitly don't support component packing for tessellation. 2020-01-07 post MSL: Don't set OrigID when emitting component packed vectors. 2020-01-07 post MSL: Deal with packing vectors for vertex input/fragment output. 2020-01-07 post MSL: Add trivial tests for Component decoration. 2020-01-06 post Fix Clang warnings. 2020-01-06 post Roll custom versions of isalpha/isalnum. 2020-01-06 post Add test shader for OpCopyLogical with packing/unpacking. 2020-01-06 post Go through access chain path for OpCopyLogical. 2020-01-06 post Basic implementation of OpCopyLogical. 2019-12-21 dm86.jang Add debug prefix on Windows 2019-12-10 post GLSL: Fix array of input patch variables. 2019-12-09 post GLSL: Fix EmitStreamVertex/Primitive. 2019-12-04 post Remove obsolete use of AtomicCounterMemoryMask. 2019-12-04 post Don't emit memoryBarrierShared() in workgroup control barriers. 2019-12-03 dsinclair Update graphics robust access results 2019-12-03 post Fix MSVC warnings when building without exceptions. 2019-12-03 dsinclair Share test shader script 2019-12-03 post Update update_test_shaders.sh as well. 2019-12-02 dsinclair Roll SPIRV-Tools, SPIRV-Headers and GLSLang 2019-12-02 post Fix uninitialized memory issue. 2019-12-02 post MSL: Support ClipDistance as an input stage variable. 2019-11-28 post Fix sign handling for S/UToF. 2019-11-28 post MSL: Fix automatic binding allocation for image atomic buffers. 2019-11-27 agaule Added --msl-decoration-binding command line argument to enable binding decoration for Metal. 2019-11-26 sarahmashay Add licensing header to test_shaders.py 2019-11-26 post Mark loop headers as complex as early as possible. 2019-11-25 bill.hollings Expose as public Compiler::update_active_builtins() and has_active_builtin(). 2019-11-12 post CMake: Clarify some warning messages. 2019-11-12 post HLSL: Add CLI support for --hlsl-auto-binding. 2019-11-11 post HLSL: Add support to remove register() bindings. 2019-11-07 post MSL: Remove dubious workaround code in unpack_expression. 2019-11-07 post MSL: Fix unpack_expression from column of padded matrix. 2019-11-06 post HLSL: Report more explicitly which member failed validation. 2019-11-06 post HLSL: Report which cbuffer failed validation. 2019-11-06 post Move .invalid. test shaders to the more appropriate subfolders. 2019-11-05 dsinclair Move all .invalid shaders into no-opt folders. 2019-11-05 dsinclair Remove old reference shaders 2019-11-05 dsinclair Only run spirv-opt if the spirv is valid. 2019-11-05 dsinclair Roll GLSLang and SPIRV-Tools 2019-11-04 post Add spvc_type_get_base_type_id. 2019-11-04 post C API: Add missing boolean options. 2019-11-04 post GLSL: Fix issue with array-of-array inputs in tess. 2019-11-01 dmalyshau Avoid including stdexcept in no-exception environment Created with: roll-dep src/third_party/spirv-cross/spirv-cross Bug: dawn:33 Change-Id: I5a50b5e5a73ca01818333ee43e5cdb65d63c109a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994669 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#730087}
-
