- 16 Dec, 2017 2 commits
-
-
Will Chen authored
* reattach-after-editing-styles.html - migrated into a protocol test. * shadow-dom-rules-restart.html - migrated into a protocol test. * injected-script-discard.html - migrated into a protocol test. * tabbed-pane-closeable-persistence-restore.html - removed. It required an unusual testing API and has adequate coverage from tabbed-pane-closeable-persistence.js and browser test "DevToolsSanityTest.TestSettings" * open-close-open.html - tried migrating into a browser test, but found a race condition with quickly opening, closing, and re-opening DevTools window. This test covered a very specific regression and had a very specific implementation fix which doesn't seem applicable anymore: https://bugs.webkit.org/show_bug.cgi?id=56747 Bug: 667560 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I41b0ea3e7837dee5049cc973354c431d09d9ae7f Reviewed-on: https://chromium-review.googlesource.com/827647Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#524530}
-
Alex Moshchuk authored
Bug: 739418 Change-Id: Idc340923293ac257c15045c047da08c3c18281a6 Reviewed-on: https://chromium-review.googlesource.com/831147Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#524529}
-
- 15 Dec, 2017 38 commits
-
-
Matt Falkenhagen authored
The "service worker context" is attached to a StoragePartition. When this context tries to start a service worker, it asks SiteInstance for a process to start the worker in. This process must be in the same StoragePartition as the context. In some cases like the <webview> tag, a non-default StoragePartition is created for guests, but the service worker was trying to start up in a process for the default StoragePartition since it created a SiteInstance using the script URL of the worker (e.g., https://www.example.com) and got a process from that. The solution is to stash the site URL on the StoragePartition when it's for guests (e.g., chrome-guest://someapp/somepath), and have service worker use that site URL when creating a SiteInstance. Bug: 781313, 752667 Change-Id: I8bf7ee8fd78a42e6c4e23684160c18da4e5189e5 Reviewed-on: https://chromium-review.googlesource.com/807973Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#524528}
-
Elliot Glaysher authored
I only saw these comments after the patch landed. Bug: 769308 Change-Id: Ia401bb2ec83a714e89a0cc16d8262a341f354e99 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/831059Reviewed-by:
Elliot Glaysher <erg@chromium.org> Reviewed-by:
-
Yuly Novikov authored
BUG=793970 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I44b9c33f7d7dc2bfde4e0cf4093e91dd80adc391 Reviewed-on: https://chromium-review.googlesource.com/821470Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#524526}
-
Ivan Sandrk authored
In locked fullscreen mode we want to disable most keyboard shortcuts to prevent circumventing the mode. More details on the design doc: go/locked-fullscreen-mode/?disco=AAAABc8Ml1k Bug: chromium:755696 Change-Id: I9ad28cab5cc5dae77ff00295b470ef268bff4d9d Reviewed-on: https://chromium-review.googlesource.com/785952 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
-
Joel Einbinder authored
Some dark theme colors were being unintentionally overwritten by the light theme. Some other colors were never defined in the dark theme. Bug: 738029 Change-Id: I161a23dbf296980af0c4f4a9fab49558e9941fd1 Reviewed-on: https://chromium-review.googlesource.com/826037Reviewed-by:
-
Yves Arrouye authored
Act directly on changes to policy data. Do not store a CrOS setting for when an enrollment identifier is needed. Do not convert the current policy in ChromeDeviceSettingsProto to anything (it will be removed). BUG=chromium:778535 TEST=unit_tests Change-Id: I49fb2537556f9e3781267f9eb2ede1b2d5dee964 Reviewed-on: https://chromium-review.googlesource.com/827575Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#524523}
-
xlou authored
TestEng needs some APIs to help with testing. This API returns the list of printers which includes kConfigured, kEnterprise, and kAutomatic printers that are available through CupsPrintersManager. R=achuith@chromium.org, isherman@chromium.org, skau@chromium.org Bug: 780998 Change-Id: Ib5411ba5a3a094a2772ce5ecbbf636f66e9597dd Reviewed-on: https://chromium-review.googlesource.com/818394 Commit-Queue: Shirleen Lou <xlou@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#524522}
-
Ovidio Henriquez authored
This change updates the prefixes used for loading Chromium specific resources to use the aliases used by the Apache HTTP server for the http bluetooth test. As a result, the cross origin iframe test now uses the new test API so that it can be migrated to the wpt/ directory. BUG=509038 Change-Id: Ib946c912913d7a67b887fff4d74e432ea915ddb9 Reviewed-on: https://chromium-review.googlesource.com/827531Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#524521}
-
Dmitry Skiba authored
This CL adds more trace events to functions called during renderer startup. See crbug.com/794646#c1 for before/after results. Bug: 794646 Change-Id: I2bd0d7f46f128c112c9da9fac9b643ca203d6237 Reviewed-on: https://chromium-review.googlesource.com/825623 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524520}
-
rnephew authored
Bug: 781409 Change-Id: I214af9ee0173795c5909d3a037c944af8f5ae456 Reviewed-on: https://chromium-review.googlesource.com/830683Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#524519}
-
Kurt Horimoto authored
In addition to adding keyboard notification observation, this CL also moves VoiceOver fullscreen disabling into a shared object. Bug: 793129 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia8f8501ff7f5e97ec9d794e6c3d33687e90f4d9f Reviewed-on: https://chromium-review.googlesource.com/816356 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524518}
-
Maria Khomenko authored
When tests use a rule that enables features and the test enables yet another feature separately only one set of features will end up getting applied because the enable-feature/disable-feature flag is duplicated. Ensure we aggregate all requests before applying. BUG=786454 Change-Id: I79208e13f25de7c725d71f241481a454265d83c4 Reviewed-on: https://chromium-review.googlesource.com/830259Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#524517}
-
Elliot Glaysher authored
mus-chromeos can work as a remoting accessor, but before this patch, didn't process input events correctly. You can now chromote into a mus-ash environment. Bug: 769308 Change-Id: I92ccd3d5e6cda9e873be59d711acdc83a2864772 Reviewed-on: https://chromium-review.googlesource.com/827940Reviewed-by:
-
xlai authored
This CL lets HTMLCanvasElement directly access Canvas2DLayerBridge. As a result, the ImageBuffer and ImageBufferSurface classes are trimmed down drastically: 1. Functions that serve to re-route calls in between canvas and its rendering contexts and Canvas2DLayerBridge become redundant and are all removed. 2. ImageBuffer::CopyRenderingResultsFromDrawingBuffer, which is used by webgl only, now becomes a function in WebGLRenderingContextBase. 3. Functions that are used by canvas 2d only, such as ImageBuffer::PutByteArray, ImageBuffer::WritePixels, etc, have all became functions in BaseRenderingContext2D. 4. ImageBuffer::CanCreateImageBuffer becomes SkiaUtils::IsValidImageSize. 5. ImageBuffer::CopyToPlatformTexture becomes StaticBitmapImage::CopyImageToPlatformTexture. 6. Some small functions that are called once are dissolved into other classes. Bug: 776806,776802 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4fb6ba344ac7b23761631985e61d65906f6225ed Reviewed-on: https://chromium-review.googlesource.com/824437 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#524515}
-
Donn Denman authored
When the panel is showing and Talkback is enabled the panel should be hidden. BUG=787553 Change-Id: Ic98b347f7cff6dc931b952e9846968fbecc67eed Reviewed-on: https://chromium-review.googlesource.com/830607Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#524514}
-
Christopher Cameron authored
Set local surface id based on resize in BrowserCompositorMac. Bug: 772576 Change-Id: I212c9bd4c694e6300345bb7c83a7a22c73c7ce97 Reviewed-on: https://chromium-review.googlesource.com/830822 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#524513}
-
Victor Costan authored
Bug: 729800 Change-Id: Ic4753af825aa89e26c06da2ff944f03667669697 Reviewed-on: https://chromium-review.googlesource.com/818451 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524512}
-
Sahel Sharify authored
This cl implements touchpad fling processing on browser side. Instead of sending GFS events to the rendered, the fling controller generates the fling_curve_ on GFS, and ProgressFling generates and sends wheel events with momentum phase every 16ms. GSU events with inertial state will be generated from wheel events and handled by the renderer as usual. If the GFS has zero velocity the controller sends a wheel end event immediately rather than generating a fling curve. Once the fling curve is over or a GSU event with inertial state is not consumed, the fling controller will send a wheel event with momentum phase ended. Processing the wheel end event will generate a GSE event which shows the end of fling. Fling boosting also happens on the browser side whenever possible. Bug: 249063 Test: FlingControllerTest.* Change-Id: I69a89bd38da7e5253bf921a1aa33e5efe601f361 Reviewed-on: https://chromium-review.googlesource.com/664258 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#524511}
-
danakj authored
TBR=sky@chromium.org Change-Id: I681f512b7fcb29cda09ee1771758917a50665c90 Reviewed-on: https://chromium-review.googlesource.com/830891Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/b5e23eeaae74..cb66d9d95233 $ git log b5e23eeaa..cb66d9d95 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 spang tracing: Add support for system tracing via chrome://inspect?tracing Created with: roll-dep src/third_party/catapultBUG=786091 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I6f4fe62368d90b011ca322d08448265e8ddb6d66 Reviewed-on: https://chromium-review.googlesource.com/830657 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524509}
-
Troy Hildebrandt authored
Currently, partner bookmarks aren't submitted until all the favicons are fetched which can potentially be quite slow on a bad connection. This change submits the bookmarks after they're read, regardless of whether the favicons have been fetched yet. When all the asynchronous favicon fetching has completed, if any favicons were retrieved from a server, we refresh the bookmarks to show the new favicons. Also adds a new enum value for FaviconFetchResult to capture the case of retrieving a duplicate favicon that wasn't written to the favicon image cache as a result of being duplicate. These were being treated as the default FAILURE_SERVER_ERROR before, and blacklisting URLs unnecessarily even when the favicon existed in the cache already. Bug: 780042 Change-Id: I2409acc3c7c558106aae417d7e709fb0e7539f3f Reviewed-on: https://chromium-review.googlesource.com/804655 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524508}
-
Brett Wilson authored
This converts most remaining callers to use the new API. Any stragglers will be caught in a followup when the old API is removed. Change-Id: I85613fab9ce10417d75f4fa29c7c229565aebef4 Reviewed-on: https://chromium-review.googlesource.com/830055 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
-
erikchen authored
The feature has been in experimental for over 4 months. There were 2 blockers, both of which have been fixed. Bug: 650433 Change-Id: Ifc081da195c1a4972e20eb2ffc11ab972af50f51 Reviewed-on: https://chromium-review.googlesource.com/830667Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524506}
-
Vadym Doroshenko authored
This CL contains the following tiny clean-ups: 1.Removing checking trustLevel in AutofillAgent, which according to comment https://chromium-review.googlesource.com/c/chromium/src/+/826476/5/components/autofill/ios/browser/autofill_agent.mm#571 is not useful anymore. 2.Making function getPasswordFormDataList to be private. It's not called outside of password_controller.js 3.Removing a todo comment in getPasswordFormData, which doesn't have much sense now (even on other platforms PasswordManager doesn't do anything like that). 4.Fixing comment in form.js Bug: 782224 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifda40db4c15b8768282f02d36e2463bf9cf58e54 Reviewed-on: https://chromium-review.googlesource.com/827939Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#524505}
-
Sunny Sachanandani authored
These have been undocumented for a long time. This CL documents these in the CHROMIUM_ordering_barrier extension. R=piman BUG=NONE Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3c9a4a7e4634e5bfb760f3852fb07b05e8eed5eb Reviewed-on: https://chromium-review.googlesource.com/826486 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Tim Brown authored
Also update the "Notes for other distros" in the build instructions. All usages of gconf has been removed, and we depend on gsettings, not dconf directly. This is the final step in switching from gconf to gsettings. Bug: 768027 Change-Id: I4430c261ac2c9691838e7dfe9c0d7c6842fa535f Reviewed-on: https://chromium-review.googlesource.com/831106Reviewed-by:
-
Alex Newcomer authored
The bug is that after two-finger tapping on an app icon in the shelf, the shelf sometimes becomes unresponsive. This was caused by logic that assumed we wanted to forward all gesture events when the context menu was created with a gesture event. This is fixed by adding a check to see if we are actually dragging an app icon before asking MenuRunner to send events to owner. TEST=manual Bug: 794681 Change-Id: Ib2b764126874f9fd58578a1610a70e2c7881ff78 Reviewed-on: https://chromium-review.googlesource.com/828293 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#524502}
-
Victor Costan authored
The default constructor is only used in tests, for convenience. It is not obvious what the semantics should be for such a constructor. This CL removes the default constructor and introduces a test helper that creates IDBValue instances. Bug: Change-Id: If8b2cada03afe8cd3ffa58cc6ab711d96b96f013 Reviewed-on: https://chromium-review.googlesource.com/828694 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
The API is now accessible from browser, so there is no need for special handling in renderer. This unblocks moving DevToolsAgent to blink. Bug: 776009 Change-Id: Ie2b96e2fa99a613cbc26ec6703afe7d940d3d3c8 Reviewed-on: https://chromium-review.googlesource.com/828292 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
rnephew authored
Bug: 781409 Change-Id: Ia653a5a71e3e0063836a6e158ca3fcd6f2dc549b Reviewed-on: https://chromium-review.googlesource.com/830676Reviewed-by:
-
Peter Qiu authored
Bug: None Test: Build Change-Id: I5de864400b4b441deb934d5426cff23a4f3b1b74 Reviewed-on: https://chromium-review.googlesource.com/829917Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#524498}
-
Zhenyao Mo authored
and no longer blacklist GPU access if preliminary GPU feature decisions differ from full info decisions. The reason we can do this now, is because the only GPU feature check that's not from GPU process is kDisableAcceleratedVideoDecode on Android. There is no decision difference on Android between preliminary and full info. This should get quite a few Windows machines putting to SwiftShader back to GPU acceleration. BUG=744658,764290,766190,774000,793845 TEST=bots R=piman@chromium.org,kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3fae7ff326a9cf2ea5b23c56261cb3139416a38f Reviewed-on: https://chromium-review.googlesource.com/828040 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
David Tseng authored
Debug generates slightly different output than release. TBR=dtseng@chromium.org Original description: ChromeVox Classic is no longer available to users. This allows us to remove some complexity surrounding the idea of the various modes for ChromeVox (classic, next, etc). This change mostly is meant to be cleanup, but it also addresses some bugs. Namely, we unintentionally relied upon onModeChanged to trigger specific behaviors such as installing command handlers. This made sense when mode changes had to be supported. However, with this in a limbo state now that there is no classic mode, we can no longer invoke commands with an empty desktop. Original change: https://chromium-review.googlesource.com/c/chromium/src/+/825169 Bug: Change-Id: Ibcfe282ceacac766ca47edecaa3302d59be8fcd5 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/829976Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#524496}
-
W. James MacLean authored
Since (i) this test seems to run fine for the /1 parameter case, and (ii) the /1 parameter case represents the default configuration for chrome as of M63, let's only disable the test for the failing configuration, /0. TBR=kbr@chromium.org Bug: 794490 Change-Id: Id1ab8dcfdafecafca138d42a9b3d3401f5d7d203 Reviewed-on: https://chromium-review.googlesource.com/830709Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#524495}
-
Scott Violet authored
The TestApi class now handles all this, so no reason for the public virtual ForTesting functions. BUG=776514 TEST=test only changes Change-Id: I1e8165fe1747a7b1b0c1ccfc4f2d0f036eb5d3b5 Reviewed-on: https://chromium-review.googlesource.com/830685Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524494}
-
rbpotter authored
To improve consistency with other printer types and avoid a second round of rendering, use the PDF stored in the print preview data store for local printers. Bug: 795398 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d3423efb8b473ef862491b203bb18eb172e6458 Reviewed-on: https://chromium-review.googlesource.com/704262Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#524493}
-
Ian Vollick authored
Fixes a mistyped number. Bug: None Change-Id: I770e954de312774a05e96ceb7735895d8a1df9c6 Reviewed-on: https://chromium-review.googlesource.com/830889Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524492}
-
David Benjamin authored
To parse some Android structure, CBS will need to grow support for tag numbers above 31. In preparation for that, BoringSSL will need to make the CBS/CBB tag representation not quite match the DER encoded form. See https://boringssl-review.googlesource.com/c/boringssl/+/23304. https://chromium-review.googlesource.com/783254 attempted to prepare for this by leaving net::der::Tag as-is and translating between the two tag representations. But the NormalizeName code takes a Tag and passes it into a CBB function. To avoid needlessly translating things there, this CL takes the opposite tack. It instead defines that net::der::Tag matches the BoringSSL representation. This fixes the NormalizeName test with the BoringSSL change re-landed. It does mean we'll need to replace ParserTest.TagNumbersAboveThirtyUnsupported with ParserTest.TagNumbersAboveThirtySupported concurrently with the BoringSSL roll, but we can manage that one. This CL should be no-op as-is, but will no longer be a no-op when the BoringSSL change is relanded. Bug: Change-Id: I4e8fc1607eb3691733f998a24648f330e65137e6 Reviewed-on: https://chromium-review.googlesource.com/828385Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#524491}
-
