- 20 Jan, 2021 40 commits
-
-
Jonah Chin authored
This is a reland of 4107e01f Original change's description: > Change texture subset logic in PaintCanvasVideoRenderer > > This CL is to simplify how PaintCanvasVideoRenderer::Cache manages > video frames whose |visible_rect| is smaller than their |coded_size|. > By always using SkImage::MakeFromAdoptedTexture, texture lifetime > management is now always handled internally by skia. This will make the > transition to OOPR here much simpler. > > More details about overall PaintImage effort: crbug.com/1023259 > Info about the OOPR-Canvas2D project: crbug.com/1018894 > > Bug: 1115217 > Change-Id: I2177b2deeea893fa5331afbe8796761253db2759 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451213 > Commit-Queue: Jonah Chin <jochin@microsoft.com> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818045} Bug: 1115217 Change-Id: I532715126f23735c72d7282bfc47495ac3da24e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634055Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845058}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I44d864f08a04a4eb90710ec1251843246353f9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638860Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845057}
-
Moe Ahmadi authored
Removes fakebox resources/handlers/tests from the NTP since it's been made deprecated by the realbox. Fixed: 1168269 Change-Id: I03b93330f91413a3efd57be92e5ec62e6d89c778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638536Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845056}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 89.0.4389.6. R=sky@chromium.org Bug: 1041619 Change-Id: I994c655a8e71f486d5c55944a2de3c5553e4dbed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638243 Commit-Queue: Rakib Hasan <rmhasan@google.com> Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#845055}
-
Mustafa Emre Acer authored
This CL adds a test case where the upgraded HTTPS URL redirects to another HTTPS URL. The test simply checks if an upgraded HTTPS URL that redirects to another good HTTPS URL successfully loads and records a histogram entry. There are additional interesting cases involving redirects, however it's not yet fully clear how the feature should behave in those cases. For example, an upgraded HTTPS URL could redirect to a broken HTTPS URL. It's TBD whether this should fall back to HTTP or not. For that reason, these cases aren't yet tested. Presently, the autocomplete code does the upgrade from HTTP to HTTPS and it only upgrades URLs with default ports. As a result, browser tests need to use URLs with default ports, so they use URLLoaderInterceptor instead of EmbeddedTestServer. (URLLoaderInterceptor can return responses for URLs with a default port (e.g. https://example.com) whereas EmbeddedTestServer can't.) I wasn't able to simulate a redirect using URLLoaderInterceptor, so this CL modifies the autocomplete code to accept a non-default port as well. It also adds a new test class that uses EmbeddedTestServer to serve the http and https URLs. The rest of the browser tests are unchanged and still use URLLoaderInterceptor so that the codepath that uses the default ports is still exercised. Bug: 1141691 Change-Id: Ic0d0638758bf457fad508ef028144681a7034cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621964 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#845054}
-
Raphael Kubo da Costa authored
The comment about passing parameters by value was added in r429564 ("[sensors] Close mock sensor stubs after test is finished") but was made obsolete by r450741 ("[Sensors] Fix error type and message used"). Change-Id: Ic8c07ce6d2f0b481a64dd706339761eca5d6323e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631503 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845053}
-
James Cook authored
For Wayland debugging, it's helpful to add WAYLAND_DEBUG=client to the lacros environment. Introduce --lacros-chrome-additional-env to set arbitrary additional environment variables when launching lacros. Bug: none Change-Id: Ie44f4edd80459d606216cab733e99027d42fc986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636264Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845052}
-
Esmael El-Moslimany authored
Bug: 1139032 Change-Id: Icea07c79fbad8bf34664f1ce7ce53380beaadd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637262 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845051}
-
Jeffrey Young authored
There was a case when |UpdateSettings| could be called the first time a user opened Ambient mode settings, even when Ambient mode was disabled. Now, only update settings if pref is enabled. Additionally, issue an |UpdateSettings| call when the pref is enabled. This ensures that Ambient settings are synced to server even when a user does not edit temperature settings or photo albums. BUG=b:177456397 TEST=unit_tests --gtest_filter=AmbientModeHandlerTest.* TEST=open settings page, personalization, screen saver, toggle ambient Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I924af998954927f0fc38746b34b8fce1ff641509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631305Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845050}
-
Jiewei Qian authored
This is a reland of 62cb2352 The original CL fails when AppBrowserControllerBrowserTest.Shutdown passed a destroyed to LaunchSWAImpl. The reland removes this DCHECK because the use of GetCreationStatusForProfile already makes sure the DCHECK is always successful. Original change's description: > system-web-apps: implements a new LaunchSystemWebAppAsync API > > This CL implements a new LaunchSystemWebAppAsync API, which is for other > chrome components to launch a SWA safely. This new API should be used > for SWA launches. > > The new API uses AppService to record metrics, handle disabled apps, > etc. > > The old LaunchSWA is deprecated (its logic now becomes LaunchSWAImpl). > > LaunchSWAImpl is publicly declared because certain browser tests need to > know the browser that hosts the SWA. It shouldn't be used to launch the > App (other than LaunchSWA and Web app implementations). Subsequent CLs > will attempt to migrate these browsertests to work with the new API. > > Bug: 1154540 > Change-Id: I648a3b0404067ba460f0174e975fae44b3a0001a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592270 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843939} Bug: 1154540 Change-Id: Ice207ac03834452223c5bb2ef880c6667e6cb25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633485Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#845049}
-
Trent Begin authored
The network ONC strings are used both in //chrome and //chromeos. Strings that are required in both locations need to be moved to //chromeos to prevent a layering violation. Screenshots are added in this change as they were not required when these strings were originally added. This change moves the remaining cellular, tether, and EAP strings. Bug: chromium:1159069 Change-Id: Ifa804cea9be794b8d93091cfd286bb87bd1d7314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638221Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845048}
-
Luciano Pacheco authored
When running as JS module which is strict by default, the code fails to assign to `e.target`. Fix this by declaring a local variable `target` with the desired Closure type markup. Bug: 1133186 Change-Id: I5033eae87310e4eebdae2e2b22487df8ffc01a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636904 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#845047}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I766596592c91c3e226df72b99d4cf53d3d67f7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845046}
-
Alison Huffman authored
Currently on iOS, DOM Distiller cannot guarantee that the data being sent to it comes from the distillation script. This allows arbitrary HTML to be included in the final reader mode version of the page. This combined with a find-replace-style inclusion of arbitrary origin data sourced from image tags, allows the leaking of cross-origin authenticated pages. This change adds a CSP policy for iOS reader mode, enforces paginations belong to the same origins, includes offline images through JavaScript, and performs mime-sniffing on offlined images to ensure they are valid images. Bug: 1111239 Test: Tested changes with cases provided in bug. Change-Id: Idf9c8986c541bcab32fb8d320ebdf75b55dc7839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608284 Commit-Queue: Alison Huffman <ahuffman@microsoft.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845045}
-
Ryan Heise authored
Bug: chromium:1163679 Change-Id: I5bb4d8efe9317caf328fafb818f12abb5d95f5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629664 Commit-Queue: Ryan Heise <heiserya@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#845044}
-
Dmitry Gozman authored
This is similar to what chrome/browser/renderer_preferences_util does. Bug: none Change-Id: I1b0b73dca22175446c143497a07c1ad2994e72e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637081 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845043}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e0490eedcc8..192a0147c3fe 2021-01-20 vantablack@google.com Multithreading in D3D11 minimum viable product 2021-01-19 syoussefi@chromium.org Add a helper ShaderVariable method to facilitate member rename If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ie6697d64ca00c7304fb61318cc462d925fdc76fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845042}
-
Alex Gough authored
This enables the CETCOMPAT linker flag for Windows marking binaries as CET compatible. On supporting hardware this will cause Chrome to run with Hardware Enforced Stack Protection for compatible modules. CET will still be disabled for the renderer process as the feature CetForRenderer is default-disabled. x86 is not supported: build/config/compiler/BUILD.gn:2519 Tests: mini_installer on supporting hardware Bug: 1131225 Change-Id: Ic5db6eca0acf4cdfb0eff0f624e4d4f4e5a7da50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602845Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845041}
-
Jinsuk Kim authored
Removes the dependencies on the following flags. They are now passed from ToolbarManager through ctors/setters: - TabUiFeatureUtilities.isGridTabSwitcherEnabled() - TabUiFeatureUtilities.isTabToGtsAnimationEnabled() - StartSurfaceConfiguration.isStartSurfaceEnabled() - VrModuleProvider.getDelegate().isInVr() This change allows following toolbar classes to be in the modularized target: - NewTabButton - ProgressAnimationSmooth - ToolbarProgressBar/Test - LoadProgressCoordinator MVC/Test - TabSwitcherButtonCoordinator MVC - TopToolbarOverlayCoordinator MVC - TopToolbarSceneLayer Bug: 1127732 Change-Id: I403421191d5634a02a6ea9a5ca8bbc2daa7681d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631394 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#845040}
-
Michael Savigny authored
Change from 'racing' to 'remote_local_fallback'. Racing needs more testing on CQ/CI before making it the default. Bug: 1149386 Change-Id: I737f27bbd1bcca5b29448882108ad8ec642566ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635345Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Michael Savigny <msavigny@google.com> Cr-Commit-Position: refs/heads/master@{#845039}
-
Wan-Teh Chang authored
Implement mirroring and rotation of AVIF images by converting the 'irot' and 'imir' image item properties to the equivalent Exif orientation value. The Exif metadata, if present in the AVIF image, is ignored. Add several AVIF test images with the 'irot' or 'imir' image item properties. Check the image orientation in avif_image_decoder_test.cc. Update and fix TODO comments in avif_image_decoder_test.cc. Bug: 1087059 Change-Id: I79c4d325407ce373c849c4e91058f98fd3397ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634311Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#845038}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie11c7f3111ee176fb257867c81b0134d7b3547cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638780Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845037}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b746faf. With Chromium commits locally applied on WPT: 72936ae9 "Improve raster scale for nested and unknown-scale transform animations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: If53024ef6c9c58dfcae258cef27e24764932ba63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638158Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845036}
-
Aleks Totic authored
Did not handle block size distribution over empty rows correctly. If there are empty constrained, and unconstrained rows, distribute only over unconstrained rows. We used to distribute over all empty rows. Row height distribution is tricky. There is no agreement between browsers on what the right thing to do is. FF never grows empty rows. Chrome does not distribute heights specified on TBODY. Bug: 1161157 Change-Id: I7cb2fb76ef4add651c61b10dbf8dd9fa0b58db0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632154Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845035}
-
Yutaka Hirano authored
Bug: 1168373 Change-Id: Ifa90366c8a85699702a1b4171aaacbf34c431bfb No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639116 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845034}
-
rbpotter authored
Remove use of CallJavascriptFunctionUnsafe from net_internals_ui.cc. Update BrowserBridge to class based syntax and use sendWithPromise as needed. handler occurs like in production code, so cannot easily be stubbed out with a TestBrowserProxy. Therefore, moved test observers to the class being tested. Note: Unlike many WebUI tests, these tests assume a round trip to the Change-Id: Id2453205e1bdc912b5e20aeba12f1082ed09629d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634129 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845033}
-
Moe Ahmadi authored
When composing input text with IME featuring candidate words dialog, pressing the arrow keys produces KeyboardEvents with |isComposing| property true. Ignoring those events prevents the selection from changing in the realbox dropdown while still allowing the user to select candidate words. Also since the 'Enter' key is used to confirm a composition, that too should be ignored during IME composition. Furthermore, when composing Korean (Hangul) input with IME, an extraneous input event is fired when selection changes via the arrow keys before the input text actually changes. This causes autocomplete to be queried and the dropdown to flash producing an undesirable UX. Ignoring input events when the input text remains unchanged prevents that. Note that cases in which the user types the next character in the inline autocompletion and thus the input essentially remains unchanged are handled in onInputKeydown_(). Bug: 1154327, 1167356 Change-Id: Idf6f95af03f44a469036e60f6f8c4f161a6048c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628017Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845032}
-
Wojciech Bielawski authored
Python3 generator objects don't support concatenation, aren't compatible with len() and can't be reused. In such cases they must be wrapped with list(). Bug: 1168119 Change-Id: Iec1bd845a9b2c77f0ec03d2e0ed02fbdfebb099a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637581Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#845031}
-
Dale Curtis authored
Missing ()s around print(). Bug: 941669 Change-Id: Iafb67f9f3b04e068bb91310612b8e64eaeb25b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638537Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#845030}
-
Azeem Arshad authored
This CL adds the RequestInstalledProfile method in hermes Euicc client. A corresponding method is also added in FakeHermesEuicc client. The fake client behavior simulates how installed profiles will be listed in hermes. Cellular services will be created in shill for non-pending profiles but profiles won't be listed until after a call to RequestInstalledProfiles. This also renames the RequestPendingEvents method to RequestPendingProfiles. Bug: 1093185 Change-Id: Id8f24b6540031deb23ae6ddc088cfb8aa73a65b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638515Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845029}
-
Bartek Nowierski authored
We already have USE_PARTITION_ALLOC_AS_MALLOC, which serves the same purpose. Change-Id: I689386a830115a4b1c5632b4e75639365e57d996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631893Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#845028}
-
Minoru Chikamune authored
Before this CL, SVGImageChromeClient uses per-thread CompositorTaskRunner. After this CL, SVGImageChromeClient will use per-ASG CompositorTaskRunner. Bug: 1105403 Change-Id: I8aee7c032baa96e3d86bfa255d1e76f0464f2cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626684 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845027}
-
Michael Crouse authored
Bug: 1165517 Binary-Size: Expected increase due to inclusion of TFLite in binary. Change-Id: I1c4c7b26f257c152d9477855ad32a77c0d30b85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616241Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845026}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611078768-634fb3ae1c67578f99ad9e12394867d392a20265.profdata to chrome-mac-master-1611100586-c8c655fcd161c65cbf56bbbf122c093bef715f90.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I14e56c0006f8887bd46fc01d6e8258586b35158e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845025}
-
Julie Jeongeun Kim authored
This CL replaces blink::mojom::ResourceType with network::mojom::RequestDestination in //chrome/browser/signin since blink::mojom::ResourceType is deprecated[1]. It adds IsFetchLikeAPI() to ChromeRequestAdapter to check if the request has |is_fetch_like_api|. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: Ic83985731cd724f42447a73521b17a56219d29c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636895 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#845024}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610775681-262289403e7fd8444a73878a73a9f9f97304c245.profdata to chrome-linux-master-1611100586-44f5728e7d171615fda2c2af633f569a7b45f05a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4e18715e339b984027ec924a1ebcd1bcd55ca975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845023}
-
Shahbaz Youssefi authored
Bug: 1143408 Bug: angleproject:2930 Bug: angleproject:3481 Change-Id: I7344df11f5e8999e73b564dba78dc2ae3ad7ed5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637955Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845022}
-
Dominick Ng authored
BUG=1151969 Change-Id: Ic9f451aee91e8473104996ca4194510577e0524f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632106 Auto-Submit: Dominick Ng <dominickn@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#845021}
-
Adam Langley authored
This change changes the wording for the caBLE UI when doing caBLEv2 serverlink. The dialog now contains a link (“Didn't get it?”) which triggers a new dialog state that instructs the user to connect the phone via USB cable. BUG=1002262 Change-Id: I292fe39455cbef296ec6088a7d4ff8a309ff066b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630740 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#845020}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I284d1d412b8bcc6a2aca7a34f86b9a4b1d49b2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845019}
-