GitLab

The corresponding desktop CL: https://codereview.chromium.org/1090753002

BUG=NONE
TEST=Building html_viewer from scratch also builds the network service.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1097503002

Cr-Commit-Position: refs/heads/master@{#325501}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bdb0bf5..9c79820

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1098463002

Cr-Commit-Position: refs/heads/master@{#325500}

For a full list of changes, see
https://github.com/chromium/web-page-replay/compare/4e4d540...4e772b9

BUG=

Review URL: https://codereview.chromium.org/1087243003

Cr-Commit-Position: refs/heads/master@{#325499}

This CL moves the ownership of NavigationRequests from a map in NavigatorImpl
to the FrameTreeNode. This ensures that NavigationRequests are unique per
FrameTreeNode and are also properly deleted on destruction of the
FrameTreeNode. It also makes it easier to have PlzNavigate adapt to the
refactoring of DidStart/StopLoading happening in
https://codereview.chromium.org/1080143003/.

BUG=439423

Review URL: https://codereview.chromium.org/1080073004

Cr-Commit-Position: refs/heads/master@{#325498}

This CL adds the DBus bindings needed to be able to host BLE advertisment
objects and register those advertisements with BlueZ.

R=armansito@chromium.org, jamuraa@chromium.org
BUG=466375

Review URL: https://codereview.chromium.org/1052363005

Cr-Commit-Position: refs/heads/master@{#325497}

Reason for revert: breaks some keyboard layouts (crbug.com/473932)

BUG=473932
TBR=oshima@chromium.org,sadrul@chromium.org

Review URL: https://codereview.chromium.org/1094693002

Cr-Commit-Position: refs/heads/master@{#325496}

Standard functions for people to check if content from an origin can be
considered to have been transferred to the browser securely, as defined in
https://www.w3.org/TR/powerful-features/#is-origin-trustworthy.

BUG=362214,470142

Review URL: https://codereview.chromium.org/1049533002

Cr-Commit-Position: refs/heads/master@{#325495}

This is a regression from https://codereview.chromium.org/953233002

BUG=475939

Review URL: https://codereview.chromium.org/1078123002

Cr-Commit-Position: refs/heads/master@{#325494}

Multi-line Python regex's with inner python comments was breaking sublime
text's syntax highlighting.

BUG=NONE

Review URL: https://codereview.chromium.org/1091063002

Cr-Commit-Position: refs/heads/master@{#325493}

This patch includes the changes that enables <webview>.addContentScript/removeContentScript API  work on extensions.

This is the first patch in a series of patches:
1) Implement <webview>.addContentScript/removeContentScript API [1] (https://codereview.chromium.org/959413003)
2) Implement <webview>.addContentScript/removeContentScript API [2] (https://codereview.chromium.org/1056533002)
3) Implement <webview>.addContentScript/removeContentScript API [3] (https://codereview.chromium.org/1058113002)

TBR=asvitkine@chromium.org
BUG=461052

Review URL: https://codereview.chromium.org/959413003

Cr-Commit-Position: refs/heads/master@{#325492}

Code that interacts with device/usb often lives on the UI thread. As
with the recent migration of device/hid (issue 422540) moving ownership
of these classes to the UI thread makes calling code substancially
simplier. Blocking operations are handled internally by posting tasks
to the FILE thread and returning a result to the UI thread
asynchronously.

This change paves the way for replacing libusb with platform-specific
implementations of these classes that may have different thread usage
requirements (as is the case in the device/hid code).

BUG=427985

Review URL: https://codereview.chromium.org/980023002

Cr-Commit-Position: refs/heads/master@{#325491}

BUG=472672

Review URL: https://codereview.chromium.org/1057553003

Cr-Commit-Position: refs/heads/master@{#325490}

Whitelist the chrome history page so that it can trigger starting up the sync
engine. It gets special treatment since it's where the other devices UI lives.

BUG=476678

Review URL: https://codereview.chromium.org/1062013003

Cr-Commit-Position: refs/heads/master@{#325489}

BUG=455694

Review URL: https://codereview.chromium.org/1056213003

Cr-Commit-Position: refs/heads/master@{#325488}

The previous usage of Log required layers and components to
redefine Log classes and have them declare log instances. This was
not convenient and made base packages needlessly aware of specialized
layers.

This approach has the callers specify the group tag at every call, removing the need to get any sort if logger instance.

BUG=472152

Review URL: https://codereview.chromium.org/1080543002

Cr-Commit-Position: refs/heads/master@{#325487}

It makes it possible to tell if the GPU process is stuck waiting
for a DRM device to authenticate.

BUG=476728

Review URL: https://codereview.chromium.org/1086353003

Cr-Commit-Position: refs/heads/master@{#325486}

Review URL: https://codereview.chromium.org/1061433003

Cr-Commit-Position: refs/heads/master@{#325485}

This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc.
It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc.

Original CL (reverted for unrelated failure):
https://codereview.chromium.org/1043343002/

BUG=430115
TBR=michaelpg, pneubeck, mpearson@chromium.org

Review URL: https://codereview.chromium.org/1091043002

Cr-Commit-Position: refs/heads/master@{#325484}

Revert of Fix errors found in Mac gn component builds (patchset #10 id:180001 of https://codereview.chromium.org/1087873003/)

Reason for revert:
Suspected of breaking Mac GN, see https://codereview.chromium.org/1087873003

Original issue's description:
> Fix errors found in Mac gn component builds
>
> Mac gn component build fail because of missing frameworks and missing some other
> dependencies, and occasionally file list out of sync with the gyp counterpart:
> http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/321/steps/compile/logs/stdio
>
> For instance, the frameworks linked in the components that sync depends on is not
> automatically linked into sync, thus revealing the issue.
>
> Committed: https://crrev.com/ae8297db22a6ca96652d42bd0cdc3deff17aba4a
> Cr-Commit-Position: refs/heads/master@{#325479}

TBR=dpranke@google.com,dpranke@chromium.org,brettw@chromium.org,avi@chromium.org,toyoshim@chromium.org,piman@chromium.org,pavely@chromium.org,dalecurtis@chromium.org,jiangj@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1089773003

Cr-Commit-Position: refs/heads/master@{#325483}

The [data_]deps of source_set dependencies aren't built.
The group target type works as I'd expect; see bug for details.

This is still a GN bug(?) workaround, but a cleaner one.

BUG=477104
TEST=Building mojo/services/html_viewer:apptest builds mojo_shell
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1053493003

Cr-Commit-Position: refs/heads/master@{#325482}

BUG=467287
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1095433005

Cr-Commit-Position: refs/heads/master@{#325481}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d352e4a..3cf1422

TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/1089393003

Cr-Commit-Position: refs/heads/master@{#325480}

Mac gn component build fail because of missing frameworks and missing some other
dependencies, and occasionally file list out of sync with the gyp counterpart:
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/321/steps/compile/logs/stdio

For instance, the frameworks linked in the components that sync depends on is not
automatically linked into sync, thus revealing the issue.

Review URL: https://codereview.chromium.org/1087873003

Cr-Commit-Position: refs/heads/master@{#325479}

BUG=none

Review URL: https://codereview.chromium.org/1088013002

Cr-Commit-Position: refs/heads/master@{#325478}

Changes the parameter default_zoom_factor to appear as defaultZoomFactor
to javascript.

BUG=477559

Review URL: https://codereview.chromium.org/1093603002

Cr-Commit-Position: refs/heads/master@{#325477}

BUG=465418

Review URL: https://codereview.chromium.org/1057613006

Cr-Commit-Position: refs/heads/master@{#325476}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f7aaadb..bdb0bf5

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1089993002

Cr-Commit-Position: refs/heads/master@{#325475}

This fixes the compilation failures associated with _ChromeEnableBits caused by https://codereview.chromium.org/1038453002/.

BUG=477476
TBR=inferno@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1096493004

Cr-Commit-Position: refs/heads/master@{#325474}

It does not seem necessary to have this variable, just to create another
down below called 'buf'.

BUG=None
TEST=base_unittests --gtest_filter=MD5*
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1087333004

Cr-Commit-Position: refs/heads/master@{#325473}

that return the MockRenderProcessHost.

Preamble to a fix for bug 474231, where I'll add a new method to
MockRenderProcessHost.

BUG=474231

Review URL: https://codereview.chromium.org/1051343005

Cr-Commit-Position: refs/heads/master@{#325472}

Previously all dependencies would stop propagating for link purposes when a shared library or executable boundary is reached.

This patch makes public shared library dependencies propagate through shared libraries. Since the ability to use header files is propagated through these boundaries, so do the link dependencies. See the comment in target.cc for more details.

BUG=475091

Review URL: https://codereview.chromium.org/1083663007

Cr-Commit-Position: refs/heads/master@{#325471}

This is a minor refactoring change.  See linked bug for related work.

In order to make db_ private we needed to:
  - Add accessors for common operations (IsOpen, etc.)
  - Make TestDirectoryBackingStore a friend so it can db_.release().

BUG=475557

Review URL: https://codereview.chromium.org/1082423002

Cr-Commit-Position: refs/heads/master@{#325470}

This changes the renderer side of Chromium to only denote persistent
notification ids as int64_ts rather than as strings.

This CL is part of a three-sided patch:
  [1] https://codereview.chromium.org/1078783002/
  [2] This CL.
  [3] https://codereview.chromium.org/1072873002/

BUG=

Review URL: https://codereview.chromium.org/1071203002

Cr-Commit-Position: refs/heads/master@{#325469}

This CL removes the "override" keyword from all Blink API implementations.
We don't use the keyword for the Blink API since it's in a different
repository, and it makes changes to the API much harder.

Additionally, clean up some minor camelCase -> under_score variables.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1090953002

Cr-Commit-Position: refs/heads/master@{#325468}

BUG=476187

Review URL: https://codereview.chromium.org/1092463003

Cr-Commit-Position: refs/heads/master@{#325467}

These tests are for RemoteMediaVideoInfo and MediaUrlResolver. Many more
unit tests are needed, but these are a start. While these tests do not
replace the downstream instrumentation tests, a complete set of Cast unit
tests may reduce the need for them, and allow us to use those simply as
integration tests.

This CL also fixes one bug in MediaUrlResolver and removes getting the
already known browser user agent.

BUG=472067

Review URL: https://codereview.chromium.org/1079153002

Cr-Commit-Position: refs/heads/master@{#325466}

BUG=467287
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1082503002

Cr-Commit-Position: refs/heads/master@{#325465}

The new URLRequestContext disables alternate protocols
to ensure that the Data Reduction Proxy secure proxy check
request goes out over vanilla HTTP so that it can be
intercepted by middleboxes.

Also, secure proxy check is now done on IO thread.

BUG=437080

Committed: https://crrev.com/652eabf1141c00594aa6e9ed81beb980aec89198
Cr-Commit-Position: refs/heads/master@{#325302}

Review URL: https://codereview.chromium.org/981633002

Cr-Commit-Position: refs/heads/master@{#325464}

Change ScopedSuspendBookmarkUndo to take the BookmarkUndoService
instead of the Profile in its constructor and change client code
accordingly.

Add a GetProfileIfExists() method to BookmarkUndoServiceFactory
to avoid service creation when suspending the undo/redo mechanism
as if the service is initialized at BookmarkModel creation time.

BUG=477679

Review URL: https://codereview.chromium.org/1059523005

Cr-Commit-Position: refs/heads/master@{#325463}

BUG=410824

Review URL: https://codereview.chromium.org/1086393002

Cr-Commit-Position: refs/heads/master@{#325462}