- 29 Sep, 2020 33 commits
-
-
Andre Le authored
- Create a base class for quick actions controller. - Create silence phone controller that connect to the DND controller in PhoneHubManager. Display the icons according to the states. - Hook up the quick actions UI in the bubble to silence phone controller. Enable hotspot and locate phone implementation will be added in the next CL. BUG=1106937,1126208 Change-Id: I3eb511e1843cd4cb6b80316a706a2dcbc61a8e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419552 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#811478}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009280800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/VGNbHOZcwQ-4eGRBpvMYde9m0v8pkT_TboRdiMdOPC4C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/166042882,b/166043485,b/169488265 Tbr: help-app@grotations.appspotmail.com Change-Id: I31c2c791e8166c029f9b7f6b4e9e16c0d0f0aafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435492Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811477}
-
Bartek Nowierski authored
There are a couple reasons for this change: 1. Avoid copying 2-pointer struct. 2. If any of the pointers in the struct gets replaced by CheckedPtr with a non-trivial constructor, the compiler will complain. See go/miracleptr for more details on the experimental CheckedPtr project. Bug: 1080832 Change-Id: Ic2c6c1cc37601a8a22cb0bb2177547ea614fbcea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434021 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#811476}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Iaa7a5aa9633f87b0f3538a7362091ed6e4ff72b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435723Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#811475}
-
Tal Pressman authored
Change-Id: Ide40db02dcd3f16caf3da24b1283f3dd99348680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428271Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#811474}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I074bcae49156e45b0d7795aedb502de95e03ca16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435756Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#811473}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a49d4b5de90..1099c11d5d12 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-28 chanli@chromium.org [depot_tools] Roll led to latest 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I47d85337c4cee4a363a6e547d9feca0924704ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811472}
-
Xianzhu Wang authored
This reverts commit 5fd12ebf. Reason for revert: No obvious change for crbug.com/1121730. Original change's description: > Revert "Enable transformed rasterization for most layers" > > This reverts commit b179b125. > > Reason for revert: for debugging crbug.com/1121730 > > Original change's description: > > Enable transformed rasterization for most layers > > > > Background: transformed rasterization is used to render sharp text in a > > composited layer with fractional transform. It snaps the composited > > transform of the layer to whole pixels, then applies the fraction > > during rasterization. > > > > Previously we disallowed transformed rasterization in blink for directly > > composited layers (excluding backface-visibility:hidden and trivial 3d > > transforms such as translateZ(0)), especially for will-change:transform > > because change of fractional transform would cause re-rasterization > > which would defeat the purpose of will-change:transform. > > > > Now for a layer that was not eligible for transformed rasterization, > > calculate the initial raster translation which achieves sharp text > > rendering with the initial transform. When the transform of the layer > > changes, keep its original raster translation to avoid invalidation > > of tilings, to ensure animation performance. The rendered result will > > be blurry during animation but the initial rendering result is sharp. > > > > Remove blink-side transformed rasterization conditions and let cc > > decide it based on screen and draw transforms of the layers. > > > > Bug: 1111195 > > Change-Id: If0455be2f29e69cd7152c951626e6e8cc143b5bd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351164 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Reviewed-by: vmpstr <vmpstr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#798268} > > TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1111195, 1121730 > Change-Id: Ibab42e963cab263cab062377ffa2aad38291c5a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427125 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810026} TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111195 Bug: 1121730 Change-Id: Ie61adb5086d7424346ec3ca006555e31e936be43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435803Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811471}
-
Henrique Nakashima authored
This is a reland of 7cf7dadf Fixes: https://chromium-review.googlesource.com/c/chromium/src/+/2432754/2..3 device_junit_tests is also the name of a junit_binary, and cannot be used as the target name. Not sure why CQ didn't catch this last time, confirmed locally that was the problem. Original change's description: > Modularize DeviceConditions to chrome/browser/device > > This is a step to unblock some classes that depend on it (list below) > and allow modularized code to reuse it. > > 11 inbound dependency(ies) into .c.b.DeviceConditions: > [chrome_java] > <- .c.b.background_sync.BackgroundSyncBackgroundTask > <- .c.b.background_sync.PeriodicBackgroundSyncChromeWakeUpTask > <- .c.b.download.DownloadInfoBarController > <- .c.b.explore_sites.ExploreSitesBackgroundTask > <- .c.b.offlinepages.BackgroundSchedulerBridge > <- .c.b.offlinepages.BackgroundSchedulerProcessor > <- .c.b.offlinepages.OfflineBackgroundTask > <- .c.b.offlinepages.prefetch.OfflineNotificationBackgroundTask > <- .c.b.offlinepages.prefetch.PrefetchBackgroundTask > <- .c.b.services.gcm.ChromeGcmListenerService > <- .c.b.sharing.click_to_call.ClickToCallMessageHandler > > This also breaks about 0.4% of the existing package cycles. > > Change-Id: I8ff8b665af2269161811ff76a4087b7e38d38172 > Bug: 1132380 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429587 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810702} Bug: 1132380, 1132399 Change-Id: I3a41f3cb154ed261aed671debeb393b82b1411fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432754 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#811470}
-
Kenneth Russell authored
Use explicit expectations because wildcards make maintenance of the expectations files more difficult in the long run. Bug: 1095679, 1130440 Change-Id: I0ba4a2b8800e521202baa0e6c9ce498798b65061 Tbr: enga@chromium.org Tbr: ynovikov@chromium.org Tbr: bsheedy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436752Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#811469}
-
Xi Han authored
This reverts commit 40a4a6b6. Reason for revert: crbug.com/1132734 Original change's description: > [Instant Start] Supports stack tab switcher. > > In this CL, we remove the check of stack tab switcher in > TabUiFeatureUtilities#supportInstantStart(). Thus instant start can be > enabled in MVP++. These changes can be verified by: > - StartSurfaceTest#testShow_SingleAsHomepage_V2__Instant*. > > The following changes are made to support stack tab switcher in instant > start: > 1) Defer the creation of TabList in StackLayoutBase. It allows the > StackLayoutBase/StartSurfaceStackLayout to be created pre-native. > 2) Add pending observer list in TabModelFilterProvider. Any observer > which is added before the TabModelFilterProvider is initialized, will > be cached and notified when the initialization is completed. > 3) StartSurfaceLayout and StackLayoutBase will create its SceneLayer if > hasn't yet before calling updateSceneLayer(). > > Bug: 1116449, 1076449 > Change-Id: I42a730045d4b9799d4bb08dc7d7dc947956f42ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356167 > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Xi Han <hanxi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810924} TBR=hanxi@chromium.org,twellington@chromium.org,mdjones@chromium.org,wychen@chromium.org,hnakashima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1116449 Bug: 1076449 Change-Id: Ib4ab05dfe04288d28bbfbd01ef2a0f01493795c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437010Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811468}
-
Christopher Cameron authored
Video playback fails with the Metal-based command decoder, because it binds IOSurfaces as TEXTURE_2D, not TEXTURE_RECTANGLE. Plumb through a flag to specify if TEXTURE_RECTANGLE support is present. Bug: 1108909 Change-Id: Ib7bccefea54985f052267f51f6b91ce955e30f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436311Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#811467}
-
Livvie Lin authored
Modifies name for consistency with other relevant configs. Change-Id: I48677a0283fcd92e2147ab0492f2982d75c59ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432134Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811466}
-
Liquan (Max) Gu authored
Change: * onWebContentsForRequestAvailable() was called two times when bottomSheetController.requestShowContent() failed in PaymentHandlerCoordinator. One is in PaymentHandlerCoordinator; one is in ServiceTabLauncher. Now, onWebContentsForRequestAvailable() guaranteed to be called only once - in ServiceTabLauncher only. Bug: 1132972 Change-Id: Iba288b1287e034a35ff83994f5f675b5df463527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435739Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#811465}
-
Collin Baker authored
Bug: 1106523 Change-Id: I36cbf3d0de3c5e4a229874f2d505016772fb6d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432384Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#811464}
-
Nnamdi Theodore Johnson-Kanu authored
- Add close button functionality - Update ESim flow ui to use iron pages screenshot: https://screenshot.googleplex.com/A7ZxANAamWYTxs3.png Bug: 1093185 Change-Id: I755d40eefa068398a6a3c1cab6428f8f5aed7ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424830 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#811463}
-
Adam Langley authored
Previous changes have left cut points where the change in QR key structure was split off. This change contains the remainder of those changes. It doesn't quite make CableDiscoveryData V1-only, but it's a lot closer. BUG=1002262 Change-Id: Id57aec7f09d574720ed57a49e1482eb6890e3947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430324 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#811462}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/printing This CL was uploaded by git cl split. R=rbpotter@chromium.org Change-Id: I2e8c8fbca3a293b1ac93a7a82f9a821e05bc9554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435194 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811461}
-
Caitlin Fischer authored
There's a note in media_switches.cc indicating that this feature is okay to be removed. Bug: 1126640 Change-Id: Ie4c87b13fb573327038753ea30a59708df3bc691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427213Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#811460}
-
Andrew Shulaev authored
Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit# Bug: 1007635 Change-Id: I1910c2ad1c47d00f069d6c70dbc7dc6e1ef2eedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434929 Auto-Submit: Andrew Shulaev <ddrone@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#811459}
-
Andrew Shulaev authored
File removed from allowlist does not seem to have occurrences of neither base::Callback nor base::Bind Bug: 1007635 Change-Id: I89d65021176a4182fa7dccf2eb79e5e3093c0f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435387 Auto-Submit: Andrew Shulaev <ddrone@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#811458}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/306fc502cf96..62139fcca727 2020-09-28 cwallez@chromium.org Use typed integers for the ExecutionSerial 2020-09-28 cwallez@chromium.org D3D12: Use typed integers for the ExternalMutexSerial 2020-09-28 cwallez@chromium.org D3D12: Use typed integers for the HeapVersionID If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I195d50621bdc7e97f23f45457846b497ea9134cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436929Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811457}
-
Russ Hamilton authored
Bug: 973801 Change-Id: Ia87925e48d9f0953b5f4e3a2d89472129e4ecee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432424Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#811456}
-
Ana SollanoKim authored
In this change the function GridGap() is implemented to get the row or column gap of the grid. If the gap is not defined, then the function returns 0. This result is added to the current_inline_offset and current_block_offset. A unit test was also introduced to validate the result. Bug: 1045599 Change-Id: I7e1c86db5bb266131fa2bdc9720674794ac1edf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430486 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#811455}
-
Jenny Zhang authored
When user invokes feedback from lacros-chrome, we will send the request via crosapi mojo call to ash to show Feedback ui, so that the feedback report will be sent from ash, which includes both ash and lacros user log. The chrome version string in feedback report will contain both ash and lacros versions if Lacros is allowed/supported and launched in the session. Bug:1119925 TEST: 1. Open Lacros browser, send a feedback report by clicking "Report an issue" under Help menu. 2. Verify the report can be found at http://listnr site. The chrome version string should have both lacros and ash version strings, for example, "Lacros 87.0.4266.0 dev, Ash 87.0.4266.0 dev". 3. Verify the report contains both system_logs.zip and histograms.zip. The system log should contain ash log data and lacros user log from /home/chronos/user/lacros/lacros.log under "lacros_user_log" section. Change-Id: Iecc94ef9c50d6993159aebd9d3ac305e3f9a5896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408883Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#811454}
-
Ken Rockot authored
This records the network connection type any time it changes. Also adds an enum histogram value for the new 5G type that was recently added to the ConnectionType enum. Bug: 1127134 Change-Id: I5a7d1306b69c4714a8b24a5462871aa0842121d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431589 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811453}
-
Yoshisato Yanagisawa authored
Bug: crbug.com/1105814 Change-Id: I99da69983014a3c7df8d71c62226d6893d556d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434892Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#811452}
-
Dominic Farolino authored
This CL moves the RouteProvider implementation from ChildThreadImpl, to RenderThreadImpl. This is because RenderThreadImpl is the only type of ChildThread(Impl) that uses this functionality, therefore this CL creates a healthier boundary between render threads and child threads. At the same time, it simplifies a nasty code path present in both RenderFrameImpl/RenderFrameProxy::GetRemoteAssociatedInterfaces() that separates a "production" path vs a "test" path. We do this by introducing the GetRemoteRouteProvider() method on the RenderThread public API, and providing two implementations: - RenderThreadImpl - Responsible for returning a legitimate mojom::RouteProvider* that will be hooked up to a real cross-process implementation - ChildThreadImpl - Responsible for providing a dummy mojom::RouteProvider* bound to nothing, so that the messages sent over it are simply drained This is a reasonable tradeoff over the alternative solution of introducing a MockAgentSchedulingGroup to handle cases where its RenderThread is a MockRenderThread. If things regarding RenderThread should be mocked, then it makes sense for RenderThread implementations to mock them, as opposed to have mocks appear in both MockRenderThread *and* MockAgentSchedulingGroup, which is slightly more awkward and cumbersome. Bug: 1111231, 1132901 Change-Id: I903553a67f14d22d654556c4398d169196763a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433793 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#811451}
-
Xida Chen authored
In this previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2293427 When we make the DroppedFrameCounter ignore frames during loading, we change the behavior of the FPS meter too, so that the FPS meter ignores the loading frames. This is undesired, because there is no explanation to the users why these frames are not included. Excluding these frames in the smoothness metrics should be internal implementation details for UMA. This CL makes changes such that the FPS meter still takes the loading frames into account. Bug: 1129049 Change-Id: Ief2b8878c7342c945de74a7af97f41ec5a17b71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418537Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#811450}
-
Siyu An authored
AutofillEnableStickyBubbleAndUpdatedLogging. For more details about the feature please refer to go/sticky-payments-bubble-dd. This feature is currently running 50% in Canary/Dev. So added this to fieldtrial_testing_config and get ready for Beta. Also fixed some tests that will be obsolete when this feature is launched. Bug: 1070799 Change-Id: I3061a5de8c94e5a7e453e84615d9807fc0baa6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424078Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#811449}
-
Xida Chen authored
Blink's animation doesn't use Timing::Nullvalue anymore, and this CL removes the IsNUll. Bug: 791086 Change-Id: I488f077b96ec6477176876f224f7f5e5d71c07ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430484 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#811448}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ib541131caa821909b891725058ee47e1b67f764f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436352Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811447}
-
Noel Gordon authored
After CL:2432150 piex_loader.js no longer depends on files app types (external types). It only depends on DOM platform types. js_library("piex_loader"): Remove deps=[]. Replace with a note about not adding any more deps so that piex_loader.js can be used standalone. js_library("image_loader_util"): image_loader_util does not depend on piex_loader; remove that dep. Bug: 1132695 Change-Id: I8df346343c86d68d610c72b2f77164153a800074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435031Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811446}
-
- 28 Sep, 2020 7 commits
-
-
Jamie Madill authored
This allows the runner to capture the contents of this directory from the device. The directory is used by ANGLE tests to produce images for Skia Gold. Bug: angleproject:4090 Bug: b/168049670 Change-Id: I10a669c21357366a2535d13d5f578771b52e8612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434088 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#811445}
-
Piotr Pawliczek authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/77b1345ec0eb..1342b20cf245 $ git log 77b1345ec..1342b20cf --date=short --no-merges --format='%ad %ae %s' 2020-09-19 pawliczek system_api: New error codes in debugd/CupsResult 2020-08-13 wvk vm_tools: Add SetVmId method to concierge BUG=chromium:1069844,chromium:1123268 TEST=tested on atlas as a part of larger patch Change-Id: I848a8c6edc7da9fba8a9f10a5e138d5df4550f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436550 Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#811444}
-
Andrew Grieve authored
This reverts commit 9d395e1d. Reason for revert: Finished collecting data. Original change's description: > Optimize for speed Android performance sensitive functions. > > Set optimize_max compiler options to build some hot blink render > components and improve size-vs-speed balance on Android. > > Pixel4 Aarch32/64: > +628Kb/+884Kb libchrome size > +6.9%/+5.7% speedometer2 speed > > Bug: 1125115 > > Binary-Size: Will revert this after perf graphs show impact of it. > Change-Id: I45e176ae1cbc2e513eda986b667ce65640ec9a2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390778 > Commit-Queue: Pavel Iliin <Pavel.Iliin@arm.com> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804555} TBR=agrieve@chromium.org,Pavel.Iliin@arm.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1125115 Change-Id: I66387878027a71a59a65b269b6e95b3b31c5d90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436271Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#811443}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /content/renderer/pepper This CL was uploaded by git cl split. R=raymes@chromium.org Change-Id: I7a8be6603564a805c85b254fee8dcf24fee6b30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434630 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#811442}
-
Liviu Tinta authored
We are running a Finch trial and we would like to know how many times the browser process fails to verify User Activation. Bug: 1098466, 1098467 Change-Id: I28572dd8bf5eb600efa13732bd8f64a316f2d3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418974 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811441}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b94db86cf9b3..44be0942f9a8 2020-09-28 bclayton@google.com Pipeline: Fix return type of SIMD::Pointer::limit() 2020-09-28 bclayton@google.com Pipeline: Assign to SpirvRoutine::pointCoord If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id55cb1a4e2534fb0ee87726bfb299b7454a12021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811440}
-
Moe Ahmadi authored
Modules do not need names in addition to titles. Bug: 1130799 Change-Id: I6475d1b1b72b5e94e7417dbf533b7684c051fd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436374Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811439}
-