- 18 Jun, 2020 40 commits
-
-
Jan Krcal authored
This CL removes UMA user actions that have been replaced by a new histogram since M79. Bug: 995757 Change-Id: Iaeae4bd9125f68209a48f8a0c315eefb39b6b2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247729 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#780069}
-
Chris Lu authored
This change adds SaveCardInfobarModalOverlayMediator and SaveCardInfobarModalOverlayCoordinator to manage the SaveCard Overlay Modal UI. Bug: 1071914 Change-Id: I137f38832a56cbf1e0cf934c86c39b1066c08dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246795 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#780068}
-
Omer Katz authored
This CL: * Introduces atomic ObjectStartBitmap * Uses it to get object start of mixins * Removes mixin virtual GetTraceDescriptor method. See for more information: https://docs.google.com/document/d/180i8OnHeZ9pLnaEA0NxDT1UOfrpHKF9ovCRv2X4ET6k/edit?usp=sharing Bug: 986235, 1080701 Change-Id: I1fab84f39c64714b08b8909a39ea0b8367eaf1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247020 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#780067}
-
Chong Gu authored
Bug: 1096611 Change-Id: I8d7b3b2898fded0a805e8c4da784703c7e448180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252685Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#780066}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a6f1fc99. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I97d8021bdc61bcf50b61f7717b02f0f879f52d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252879Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780065}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592495797-0ce2a459124ac0074ced31c25e7b4057cfe18bea.profdata to chrome-win32-master-1592506745-dd4e30b5db51eb72110579247828d44bc4732ba7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I66af096d3d2c0db10e725b8470e6932d5effa934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252533Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780064}
-
Daniel Rubery authored
This CL adds code to fetch the model from the cache (without making a network request) immediately at startup. Since the models have a very long max-age, this should solidly address the high proportion of MODEL_NEVER_FETCHED in SBClientPhishing.ClassifierNotReadyReason. See https://uma.googleplex.com/p/chrome/histograms?sid=20464e66b314d32caf0ef36facc35186 Bug: 1068623 Change-Id: I46c56daa4abb5ac32abf54c1970cb4146e79c22a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250956 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#780063}
-
Anders Hartvoll Ruud authored
A longhand that's part of some shorthand expansion needs manual attention in the code template if that longhand is behind a flag. This CL fixes that by generating shorthand expansions for all possible runtime flag configurations (for relevant flags), and selecting the correct one dynamically. We assume that the flag-protected longhand will appear/disappear "in-place" in the list of longhands. In other words, if some runtime flag were to reorder longhands, manual code will still be needed in the template. Since this CL means we'll generate 2^N expansions for N flags, there's currently a limit of 4 flags per shorthand (which should be generous enough). Bug: 1096015 Fixed: 1094236 Change-Id: I99d321b971ea2b746688829f35a868db7d0f5f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250242 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#780062}
-
Kyle Milka authored
Make ShareSheetCoordinator implement WindowAndroid.ActivityStateObserver this allows it to close the share sheet when switching apps. Bug: 1087463 Change-Id: I6de44ea0e5c02de0c287f84bbbd991f331d2714d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253139Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#780061}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I78d2bd8a5ed30f0d5b13b6ceb35dfb5b85e0fc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252571Reviewed-by:
-
Ahmed Fakhry authored
This is a regression caused by my earlier CL: https://crrev.com/c/2227615. That CL exposed a bug in the ordering between adding a view to the view model, and as a child to ShelfView. The view should be added the model first before adding it as a child to avoid have a wrong view count in the model when updating the visible views. Also, this CL fixes the value of visible_shelf_item_bounds_union_ which was being updated too early while views are animating making it have the wrong bounds. BUG=1095601 TEST=Manually, added a new test. Change-Id: I5bca5a6febe06bfad791e2321727975bd1530d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252931Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#780059}
-
Maggie Chen authored
Majority of the Vulkan crashes on Windows have this driver version. This version was accidentally excluded in the previous CL. Bug: 850881 Change-Id: I0df2ea2e2ba4e5e7ce300e13ece2468f026ddab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253079Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780058}
-
Sorin Jianu authored
Making all App instances singletons appears to have been a mistake. Singletons in Chromium are typically leaky singletons, and thus, destructors for App instance don't run, breaking expectations and creating confusion. This CL makes all the App instances normal ref counted class instances, execept for the Windows COM server, which remains a singleton because of a design quirk: coclass instances created by COM need a way to refer the COM App server class (to talk to the update service, for example). We could not find a way to pass the App instance to coclasses, and so, the need for the singleton. TBR: waffles@chromium.org Bug: 1064498 Change-Id: I2872aa1821fcf27b74f22236483cfc11ea7c3059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252462Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780057}
-
Martin Kreichgauer authored
Builds currently fail because the file doesn't exist in Visual Studio 2017. Bug: 1089996 Change-Id: I1558fc11fda532406baf5b0af998c5e58a774aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252620Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Cr-Commit-Position: refs/heads/master@{#780056}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/477818f5075f..404049010310 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC smcgruer@google.com,atotic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093350,chromium:1096544 Tbr: smcgruer@google.com,atotic@google.com Change-Id: I8b05e21b3ad64730b8c2b8b627e45330d2789f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252532Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780055}
-
Roger Tawa authored
Bug: 1069049 Change-Id: I3ca779e3bbda80abeae89bd035c9159c4dca853c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250513 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780054}
-
Fred Ranking authored
data_source_ should be guaranteed to be release after DataPipeProducer::Cancel() triggered, This ensures that DataPipeProducer destruction eventually leads to teardown of the corresponding SequenceState object. Bug: 1095883 Change-Id: Ibf1d5787a57ae5da9eaa24e25e1e72c1a3a9907c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245987 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#780053}
-
Omer Katz authored
This CL also fixes any unittests that didn't pass the plugin checks. Bug: 986235 Change-Id: Iafff8ad41f76bd7d7957c0b9af435651c1df7591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246176 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Robbie McElrath authored
This also updates the preference library's dependencies: core, annotation, collection, fragment Binary-Size: New androidx fragment library is larger. Bug: 1092986 Change-Id: Ifbc383b4e48c443e0cc1993e387e76270e89dac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238412Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#780051}
-
Yue Li authored
Bug: b/158541058 Test: Manual Test Change-Id: I74300ee103845a66b2acb8c61de59777c3495d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250463 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780050}
-
Xida Chen authored
This CL extends the expiry of a set of input related histograms, specifically they are: *.TimeToScrollUpdateSwapBegin4 *.RendererSwapToBrowserNotified2 *.GpuSwap2 *.NavigationToFirstScroll.AfterPaint This set of metrics are documented as "key input metrics" in this doc: https://docs.google.com/document/d/1EPKT652e2PcO1ysA7LQosGyyr1xmxbtiiiivNU3lnpQ/edit?ts=5808d608# I believe we should keep monitoring these metrics. Bug: 1089984, 1089983, 1059795, 1088756, 1055387, 1039305 Change-Id: I164d6da77bb08d60a4cfd1c723c39dabf9e51f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250778Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780049}
-
spdonghao authored
Bug: 1076139 Change-Id: I15ecbc7cbaeb6d0f1bcf316fd0c844d13452a5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237715 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780048}
-
Dominique Fauteux-Chapleau authored
This also adds calls to this ctor via FileSourceRequest and ValidateDataUploadRequest. Bug: 1069066,1069069 Change-Id: Iec602e842fd920563989f05e1d413ca3eaef7eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249089 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#780047}
-
Daniel Rubery authored
Previously, the ClientSideDetectionService was running two ModelLoaders, one for the regular model, and one for the SBER model. This CL makes the ClientSideDetectionService track the SB prefs, so it can only load the model needed for that profile. Bug: 1068623 Change-Id: I544c059caa3a2545dc41771fc0bee04a808b5992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249162Reviewed-by:
-
Azeem Arshad authored
This CL adds fake implementations for Hermes dbus Manager and Profile client classes. See http://go/cros-esim-design-doc for details. Bug: 1093185 Change-Id: I29a35122ff48f2081ca91bfa9a1896fc547e3ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238672 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#780045}
-
Aleks Totic authored
This reverts commit 39818338. Reason for revert: crbug.com/1096758 Linux Tests (dbg) was failing Original change's description: > [b4p/Settings] Add dialog for removing duplicated passwords > > For a b4p user, in case some password has copies attached both to the > device and the Google Account, attempting to delete it should show a > dialog that allows selecting which copies to remove. This CL implements > this dialog but does not yet wire it in. Some details in the UI are left > for future CLs, such as the user avatar and displaying the website > associated with the password to be deleted. Note RemovePasswordBehavior > is not used here, for reasons that are better explained in > crrev.com/c/2246157. > > Screenshot of implementation: > https://screenshot.googleplex.com/hZnTiuy80tL > > Screenshot of mock: > https://screenshot.googleplex.com/pGV0iMTQBxw > > Bug: 1049141 > Change-Id: I50ca0e5bfc99dbc76c12c345c00f82788bbc377c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248180 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779743} TBR=fhorschig@chromium.org,aee@chromium.org,victorvianna@google.com Change-Id: I831cf3e91df28d1dabaeb1bfd14206206f79baba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252575Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#780044}
-
Azeem Arshad authored
This CL adds client class for Hermes Manager and Profile objects. See http://go/cros-esim-design-doc for details. Bug: 1093185 Change-Id: I4ca9d3da0d6e7b5d67ef27bf804a8de572c7ae44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238409 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL uses the (H264|VP8|VP9)VaapiVideoDecoderDelegate's ColorSpace for the decoded VideoFrames, if the former is valid. This ColorSpace comes ultimately from the codec parsers e.g. [1,2] (VP8 doesn't seem to support it in the VP8 frame itself, so it'll fall back to the container provide one). [1] https://source.chromium.org/chromium/chromium/src/+/master:media/filters/vp9_parser.cc;l=296;drc=24d1cda83eb280883bf7950900b7948b4b3f102a [2] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/h264_decoder.cc;l=644;drc=fa9094c73631d4b167dc422d62ac40915462423a Bug: b:147021705 Change-Id: I19c629f3c60a383e842206e18052057affa466ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247330 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#780042}
-
Xianzhu Wang authored
We should paint the canvas directly instead of recording a foreign layer for an HTML canvas when we paint with composited layer flattened (e.g. for printing). Change-Id: I29bc6647cd3817e274f6d394e9b390fef211a70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251178Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780041}
-
John Abd-El-Malek authored
Bug: 1088488 Change-Id: I359e3deb4ed4f407f3e756b7b808b444cb4de830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253023 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#780040}
-
John Abd-El-Malek authored
This is disabled by default, and the embedder has to enable it explicitly. Bug: 1088488 Change-Id: I3d85ac27fdfd26bddcbb294c653f0ef83f119bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246222Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#780039}
-
Xianzhu Wang authored
The original code mistakenly assumed that no filter can create visual effects from nothing, but feImage is one of the exceptions. Change-Id: Icc9fc0717522a0ea19da29143dd35b66663f1922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250708Reviewed-by:
-
Xianzhu Wang authored
It has not been used since we separated GraphicsLayerDisplayItem from ForeignLayerDisplayItem. Change-Id: I0fe7467d09364c474252d433d1c5e24ca3360550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250640Reviewed-by:
-
chrome://media-appTrent Apted authored
r772108 prevented these non-native files from being offered to web apps that use the file handling API due to lack of support. r778183 added the support for known use-cases used by the chrome://media-app "System" Web App. This CL tweaks the logic added by r772108 so that chrome://media-app (specifically) is allowed to act as a file handler for these non-native files. Bug: 1079065, b/157532509 Change-Id: I8f198357b9b5ecd487edb37255a7a55e09295232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249402Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#780036}
-
Victor Costan authored
QuotaClient's methods will only be called with a StorageType in the list of types provided to QuotaManager::RegisterClient(). WebSQL only provides kTemporary, like most storage APIs. Therefore, its QuotaClient implementation does not need to handle other StorageType values. Bug: 1016065 Change-Id: I727edcfdd4e4ed08c15b7b41001fdeb3d2a87059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250832 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#780035}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/13d717d087e2..3673ac461dad 2020-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ia8c0df1ff5dc0607318f317cb334be72cf713bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252531Reviewed-by:
-
Sam Sebree authored
This CL gives dark mode native controls a white focus ring instead of the default focus ring color. Bug: 929098 Change-Id: Ibe3414bf023d5f9b4fcb06b31635f69248df292e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238884Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780033}
-
Mirko Bonadei authored
This CL decouples the closure_compiler build configuration from //ui/webui. Before this CL, //ui/webui/webui_features.gni was included from //third_party/closure_compiler/compile_js.gni to get the definition of the GN variable "closure_compile" (now renamed to "enable_js_type_check"). Bug: 1094871 Change-Id: I8545b1296b056fdd6af4a06ad3387bcb3f70c277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248564Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#780032}
-
ckitagawa authored
Under rare circumstances compressing causes the FileInfo to not exist. As a result we attempt to dereference an empty base::Optional object. This CL simply checks if the optional item exists before dereference. Bug: 1096648 Change-Id: I2869a7556443b7209960a069189b4da83dda07fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252944 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780031}
-
Donn Denman authored
Adds an IPH for switching from Tap triggering to Long-press triggering as part of the ContextualSearchLongpressResolve experiment. There are two strings that can show in the bubble, one for users that have opened the panel in the past, and one for the general user-base that has not opened the panel recently. The IPH triggering logic is: 1) Show when the user taps and we would have tap-triggered. 2) Only show 3 times in a 90 day window. 3) Don't show if the user has done any longpress selection (which triggers Contextual Search) in the 90 day window. 4) Don't show if the user has opened the panel after a longpress in a 1 year window (the max allowed). BUG=1086724 Change-Id: I19335076afeb8a349c77e93a794d9adf8bfcfb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233861Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
