- 21 Sep, 2018 27 commits
-
-
Doug Turner authored
This CL protects calling Sign() on a private key that is null. The key can become null in two cases. The first case is if |network_service_client_| is null during OnCertificateRequested(). The second case is if HandleSSLPrivateKeyError() is called. In both cases, after this CL, if |ssl_private_key_| is null, we just call the sign callback with net::ERR_SSL_CLIENT_AUTH_CERT_NO_PRIVATE_KEY. Bug: 887539 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I0e2563f00d73ff0659786e85a041567ceeaaea48 Reviewed-on: https://chromium-review.googlesource.com/1237396Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#593036}
-
Josh Nohle authored
Because DeviceReenroller is a DeviceSyncClient::Observer, it should remove itself as an observer in the destructor. Bug: 887557, 887758 Change-Id: I318ee3a3a9f3b7df6cef1bfb362049a6687b9436 Reviewed-on: https://chromium-review.googlesource.com/1237536 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#593035}
-
Miguel Casas authored
This CL renames the file hosting CanvasResourceDispatcherTest, to comply with the class (and functionality) inside. s/offscreen_canvas_frame_dispatcher_test.cc/canvas_resource_dispatcher_test.cc/ Stumbled upon this mismatch during crrev.com/c/1228859. Bug: 878801 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib653677f7994de4f0e0178df3a7403a70abd1b99 Reviewed-on: https://chromium-review.googlesource.com/1237180Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#593034}
-
siyua authored
This CL changes the layout of local card migration according to the mock: go/autofill-paradise 1) Change title label view layout. 2) Change the width of content_container top / bottom border to 0 3) Adjust image bottom border Uploaded a new screenshot in bug. Bug: 852904 Change-Id: I1bf1a1745ac6cbd579da4f680a9552ac159b4ddc Reviewed-on: https://chromium-review.googlesource.com/1208936Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#593033}
-
Clark DuVall authored
SimpleIndex uses an ApplicationStatusListener to know when to write the cache to disk. This is used in the network service, and when network service is run out of process, this causes a crash since ApplicationStatusListener should only be used from the main process. To fix this, I changed ApplicationStatusListener to have a SetCallback interface, that can then have an implementation in the network service. If the cache is being created in the network service, we can pass the network service implementation of ApplicationStatusListener. The NetworkServiceClient will then notify network service of status changes from the main process. Bug: 881572 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1824e8e8c13f4294fd3a500545714c13a90db08b Reviewed-on: https://chromium-review.googlesource.com/1225606Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
Kevin Strohbehn authored
Drag closed from FULLSCREEN_SEARCH Drag closed from HALF_SEARCH Drag closed from PEEKING Drag closed from FULLSCREEN_ALL_APPS Bug: 885909 Change-Id: Ia13a5da2fefa408bc440d663f83763c93a80fc80 Test: Manually tested scenarios: Reviewed-on: https://chromium-review.googlesource.com/1237395 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593031}
-
Min Qin authored
This CL makes OfflineItemModel inherit from DownloadUIModel Bug: 881499 Change-Id: Ic7591f5ce7f5f5243cfeb8ff89ad1e77aa1b78db Reviewed-on: https://chromium-review.googlesource.com/1237134 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593030}
-
Dmitry Gozman authored
The main reason is alignment between start and commit navigation paths, so that we can later call CommitNavigation directly from StartNavigation. As a side effect, this patch also ensures that we consume the activation for any navigation attempt, even if is was ignored due to frame detach or some other reason. Bug: 855189 Change-Id: Ib705c0f20d567341d88e0fc3097ebc4246dcfeff Reviewed-on: https://chromium-review.googlesource.com/1232200 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#593029}
-
Jun Choi authored
Implement FidoBlePairingDelegate which handles a) Caching BLE Pin code when user inputs the pin code via WebAuthN UI. b) Handling logic of BluetoothDevice::RequestPinCode() and BluetoothDevice::RequestPasskey(). Bug: 877344 Change-Id: I10585c98ad9517b168824119ff2f50a67ff8f0c6 Reviewed-on: https://chromium-review.googlesource.com/1228777 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#593028}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6dd0074561b7..cae258d6b7d4 git log 6dd0074561b7..cae258d6b7d4 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@cae258d6b7d4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I703b62628bc17c4c92c98df2a7f6d0220fec6c92 Reviewed-on: https://chromium-review.googlesource.com/1236470Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593027}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/477dda58e6d7..8c9d5d0fbbbc Created with: gclient setdep -r src-internal@8c9d5d0fbbbc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6498530abdf479756afa6ad1583b60a402c4be65 Reviewed-on: https://chromium-review.googlesource.com/1237473Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593026}
-
Christian Fremerey authored
Currently, failures to obtain a video capture buffer from the buffer pool are logged all in one bucket. This CL splits the failures into out of memory vs. buffer pool max count exceeded. To enable this, the CL changes the interface of media::VideoCaptureBufferPool to return a result code that breaks out failure cases instead of having a single failure path. Bug: 878943 Change-Id: I0a74a8034e936ea02a1ead26a6cb5d916e05e288 Reviewed-on: https://chromium-review.googlesource.com/1220192 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593025}
-
Jialiu Lin authored
Erase some expired histograms (or update the expiration_date attribute). Bug: 884868,871505 Change-Id: I10241e2baad43c6960c04a7571a0ef8f9e5c68fe Reviewed-on: https://chromium-review.googlesource.com/1229499 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#593024}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c22dec277af..7e301cfffe7f git log 0c22dec277af..7e301cfffe7f --date=short --no-merges --format='%ad %ae %s' 2018-09-20 nodir@google.com [gclient] Use canonical URLs in solutions 2018-09-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@7e301cfffe7f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877161 TBR=agable@chromium.org Change-Id: I7ef130a75c80922136ed2ef11732730b0b890ff0 Reviewed-on: https://chromium-review.googlesource.com/1236472Reviewed-by:
-
Kyle Milka authored
Bug: None Change-Id: Ia2261537611e93c2f970d86fd003d230a583180a Reviewed-on: https://chromium-review.googlesource.com/1237386 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593022}
-
Jérôme Lebel authored
Replacing GetSyncErrorDescriptionForBrowserState() by GetSyncErrorDescriptionForSyncSetupService(). Browser state is not always available. This patch is to prepare for crrev.com/c/1231333 Bug: 849754 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iec560ea22b8e8344cca29de036aef299e8e7b667 Reviewed-on: https://chromium-review.googlesource.com/1234155Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#593021}
-
James Cook authored
The controllers in chrome were observing the wrong aura::Env instance. Bug: 887156 Test: manual Change-Id: Ib7e978a4ea7014c2fad65ee6afb73e40311117c7 Reviewed-on: https://chromium-review.googlesource.com/1236559Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#593020}
-
chrome://net-internalsMatt Mueller authored
This information can be viewed using chrome://net-export to save a log, and viewing the log with the external netlog_viewer project: https://chromium.googlesource.com/catapult/+/master/netlog_viewer/ Bug: 678391 Change-Id: I911d21002c1615f85de02ef2982ddb4abd935a16 Reviewed-on: https://chromium-review.googlesource.com/1228483 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593019}
-
Varun Khaneja authored
Bug: 673607, 728827, 725336, 705809 Change-Id: Ia1418bba1f6ab0956637de3677a2f0fbef48adc9 Reviewed-on: https://chromium-review.googlesource.com/1233356Reviewed-by:
-
Scott Chen authored
This CL also adds a helper function to check if the NUX onboarding feature should be force-enabled on non-win/non-branded builds. This will make testing and development for the feature much easier. There will be follow-up CLs to transition all NUX contents to be behind this flag instead of the build flags. To test this, add --enable-features=NuxOnboardingForceEnabled Bug: 874142 Change-Id: I0c1ae6d396901b0a7cbb1c13fe158b488ff0e14c Reviewed-on: https://chromium-review.googlesource.com/1229502Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593017}
-
Siddhartha authored
Use stability of the browser process to decide whether or not to start background tracing on Android We use the crash dump uploader to check if we had any browser crash dumps from the previous sessions, or if we uploaded browser crash dumps in previous session. Chrome tracing delegate uses this information to make sure browser is stable before starting background tracing. BUG=882741 Change-Id: Idc55b90f76e2739c054777e01ea39ce7ba5a131d Reviewed-on: https://chromium-review.googlesource.com/1220191Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
-
Stephen Martinis authored
This CL changes the tests for generate_buildbot_json.py to capture all printed lines. It requires tests to assert about the contents of these printed lines, and then clear them. It also adds a --verbose flag to the main script, which is passed when checking the configs. Also fixes a test for swarming mixins and how they interact with certain classes of tests. Bug: 886993 Change-Id: I047d74689d72f35bc7d19c8da338c070a8a5d9a5 Reviewed-on: https://chromium-review.googlesource.com/1237239 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593015}
-
Eric Roman authored
Bug: 721403 Change-Id: I56ab262ba7349e6261816e99fe01fe1d39e0e79a Reviewed-on: https://chromium-review.googlesource.com/1237252Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593014}
-
Jun Mukai authored
So far the display ID was recognizesed on creation of a toplevel, but moving across displays isn't considered well. This CL recognizes the timing of a window moving to another display, and let WindowTreeHostMus updates its own display ID properly. BUG=866947 TEST=the new test case covers Change-Id: I1e859f879a919674e90875a74434bb73e94edd73 Reviewed-on: https://chromium-review.googlesource.com/1234857 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593013}
-
Renjie authored
MakeMultipleFramesPacket() method has already existed but not all packet makers were using it. This CL cleans up the redudant code. No behavior change. Change-Id: Ic1379d9cf97c2c776be826608d04f7f013e39600 Reviewed-on: https://chromium-review.googlesource.com/1236928 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#593012}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/b64cb7b68093..9f85491d8830 git log b64cb7b68093..9f85491d8830 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 iannucci@chromium.org Whitespace to trigger additional builds. Created with: gclient setdep -r src/native_client@9f85491d8830 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:861512 TBR=mseaborn@chromium.org Change-Id: Ib74c016615152c02dea0c08364c6e443524349f8 Reviewed-on: https://chromium-review.googlesource.com/1237353Reviewed-by:
-
Weidong Guo authored
This is a follow up CL of go/cgcl/1194340 to fix the same issue when blur is not enabled. Bug: 878162 Change-Id: Ia6c3b6942b4304a12bfa3049e0b37252a4deae8f Reviewed-on: https://chromium-review.googlesource.com/1237403Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593010}
-
- 20 Sep, 2018 13 commits
-
-
Karan Bhatia authored
Cleanup ruleset manage unittests by removing the need to use net::URLRequest. Also, make WebRequestInfo movable. BUG=696822 Change-Id: I0a0d93406b67ff1a9338b470ef68b03062ae22fd Reviewed-on: https://chromium-review.googlesource.com/1235331 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593009}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4bf804086c4f..e65756725f82 git log 4bf804086c4f..e65756725f82 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 npm@chromium.org Make some methods const in XFAJSEmbedderTest Created with: gclient setdep -r src/third_party/pdfium@e65756725f82 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iee59439218814050299cdd2615982e0fd5eb505d Reviewed-on: https://chromium-review.googlesource.com/1236485Reviewed-by:
-
Darren Shen authored
There are some rules for showing/hiding the virtual keyboard when navigating to a new page / tab. Added some tests to make sure we don't regress these scenarios. Bug: 849995 Change-Id: I2fee098943b6073a0d1c1f8b86cdf1a3b35455e5 Reviewed-on: https://chromium-review.googlesource.com/1233097Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#593007}
-
Raymond Toy authored
The return type of size() was recently changed from size_t to unsigned. Adjust printf string for that. Bug: 887639 Test: Doesn't affect any test Change-Id: I371ee874bc4e3af6fd9891f059ce6423fdd498a8 Reviewed-on: https://chromium-review.googlesource.com/1236269Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593006}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7397af8da50b..97f63244f536 git log 7397af8da50b..97f63244f536 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 dproy@google.com Make all mithril components class components Created with: gclient setdep -r src/third_party/perfetto@97f63244f536 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I01d82904e216a765f5cb28950f8b579a0da14eff Reviewed-on: https://chromium-review.googlesource.com/1237356Reviewed-by:
-
Jacob Dufault authored
The IDL file did not fully specify all of the output. Bug: 887688 Change-Id: I5ee75419006a27504e978164379acf7c024988db Reviewed-on: https://chromium-review.googlesource.com/1237374 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593004}
-
Eric Karl authored
This reverts commit 60d359fd. Reason for revert: This logic could still be flaky (what if we go invisible after deferring commits), and isn't needed after https://chromium-review.googlesource.com/c/chromium/src/+/1184376, so let's revert. Original change's description: > Android OOP-D: DisplayScheduler should only report draw-inducing damage > > Currently DisplayScheduler reports damage to SurfaceManager in any case > where a damaged surface ID damages the display. While these cases will > trigger a draw when visible, they don't necessarily trigger a draw > in any defined timeframe. This can lead to issues. Consider: > > 1) Display 1 is not visible, embeds surface A. > 2) Surface A sends CF 1, we don't immediately ack as we will wait for > Display 1 to draw. > 3) Display 2 becomes visible, embeds surface A with a new surface ID. > 4) Display 2 will never update, as no new frames will be produced for > surface A as the renderer is continually waiting on the ack for > CF 1. > > By having DisplayScheduler report no damage if invisible, we always > ack frames in a timely manner. This may allow a renderer to produce > some extra frames when its display is invisible, but this should be > limited as the renderer itself receives visibility notifications and > won't get additional BeginFrames once visibility is fully processed. > > Bug: 875895 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I272de950d8e4d4c819c445dc8162ac360afb80a1 > Reviewed-on: https://chromium-review.googlesource.com/1182862 > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584917} TBR=fsamuel@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875895 Change-Id: Idefad0b80d08b3c9fecf655b27b3c6ffb85eca10 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1232335Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#593003}
-
sczs authored
- Deletes legacy recent_tabs files. - Modifies recent_tabs_table_coordinator_test to work with the new coordinator. (Deletes tableVC related asserts, since a coordinator shouldn't be tied to a VC) - Renames RecentTabsHandsetViewControllerCommand to RecentTabsPresentationDelegate.h and moves it to its own file. - Renames LegacyRecentTabsTableViewControllerDelegate to RecentTabsTableViewControllerDelegate. Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iea5b2aa8c32bdac7c6f8070cf721d8ad0991962a Reviewed-on: https://chromium-review.googlesource.com/1235278Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#593002}
-
Mike Wasserman authored
Allows ws clients to close touch ui on events outside their windows. Add a new PointerWatcher plumbing to [Mus]ViewsDelegate. Wires up watchers to the Mus-only PointerWatcherEventRouter. (ui/views/mus/* is not allowed as a dependency of ui/views/*) Destroy the touch selection ui on PointerWatcher mouse events. Bug: 884394, 887725 Test: Mouse events outside the KSV window close KSV text touch ui. Change-Id: I0e41da4d03719001191f7d5ab669bcc1805bd63c Reviewed-on: https://chromium-review.googlesource.com/1232955Reviewed-by:
-
Manas Verma authored
After saving a card locally, we see a "Card saved" text animation. When the text is clicked on, the icon is highlighted and the text looks bold and clunky. This CL makes the text look normal. Before: https://screenshot.googleplex.com/Jt3omKZ7RY9 After: https://screenshot.googleplex.com/jAMgKyYs3RQ Bug: 881320 Change-Id: I604c981fad7171c88d93d95d9029a2aa0a70484e Reviewed-on: https://chromium-review.googlesource.com/1236271Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#593000}
-
Robert Sesek authored
Bug: 832124 Change-Id: If17c7e3cdd5143e2014176feb5bcfda60a8da4fe Reviewed-on: https://chromium-review.googlesource.com/1236755Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#592999}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b20563f5defb..477dda58e6d7 Created with: gclient setdep -r src-internal@477dda58e6d7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I80a4f6e091ed5b7a14ae26c2479bd2d087ffd4ab Reviewed-on: https://chromium-review.googlesource.com/1237355Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9cba9ffdfdc6..0c22dec277af git log 9cba9ffdfdc6..0c22dec277af --date=short --no-merges --format='%ad %ae %s' 2018-09-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@0c22dec277af The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5beae3f74292c7d2764e31d90c1f9071a14ac96d Reviewed-on: https://chromium-review.googlesource.com/1236892Reviewed-by:
-
