- 10 Dec, 2020 40 commits
-
-
Norge Vizcay authored
* Introduces new function insertPasswordEntryForTesting on PasswordManagerHandler that allows storing credentials into the password store for testing purposes. Bug: 1155675 Change-Id: I3cc8bd09d01b810da1ee95ed9fac93f4df63e407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574857Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Norge Vizcay <vizcay@google.com> Cr-Commit-Position: refs/heads/master@{#835635}
-
Moritz Firsching authored
Currently, when loading half scans of certain type of progressive jpegs, the last scan is not displayed correctly. We provide a fix and a test. Bug: 1156120 Change-Id: If6ab87bda49fddf28bdf2062fc155ac85f9290c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577498 Commit-Queue: Moritz Firsching <firsching@google.com> Reviewed-by:
Leon Scroggins <scroggo@google.com> Auto-Submit: Moritz Firsching <firsching@google.com> Cr-Commit-Position: refs/heads/master@{#835634}
-
Hiroki Nakagawa authored
Before this CL, there were 2 bugs in the Early Hints UMAs: (1) Calculation order of the time duration is wrongly reversed. (2) The current implementation assumes that `LoadTimingInfo::receive_headers_start` doesn't take informational responses (1xx) into account, but actually it does [1, 2] based on the Resource Timing spec (See the note on [3]). Therefore, `early_hints_for_final_request_time` is always equal to `final_response_start`. This means the duration between them is meaningless. For the issue (1), this CL corrects the calculation order (see changes in uma_page_load_metrics_observer.cc). For the issue (2), this CL introduces `LoadTimingInfo::receive_non_informational_headers_start`. This is similar to `receive_headers_start` but it captures the time only when the response is non-informational. This is propagated up to NavigationHandleTiming and used for calculating the duration instead of `receive_headers_start`. Other notes: - This changes HTTP/1.1 and HTTP/2 but doesn't change HTTP/3. This is because HTTP/3 doesn't support LoadTimingInfo yet. See also https://crbug.com/1096414. - UKMs for the Early Hints use a different calculation logic, so they don't have these issues. However, to measure the effectiveness of the Early Hints precisely, we have to record the new timing for non-informational responses in UKM as well. See the TODO comment in uma_page_load_metrics_observer.cc for details. [1] https://source.chromium.org/chromium/chromium/src/+/master:net/http/http_stream_parser.cc;l=876;drc=1066e389d45dd39f22f2daf582fc56948d5cc480 [2] https://source.chromium.org/chromium/chromium/src/+/master:net/spdy/spdy_stream.cc;l=415;drc=1066e389d45dd39f22f2daf582fc56948d5cc480 [3] https://w3c.github.io/resource-timing/#dom-performanceresourcetiming-responsestart Bug: 1093693 Change-Id: Id2f696669804c2763de4c21fe40689e3af05bd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521563Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#835633}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b11fabe60575..5ed854f3f20b 2020-12-10 szuend@chromium.org Move Icon component from 'elements' to 'ui/components' module 2020-12-10 tvanderlippe@chromium.org Use URL-based loading for wasmparser_worker 2020-12-10 mathias@chromium.org Simplify and re-order entrypoint HTML document 2020-12-10 tvanderlippe@chromium.org Move worker integration into entrypoint for wasmparser_worker 2020-12-10 tvanderlippe@chromium.org Move worker integration into entrypoint for heap_snapshot_worker 2020-12-10 tvanderlippe@chromium.org Use FormatterWorker.format in unittests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1009443 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I24300cebca51983b12cafc071ca1357fc44f831f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583221Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835632}
-
Ramin Halavati authored
This reverts commit f354c627. Reason for revert: Ephemeral Guest profiles will have the same UI as old (off-the-record) Guest profiles in M89. Original change's description: > Make two settings sections visible for ephemeral guest profiles > > - Make the "You and Google" and "Auto-fill" sections visible, > when settings is based on an ephemeral guest profile. > - The notion of Ephemeral Guest profiles (go/ephemeral-guest-profiles) > is to be replacing the current guest profiles. > > Bug: 1140419 > Change-Id: If10584bb4a8105275c2eac8c581c7abccf545225 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483753 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819350} TBR=dpapad@chromium.org,rhalavati@chromium.org,huanzhong@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1140419 Change-Id: I1ec303884ba5a5585225b50e5364197880917f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582084Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#835631}
-
Jérémie Boulic authored
Convert the following JS files in //ui/file_manager/file_manager/common/js: - test_importer_common.js - unittest_util.js - importer_common.js - importer_common_unittest.js Bug: 1133186 Change-Id: I3c4ae19a4d2a5a6b56087f6bc0390b7c1dbd3252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579932 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#835630}
-
Peter E Conn authored
Change-Id: I4bbba28ef64ee3c1b989f43a0878d3f14bd33dfe Bug: 1155373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580883Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#835629}
-
Mario Sanchez Prada authored
This CL migrates MediaPlayerDelegateHostMsg_OnMediaPositionStateChanged to mojo, also adding the plumbing required to allow renderer -> browser mojo messages replacing MediaPlayerDelegateHostMsg* legacy IPC messages from //c/common/media/media_player_delegate_messages.h. More migrations of other MediaPlayerDelegateHostMsg* messages will be implemented in follow-up CLs, following an iterative process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: I1bc517ce97acd82f1a05d70b8592ab390f34ae5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526440 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#835628}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6520135abe88..1243857485fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: I6238a0a39bd93be613eac06ba692b8a61ae6d996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583219Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835627}
-
Colin Blundell authored
ChromeSubresourceFilterClient currently has logic to prevent the ads blocked UI being shown multiple times for a given navigation. However, ContentSubresourceFilterThrottleManager already guarantees that SubresourceFilterClient::ShowNotification() will be shown only once per main-frame navigation, even if multiple subresource loads are blocked. This CL removes the unneeded //chrome-level code to clarify ChromeSubresourceFilterClient in advance of componentizing most of it for sharing functionality with //weblayer. Bug: 1116095 Change-Id: I604498ee12a83d2afdc2cb2289877e211237901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574937Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#835626}
-
Richard Knoll authored
Reactivated UMA still shows zero usage of this and the extensions API was the only user. Remove it as this won't be supported in the upcoming FCM API migration anyway. Bug: 1148321 Change-Id: I6382efeba8d98353d46da8915613015c745c2b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549929 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#835625}
-
Shik Chen authored
Bug: b/172879638 Test: Manually in expert mode Change-Id: I4507280850563ffdb684e3c41ad51bfd579c95ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583587 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#835624}
-
Mathias Bynens authored
This patch extends the existing `CSS.forcePseudoState` CDP command so that it supports the CSS :target pseudo-class. DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581544 Bug: chromium:1156628 Change-Id: I06d3bc2c76d78601fd0abd403f621e74d2e2ae03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575668 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#835623}
-
Wolfgang Beyer authored
Frontend CL: https://crrev.com/c/2581542 Re-enable tests CL: https://crrev.com/c/2581839 Bug: 1152082 Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k Change-Id: I488a7ef1c88d9ff56080918f0154c22b76ea529b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580885Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835622}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/067a12f05951..55b7f38f9036 2020-12-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3fc522ff to 2db43e77 (469 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Ic390734f921ced45dc4788e79d274fef62916a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583416Reviewed-by:
-
Elad Alon authored
In this CL, we only apply the display-capture permission policy to getCurrentBrowsingContextMedia, because it's behind a flag and therefore safe to change. As follow-up work, we will introduce UMA histograms to check how many sites would be negatively impacted if this policy were applied to getDisplayMedia. We will then decide how to go about applying this policy to that API as well. Spec: https://w3c.github.io/permissions/#dom-permissionname-display-capture Intent-to-Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/gBpWuawy-Ms Chrome Platform Status: https://chromestatus.com/feature/5144822362931200 Bug: 1150788 Change-Id: I058f84ab6b2e3427e4990b3d01f057c9811f9487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551098Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#835620}
-
Pavol Marko authored
Transform the sequence of ifs to set authentication headers to a switch-case over the token type. Bug: none Change-Id: Id636342873c77f76cf6adb8abe7f5668c448b2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567219 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#835619}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607547301-0ddf36656043436fe87b3dfd771fe4fe3bc2c5ce.profdata to chrome-win64-master-1607568819-189005e62ee8b8bdd63cb408a8a785cae17219c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3e5e18cc16c0a68c0a7a6df6acf1f7b7afacf8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583747Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f5478d8ceb7..b11fabe60575 2020-12-10 alcastano@google.com Keep associated IssuesModel in all Issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I965cb0eb5fb80e68be4133b9d0d5db7ca0f85981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583867Reviewed-by:
-
Patrick Brosset authored
With this extra piece of information, the overlay frontend can now show how tall or wide gaps in a flex container are, from DevTools. Corresponding devtools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2579039/ Bug: 1150832 Change-Id: Ia001a4950658624219bef05f169f2ec11566ec56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582260 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL changes the ContextMenu callback parameters used by the WebKit API to use ContextMenuParams instead of just the URL. This will be necessary to check the new implementation where the interaction is added to the whole view. Bug: 1140387 Change-Id: Iabc574d4e0a88d43b4c2e1b7a9c1caeddda3c701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582041 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#835615}
-
Polina Bondarenko authored
Add OnSnapshotsDisabled() processing to ArcDataSnapshotdManager. All available snapshots must be removed and ongoing flows stopped (except when MGS is already running with loaded snapshot) once the feature is switched off. BUG=b:170187468 TEST=components_unittests Change-Id: I9f2c64817589639407f4294f04b077fea85aefea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558403 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#835614}
-
Marc Treib authored
Reconfiguration can't happen while certain operations (e.g. loading of data types) is ongoing. The member |needs_reconfigure_| indicates that a reconfiguration should be performed as soon as it becomes possible. This CL adds one additional point where a pending reconfiguration may be started, in OnAllDataTypesReadyForConfigure(). Previously, we'd still start the old configuration, and process the reconfigure only after all the previous data types had been downloaded. Bug: 1102837 Change-Id: Icc971f29229665832255baebfc545bfd34d83feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580882 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#835613}
-
Mario Sanchez Prada authored
This migrates these legacy IPC messages to the media.mojom.MediaPlayer mojo interface, now implemented by HTMLMediaElement inside of Blink, and updates its callers in the browser process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: I2cb9a39813e3078212e4a1a4a513b4bc0d0770bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537704 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Irem Uguz authored
This cl adds CertProfile id to certificate provisioning details UI page as a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/2562250. Bug: 1137523 Change-Id: Ib00c266afbd4d13378dc0d5820b689328d9216ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574199 Commit-Queue: Irem Uğuz <iremuguz@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#835611}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie9fab0462f26d6bbc7a1bc4b063888ad9d76ca3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583415Reviewed-by:
-
Yunke Zhou authored
Bug: 1156080 Change-Id: I43d7639d4bdc78ef5147180ae285b1ec8431b6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574847 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835609}
-
Antonio Sartori authored
Some Web Platform Tests for Content Security Policy were wrongly expecting the violated directives of CSP reports for CSS styles to be 'style-src' instead of 'style-src-attr' and 'style-src-elem'. This change fixes that. Bug: 694525, 651742 Change-Id: Id13f697eaf8ed72fba1e56eb7b0f7ac2a5837408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580810 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#835608}
-
Evan Stade authored
1. Don't null-check after pointer cast, because it will never be null (unless the DCHECK on the previous line had already failed, however this clearly never happens because the same pointer is de-reffed on the next line, so we'd have seen crashes) 2. Combine two methods instead of having one method thunk to the other. Bug: none Change-Id: Id67f5cf04fda40ec694689452c403601402cc306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575892 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#835607}
-
Antonio Sartori authored
The policy container is a project to unify and fix security policies inheritance for local scheme documents. In the first prototype, we added referrer policy to the policy container behind a flag. Since this seems to be working well, let's enable the flag by default. Bug: 1130587 Change-Id: I66bd8fd823b3c114ba7f3e671eb73902955219f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573080 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#835606}
-
Tim van der Lippe authored
They are replaced by Karma unit tests in https://crrev.com/c/2581919 R=aerotwist@chromium.org Bug: 1024752 Change-Id: I0222c355d2a57848716772b1be7bbfa72a3019b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581922 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#835605}
-
Fergus Dall authored
RegisterClientWithToken posts a task to |proxy_thread_| which does the actual work and runs the callback. But the callback is the response to a mojo message that must only be run on the sequence that created it. This causes a DCHECK failure in mojo::ResponderThunk::Accept. Fix this by having RegisterClientWithTokenOnProxyThread post a task back to the original sequence to actually run the callback. Also have RegisterClientWithTokenOnProxyThread call AddClientObserverOnProxyThread directly instead of going via AddClientObserver, as it is already running on the right thread anyway. This issue appears to have been introduced in CL:2501104 Bug: none Change-Id: I4ae88c0c508e9120be7526c7b46c492592176500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583596 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This is preparing for the new implementation of ContextMenuController. Bug: 1140387 Change-Id: I690d2f60bb9fde71ad48322afd14074fb1209814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575665 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#835603}
-
Shik Chen authored
Bug: b/172879638 Test: Manually in expert mode Change-Id: Id9ceb55e431fb952540eb2c1c2eed3d3bd220c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578582Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#835602}
-
http://crrev.com/835582Eugene Zemtsov authored
Change-Id: Id48ff016d5162417624988478c693408bb9f4e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583865Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#835601}
-
Antonio Sartori authored
This change fixes a few blink unittests so that they work with the feature PolicyContainer enabled. This is a preparatory CL to enable that feature by default. Bug: 1130587 Change-Id: I9ac10a4c1c06b77721aebf0b983992adebf0c4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582221Reviewed-by:
-
Swapnil authored
This CL adds a new flag |override_update_url| to the ExtensionSettings policy. If the flag is set to true, update URL from the ExtensionInstallForceList or ExtensionSettings policy will be used for updates, not only for the first install. The flag is taken into consideration in these 2 cases: 1) Extension is listed in ExtensionInstallForcelist policy, and installation mode is not set in ExtensionSettings policy. 2) Extension is marked as 'force_installed' or 'normal_installed' in ExtensionSettings policy. We also ignore the extension ids if the update URL of the extension is a Chrome Web Store URL. This CL only adds the flag, the main logic is implemented in https://crrev.com/c/2510992. Bug: b/168097360 Change-Id: Id4e77669baf495b33b5887d6f4d68abc68b682f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485936 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#835599}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45a63bacb6df..6520135abe88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: I9adf1c0def851cf76f2d7774f7e62fcd082e48b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583863Reviewed-by:
-
Alice Wang authored
This CL moves two confirm sync data dialogs to signin.ui target. Bug: 1155131, 1155132 Change-Id: I26a78b7f44ca073ef7bb6192f69d359c9fae0c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577228 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#835597}
-
Fredrik Söderqvist authored
This method shouldn't need to mutate the buffer. Clean up by adding some local variables for the document and the associated parser while here. Change-Id: Ic0f4541d557a07da833637906c01a1aa7dc37473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582220Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#835596}
-
