GitLab

https://crrev.com/550137 introduced base::data(), along with a
specialization for strings to return mutable pointers. Update callers
of base::string_as_array() to use base::data() instead.

Note that this does come with an observable behaviour change:
string_as_array() returns nullptr for empty strings, while base::data()
returns the pointer to the NUL terminator (in line with std::data()).

However, this can be observed to be safe from the existing callers, due
to the preceding resizes that ensure non-empty() strings, or the
existing logic to handle empty strings.

Bug: 828324
TBR=caitkp@chromium.org, lazyboy@chromium.org, miu@chromium.org, sergeyu@chromium.org

Change-Id: I1fb5824b7115ff2b9ebf032f74a860e4cf3f52c6
Reviewed-on: https://chromium-review.googlesource.com/1056014
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558321}

https://chromium.googlesource.com/angle/angle.git/+log/66aafcb4641c..5d2ccc534d26

$ git log 66aafcb46..5d2ccc534 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 hans Use DefWindowProcA for window created with CreateWindowExA

Created with:
  roll-dep src/third_party/angle
BUG=chromium:842408


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I01da66d6a726675f2362ecc4206c1ae11578d247
Reviewed-on: https://chromium-review.googlesource.com/1057357
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558320}

The bug it was blocked on is now fixed, merging with the other tests.

Bug: webrtc/9141
Change-Id: If662ef9dfc4f58c0d8d43b41d32f745212ef462f
Reviewed-on: https://chromium-review.googlesource.com/1057668Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558319}

This cl adds the equivalent of fling traces in InputHandlerProxy to the
FlingController class.

Bug: 249063
Change-Id: I6a5478d6e02fe47f729b8310659997eb4b4dc485
Reviewed-on: https://chromium-review.googlesource.com/1052900Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558318}

Change the default behavior of the kRuntimeHostPermissions feature to
allow extensions to have origin access, rather than defaulting to
withholding permission. In the first stage of click-to-script, we don't
want to change any defaults.

Reland notes: the original patch caused
ExtensionApiTestWithManagementPolicy.WebRequestProtectedByPolicy to fail
because it relies on the permissions being withheld, but the patch
didn't update it with a call to withhold permissions.

TBR=karandeepb@chromium.org

Bug: 841099
Change-Id: If913aee7e14b7ea89c751528b8402d07a514b047
Reviewed-on: https://chromium-review.googlesource.com/1057433Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558317}

Change-Id: Ie6fcc3e9140da5232e10583db2fc7f85c1d928b8
Reviewed-on: https://chromium-review.googlesource.com/1057350Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558316}

When a notification was updated (same ID, new properties), the
appearance --- title, image, etc. --- was updated, but the old delegate
wasn't replaced with the new delegate. Fix that and add a test.

Bug: 840105
Change-Id: I83fd7453f13c41adf96a417e3945a85933a9e1a3
Reviewed-on: https://chromium-review.googlesource.com/1056091Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558315}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/162ca8aa..d936a701

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I4d77ac7bcd040a15ae4de27d9ed252f7732263f3
Reviewed-on: https://chromium-review.googlesource.com/1057411Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558314}

Update the backgroundfetchfail & backgroundfetchabort event types to
instantiate BackgroundFetchUpdateEvent & BackgroundFetchSettledEvent
respectively.
https://wicg.github.io/background-fetch/#service-worker-global-events

Bug: 822765
Change-Id: Iea5311fdbedf805ec8d4d54daca0257078dc050d
Reviewed-on: https://chromium-review.googlesource.com/1005177Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558313}

This API changes in AT O.

Bug: internal b/77915277
Test: Compile
Change-Id: Id3c651378d9ac12319cd5aa437e9c56d48ea3096
Reviewed-on: https://chromium-review.googlesource.com/1033472
Commit-Queue: Doug Horn <doughorn@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558312}

Before this CL, overload resolution algorithm was based on old
version, and had some Blink specific customizes.
This CL updates it to be almost compatible with current spec,
except for types that Blink does not support.


Bug: 828401
Change-Id: Ia2ee07a08f45390f39258268608fd71fdd06da89
Reviewed-on: https://chromium-review.googlesource.com/1013798
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558311}

This is a speculative fix for Chrome being unusable after unlocking the machine
after several hours/days of not being used. Our current best theory is that the
browser process goes to sleep but the renderer keeps running [and sending IPCs].
When the browser wakes up, it must spend all its time processing those IPCs,
many of which involve writing to disk.

Bug: 808031
Change-Id: Iff94f6a14cb3f3037ba43da19f32cec915b9fdb3
Reviewed-on: https://chromium-review.googlesource.com/1057458Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558310}

Modify Cache Storage API to include an ownership field. This gives the
ability to create private caches for internal usage, without exposing
the cache entries to developers.

The ownership enum will be part of the key for cache storage map look-ups.
The ownership enum will also be part of the path where the cache is
saved to disk. This way we can have more than one cache for the same
origin, and they are written to different places.

All caches will update the same quota client.

TBR=kenrb@chromium.org,mek@chromium.org

Bug: 838908
Change-Id: I5494d696d9837abbbe2ef428be0f03e4360f2bda
Reviewed-on: https://chromium-review.googlesource.com/1037264
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558309}

Speculative fix for pre-Refresh content test failures.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I743bb7e99a702ea300f0505d6d64a87b906db383
Reviewed-on: https://chromium-review.googlesource.com/1057460Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558308}

Change-Id: I16c960c107169bf1ae254587926c02349844a7a2
Reviewed-on: https://chromium-review.googlesource.com/1057412
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558307}

Bug: chromium:839695
Change-Id: I062d9a97559a4d26062e8a4932527765f06025a4
Reviewed-on: https://chromium-review.googlesource.com/1050584
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558306}

This way Android Studio makes use of our existing android ndk rather
than having to download a whole new ndk in third_party/android_tools.

Bug: 840542
Change-Id: Idcf06675f5e5f74cd860570102c38ae20dd97807
Reviewed-on: https://chromium-review.googlesource.com/1054439Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558305}

This reverts commit d4c4b89c.

Reason for revert: broke official build on Android. Builder link:
http://uberchromegw/i/official.android/builders/official-arm/builds/3206

Original change's description:
> Add ruleset indexing action as data_dep to telemetry tests
> 
> This allows telemetry to have access to an indexed ruleset, without
> having to specify one in the source tree (which would need to be
> updated every time the format version changes).
> 
> Follow-ups will copy this into telemetry's user-data-dir.
> 
> Bug: 823982
> Change-Id: Iba551b1cd6137d73bed8dfbb0bc69d00f32be7ab
> Reviewed-on: https://chromium-review.googlesource.com/1052860
> Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557855}

TBR=jkarlin@chromium.org,nednguyen@google.com,csharrison@chromium.org

Bug: 842573, 823982
Change-Id: I954fcbaec79ace212d252864f8d48c115a28cd37
Reviewed-on: https://chromium-review.googlesource.com/1057308Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558304}

This generates an html report that shows java method counts rather than
binary size.

Change-Id: I6d6ba23969fa495e714ea3d1264cd1dbf61bd4bc
Reviewed-on: https://chromium-review.googlesource.com/1055855Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558303}

As per crbug.com/788026 Comments 1,11:
- Change title text
- Consolidate text into one paragraph
- Remove excess whitespace near bottom
- Width = 448px
- Remove X (Close) button from upper right

Bug: 788026
Test: Set whatever policy is needed to disallow multi-signin from an
account, try signing in from that account, observe Harmonious dialog.

Change-Id: I1b5f2d2bf3ae092a28aa8ee48069cfead7c1559d
Reviewed-on: https://chromium-review.googlesource.com/944258Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Greg Levin <glevin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558302}

Bug: None
Change-Id: I7b802032b414404bb6604d155c7c78f7b3437e3c
Reviewed-on: https://chromium-review.googlesource.com/1057431Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558301}

Even when the parent MenuButton has keyboard focus, mnemonics should never
show on Mac.

Bug: 836964
Change-Id: If3906f664387c2730bc18f2c2bf638de6025c597
Reviewed-on: https://chromium-review.googlesource.com/1050068Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558300}

network::ProxyResolvingClientSocket supports connecting using tls. This CL
switches P2PSocketHostTcp to using that.

Bug: 721401
Change-Id: I7cbdafb92268e54104d22288baadeda528b4a95d
Reviewed-on: https://chromium-review.googlesource.com/1053833
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558299}

This reverts commit 1c397d3d.

Reason for revert: Causes crashes, https://crbug.com/842581.

Original change's description:
> [Extensions] Remove GetAssociatedWebContents() calls from file manager API
> 
> The ExtensionFunction::GetAssociatedWebContentsDeprecated() method is
> unpredictable and can return surprising values in certain circumstances.
> It is deprecated and should be removed to ensure that callers are using
> the WebContents they expect.
> 
> Update the fileManagerPrivate API to use GetSenderWebContents() instead.
> 
> The fileManager API was using GetAssociatedWebContents() to find a
> WebContents to use for an opaque ID for the SelectFileDialogExtension
> dialog. However, the WebContents that is used for the dialog is
> determined by FindRuntimeContext() is SelectFileDialogExtension,
> which uses the window from the dialog to determine which WebContents
> to use. In practice, GetAssociatedWebContents() only worked because
> both GetAssociatedWebContents() and FindRuntimeContext() fell back to
> using the active tab if all else failed.
> 
> Instead, make the opaque ID for a WebContents be based on the
> WebContents that would actually be used by the
> SelectFileDialogExtension.
> 
> Bug: 461394
> Change-Id: Id8607fd60a2cc6a6fb1cd14b3174c33bda79c8b4
> Reviewed-on: https://chromium-review.googlesource.com/1021680
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Naoki Fukino <fukino@chromium.org>
> Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557936}

TBR=ellyjones@chromium.org,fukino@chromium.org,rdevlin.cronin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 461394
Change-Id: I76fcb52ef14637abbf8bf9fbda48c83c889cd45d
Reviewed-on: https://chromium-review.googlesource.com/1057355Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558298}

This reverts commit b8b2dcd2.

Reason for revert: Problem has since been fixed.

Original change's description:
> Disable failing wasm stories
>
> NOTRY=true
> TBR=nednguyen@chromium.org
> CC=​bradnelson@chromium.org
>
> Bug: 840935
> Change-Id: I99ec329b99822a800d70da48dcea4a085fe71e56
> Reviewed-on: https://chromium-review.googlesource.com/1050577
> Reviewed-by: Charlie Andrews <charliea@chromium.org>
> Commit-Queue: Charlie Andrews <charliea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556924}

TBR=nednguyen@google.com,charliea@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

NOTRY=true
TBR=nednguyen@chromium.org

Bug: 840935
Change-Id: If27b317e19ae8bfa876b16338102a181868c69f4
Reviewed-on: https://chromium-review.googlesource.com/1057365
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558297}

This is a preparation CL for removing some code from PasswordAutofillAgent. Most of the tests in the file do not test the real behavior. We fill the username/password using JavaScript and it's a different code path from typing them manually.
The tests changed here are necessary to update. Let's land them first and observe if it introduces some flakiness before proceeding.

Bug: 842643
Change-Id: I4dd593c829c25e8f45ad816f6a3ddd3b941d76af
Reviewed-on: https://chromium-review.googlesource.com/1054675
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558296}

https://skia.googlesource.com/skia.git/+log/b06a1eb4e579..5140f9a8e424

$ git log b06a1eb4e..5140f9a8e --date=short --no-merges --format='%ad %ae %s'
2018-05-11 robertphillips Minor refactoring to image filters

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I6c3a1d580b1e2b0b4cac269489d0e7b081928f34
Reviewed-on: https://chromium-review.googlesource.com/1057428
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558295}

Now that tab-unders can be controlled via the popup setting, admins can
simply use the popup enterprise policy to also control tab-unders.

Since tab-under blocking was never actually launched in versions <M68,
this CL also drops policy support for them completely.

Bug: 842306
Change-Id: Ie7b7d41b2caeaf1e26bc931777a25ec113c03dc4
Reviewed-on: https://chromium-review.googlesource.com/1056170Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558294}

PlatformUiInputDelegate is used by PlatformUiElement and ContentInputDelegate is
used by ContentElement.
ContentInputDelegate is a PlatformUiInputDelegate. It has extra responsiblity to
handle focus and text input in web content. PlatformUiInputDelegate generates/sends
WebInputEvent to platform UI (i.e. view on Android platform).

Bug: 838925
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I18c90b656e5e0f341666f4eb22d5a5ac2252c2ef
Reviewed-on: https://chromium-review.googlesource.com/1050809
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558293}

https://swiftshader.googlesource.com/SwiftShader.git/+log/bf58b98..2a0def7

BUG=

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: Iba8c17d2cbaf8524c726f74765f0ba8de01ccf92
Reviewed-on: https://chromium-review.googlesource.com/1057408Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558292}

The dependencies in the build rule use the name of the idl file
containing the dictionary defintion. For the cases where ImplementedAs
is used, the build rule will fail since the generated file matches the
ImplementedAs value.

This CL changes the file name of the generated dictionary implementation
to match the idl name rather than the ImplementedAs name.

Bug: 839847
Change-Id: Ic5d9dfc82ba90188e26f1206465eb790dc8a193b
Reviewed-on: https://chromium-review.googlesource.com/1044217
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558291}

This reverts commit 381d19a1.

Reason for revert: Crashes on canary

Original change's description:
> Fix a startup performance issue with the ModuleDatabase feature
>
> The ModuleEventSink interface was bound on the UI thread, which caused
> cross-process IPC to retrieve information about a loaded module in the
> renderer process.
>
> A new sequence with background priority is instead used so that it
> doesn't impact startup.
>
> Bug: 832286
> Change-Id: I5ab50bc45386c9a1ddb2888f80293d78bd768a88
> Reviewed-on: https://chromium-review.googlesource.com/1037935
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558010}

TBR=sky@chromium.org,chrisha@chromium.org,pmonette@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 832286, 842506
Change-Id: I95befdad542c085e83e2ba5e292ae43f0545430e
Reviewed-on: https://chromium-review.googlesource.com/1056687
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558290}

Remove template parameter for observed objects, making it impossible to
cast an marking worklist item to that type. This was a source of UBSAN
errors in the tests.

Bug: chromium:757440
Change-Id: I35843b1bcfd81c404e840790bb00a7911e2bc3aa
Reviewed-on: https://chromium-review.googlesource.com/1057234Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558289}

This test fails on bots. Mark is DISABLED directly, rather than by the
DISABLE_SLOW_FILESAPP_TESTS macro used to control DEBUG/MSAN/ASAN (the
CopyBetweenWindows test is the only remaining test using this macro).

Add comment (conjecture about why this test is failing) and retain the
reference to issue 500966.

Tbr: fukino
No-Presubmit: true
Bug: 836254
Change-Id: I79aaac465b0fdd255a10d251cd474940c6692eb5
Reviewed-on: https://chromium-review.googlesource.com/1057548Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558288}

Part of ongoing effort to get automation tree working
in chromecast.

PS 1 is baseline for copied files.  Modifications on top
of that in PS >= 2. Duplicated code will be refactored
into common /extensions later.

Bug: b/73383411
Test: None
Change-Id: I33c032e1b8d0a78b14797b26e021e0b612f0b5ec
Reviewed-on: https://chromium-review.googlesource.com/1044278
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558287}

This fixes the logic that updates style and layout to not consider
in-body CSS as render-blocking when the
CSSInBodyDoesNotBlockPaintEnabled experiment is enabled.

It also fixes the logic to also look at pending imports (which are
always render-blocking wether in body or head) and treat them
the same as render-blocking stylesheets.

It also removes the logic that would ignore pending stylesheets
deep in the style engine when HaveScriptBlockingStylesheetsLoaded
was called. It wasn't necessary because IsRenderingReady already
checks for the ignore flag and led to a lot of inconsistent logic.

This is an update of the unsbmitted CL from last year:
https://codereview.chromium.org/2823873002/

BUG=707747

Change-Id: Id88b945334d8d029a654e2619004b077b47055ab
Reviewed-on: https://chromium-review.googlesource.com/1053878Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Patrick Meenan <pmeenan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558286}

https://github.com/w3c/csswg-drafts/pull/2666 and
https://github.com/w3c/csswg-drafts/pull/2671 updated the spec so that
elapsedTime as a member of AnimationEvent and TransitionEvent is
specified as a double instead of a float. Remove the TODOs as our
implementation is now correct.

Change-Id: I1c7abf14765fdbd46e37b4f8c506fed574cecdd0
Reviewed-on: https://chromium-review.googlesource.com/1056787Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558285}

Add warning suppression flag to where it is necessary instead.

Bug: 428099
Change-Id: Ief28527a0e5dc3c7281b5857e3ce9dec5b5bf921
Reviewed-on: https://chromium-review.googlesource.com/1029290Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558284}

This updates a few strings on chrome://sync-internals that were
misleading:
"Backend Initialization" becomes "Engine State". "Backend" was renamed
to "Engine" long ago, and the value in the "everything is fine" state is
"Started", which was confusing when applied to "Initialization".
"Syncing" becomes "Sync Cycle Ongoing", because "Syncing: false" was
similarly misleading.

Bug: none
Change-Id: I1e0cddc9b4a74277d67cf69aba83b7695bb8fa07
Reviewed-on: https://chromium-review.googlesource.com/1054671Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558283}

Updating Viz testing filters based on new Mac failures.

TBR=fsamuel@chromium.org
TEST=viz_browser_tests, viz_content_browsertests

Bug: 76018
Change-Id: I8ad81d565ad57a92ec92d0bd8482f5e8205bc81f
Reviewed-on: https://chromium-review.googlesource.com/1057352Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558282}