GitLab

As of Blink r176304, SelectorCheckingContext::scope
for styles in shadow tree changed from its shadow host to
shadow root.

Thus the subtlety of scoping difference between TreeScope
and SelectorCheckingContext::scope is gone, and code for
handling the difference can be cleaned up.

This made possible by dropping support for <style scoped>,
which introduced the complexity at r175993.

With this change no functional difference is expected,
thus all layout tests should pass.

- Convert SelectorChecker::parentElement(context) to static helper function.
- Convert SelectorChecker::scopeContainsLastMatchedElement() to static
  helper function.
- s/{b,B}ehaviorAtBounary/{c,C}ontextFlags/g
- Removed the 2nd parameter in rulesApplicableInCurrentTreeScope()
- Removed the 2nd argument for isHostInItsShadowTree()
- Removed StaysWithinTreeScope
- Removed DoesNotCrossBoundary
- Removed ScopeIsShadowRoot.
- Removed BoundaryBehaviorMask
- Removed ScopeIsShadowHostInPseudoHostParameter
- Introduced DefaultBehavior (to be removed, though)

BUG=none
TEST=pass all layout tests.

Review URL: https://codereview.chromium.org/334263020

git-svn-id: svn://svn.chromium.org/blink/trunk@177183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken
BUG=364377
NOTRY=true

Review URL: https://codereview.chromium.org/359963003

git-svn-id: svn://svn.chromium.org/blink/trunk@177181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change:
* simplifies the paintPhase checks in InlineFlowBox::paint
* clarifies and moves the "should paint box decorations" check above
  other work, including the roundedFrameRect computation
* makes some internal painting methods private
* fixes the name of "adjustedPaintOffset"
* resolves lint errors that arose during the above

3% reduction in record time on desktop Wikipedia.
Negligible impact on N7 key_silk_cases.

BUG=388946

Review URL: https://codereview.chromium.org/352903002

git-svn-id: svn://svn.chromium.org/blink/trunk@177180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |WebFrameImpl::executeComamnd()| to |Editor| class to make
"web" as thin API layer and ease of maintenance.

This patch also get rid of |WebViewImpl::bubblingScroll|, which
becomes unused function as result of moving |WebFrameImpl::executeCommand()|.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/337473010

git-svn-id: svn://svn.chromium.org/blink/trunk@177179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec tells us,

 http://whatwg.org/specs/web-apps/current-work/#run-a-worker

that in case of failure to load the script of a (shared) worker, we
should report the failure and abort (step 4.) The global scope's
closing flag will be left as false, meaning that we can safely shut
down and destroy the shared worker global scope. Do so.

R=
BUG=364390

Review URL: https://codereview.chromium.org/361443002

git-svn-id: svn://svn.chromium.org/blink/trunk@177178 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Those tests were added to web/tests as this was the only way
to test them at the time. They can now use DummyPageHolder and
be moved to core/rendering where they belong.

Review URL: https://codereview.chromium.org/361633003

git-svn-id: svn://svn.chromium.org/blink/trunk@177177 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I wrote this in r177164 thinking just that I wanted to verify the hit
test traversed all iframe boundaries, but of course there are other
widgets that aren't iframes (eg. plugins).

I tried changing the ASSERT to verify explicitly that the target
element is not an HTMLIFrameElement, but this doesn't work
either because touch adjustment may adjust the target to be over
an iframe element without necessarily hit-testing down into the
iframe.  This seems like we might want to change this to hit-test
down through the frame after adjusting to it, but the behavior has
been like this for a long time and we haven't seen an issue.

So just remove the ASSERT completely.  I don't think there's
anything meaningful to verify here.

TBRing to get the bots green ASAP and since the fix is trivial.

TBR=zeeshanq
BUG=390032

Review URL: https://codereview.chromium.org/359253002

git-svn-id: svn://svn.chromium.org/blink/trunk@177176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/362453003

git-svn-id: svn://svn.chromium.org/blink/trunk@177175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#hitregionoptions

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tRFguWa-oZc

BUG=328961

Review URL: https://codereview.chromium.org/346003007

git-svn-id: svn://svn.chromium.org/blink/trunk@177174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch updates the popup on the flakiness dashboard to be under
the cursor even if the page is scrolled.

TEST=manual, verified the popup works when scrolled in both Chrome and Firefox.

Review URL: https://codereview.chromium.org/356783003

git-svn-id: svn://svn.chromium.org/blink/trunk@177173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In previous CLs, we've been working up from the bottom of the widget hierarchy
to rewrite Garden-O-Matic in Polymer. This CL moves this project forward by
starting from the top of the widget hierarchy. When these two efforts meet in
the middle, we'll be done!

This CL is mostly about fleshing out the structure of the components. We'll
need to iterate on the visual style of each component in future CLs. I've added
dependencies on Polymer's core and paper elements because the core elements are
super useful and the paper elements are super pretty.

The top-down version is hosted in gom2.html to avoid breaking the working
product. Currently, gom2 shows correctly grouped sets of failing tests and the
regression ranges for each group (albeit without any fancy styling).

NOTRY=true

Review URL: https://codereview.chromium.org/345853005

git-svn-id: svn://svn.chromium.org/blink/trunk@177172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will allow to set breakpoint on media event listeners for video and audio elements.

R=yurys, vsevik

Review URL: https://codereview.chromium.org/343653007

git-svn-id: svn://svn.chromium.org/blink/trunk@177171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=267592
R=yurys, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/342713002

git-svn-id: svn://svn.chromium.org/blink/trunk@177170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The screen orientation mock was broken and some LayoutTests had to be
disabled. Now that https://codereview.chromium.org/339913002 has landed,
we the disabled tests should be working again.

BUG=389047,388748

Review URL: https://codereview.chromium.org/360493003

git-svn-id: svn://svn.chromium.org/blink/trunk@177169 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://whatwg.org/html#texttrackcue

TEST=LayoutTests/media/track/opera/interfaces/TextTrackCue/track.html

Review URL: https://codereview.chromium.org/356903006

git-svn-id: svn://svn.chromium.org/blink/trunk@177168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://codereview.chromium.org/60013004 started this but must have missed these.

Review URL: https://codereview.chromium.org/359023002

git-svn-id: svn://svn.chromium.org/blink/trunk@177167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a WinXP bot failure after https://codereview.chromium.org/332633006.
This case was presumably missed because WinXP is not in the CQ bot set.

TBR=sigbjornf@opera.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/355313002

git-svn-id: svn://svn.chromium.org/blink/trunk@177166 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL reduces the number of hit tests in trivial tap scenarios from 15
to 9.  Later CLs will push GestureEventWithHitTestResults up to
WebViewImpl, down to synthetic mouse events, and attempt to share hit
test results across some event types (further reducing from 9 down to 2
or 3).

GestureEvents fall into two categories that are handled very differently
today for hit-testing purposes: scroll events and non-scroll events.
Scroll events do per-frame hit-tests and propagate across EventHandler
instances from the outer-most frame to the inner-most (because they may
do some work for scroll bubbling at each frame).  Non-scroll events do a
global hit-test and jump directly to the inner most frame.  Make this
confusing distinction more explicit.

Then consolidate non-scroll GestureEvent hit-tests in blink core into a
single method: EventHandler::targetGestureEvent which returns a new
GestureEventWithHitTestResults type.  Pass these "targeted events"
around blink instead of doing repeated hit tests.

Eliminate duplicate frame tree walk on most gesture hit tests.
Previously we'd do an initial hit test to find the right subframe and
EventHandler instance, then use EventHandler::hitTestResultAtPoint to
hit test from the main frame again all the way down.

This CL should not have any noticeable web-exposed behavior changes, but
it paves the road for future optimizations which will.

Mutate HitTestResult to make it reflect the results of touch adjustment
(effectively converting a rect-based test result to a point-based result
somewhere inside that rect).  This makes it possible to use the same
code for gestures that do and don't do adjustment, avoids passing around
extra data, and makes bugs with using unadjusted points less likely.
Update touch- adjustment entry points to take a HitTestResult instead of
a point (which we'd then need to hit-test against again).  Touch
adjustment tests still need to do hit tests here though.

Remove unused 'baseEventType' hack (synthetic mouse events have carried
a 'from touch' bit for awhile now that probably supercedes whatever this
was being used for).

Fix a bug with resize handle behavior in iframes not being consistent
with other resize handle behavior.

Includes a trivial tweak to FROM_HERE macro to be explicit about
namespace usage since it can be used both within and outside of WebCore
namespace contexts.  This makes eclipse happy.

Fix WebViewImpl::handleInputEvent trace logging of event name.

BUG=381728

Review URL: https://codereview.chromium.org/338543003

git-svn-id: svn://svn.chromium.org/blink/trunk@177164 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=177154

TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/338983005

git-svn-id: svn://svn.chromium.org/blink/trunk@177162 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=389728

Review URL: https://codereview.chromium.org/360583002

git-svn-id: svn://svn.chromium.org/blink/trunk@177161 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381876
TBR=tkent for web

Review URL: https://codereview.chromium.org/355193003

git-svn-id: svn://svn.chromium.org/blink/trunk@177160 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is needed to build the generated bindings.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/359693002

git-svn-id: svn://svn.chromium.org/blink/trunk@177159 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This lets us remove code elsewhere that did the same thing, but potentially incorrectly and with unnecessary knowledge of squashing.

BUG=384520

Review URL: https://codereview.chromium.org/354223002

git-svn-id: svn://svn.chromium.org/blink/trunk@177158 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead use the same paths as other compositing updates.


BUG=384520

Review URL: https://codereview.chromium.org/358153003

git-svn-id: svn://svn.chromium.org/blink/trunk@177157 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This code doesn't many any sense. I also added a RELEASE_ASSERT that the field
already had this value and every test passed. That means this code doesn't do
anything.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/345463010

git-svn-id: svn://svn.chromium.org/blink/trunk@177156 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There's no reason we can't use the clip cache when there's an enclosing
pagination layer. None of the rest of the code in RenderLayerClipper cares
about paginations layers.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/355293002

git-svn-id: svn://svn.chromium.org/blink/trunk@177155 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We forgot to push LayoutState for inlines which meant that
we didn't invalidate correctly relatively positioned inlines
as the offset was wrong. This was visible in
fast/repaint/inline-relative-positioned.html where we invalidated
at the wrong position (and ultimately for the wrong reasons).

Review URL: https://codereview.chromium.org/358033003

git-svn-id: svn://svn.chromium.org/blink/trunk@177154 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=177136

BUG=379147
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/359073002

git-svn-id: svn://svn.chromium.org/blink/trunk@177153 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a use after free during preferred logical width
calculation when we have autosizing enabled. This is a speculative
local fix to see if more of these regressions pop up; the final fix
will need to address crbug.com/389648 as well.

BUG=385268

Review URL: https://codereview.chromium.org/358163002

git-svn-id: svn://svn.chromium.org/blink/trunk@177152 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eseidel@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/355213003

git-svn-id: svn://svn.chromium.org/blink/trunk@177150 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All entrypoints in SVGTextQuery start with check if the text content
element has any boxes. If it doesn't, a value representing "empty" is
returned. In all cases this value is the same as the default value of the
corresponding query-data. SVGTextQuery::executeQuery itself has no
problems handling this case (and will return 'false' as expected.)
Removing these early-outs means a few more cycles is needed in these
"degenerate" cases, although that seems like a small (and hopefully
reasonable) price to pay for less code (and duplication/exit-paths).

Review URL: https://codereview.chromium.org/358033005

git-svn-id: svn://svn.chromium.org/blink/trunk@177149 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Perform an intersection of the involved ranges to reject fragments early,
while still avoiding calls to mapStartEndPositionsIntoFragmentCoordinates.
This means the "cache" added in https://codereview.chromium.org/349223003
can be dropped, since we'll now never even reach it. This gives a moderate
speed-up - a few percent - on the original TC compared to using the cache.

BUG=267504

Review URL: https://codereview.chromium.org/359783002

git-svn-id: svn://svn.chromium.org/blink/trunk@177148 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Jim.

R=abarth@chromium.org
BUG=389681

Review URL: https://codereview.chromium.org/356273002

git-svn-id: svn://svn.chromium.org/blink/trunk@177147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adam says this is no longer used.

BUG=389681
R=abarth@chromium.org, abarth, dpranke

Review URL: https://codereview.chromium.org/360553005

git-svn-id: svn://svn.chromium.org/blink/trunk@177146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This testing framework is horrible.  When you have a syntax error
you have to go digging in the console to fine it, it doesn't notice.

BUG=389681
R=abarth@chromium.org, abarth

Review URL: https://codereview.chromium.org/359813002

git-svn-id: svn://svn.chromium.org/blink/trunk@177145 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL deletes RenderLayer::updateLayerPositionsAfterDocumentScroll and
unwinds all the complexity it created. Now that we're always passing
IsOverflowScroll, we can remove all the other flags for deciding when to clear
the clip cache. Also, now we always start the walk at RenderLayers that would
trigger HasSeenAncestorWithOverflowClip, so we can just assume that flag is
set.  That means there are no flags left!

Also, finally delete RenderLayerClipper::clearClipRects. Now everyone clears
all the descendant clip rects too.

Review URL: https://codereview.chromium.org/331653004

git-svn-id: svn://svn.chromium.org/blink/trunk@177144 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a replaced element has a percentage height specified then its height should
compute to 'auto' when its containing block does not have a height 'specified
explicitly'. We were taking this to mean when its containing block's specified
height value is 'auto' - in fact it means when the containing block's computed
height is auto. This brings us into line with IE and Firefox.

http://lists.w3.org/Archives/Public/www-style/2014Jun/0079.html

BUG=385877

Review URL: https://codereview.chromium.org/347053007

git-svn-id: svn://svn.chromium.org/blink/trunk@177143 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On linux use_webaudio_ffmpeg is true and when it is platform needs to
depend on //third_party/ffmpeg. This target is set up in the GN build now
(at least for this platform), so it's safe to re-enable.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/353943003

git-svn-id: svn://svn.chromium.org/blink/trunk@177142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The server version has won. Any features missing
from the server version should be added there.

BUG=389681
R=abarth@chromium.org, abarth, dpranke

Review URL: https://codereview.chromium.org/351873005

git-svn-id: svn://svn.chromium.org/blink/trunk@177141 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some folks still probably run GOM locally, but
it's not worth the burden on the code to keep this around.
If we want this we should re-build it to be web only.

R=abarth@chromium.org, abarth, dpranke
BUG=389681

Review URL: https://codereview.chromium.org/355193005

git-svn-id: svn://svn.chromium.org/blink/trunk@177140 bbb929c8-8fbe-4397-9dbb-9b2b20218538