- 29 Oct, 2019 40 commits
-
-
Roman Sorokin authored
In case no window is provided Bug: 1017659 Change-Id: I8184f0c86a6e31711b09e53867d8f015e308117d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883650 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#710384}
-
Xianzhu Wang authored
It was added several years ago but hasn't been used after its first use. Remove to simplify code. Change-Id: I9d7a18758b720ebad90624353da83659e68f0112 Bug: 1014162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881983 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#710383}
-
Corentin Wallez authored
This is to make the name reflect that there aren't just OpenGL tests in this executable now, there are WebGPU / Dawn tests too. Bug: 1017035 Change-Id: Id685700c01dfe754fc23220c34d49c96f835cc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885470Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#710382}
-
Lei Zhang authored
In r686771, we converted a base::Callback used by printing::PrintManager for Android printing to a base::OnceCallback. This was incorrect, as the PrintManager's lifetime is tied to the tab's lifetime. Now printing for a given PrintManager works the first time, but never again after the OnceCallback has been called. The callback needs to remain valid for the duration of the PrintManager's lifetime, so make it a RepeatingCallback. TBR=vkuzkokov@chromium.org Bug: 1018377 Change-Id: I367ea2e1850ee67a30ef024da2b93d4cef701f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885001 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710381}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc883a948e71..287b0a670fbf git log dc883a948e71..287b0a670fbf --date=short --no-merges --format='%ad %ae %s' 2019-10-29 timvp@google.com Vulkan: Enable forceOldRewriteStructSamplers for all Android ICDs Created with: gclient setdep -r src/third_party/angle@287b0a670fbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I02df77e279f19891fcef0ccfee2b6710e2bd8cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710380}
-
Ben Pastene authored
This rolls chromite to crrev.com/c/1863321. That picks up a change to how artifacts in the Simple Chrome SDK cache are stored. Since we add some of those artifacts to a test target's data deps, we also need to tweak them a little to conform to the new cache layout. Bug: 1012981 Change-Id: I5510be69ec38de31b6cedec2b45a182b91275589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884279Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#710379}
-
Marc Treib authored
After crrev.com/c/1866513, sync_startup_tracker_ was never actually set. Removing it also lets us remove some more dead code. Bug: 1015805 Change-Id: I4fb4d6b696ba3241d66ca6fd16cfd6d5abfc68e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886892Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#710378}
-
Andrew Xu authored
There may be a one-pixel gap between the gradient zone and the arrow button (not always). It is caused by the rounding error during painting. The easiest way to fix this is to enlarge the gradient zone by one pixel. It does not introduce other visual side effects. Bug: 1018965 Change-Id: Ifceb1310adee0e907ec3fc1ed7e88ea50af2b7fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885092 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#710377}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I13101a52bff081033dde355763396152208d0a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887833Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710376}
-
Tim van der Lippe authored
In https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1883707 the namespace will be changed. Update the test to make sure we don't break it. Bug: 1006759 Change-Id: I0c186eb7d2d32d812c646d90b98623bbb54eb1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881235 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#710375}
-
Mikel Astiz authored
Remove redundant call to TriggerSyncForModelTypes() after FakeServer has been extended to issue invalidations, just like the real server does. Bug: None Change-Id: Iab3fd66c81c3967fadc5db1209953916c043da6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886864 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710374}
-
Byoungkwon Ko authored
We need to update interface for webxr because of WPT fail. Update interfaces/webxr.idl (#18891): https://github.com/web-platform-tests/wpt/commit/ee40b7bdc5a1e62be5b49b298b8d080b3de816b6 I fixed it. Bug: 1001507 Change-Id: Ibb8d45276a67f5bfe8f6cd443dc95f5a59f0dae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871530Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#710373}
-
dpapad authored
CL produced with ESLint --fix and clang-format. This is in preparation for turning on the 'prefer-const' ESLint rule for that folder. Bug: 72003 Change-Id: I94a6f0ae63da907e552c659325de600b6b3733c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885553 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710372}
-
David Benjamin authored
This does not appear to be needed anymore. Bug: none Change-Id: I299d9e401ea05ec7c67e90b46c571157a27ee291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885172Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#710371}
-
Jacob DeWitt authored
Now that WebVR is gone, we can remove the mojo interfaces that were only used for WebVR gamepad integration. WebXR has a different way of sending gamepad data to blink. This paves the way for further cleanup of the WebXR mojo interfaces. Fixed:1017856 Change-Id: Ib5e74531f4b48baf168e2ce271f97aa3ee8804ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885131Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#710370}
-
Livvie Lin authored
After adding insecure-broken to the DevTools protocol, the SecurityStateComparator needed to be updated to handle the additional value. This cl rebaselines and re-enables the test now that the frontend changes have been submitted (crrrev.com/c/1880092). Bug: 1008218 Change-Id: Iae4cfa2dd43142ffea695737320cf3dd52aa9692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884353Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710369}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0668f3ddd97f..ca687f6e0c70 git log 0668f3ddd97f..ca687f6e0c70 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 primiano@google.com Merge "tools(tmux): fix script argument" Created with: gclient setdep -r src/third_party/perfetto@ca687f6e0c70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Id1978b3a232d742b1e9fdfe369ba8738f787fb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710368}
-
Lindsay Pasricha authored
Target 13.2 for iOS13 beta coverage and target 12.4 for iOS12. CIPD packages: infra_internal/ios/xcode/mac 11b44 infra_internal/ios/xcode/ios 11b44 Bug: 1018869b Change-Id: I6ae9bc093a81a0d72a167a1ad9feddbd05d8de11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884658Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#710367}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: I0bc25d3a803c51a5d1d4c06d21925486393b1808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884456 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710366}
-
Christopher Cameron authored
This fixes a bug where docked DevTools in PWAs doesn't work (and would affect anything that attempts to put two WebContents in a PWA). This function was never implemented because it involved passing a map of NSView*s over mojo. Since various refactorings, we now have a ScopedNSViewIdMapping which helps with this. Starting at the bottom of the change's stack and working to the top: * Change NativeWidgetNSWindowBridge::SortSubviews to take a std::vector of NSView ids, instead of a std::map ranking NSView*s. In the function, create the std::map ranking from the std::vector. * Change the caller, NativeWidgetMacNSWindowHost::ReorderChildViews. to build a std::vector of NSView*s, and then from that create a std::vector of NSView ids. * If the NSView*s do not have an id (that is, if they are not a WebContentsView, which only happens in tests), then create a temporary remote_cocoa::ScopedNSViewIdMapping to create an id. * Rename NativeWidgetMacNSWindowHost's SetAssociationForView, ClearAssociationForView, and associated_views_ to reflect that the "associated views" are a map from views::NativeViewHosts (a subclass of views::View) and NSView*s. Then there is an iffy part of the change * Allow looking up an NSView's id (the uint64 that is sent over mojo to refer to the NSView) from the NSView. * Arguably, we should change gfx::NativeView to also carry an id with it. But that is a too-large-scope change for now. Bug: 991598, 1017446 Change-Id: I2371d1716f98c2e6223a5db0272984c98c6fa4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885950 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710365}
-
Etienne Bergeron authored
This CL is lifting the parameterized unittests originally wrote for windows to a common file to be available to other platforms. Test from KnownExpectedFonts will now also run on Linux. * Added the test cases for linux. Test from Glyphs are now running on every platforms. Adding a matching_glyphs count to font_fallback_linux.cc. Previously, a default font was returned for a single character even if it was not matching the character, it was still the best match. If no codepoints are found, the font is considered a no match. Change-Id: Ie4f871281737e254bbdbea9e04f8e527f1049569 Fixed: 3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879956 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#710364}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0f9edb78. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I42e9dcaeeb0b356cf1a047ffd28045ae7ee81aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886374Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710363}
-
Mohamed Abdelhalim authored
This removes the PROCESSING_* states and introduces processing_navigation_throttle_ which is true iff NavigationThrottles are running an event. Bug: 916537 Change-Id: I72bdc5d8f51d68efcea29890915da1adb4243c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883518 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#710362}
-
Carlos Caballero authored
Theme color was being stored in WebContentsImpl which meant that a page coming from the bfcache would not correctly restore the theme color as no OnThemeColorChanged event gets fired from the restored renderer. So instead this patch stored the theme color in the RVH (that way it gets restored automatically when the RVH is swapped) and WebContentsImpl will check the color when a navigation happens and fire observers as needed. Bug: 1001087 Change-Id: Ic2ede6d3412bfc9581de1501f74d704145481f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816476 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710361}
-
Mikel Astiz authored
FakeServer::SetWalletData() now takes care of delivering invalidations by broadcasting OnCommit() to observers, which is better aligned with the production server and real-life scenarios. Wallet-specific code in FakeServer refactored to adopt timestamps as a better way to implement waits. Alternatives to achieve the same without exposing the underlying timestamp for a progress marker run into the issue that some tests still use TriggerGetUpdatesAndWait() without actually changing the server data. Bug: 1019108 Change-Id: Ia6df0f6c0a25a52e19ea4af33f6b96050a5c2968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886815 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#710360}
-
Javier Fernandez authored
First of all, bear in mind that this change affects only to intrinsic size computation in legacy layout. During the intrinsic size computation of blocks with inline children, we are determining the breaking opportunities for each child. When the word-break: break-word is used, each of this breaking opportunities should account for the min-content size. We only consider breakable locations for start and end if they are br elements or spaces, under auto-wrap, to compute the intrinsic size of a box. This is fine, since we are already using a break iterator to determine the min-size of each word. However, we were incorrectly summing the first_line_min_width for each inline sibling, even when they were part of the same text line. This change tries to avoid that problem by assuming that there is always a breaking opportunity after every character, since the spec now states that break-word should behave as normal and overflow-wrap: anywhere. Bug: 1013644 Change-Id: I04261b323cd029a624724363a566fccc826863af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856959Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#710359}
-
Mihai Sardarescu authored
UnifiedConsent feature is now enabled on all platforms. This CL does the following: * It removes dead code from the SyncDisableObserver and cleans up its tests. * It removes a series of tests from the UKMBrowserTest that are no longer relevant (UKM only depends on sync for purging extensions). Note that the name SyncDisableObserver is no longer relevant: * UKM does not really depend on Sync for UKM consent anymore * UKM depends on sync for purging extensions. As a follow-up CL, it may be a good idea to rename ukm::SyncDisableObserver to ukm::ConsentStateObserver and rename the internals to avoid using SyncState as the per-profile state. Bug: 1015805 Change-Id: I0e20134c03fc5d35b6a4a619ee3e6df466461164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869007Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#710358}
-
Justin Cohen authored
Sometimes after session restoration the NavigationItem URL is placeholder. Because -currentURLWithTrustLevel:trust_level will return the virtualURL, compare with a NavigationItem virtualURL as well here. Change-Id: Ie189fdb435a43aa7ffffe41fdd9c62183b55e2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887271 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710357}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d4b95d213d6f..ee08d523f60a git log d4b95d213d6f..ee08d523f60a --date=short --no-merges --format='%ad %ae %s' 2019-10-29 robertphillips@google.com Move creation of AAQuadIndexBuffer to GrResourceProvider Created with: gclient setdep -r src/third_party/skia@ee08d523f60a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: I546af6bdf83fa754b040535904054520532a668f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886366Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710356}
-
Alex Clarke authored
This will make some internal testing easier. Change-Id: Ie38c61d892bdc78dd3d7c35f95436d1ea1ffb12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881234Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#710355}
-
Hans Wennborg authored
Since upstream llvm/clang has moved to Github, there are no longer any svn revisions. Instead, our package versioning scheme now begins with the number of commits since the initial commit in the repository, prefixed by an "n". These "n" numbers are NOT comparable to svn revisions. Ran `tools/clang/scripts/upload_revision.py 55c223a7ed522293cf9995d07d348368c345d1f2`. Bug: 1011815 Change-Id: If2b9dce272182ca4f0881424e1d64410b796b4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879890 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#710354}
-
Jaeyong Bae authored
This patch means refactor function name according what function do. And, it might make sense to move the static merge functions to autofill_profile_comparator which has functions related to merge logic. Bug: 913940 Change-Id: I5a6d71b45fadf225e33541dc2b3a17bb7794ec1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885864Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710353}
-
Henry Jian authored
This (mostly) reverts commit 274ea563, excepts that it increments the current_version.gni instead of reverting it. Reason for revert: I need to modify the shell apk and push it now but this CL needs to wait for WAM server change to be pushable. Original change's description: > [Android WebAPK] Create resources for web shortcuts. > > Resources used need to be pre-declared in the shell. > > Since we don't know how many shortcuts are needed for a web app until > the creation request, we create 4 copies of the needed resources to > declare a shortcut, since that is the maximum number of shortcuts > allowed on Android. > > The following resources are needed (per shortcut): > - name > - short_name > - icon (placeholder taken from > https://material.io/resources/icons/?icon=filter_1&style=baseline) > > The shortcuts.xml is also partially generated to use the resources, so > that building the shell apk doesn't fail. They are all disabled by > default, and will need to be re-enabled on the server-side. > > Bug: 1010471 > Change-Id: I5371b145afd943029de8eb679b0cf3044545cbe3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875755 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Glenn Hartmann <hartmanng@chromium.org> > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709189} Bug: 1010471 Change-Id: Iee87449e0c2f60117e542b605d8cd08beffc0ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885250Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Henry Jian <hzjian@google.com> Cr-Commit-Position: refs/heads/master@{#710352}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/588b98f2..d50a9c98 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iecc251cf632099e8054994d47f108feed6003712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886373Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710351}
-
Carlos Caballero authored
DidFirstVisuallyNonEmptyPaint will not fire again if the page is restored from the bfcache. So keep track of whether it fired, and fire it again if the page is restored from the bfcache. Bug: 1001087 Change-Id: Ie64f2706d6dcff8935d10b58185394f0fd245f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827361 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710350}
-
Anton Bikineev authored
This reverts commit 77f24899. The check never triggered, so it's safe to assume that interior objects are not accessed in the write barrier. Change-Id: I7e0857011114cd36068239dbda96d1f0d21801cc Bug: 1009683 Change-Id: I7e0857011114cd36068239dbda96d1f0d21801cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886679Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#710349}
-
Tibor Goldschwendt authored
+ Always create a module native library target (not only for patitioned lib build) to simplify selection logic. Change-Id: I6b4de3a9e883ad5087c38dac6783fea28b55ddd3 Bug: 870055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877249 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710348}
-
Jan Wilken Dörrie authored
This change removes the HTTP FOAS feature flag. The corresponding feature was enabled by default in M79, which is why the client code can be cleaned up now. Bug: 914765 Change-Id: Iffe7aafcde5abcac2133efe678a6b2a99fd3a7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886335Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#710347}
-
Javier Ernesto Flores Robles authored
TBR=eugenebut@chromium.org Bug: 1016368, 1016367 Change-Id: Id1596414616fc839472a85c1a7db1b66a717acd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886899 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#710346}
-
Abhijeet Kandalkar authored
Type casting related functions like IsHTMLXXXXElement, ToHTMLXXXXElement, and ToHTMLXXXXElementOrNull are being phased out in favor of new downcast helpers in t_p/blink/renderer/platform/casting.h. There is still a long run to fully remove old type casting mechanism, but this CL aims at preventing new uses to take place. Bug: 891908 Change-Id: I6a079b9524d2e94805528bdcf17baaa66fe091da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879628Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#710345}
-