- 12 Oct, 2020 40 commits
-
-
Bailey Berro authored
This change introduces the SystemRoutineController class that connects to the cros_healthd DiagnosticsService. Subsequent CLs will declare and implement a SystemRoutineController mojo interface. Bug: 1128204 Change-Id: Ic510e1f90efedbbcba42827ca843323f04803e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457807Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#816182}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010120700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/tdIYOywbT-7Ua5VwVKvfLfPLbfSGfLAQ2PzHie1qBhsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/162270429 Tbr: media-app@grotations.appspotmail.com Change-Id: I15869f4d646a0e20003430bf68b9ff5280c83f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466156Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816181}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/109c355900d1..7c7b98f06001 2020-10-12 hjd@google.com perfetto_cmd: Fix statsd based triggers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3d46f1b7c18c2b04f7b873ee99a9f636d5ef7f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465935Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816180}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/66b5d4eb..896ca12d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e76118eb412128a06abcb6968ccc488d6c3300c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461573Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816179}
-
James Cook authored
A subsequent CL needs this information early in startup to provide device enrollment status for UMA stability metrics. Bug: 1134341 Change-Id: I4537c1866b262b2c4f7560bf01712e7dd42ffc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461049Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816178}
-
Ian Kilpatrick authored
There should be no behaviour change. Bug: 1091797 Change-Id: I9de49338c43f71e85f9d227a8000c5edd4894f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465222Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#816177}
-
Hans Wennborg authored
Newer Clang versions will perform "scalar replacement of aggregates" optimization on the 'sentinels' array, breaking the test. Leak the address of the array with debug::Alias to prevent that. Bug: 1135294 Change-Id: I834b8406c0f91954207177294976250ac9c773f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462273Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#816176}
-
Claude van der Merwe authored
Wifi Sync depends on Chrome Sync. This CL disables the Wifi Sync feature toggle and updates the feature description with a prompt to enable Chrome Sync if it is disabled. The following changes are made: 1. Add translation strings for the Wifi Sync when Chrome Sync is disabled, along with translations for the accessibility labels. 2. Adds a new polymer component for the feature summary when Chrome sync is disabled. 3. Add a new polymer component to encapsulate the logic that checks whether the prerequisite Chrome Sync setting is enabled. 4. Added a 'localized-link' slot to multidevice for the feature summary so that the special case Wifi Sync string can be used. 5. Added browser tests for the new polymer components. The new localized-string component is similar to settings-localized-link, but it contains two links (settings-localized-link limits the number of links to one) that have accessibility labels assigned manually. Bug: 1117619 Change-Id: Iab5dbe553ad3433c4b4208d61d2aafd697143860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432675 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#816175}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie8767ab952dda79a999b52881e42243c65a09423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464907Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#816174}
-
Paula Vidas authored
StopListeningPermanently() gets called during sign-out. The FCM token needs to be cleared so that the change can be propagated to device info. Empty token in device info signals that the device is not listening to invalidations. Change-Id: I6d0a4e2007af6d7457cafed265877ec9810cb4f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465844 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#816173}
-
Nohemi Fernandez authored
Moves the Sync errors item out of Google Services into the Sync settings page for the MICE experiment. Bug: 1125631 Change-Id: I4f373a14e967e76d55f7d0aa7b8ed02a53c495df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461266 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816172}
-
Egor Pasko authored
At least one bot (see crbug.com/1137405) started failing after crrev.com/814863 with a message: 'unrecognized arguments: --avd-config=...' Since a few related changes landed on top, I'm not comfortable reverting it. Rather making the check pass with this configuration. Tested locally by providing the same command line arguments as on the bot. Tbr: dpranke@google.com,agrieve@chromium.org,pkotwicz@chromium.org Bug: 1137405, 1115604 Change-Id: I28c9e3179fdbbc36ec515ed6aba8ce12f78a9417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464270Reviewed-by:Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#816171}
-
Marc Treib authored
TypeStartCallback was misnamed; it's not used as a callback. This CL renames it to MarkDataTypeAssociationDone which is closer to what it does/means. It also removes an unreachable branch within the method (replaced by DCHECKs). Bug: 647505 Change-Id: I43e041c20ff14a71260c85c4717d8c2e62ed0708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466098Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816170}
-
David Jean authored
Bug: 1108395,1108433 Change-Id: Id936266c054b84e038e2a6dacfb12a7f646bceb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450075 Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#816169}
-
Renato Silva authored
Generate an additional metric that combines data from all countries for the Chromebook marketing opt-in. Fixed: 1136816 Change-Id: I521824b2b5f7d5c06402dad5ccbe1719dd1c197d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463613 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#816168}
-
Stepan Khapugin authored
Adds an identifier for EGTests to each window. This will allow matching specific windows in tests. Bug: none Change-Id: I9d04ee645ec1658181d5580a8f4c2060b6927940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463565 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2531de9926d1..07055b5e25a2 2020-10-12 mattleibow@live.com Parse out the orientation in the SubIFD of EXIF 2020-10-12 robertphillips@google.com Revert "[svg] Add svg_tool" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I7d7453b9173734ed59b3e37a0e02f021c9ed5722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465932Reviewed-by:
-
harrisonsean authored
Update the isUpToDate util function to use userdefaults update status instead of verifying off version and version discrepancy. Move userdefault update status recording to Omaha as regular update checks will never record an up to date status. Bug: 1078782 Change-Id: Ibe2692b573efb3180ef0f255530545d75ab3248b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462256 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#816165}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac0366e76f36..fb0f797b07aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gab@google.com,amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: gab@google.com,amraboelkher@google.com Change-Id: I9ff9debfaadd4a6d31409c52fe243496bfd34cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465931Reviewed-by:
-
Paula Vidas authored
This class simulates sending sync invalidations from the server. This is needed for two client tests that use sync invalidations. Bug: 1135167 Change-Id: I9afda17806a88006c0a05917dec808eb91a2fd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461737 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
-
Yuki Shiino authored
allocator/allocator_shim_override_cpp_symbols.h and allocator/allocator_shim_override_libc_symbols.h are not used on all platforms. The old BUILD.gn looked confusing as if these two files are used regardless of platforms. Moves the two files to platform-specific sections so that it's clear that the files are platform-dependent. Change-Id: I9da23cd7377d01b0a9c968224ddea88dd4c67211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461186Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#816162}
-
Ioana Pandele authored
These fields are non-editable so they shouldn't be able to get focus. Bug: 1133221 Change-Id: Icc99206479ed15f8d8557594ef9c9be1457c3011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450313 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#816161}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602482293-c39f07959f0e29f7d514a51869e00b511fbb2f8b.profdata to chrome-linux-master-1602503558-6db36755351afd56b86dda41eeed03adf268112f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7c6206de8cfd344614e1588d92a0e03da37cd7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465930Reviewed-by:
-
Egor Pasko authored
This reverts commit ba91c305. Reason for revert: new strict mode violations in http://crbug.com/1137380 Original change's description: > Move AndroidSyncSettings strict mode exception to ChromeStrictMode.java > > BUG=None > > Change-Id: I094e2cb0edc01312f1200773e09bc842727b78ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453925 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815753} TBR=agrieve@chromium.org,pkotwicz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1137380 Change-Id: I1b5886aed2a204335537ddc3ab5ca224e0797a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464268 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602482293-da1e028d2d7af7f0b3fa08c67c62f39283c5fc49.profdata to chrome-mac-master-1602503558-f6db874387e2078784a354d0f7c8c59a21bebaa6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I74808c33298d49a824a2b1c073c83f57c8528ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465387Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/72cc54c5b852..1da46abbddb6 2020-10-12 ilnik@webrtc.org Fix quality scaler being accidentally enabled for VP9 2020-10-12 hta@webrtc.org Break out more targets from pc/peerconnection 2020-10-12 hta@webrtc.org Move pc/media_stream_track.h to the api/ directory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic8cb41fbef4af0f03368969955f1351fc2533029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465925Reviewed-by:
-
David Roger authored
Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/c76614ee7a694b28c9888e29efed8286c3677e5c Mock: https://screenshot.googleplex.com/87ZjBy33wCC6VX5.png Bug: 1126238 Change-Id: I84f78c5c5b3f6bb23b8bb7218efdf2c807994d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464937 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#816156}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dec35c569444..46d4522b161b 2020-10-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 0046c31f2f96 to 9d4b40ae645e (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Change-Id: Ib8bcdf4af02aab006ba0f2a64a3f0964cf1d1a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461483Reviewed-by:
-
Rushan Suleymanov authored
Some tests related to bookmarks reupload are flaky because there is used UpdatedProgressMarkerChecker. It doesn't guarantee that all current changes are committed. The better option is to wait for the actual expected data on the server rather than for the next commit message. For bookmarks reupload there are two possible titles in specifics: legacy canonicalized title and full title. This CL extends the ServerBookmarksEqualityChecker to wait until both of them are equal to the expected title. Bug: 1135271 Change-Id: I0a80949e30b085d94e00a82ddd8d79db39309891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462268Reviewed-by:
-
Yifan Luo authored
Bug: 1116418 Change-Id: I17236ce61c4ad5224a7165b67db66bb213f64cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461371 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#816153}
-
Victor Hugo Vianna Silva authored
(Firstly, this CL is only big because it it removes 3 similar methods at each time - Status/Commits/Updates counters - and the existing plumbing goes through many layers. All the changes are trivial code removal and no behavior is changed.) The last real implementation of TypeDebugInfoObserver was removed in crrev.com/c/2465743. The remaining implementation in SyncEngineBackend actually just propagates the notifications up to ProfileSyncService::type_debug_info_observers_, which is now empty. So this CL removes the interface and all associated code: - Implementations of On[Commit/Update/Status]CountersUpdated and their associated plumbing methods. - Methods to add/remove an observer, and observer lists. - Methods to enable the notifications (e.g EnableDirectoryTypeDebugInfoForwarding). A few points are left for future CLs: - Properly repurposing DataTypeDebugInfoEmitter. This class now only records UMA for the status/commits/updates counters. It should be renamed or at least have its documentation updated. It can also be merged with its only implementation, NonBlockingTypeDebugInfoEmitter. - Removing DataTypeController::GetStatusCounters(), which is now unused. Bug: 1102849 Change-Id: Ic993f60995f2c48ad7d284ebe218136d8ebe564d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465744 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#816152}
-
Luciano Pacheco authored
These files are dependency used by Files app which is process to generate JS modules. Bug: 1133198 Change-Id: Ib749ad8cf9c96be96f6c0372d3c80a2f74a91afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440376 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816151}
-
Tanmoy Mollik authored
If the user has only signed in without giving sync consent then the sign out button in account management page should not show the sign out dialog. Instead it will sign the user out directly without deleting data saved on device. Bug: 1136075 Change-Id: Ie2485e2896518113d62cec4a1c9fd57bfbaef2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460817 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch uses the return value of |insert| to check if the key is already in the map or not. This patch has no behavior changes. Bug: 652964 Change-Id: I6d53b923a7dbb8b39fdb03ec1a833ff8e88b5c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462856 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#816149}
-
Marc Treib authored
Contrary to the code comment, it was only used for the PROXY_TABS data type. This is now handled explicitly instead. Bug: 647505 Change-Id: I5fd3fdb4d93230acac32966c1ee54334983dc6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462093 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
Change ManageSyncSettings title to "Sync". Screenshot: https://crbug.com/1135923#c6 Bug: 1135923 Change-Id: I4a4c732b5149ae78476186c07893a1b61b0ad7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461341Reviewed-by:
-
Aaron Tagliaboschi authored
This reverts commit 0e9a9078. Reason for revert: The surfaces need be measured against the BluetoothRemoteGATTCharacteristic that a BluetoothCharacteristicProperties describes Original change's description: > Instrument BluetoothCharacteristicProperties for identifiability study > > Bug: 973801 > Change-Id: I0c1616e85080c1048f6777caaa7769ce8398e507 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354270 > Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799143} TBR=dcheng@chromium.org,asanka@chromium.org,aarontag@chromium.org Bug: 973801 Change-Id: Ia92e1bff1ef21b1167786ceb3fca1ffe257e2852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463595Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#816146}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I2ef9b64449927ea2e77e1c90edba51dc31833781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464092Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816145}
-
Gyuyoung Kim authored
This CL replaces all uses of web_pref::ImageAnimationPolicy with mojom::ImageAnimationPolicy to reduce unnecessary type conversion. Bug: 1097943 Change-Id: I608bd5919c7ae5d20ed8eba02c6bb9a1bcba9348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465802Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#816144}
-
Kuo-Hsin Yang authored
Before this patch, GetSystemMemoryInfo() reads both /proc/meminfo and /run/debugfs_gpu/i915_gem_objects (for x86 CPU family). Reading /run/debugfs_gpu/i915_gem_objects could take more than 500 ms under memory pressure on Intel platform with kernel 5.4, while reading /proc/meminfo only takes about 1 ms. Add GetGraphicsMemoryInfo() to read the gpu memory info, GetSystemMemoryInfo() reads /proc/meminfo only. GetGraphicsMemoryInfo() would return false on Intel platform with kernel 5.4 to avoid the slow i915_gem_objects access. Bug: b/170150180, 1134131 Change-Id: I0a0cfb868826b59f508a478d3db69ec089f5d4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449519 Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816143}
-
