- 21 Feb, 2020 40 commits
-
-
Darwin Huang authored
Mechanical find/replace from "Trace(blink::Visitor*" to "Trace(Visitor*" Refactoring change only. No functional changes intended. Bug: 1051193 Change-Id: Ia1a150929998758687187c82289a9d5646ad9b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068040 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#743458}
-
Yoshifumi Inoue authored
This patch marks fast/forms/date/date-appearance-basic.html flaky because it is failed on Mac debug. TBR=masonfreed@chromium.org Bug: 1043488 No-Tree-Checks: true No-Try: true Change-Id: I98f54c0042aa4661b5bf541f2daa4fce7c3caf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067765Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743457}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d76b0f8e4596..5e4f0910c1bf git log d76b0f8e4596..5e4f0910c1bf --date=short --first-parent --format='%ad %ae %s' 2020-02-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@5e4f0910c1bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If07a0c44ed147956e08f19a5e8c012640a6faf7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068159Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743456}
-
Daniel Libby authored
Keyboard arrow scrolling and scrollbar button scrolling should also scroll a percentage of the scrollable area when percent based scrolling is enabled. This CL adds plumbing from the base::Feature to blink, and uses 1/8th as the percentage to use for directional scrolls via keyboard arrows or scrollbar buttons. Adds a test suite that runs scrollbar tests in percentage mode. Keyboard is currently handled on the main thread so we just use the runtimeFlag toggling via javascript and eventSender. Bug: 1008153 Change-Id: I7ea7c5471298187da757cf22748620c4accaf192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057501 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743455}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/518e466ec497..c5d36f253374 git log 518e466ec497..c5d36f253374 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 fancl@chromium.org Fixing dashboard & sheriff-config push-on-green Created with: gclient setdep -r src/third_party/catapult@c5d36f253374 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: crouleau@google.com Change-Id: I1a13271becdfeac815886bbd4b70a67704f9a732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068162Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ccc1f15fb915..8adb09deb15b Created with: gclient setdep -r src-internal@8adb09deb15b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049646 Tbr: jbudorick@google.com Change-Id: Icff0039bb98b36e2fbced587fe895996a12ab4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068004Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743453}
-
Hirokazu Honda authored
Bug: 1035788 Bug: b:145961243 Test: HW encoder is used on https://appr.tc/?debug=loopback&vsc=h264&vrc=h264 Test: CtsVideoTestCases Change-Id: Id461857ea2ec2ce3382a5a72fc554951454bb582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041983Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#743452}
-
Eriko Kurimoto authored
This CL adds browser tests for 'module' type shared workers in WorkerTest.WorkerInBackgroundPage. Bug: 824646 Change-Id: I4500087be534bb384bcf4171437b50312b2a7da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061578Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#743451}
-
Miyoung Shin authored
This is a precursor CL to replace ExternalPopupMenu class by a mojo connection, and replace blink::TextDirection with base::i18n::TextDirection. Bug: 1044268 Change-Id: I0b6802201b05c48abaf19de78e81a848d5dc94b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061985 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Lei Zhang authored
Also reassign one of their TODOs. Change-Id: Id38eced079effbb4616e8fc6b94e925cb6b99330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067925Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#743449}
-
Rachel Sugrono authored
Change-Id: I424c2222de164cb58b5e46cea2be4b5c9d16bddb Bug: 992824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067764 Commit-Queue: Rachel Sugrono <rsugrono@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#743448}
-
W. James MacLean authored
This CL attempts to revert r707164 (https://chromium-review.googlesource.com/c/chromium/src/+/1863512) on ToT. It was slightly complicated through collisions with other CLs: Also reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1865530 Preserved: https://chromium-review.googlesource.com/c/chromium/src/+/1918262 Bug: 1050635 Change-Id: I426d45b44733a5fedd9c9a66c602e228051bafa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051206Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#743447}
-
btolsch authored
This change moves the current remaining OSP platform implementation files into //components/openscreen_platform in preparation for being used in //components/cast_channel. There are several additional fixes that were unittests + future integration work correctly: - Fixed a reversed sense of addresses (local vs. remote). - Began passing DER certificate back to caller when a TLS connection succeeds. - Fixed several use-after-moves that were dependent on argument evaluation order. Bug: 1050913 Change-Id: Ie5db314ffca1b5917ea85f17ae0614cdef8bee74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048916 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#743446}
-
Rachel Sugrono authored
Toogle (toggle :)) the info-button between being in an active state when the metadata-box is active and not in an active state when the metadata-box is not active. Also style the active state of the info button for files-ng. Change-Id: Ic54e3ce093551b6d517513149326eb3fc7f45c7e Bug: 992824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066409Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/adfb1574077d..d41bcabd124f git log adfb1574077d..d41bcabd124f --date=short --first-parent --format='%ad %ae %s' 2020-02-21 nigi@chromium.org Roll buildtools/ 1f38b432e..713b351a1 (7 commits) 2020-02-21 nigi@chromium.org Roll tools/code_coverage/ c7a868bac..a8f20a1da (1 commit) 2020-02-21 thestig@chromium.org Observe CPDFSDK_PageView inside ExitWidget(). 2020-02-20 tsepez@chromium.org Add test cases for several recently fixed XFA bugs. Created with: gclient setdep -r src/third_party/pdfium@d41bcabd124f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1026991 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6a4ccbe1b938d8d640da1491b64a79cbde588e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068016Reviewed-by:
-
sczs authored
This regression was introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/1974894 We need to respect the animated flag, this is really hard to test since we can't tell on eg if the dismissal was animated or not. Bug: 1049088 Change-Id: I9e4326f4fb7885146191bd39e9ebeded8c1c9ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067642 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#743443}
-
Kinuko Yasuda authored
This patch tries to make sure if not setting the given request_context_type for Fetch request doesn't break anything, before actually deprecating them. End state should be: * We remove FetchAPIRequest::request_context_type and URLRequest::fetch_request_context_type (if this doesn't break anything) * As a follow-up we can add the code to serialize/deserialize 'Request.destination' into CacheStorage, but it's not happening now (i.e. it's broken) More details: * Request's context type is not used when it's propagated to SW's fetch event or used for Cache Storage, and it seems it's WAI per spec (and request context type's not a spec'ed anymore) * Cache Storage's matching logic doesn't use them either. * Cache.keys() seem to be supposed to return the original request, therefore destination would need to be stored there, while the part's currently (already) broken Bug: 1045925 Change-Id: I4e95fe51b9a6b1d9f91226017e931f8a1d357a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066359 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#743442}
-
Giovanni Ortuño Urquidi authored
The project is still on going but has been transferred to the camera app team. Change-Id: I24309a57cdfa6764294aee0b47196b848d085894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067838Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#743441}
-
Yuichiro Hanada authored
This CL changes RewriteKeyEventInContext to use the new API. Before this CL, EventRewriterChromeOS::NextDispatchEvent sends the events from StickyKeysControllers and the events generated in RewriteKeyEventInContext. Now, RewriteKeyEventInContext takes Continuation as an argument and sends all generated events without storing them in dispatched_key_events_ and gets events from StickyKeysController if it has pending events. As the result, we can remove dispatched_key_events_ field and EventRewriterChromeOS::NextDispatchEvent. However, EventRewriteStatus is still used inside EventRewriterChromeOS, so we can't clean up them yet. Bug: 1049489 Test: unit_tests Change-Id: I41109afa57bc1407beab6ab264bcbfc992d9f1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056526 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#743440}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7aa682406ad4..7e4c38a48b04 git log 7aa682406ad4..7e4c38a48b04 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 sque@google.com Roll out new goma client binary VERSION=191 Created with: gclient setdep -r src/third_party/depot_tools@7e4c38a48b04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie7ba0cdb4a40c35e12da64cb45d3cb137418a5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068003Reviewed-by:
-
Trent Apted authored
The Chrome OS Gallery is affected badly by Blink's new treatment of EXIF orientation for <img> and <canvas> elements. With crrev.com/741635 (and crrev.com/725393), it's now necessary to add the "new Image()", and the <canvas> element it is drawn into, to the page temporarily. Without this, <img> and <canvas> elements attempt to respect any EXIF orientation in the source bitmap. This conflicts with logic in Gallery to support the earlier behavior of these elements. This CL sets attributes to disable the new treatment, and performs the necessary DOM machinations to ensure these attributes take effect. The approach should be robust enough to function as expected whether or not the new EXIF orientation treatment is actually taking effect. Skip presubmit: A linter complains about changes outside the scope of this CL. (OWNERS approval still sought). No-Presubmit: true Bug: 1043561 Change-Id: Ib58c8bed9dd5589e3908a8336b4446eeb523170a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065688 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL moves FrameMsg_SetFrameOwnerProperties to LocalFrame and RemoteFrame and removes WebFrame::SetFrameOwnerProperties(). Bug: 1042723 Change-Id: Ie02cc753e2e762a14b67d778e7aebb3f06a2bb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037305Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Justin Gallagher authored
Support moving tabs between different open windows via the tab context menu, allowing this to be done using only the keyboard. The option replaces the "Move tab to new window" entry if there is at least one other window that can be moved to. Inside the submenu, there is an option to create a new window or to choose any existing windows of the same profile. A new class, ExistingWindowSubMenuModel, represents the submenu. It requests the list of existing windows from the Browser, which it receives as a list of titles. Once selected, the index of the chosen browser is passed back to Browser, which references a stored list of WeakPtrs. The windows enumerated in the submenu are each calculated titles of the form "PAGE_TITLE and x more pages" that fit within an allotted pixel width. First the length of the "x more tabs" extension is calculated, and the title is elided based on how much width is left from the default 400 pixels. In addition, the title is always guaranteed at least a few characters if the extension is extremely long. Bug: 1040582 Change-Id: I9e5c2ba1a1e7f850126df019a9bc2a5b1de842e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026265 Commit-Queue: Justin Gallagher <jugallag@microsoft.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743436}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2de1869d1c21..d76b0f8e4596 git log 2de1869d1c21..d76b0f8e4596 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d76b0f8e4596 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e42bfafe54da3a19d4d443401446f28d5a995e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068006Reviewed-by:
-
Kent Tamura authored
Rebaseline for the mock theme removal and FormControlsRefresh. Tbr: keishi@chromium.org No-Try: true Bug: 910979 Change-Id: I93eb35a2962a9d43b13618be739c4983cd6d021f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067760Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#743434}
-
Isabella Scalzi authored
If the user click on an image in the Quick View content area, the the files-safe-media webview takes the focus. However, there are no focusable elements inside the image. Blur them and put the focus back to the quick view dialog element. No-try: true Test: Test coming Bug: 1038835 Change-Id: I775122bd04397843941b078336c6fe09cf70f873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067839Reviewed-by:
-
Rachel Sugrono authored
Change the line-height of the title and info row and restyle the title. Change-Id: Ideb870847d48a7ce1b7028800293300100ad5293 Bug: 992824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067837Reviewed-by:
-
Yoshifumi Inoue authored
This reverts commit 7b29a982. Reason for revert: Experimental revert to fix layout object/document leak starting from build#11028 It seems we don't call Destroy for <::marker>, but not sure. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/11028 Original change's description: > [css-pseudo] Implement legacy markers as real pseudo-elements > > Before this patch, list markers were anonymous boxes in legacy layout. > This patch makes them be pseudo-elements instead. This is a follow-up of > r731964, which did the same for LayoutNG. > > Just like r731964, this patch improves the flexbox_with_list_item.html > performance test by a 30-40% (this time for legacy). > > BUG=457718 > > TEST=editing/execCommand/create-list-1.html-disabled > TEST=editing/pasteboard/drag-selected-image-to-contenteditable.html > TEST=editing/pasteboard/input-field-1.html > TEST=editing/selection/drag-to-contenteditable-iframe.html > TEST=editing/selection/move-by-line-002.html > TEST=editing/selection/selectNode.html > TEST=editing/selection/selectNodeContents.html > TEST=editing/unsupported-content/list-delete-001.html > TEST=editing/unsupported-content/list-type-after.html > TEST=editing/unsupported-content/list-type-before.html > TEST=external/wpt/css/css-pseudo/marker-content-014.html > TEST=external/wpt/css/css-pseudo/marker-content-019.html > TEST=external/wpt/css/css-pseudo/marker-content-020.html > TEST=inspector-protocol/resources/dom-snapshot-pseudo-element.html > TEST=paint/invalidation/list-marker-2.html > TEST=paint/invalidation/offset-change-wrong-invalidation-with-float.html > > Change-Id: I58c8d49e1f2168add3c78a024a2b9371b34262d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007733 > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743220} TBR=dmazzoni@chromium.org,kojii@chromium.org,futhark@chromium.org,obrufau@igalia.com Change-Id: Ic5d1c5633fe2d7087bdfe8bda239c25d2fb67167 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 457718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068066Reviewed-by:
-
Ben Pastene authored
Relands https://chromium-review.googlesource.com/c/chromium/src/+/2062879 Bug: 1054245, 1048253 Change-Id: I424802b387fc6e414fc5328052db4e9cecae091e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062580Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Now that our default finch parameter does not contain the workaround for the YouTube, let's remove it from the fieldtrial_testing_config so that it matches the distributed default configuration. Bug: 1001450 Change-Id: I332b336e3d5567f81766758ec861ad0a3a0bbd82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065781 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#743429}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c681b47a0955..e060aaf770ca git log c681b47a0955..e060aaf770ca --date=short --first-parent --format='%ad %ae %s' 2020-02-21 btolsch@chromium.org Add URL parsing support 2020-02-20 miu@chromium.org Improved FakeClock::Advance() for simulating task execution. Created with: gclient setdep -r src/third_party/openscreen/src@e060aaf770ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I76b4f5fc4e06a6e1128d877c4561f4781ecde468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067930Reviewed-by:
-
Charlene Yan authored
Bug: 1040657 Change-Id: I50c63cb1f94da36ff24c882f76125b65165d0888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063734Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743427}
-
David Munro authored
Test: None Bug: None Change-Id: I47c1f70860ed364fdfecb403a29c3d8a1ab8b4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067757Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#743426}
-
Takashi Sakamoto authored
This reverts commit de6ebaa2. Reason for revert: causes compile failure on linux-chromeos-chrome Sample build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3372 Sample log: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8887878986181186864/+/steps/compile/0/stdout?format=raw --- [34344/60074] CXX obj/chromeos/services/assistant/lib/assistant_manager_service_impl.o FAILED: obj/chromeos/services/assistant/lib/assistant_manager_service_impl.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../chromeos/services/assistant/assistant_manager_service_impl.cc:101:16: error: unused variable 'kScreenContextQuery' [-Werror,-Wunused-const-variable] constexpr char kScreenContextQuery[] = "screen context"; ^ 1 error generated. --- Original change's description: > assistant: Remove IsScreenContextQueryEnabled > > Remove unused code. > > Bug: b/145218971 > Test: manual > Change-Id: I54e08fc38e967517212b2f41fabe6bb872d17cf3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067938 > Commit-Queue: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743408} TBR=xiaohuic@chromium.org,wutao@chromium.org Change-Id: I565b31eb10ecaf53d9adae452320de420b7f00db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/145218971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067761Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#743425}
-
Klaus Weidner authored
Move this declaration from the "overrides RenderFrameHostDelegate" section to the "overrides RenderWidgetHostDelegate" section to match the actual inheritance. Should be a no-op. Change-Id: Id0a7b70b8000b0b393cb89aae062afa74a6a17a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067566Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
-
bttk authored
Bug: 1046181 Change-Id: I0c269a5991701027702fd5011586d66de6192273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017912 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#743423}
-
Klaus Weidner authored
Add a special case to allow entering fullscreen mode when a DOM Overlay is being set up for WebXR immersive-ar mode, without consuming user activation. The initial WebXR session request had required user activation, but this may have triggered a permission/consent prompt, and if the user took more than 5s to answer that, the activation state will have expired at the time it's checked. (Fixes regression from https://crrev.com/c/1903675 which added a browser-side user activation check for Fullscreen API.) Bug: 1054557 Change-Id: Iaea843c34c948764ee5d08effdadf18d7b28d982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067539Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I0192db636f7349f0d0fa90607909df467d9399ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068117Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743421}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1052232 Change-Id: I9b583888cea7708a69eb35ac89c2dca2938f74b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066405Reviewed-by:
-
Kenneth Russell authored
Instead of only checking whether the containing frame is same-origin with respect to the top-level document during transferControlToOffscreen, check in the OffscreenCanvas constructor, both for the main thread as well as dedicated workers. Dedicated workers are same-origin per specification, so always grant access to the discrete GPU in this scenario. Add new pixel tests that verify WebGL-rendered OffscreenCanvas into an ImageBitmapRenderingContext (i.e., where the OffscreenCanvas was not originally tied to a canvas element). On dual-GPU macOS devices, also verify the active state of the low-power and high-performance GPUs. Simplify some of the tests most recently written for low/high-power GPU switching. Bug: 1048892 Change-Id: I85addc2b53a58997499e444b357d433d7082e262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043076 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#743419}
-
