- 21 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/41d4c65a3396..b432d0b75765 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from df17a76102df to 84f5eeb6dd9b (3 revisions) 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2be35682cd67 to e2147a58a233 (40 revisions) 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 60b90a0b to 4bdce889 (441 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Test: Test: Test: FIFA Mobile MECTest: Test: LEGO MECTest: Test: Lots of traces were hitting thisTest: Test: TransformFeedbackTest.SwitchProgramBeforeDraw/ES3_OpenGLTest: Test: angle_deqp_egl_testsTest: Test: angle_perftest --gtest_filter="*arena*"Test: Test: angle_perftests --gtest_filter="*brawl_stars*" Change-Id: I51352ad333ac26e3640c15785961b18f7bb26381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819298}
-
Jon Mann authored
This fixes a long standing bug where the focus moved back up to the first network when an update to the list of available networks came in. Bug: 720274 Change-Id: Iee036aa649a74eef1b1743317a07b35061e08d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480712Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#819297}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603238376-41278602b445da41d1916a61de8117b0857ab174.profdata to chrome-linux-master-1603259905-a5ed8d755823b45d7d48d45a9bc14c01d1293c89.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iaf4b83d76f169c50f6dcafa489621f30fe94e4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487958Reviewed-by:
-
Alice Wang authored
This CL changes the waited view from continue button to selected account for the collapsed screen of web sign-in bottom sheet. This is needed for the refactoring of account picker view states later. Bug: 1138824 Change-Id: I9122253daffd1da06910c52042f5e53efc00d9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487084Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819295}
-
Alice Wang authored
This CL refactors AccountPickerBottomSheetTest with onVisibleView. Bug: 1121536 Change-Id: If6385712bf6d6271d77d6ced98e4d2b3cba43f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485060Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4931a2710e1ce3b15189f525ecbe0c58b1c81f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489229Reviewed-by:
-
Vincent Palatin authored
PermissionBroker is now able to re-attach properly kernel device drivers to USB device interfaces on detecting the closure of a lifeline pipe from Chrome. Uses the new function for devices opened by webusb/chrome.usb. Bug: 1090596 Change-Id: Iebeae21890869cbff565a6ac76f48a7daac04ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475794 Commit-Queue: Vincent Palatin <vpalatin@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#819292}
-
Henrique Ferreiro authored
Change-Id: I9f94ee4c2a833be22c94dd57c6a2736048f64a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488161 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#819291}
-
Mikel Astiz authored
There's no remaining code under components/sync that has a dependency to components/sync_preferences. The trivial leftovers are cleaned up and the DEPS entry removed. Change-Id: I429196d1f41b81d804bb7a7fe4cb42614d9eb9d6 Bug: 915154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485154 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#819290}
-
Joel Hockey authored
Add FileOperationManager.restoreDeleted interface. Implementation to follow in crrev.com/c/2469340. Add trashedItems property to background FileOperationProgressEvent which is populated with a list of items moved to trash in a delete operation. Bug: 953310 Change-Id: If5067bdbcb605f63434c8efab2f8f81f57c76198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487744 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#819289}
-
Fabian Sommer authored
The observer for CertificateProviderService now also observes when an extension updates the certificates it provides. Add equality comparator for CertificateInfo for testing purposes. Bug: 1131450 Change-Id: I7efdb3f2b372e3aba279d52fda8e123050403af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481022Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819288}
-
Jacobo Aragunde Pérez authored
Set the first container as initial focus, so focus manager will search the first focusable item in case no other view is explicitly focused (e.g. with Ctrl+Shift+M, focus is set to the profile list for quick profile change). Setting focus inside the dialog is important for accessibility: when focus changes to a view inside the dialog, screen readers will announce the dialog to give context to the focus change. We don't need to override GetAccessibleWindowRole() any more because the implementation in DialogDelegateView will set the 'dialog' role for bubbles which have an initially focused view. Tests are altered to make up for the default focus change. Before, default focus was set outside the dialog and you had to advance once to reach the first element. Now, it's already placed on the first element. Bug: 1098304 Change-Id: Ie0db18193cb224497d311c8ae864ec4e532572b6 AX-relnotes: set focus into, and read accounts and sync dialog when open Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475056Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#819287}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e38a448746e8..1074330695a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fergal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fergal@google.com Change-Id: I3b38b9fe18c4bcfc0646cf6cf93523af02cf278b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487955Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819286}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603238376-a0754723f0cd6eaa7fc2494ab4a5f08c0cee1720.profdata to chrome-mac-master-1603259905-71f19f253a8b5311fb57e85e7e87c615112024a2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I092ce3c9f4cd2ab9d88dc393650ef291295c22f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487957Reviewed-by:
-
Anatoliy Potapchuk authored
This reverts commit dca1afe8. Reason for revert: The ParentalHandoffScreenBrowserTest.RegularUserLogin making linux-chromeos-chrome builders red always after this landed. Example build https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9289 Original change's description: > Adds parental handoff login screen in oobe. > > The description and mock can be seen in the comments in the bug report. > > Bug: 1134567 > Change-Id: I2ecd7c72629dc96dfbc054f747c6cb2508210709 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466618 > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819158} TBR=jwd@chromium.org,rsorokin@chromium.org,agawronska@chromium.org,yilkal@chromium.org Change-Id: Ib95ba29e59359a7cb7496269936413f461b0d1b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489424Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819284}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. It updates the method parameter from Callback -> OnceCallback. Bug: 1127505 Change-Id: I4a46a10822c02397ca09ffc3da531c685f623652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488719 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d20e0a34..d82ff002 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e18b42fb3373ff57032426e265e17e64b6359b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489001Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819282}
-
Fergal Daly authored
https://crrev.com/c/2444451 set these back to Crash only but many builder are red, I think because they can fail without crashing, e.g. https://chromium-swarm.appspot.com/task?id=4f6128c08656bb10 Bug: 1140796 Change-Id: I345a9dac39ed61a5cf5ffdd6167bf3fff60a1ecb TBR=ikilpatrick@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I345a9dac39ed61a5cf5ffdd6167bf3fff60a1ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488325 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#819281}
-
Anatoliy Potapchuk authored
This reverts commit 0092862f. Reason for revert: this breaks many tests, starting from this build https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9285 Original change's description: > Reland "Mojo JS: Use BigInt consistently for 64-bit int fields" > > This is a reland of ea79bdd2 > > Fix is in the delta from PS1 -> PS3 > > Original change's description: > > Mojo JS: Use BigInt consistently for 64-bit int fields > > > > This changes 64-bit integer fields to be deserialized as > > BigInt values consistently, rather than sometimes being > > BigInts and sometimes being Numbers. > > > > Fixed: 1102217,1009262 > > Change-Id: I9cc8d767058938e9c39f62f139737e512f47cdb2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466398 > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > > Reviewed-by: Shik Chen <shik@chromium.org> > > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Ken Rockot <rockot@google.com> > > Cr-Commit-Position: refs/heads/master@{#818611} > > Change-Id: I393a33b44b1a3e1746f7b9ee021dbe06c3ff7b07 > Tbr: shik@chromium.org > Tbr: fdoray@chromium.org > Tbr: ryansturm@chromium.org > Tbr: mahmadi@chromium.org > Tbr: beccahughes@chromium.org > Tbr: oksamyt@chromium.org > Tbr: ortuno@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485749 > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Auto-Submit: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#819004} TBR=shik@chromium.org,rockot@google.com,fdoray@chromium.org,ortuno@chromium.org,ryansturm@chromium.org,mahmadi@chromium.org,beccahughes@chromium.org,oksamyt@chromium.org,harringtond@chromium.org Change-Id: I77c90528f05e638d1ac10d01cb1321db9d1a4369 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488402Reviewed-by:
-
Christian Dullweber authored
The Clear Browsing Data dialog shows a list of hosted apps that will be affected by deletions. Only hosted apps with protected storage are affected, so hide those that do not have protected storage. Bug: 1140191 Change-Id: If02e65b235d254d50a18031c5b7b972341cd811e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487108Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#819279}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/80389cab7f58..6a2b3e4007e7 $ git log 80389cab7..6a2b3e400 --date=short --no-merges --format='%ad %ae %s' 2020-10-20 wl * Version 2.10.4 released. ========================== 2020-10-19 wl [sfnt] Fix heap buffer overflow (#59308). Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org Bug: chromium:1139963 Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: I0d16094508591d352d024b007d464678def7fe5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485583 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#819278}
-
Dominic Farolino authored
This reverts commit e89e7092. Reason for revert: http://crbug.com/1122182#c19 adds the debugging info we need on Android, so we can perform minidump analysis Original change's description: > [Prefetch]: Don't DCHECK if recursive prefetch token is set. > > This reverts commit a55089af. > crbug.com/1122182 is blocking minidump analysis for now. > > Bug: 1132770, 1123715 > Change-Id: I15910a86667d242d3da419e4ed9a274e2a82fea8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474854 > Reviewed-by: Dominic Farolino <dom@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Dominic Farolino <dom@chromium.org> > Auto-Submit: Mugdha Lakhani <nator@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817771} TBR=kinuko@chromium.org,dom@chromium.org,nator@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1132770 Bug: 1123715 Bug: 1122182 Change-Id: Ic24cdc3b5a8a5bb453e4ddf525ac85d52ddbaef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485552Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#819277}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2e6434aadb1..9f9ea0f6f024 2020-10-21 szuend@chromium.org [ts] Type-check object_ui/ObjectPopoverHelper.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ide21bfeef878a68ebd78708f535f6da328663eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489226Reviewed-by:
-
Nidhi Jaju authored
This reverts commit b52b97cb. Reason for revert: It is breaking external/wpt/streams/idlharness.any.html based on bisection. Original change's description: > Remove NotEnumerable from Transform Streams WebIDL > > According to https://github.com/whatwg/streams/pull/1035, all methods > and accessors are now enumerable, per Web IDL defaults, instead of > non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can > be removed from the Streams WebIDL files. This CL specifically > removes them from transform streams. > > Bug: 1093862 > Change-Id: I509b470722039ebad20b8caeaa7f34189c24b1ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486006 > Commit-Queue: Nidhi Jaju <nidhijaju@google.com> > Reviewed-by: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819230} TBR=ricea@chromium.org,nidhijaju@google.com Change-Id: I7176391031e4bbf89960fe6d7f358a520d06dd21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1093862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487745Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819275}
-
Yue Li authored
Bug: b/169453041 Test: Run TranslationResultLoaderTest.* in chromeos_components_unittests Change-Id: I47769ca8e86847fac34130eaa9048ff128c44f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484333Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Auto-Submit: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#819274}
-
Sergey Ulanov authored
Skia requires VK_IMAGE_USAGE_SAMPLED_BIT, VK_IMAGE_USAGE_TRANSFER_SRC_BIT and VK_IMAGE_USAGE_TRANSFER_DST_BIT usage flags to be set for wrapped Vulkan images. These flags were not set in SysmemBufferCollection for buffers that were created with BufferUsage::SCANOUT usage. As result these images couldn't be wrapped in Skia images. Update SysmemBufferCollection::InitializeImageCreateInfo() to set the required usage bits. Bug: 1140763 Change-Id: If9e980701f109519eb25ce753251082c693eedf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488910 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819273}
-
Side Yilmaz authored
DownloadManagerService#resumeDownload function may triggered for OTR profiles. However, download shouldn't be resumed if the native is not initialized yet. This CL blocks to resume download initiated from OTR profile, if native has not initialized yet. Bug: 1138139, 1099577 Change-Id: I46e6e0b47474f760150754f57e8805466c937449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471738Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#819272}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d2f82c00aeb..41d4c65a3396 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c4593127cbdd to cca03ca6bfe9 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I77a1ce61fe92b98450be7de8c991b334aa2d692a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489224Reviewed-by:
-
Jose Dapena Paz authored
GCC fails to resolve default move constructor of AutocompleteMatch, as SplitAutocompletion move constructor is not declared noexcept. Adding default declarations fixes the issue. Bug: 819294 Change-Id: I64e32608bbdd24015a4a65f398b37de9465c5b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485527Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#819270}
-
Koji Ishii authored
TBR=yosin@chromium.org, tkent@chromium.org Change-Id: Ie60dfeb5432fd32de2a93d2909abb141e1172117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487922Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819269}
-
Jose Dapena Paz authored
GCC build breaks because we are declaring an attribute in the wrong place of a function definition: ../../base/compiler_specific.h:125:27: error: attributes are not allowed on a function-definition 125 | #define NO_SANITIZE(what) __attribute__((no_sanitize(what))) | ^~~~~~~~~~~~~ ../../base/allocator/partition_allocator/pcscan.cc:221:57: note: in expansion of macro ‘NO_SANITIZE’ 221 | size_t PCScan<thread_safe>::PCScanTask::ScanPartition() NO_SANITIZE("thread") { | ^~~~~~~~~~~ Bug: 819294 Change-Id: Iff1a3ec8c4b2765c7d95c45a1951fa7f0714a86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485545Reviewed-by:Tom Sepez <tsepez@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#819268}
-
Jose Dapena Paz authored
libstdc++: do not pass a unique_ptr directly to stream insertion operator in CrossThreadMediaSourceAttachment. Fix build error using libstdc++: ../../third_party/blink/renderer/modules/mediasource/cross_thread_media_source_attachment.cc:578:37: error: no match for ‘operator<<’ (operand types are ‘std::basic_ostream<char>’ and ‘std::unique_ptr<blink::WebMediaSource>’) 578 | << ", web_media_source=" << web_media_source; | ^~ ~~~~~~~~~~~~~~~~ | | | std::unique_ptr<blink::WebMediaSource> This is because libstdc++ does not provide an operator<< implementation for std::unique_ptr (but libc++ does provide it). Bug: 957519 Change-Id: I344b0f289d625b036e6bd4cafac1000cff6f23ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486260Reviewed-by:Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#819267}
-
Jiewei Qian authored
This is a cleanup after BMO launch. SWA no longer uses extension related components. Bug: 1065748 Change-Id: I96e631a1ce5372bed458a4ff2010140950ae70c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485356 Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#819266}
-
David Tseng authored
This was left out (somewhat intentionally) in an effort to optimize the init/read path. However, this appears to be occasionally causing the process to hit resource limits on linux causing no new threads in the process to be created. Sample error: 2020-10-21T00:37:18.448831Z ERROR chrome[19371:19371]: [tts_service.cc(29)] E1020 17:37:18.448238 19371 thread.cc:68] Thread create failed: Resource temporarily unavailable R=dmazzoni@chromium.org Fixed: 1140617 Test: continually read long text over and over again. Observe no crash. Change-Id: Ie811b6ecc7e2bce9f898dc7cbd351cdfe5e4503d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489028 Auto-Submit: David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#819265}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9d160b0bba68..e2147a58a233 2020-10-21 jmadill@chromium.org Add missing condition_variable include. 2020-10-21 syoussefi@chromium.org Vulkan: Support vertex attribute aliasing for non-matrix types 2020-10-21 jmadill@chromium.org Perf Tests: Add stdout printing arg to bot mode. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I8ebc271c04ed794ff7fea1dc6635ddf10bebde10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489223Reviewed-by:
-
Luciano Pacheco authored
Note: per [1] JS modules must be served with text/javascript HTTP Content-Type. Change file_manager_jstest_base.cc to add Content-Type headers. [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules Bug: 1133186 Change-Id: I6a5436984052d74af267634f6fe0db70424b51a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470039Reviewed-by:
-
Aya ElAttar authored
As SystemFeaturesDisableList policy just launched, so its UMA stats is still needed. Bug: 1140030 Change-Id: I38191d0519554a215248e024acc8a86dd4f39402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487088Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819262}
-
sauski authored
CL stops appending table names into queries and inlines them directly instead. Bug: 1117381 Change-Id: I4cb5adc389f1685606ffa519383493a594e6bfac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485061Reviewed-by:
-
Joel Hockey authored
go/chrome-ss/b025494050650332c0d6964cb82b977199bd9fd0 go/chrome-ss/8d3b3f36cf84c787244001584e2b8425be3e7549 Bug: 953310 Change-Id: Ie6114823134d43026cdbaace7bc364e531884ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489122 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Fergal Daly authored
This reverts commit a9b6d2bd. Reason for revert: Causing builder to fail. First fail was 8 changes after this. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 Original change's description: > Use set_fixed_width() in c/b/ui/views dialogs > > Does not address subfolders which will be done in separate chunks. > > Bug: 1128500 > Change-Id: Id3caa97d0d59b4700b888c5bca5f89f69d4c64d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485148 > Commit-Queue: Peter Boström <pbos@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Auto-Submit: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819061} TBR=ellyjones@chromium.org,pbos@chromium.org Change-Id: I0d03cb731d03bf7ba11d836769bd2513c25f1366 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128500,1140866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489380Reviewed-by:
-
