GitLab

This patch adds the fieldwise_diff macro and then uses it to generate
the diff functions on the groups that have been generated so far
(StyleSurroundData) in ComputedStyleBase.

Please note that it can only be used for memebers of those groups too
that have already been generated. This is why the diffing for
BorderData has been left to a later CL.

Diff: https://gist.github.com/nainar/04f49165c4cb5ecb30371fbde1491ddf/revisions

BUG=710938

Review-Url: https://codereview.chromium.org/2858863002
Cr-Commit-Position: refs/heads/master@{#469286}

https://skia.googlesource.com/skia.git/+log/0356714916c3..64dbb89efc9d

$ git log 035671491..64dbb89ef --date=short --no-merges --format='%ad %ae %s'
2017-05-03 senorblanco GrTessellator: fix for vertex coincident with enclosing edge.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ia9db0a51e7f984fcf3a36cbb81ebae5bee5d218d
Reviewed-on: https://chromium-review.googlesource.com/495591Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469285}

Network traffic annotation is added to network request of
components/translate/core/browser/translate_url_fetcher.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2796323002
Cr-Commit-Position: refs/heads/master@{#469284}

This CL ensures that the NOT_STARTED state is recorded separately from
the STOPPED_BEFORE_COMPLETION state in the installability menu-open
check metrics.

BUG=704369

Review-Url: https://codereview.chromium.org/2844383004
Cr-Commit-Position: refs/heads/master@{#469283}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

Diff: https://gist.github.com/jm318/db6da170e28cb7fefa0056a364f164f0/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2861633002
Cr-Commit-Position: refs/heads/master@{#469282}

This CL makes the context menu for bookmark items appear when an item is
clicked.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814023004
Cr-Commit-Position: refs/heads/master@{#469281}

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2855393002
Cr-Commit-Position: refs/heads/master@{#469280}

[Cleanup] Use IsStandaloneExtensionProcess in ChromeContentRendererClient::ShouldGatherSiteIsolationStats()

BUG=None

Review-Url: https://codereview.chromium.org/2863523002
Cr-Commit-Position: refs/heads/master@{#469279}

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2860023002
Cr-Commit-Position: refs/heads/master@{#469278}

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2860943002
Cr-Commit-Position: refs/heads/master@{#469277}

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2862773002
Cr-Commit-Position: refs/heads/master@{#469276}

Since its introduction in Canary I became a big fan of the CSS rule usage
tracker and I'm looking forward to its introduction in Chrome stable.

I also thought it would be a great idea to run it periodically as part of the
e2e tests at work to collect the (un)used CSS rules instead of during manual
testing.

I then decided to implement a POC [1] to run the CSS tracker with Protractor.
This of course required some changes in Chromedriver, Protractor and WebDriver
JS Extender.
In particular, I had to change the Chromedriver so that I could send the
commands to start and stop the CSS rule usage tracking
(CSS.startRuleUsageTracking/CSS.stopRuleUsageTracking) to the remote debugger.

I thought of 3 possible implementations:
1) as part of the performance logging [2];
2) as a new endpoint of the Chromedriver to start/stop the CSS rule usage
tracking;
3) as a new endpoint of the Chromedriver to send any command directly to the
debugger, hence opening up the road to a whole series of tools able to send
commands directly to the debugger through the Chromedriver.

Of these 3 options, I implemented option 2 and 3 in this change.

If this change is acceptable, I'll proceed with the tests and fixing the linter issues.

Thanks,

EM.

[1] https://github.com/ventuno/css-usage-recorder/tree/ftr-css-recording
[2]
https://sites.google.com/a/chromium.org/chromedriver/logging/performance-log

BUG=

Review-Url: https://codereview.chromium.org/2743013002
Cr-Commit-Position: refs/heads/master@{#469275}

If xvfb dies or fails to start correctly while checking xdpyinfo, we
should exit straight away rather than continuing to try and probe with
xdpyinfo and waiting to time out.

BUG=708681,713597

Review-Url: https://codereview.chromium.org/2848833002
Cr-Commit-Position: refs/heads/master@{#469274}

r413783 introduced renderer load level monitoring and introduced the
RendererScheduler.[Background/ForegroundRendererMainThreadLoad] histograms.
r423509 changed how often these histograms were recorded without updating the
histogram descriptions. This CL updates the descriptions to correctly reflect
that these are recorded at most once per minute per renderer.

BUG=None

Review-Url: https://codereview.chromium.org/2856273003
Cr-Commit-Position: refs/heads/master@{#469273}

BUG=None

Review-Url: https://codereview.chromium.org/2856023003
Cr-Commit-Position: refs/heads/master@{#469272}

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2857963004
Cr-Commit-Position: refs/heads/master@{#469271}

On some Linux systems (like Ubuntu 14.04.5 or Ubuntu 16.04) with
4.8.0-49-generic kernel there's no /proc/<pid>/sched file. Or it exists
but doesn't have the required se.statistics.nr_wakeups field.
This causes TaskManagerBrowserTest.IdleWakeups test to fail and in
Chrome Task Manager all the Idle Wakeups counts are 0.

After some research I found out that the voluntary_ctxt_switches field
in file /proc/<pid>/status is practically the same as the previous
one. Using that field helps the test to pass.

BUG=717863

Review-Url: https://codereview.chromium.org/2859763002
Cr-Commit-Position: refs/heads/master@{#469270}

Review-Url: https://codereview.chromium.org/2856413002
Cr-Commit-Position: refs/heads/master@{#469269}

This patch splits up the iff checks in the diffing function
ComputedStyle::UpdatePropertySpecificDifferences with the intention of
making it easy to generate with the macro fieldwise_diff created here:
https://codereview.chromium.org/2858863002

As can be seen in the try bot runs this has no perf impact

BUG=710938

Review-Url: https://codereview.chromium.org/2855873003
Cr-Commit-Position: refs/heads/master@{#469268}

BUG=672263

Review-Url: https://codereview.chromium.org/2858943003
Cr-Commit-Position: refs/heads/master@{#469267}

This CL adds flags to enable/disable Chrome OS Component
(go/cros_component).

BUG=chromium:690521
TEST= Chrome OS Compnent shows up in Chrome://flags

Review-Url: https://codereview.chromium.org/2856913005
Cr-Commit-Position: refs/heads/master@{#469266}

defaults to TcpCubicBytes.

Merge internal change: 154986555
Merge internal change: 154988482

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2856163003
Cr-Commit-Position: refs/heads/master@{#469265}

BUG=705331

Review-Url: https://codereview.chromium.org/2840483002
Cr-Commit-Position: refs/heads/master@{#469264}

They are passing now:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=instantiation-error-1.html&showExpectations=true

BUG=594639
TBR=module-dev@chromium.org

Review-Url: https://codereview.chromium.org/2858123003
Cr-Commit-Position: refs/heads/master@{#469263}

https://swiftshader.googlesource.com/SwiftShader.git/+log/35e0ba7..5f72693

This mainly switches from using Subzero from DEPS to a copy from a Git subtree.

BUG=

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2856303002
Cr-Commit-Position: refs/heads/master@{#469262}

They are broken as of now.

BUG=718065

Review-Url: https://codereview.chromium.org/2859093002
Cr-Commit-Position: refs/heads/master@{#469261}

Review-Url: https://codereview.chromium.org/2855133002
Cr-Commit-Position: refs/heads/master@{#469260}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/af02d0f9..ff8039d7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2863473004
Cr-Commit-Position: refs/heads/master@{#469259}

Cr-Commit-Position: refs/heads/master@{#469258}

This CL adds showAtPosition to cr-action-menu which allows a client to
specify a rect or point to anchor to and which side of the menu to align.

This will be used in MD Bookmarks for right click context menus which
require more flexible alignment.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814743007
Cr-Commit-Position: refs/heads/master@{#469257}

This CL also creates NetworkConnectionHandlerTetherDelegate, which controls both tether connections and disconnections when requested in NetworkConnectionHandler.

BUG=672263

Review-Url: https://codereview.chromium.org/2857853005
Cr-Commit-Position: refs/heads/master@{#469256}

When user denies screencapture by clicking 'Cancel' in OS permission dialog,
Chrome will stop the capture after receiving the OnError() report. At this
point, the |mMediaProjection| is not created yet and |mCaptureState| has moved
to |ATTACHED|. So the capture state won't be |STOPPED| which will keep
stopCapture() waiting at [1].

The fix is to change the capture state to |STOPPED| for such a scenario.

[1]: https://cs.chromium.org/chromium/src/media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java?l=324

BUG=718082

Review-Url: https://codereview.chromium.org/2857743003
Cr-Commit-Position: refs/heads/master@{#469255}

The AppCacheRequestHandler class provides functionality for serving network requests from
the AppCache if applicable. This class is instantiated by the AppCacheInterceptor when a network request
is initiated. Its lifetime depends on the associated URLRequest.

The plan is to reuse this class in the network service world where we won't be intercepting
network requests in the browser process. This effectively means that there won't be any URLRequest as well

To achieve this the proposal is to provide an abstraction for a request called AppCachRequest. This class
will have two subclasses at the moment. AppCacheURLRequest and AppCacheURLLoaderRequest. The AppCacheURLRequest
class will be used by the current network implementation which relies on intercepting n/w requests.

The AppCacheURLLoaderRequest class will be used by the network service mojo implementation.
Next step is to provide an abstraction for the AppCacheURLRequestJob class.

BUG=715632
TBR=jam

Review-Url: https://codereview.chromium.org/2848493007
Cr-Commit-Position: refs/heads/master@{#469254}

This is similar to https://codereview.chromium.org/2838033002/ where
we do that same thing for animating layers with singular transform

BUG=717818
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2858853002
Cr-Commit-Position: refs/heads/master@{#469253}

R=dpapad@chromium.org
BUG=582027

Review-Url: https://codereview.chromium.org/2860903002
Cr-Commit-Position: refs/heads/master@{#469252}

https://skia.googlesource.com/skia.git/+log/461fa6ad8ed8..0356714916c3

$ git log 461fa6ad8..035671491 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I7bca1d449502b19f0e4ec9530ac101c4da59c064
Reviewed-on: https://chromium-review.googlesource.com/495487Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469251}

There was a regression recently that was fixed (https://codereview.chromium.org/2838673003/) but broke the network grouping experiment. This patch fixes that regression.

We were deeming the item as not needing to be removed or added without checking if there is a new parent.

R=dgozman,pfeldman
BUG=718116

Review-Url: https://codereview.chromium.org/2856863006
Cr-Commit-Position: refs/heads/master@{#469250}

BUG=716649

Review-Url: https://codereview.chromium.org/2859623002
Cr-Commit-Position: refs/heads/master@{#469249}

This disables safe ARC icon decoding which requires IPC.

TEST=Test passes.
BUG=709297

Review-Url: https://codereview.chromium.org/2856353002
Cr-Commit-Position: refs/heads/master@{#469248}

Help diagnose bugs from non-usable keys more quickly.

BUG=internal b/37379047

Review-Url: https://codereview.chromium.org/2861653003
Cr-Commit-Position: refs/heads/master@{#469247}