- 17 May, 2018 40 commits
-
-
Xiaocheng Hu authored
LayoutBlock::PositionForPointIfOutsideAtomicInlineLevel() hard-maps the left side of an atomic inline to the DOM position at its start, and the right side to its end, which is wrong if the atomic inline is RTL. This patch fixes the issue. Note: this patch doesn't fix selection flickering when dragging mouse over an atomic inline surrounded by bidi text, due to bugs in bidi adjustment in SelectionController. Bug: 811502, 834066 Change-Id: Id1687922f3d713cb2eb4b8668cb0687196a2fc44 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1062831Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#559413}
-
Alexandros Frantzis authored
This commit prepares ozone_demo to use GpuFences for overlay planes, when support for them lands in any of the Ozone backends. The --use-gpu-fences ozone_demo flag controls whether to enable the use of fences or use the existing glFinish mechanism. Bug: 828393 Test: Run ozone_demo on Ozone-DRM Change-Id: I797e9445479ff4a9768cb89033d1dd6fd826b5ae Reviewed-on: https://chromium-review.googlesource.com/1021693 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#559412}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ibb6b5ef9c34efcfd06bb9e362a7ec2cad16c2609 Reviewed-on: https://chromium-review.googlesource.com/1063150Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#559411}
-
James Darpinian authored
The flakiness is on all platforms. https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpncHVfdGVzdHMucGl4ZWxfaW50ZWdyYXRpb25fdGVzdC5QaXhlbEludGVncmF0aW9uVGVzdC5QaXhlbF9XZWJHTFNhZENhbnZhcww Bug: 835867 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I959dd5e6db6f8ca4f50effeca828a8cd98f6b5fa Reviewed-on: https://chromium-review.googlesource.com/1062911 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559410}
-
Koji Ishii authored
This patch adds ComputedStyle::GetFontBaseline function, and use it in all places in LayoutNG. It should depend on 'writing-mode' and 'text-orientation', but in many places in LayoutNG it is determined only from 'writing-mode'. This fixes 4 tests but discovers 2 failures. As in the added comment, the inline boxes and text should be aligned to parent's dominant baseline. In many places in LayoutNG and also in the current engine, we check the baseline of the child box. Some of these look incorrect, but fixing them is for future CLs. This CL just replaces each code with the common function. A design question is whether to add this to NGConstraintSpace or not, because the layout depends on parent's dominant baseline. This patch does not do this but instead pass when necessary, because it is only needed for inline context, and we don't create NGConstraintSpace for inline descendants. This may be revisited in future. Bug: 636993 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iba77fd528fb0ea54526f45d8dfd83bbcfb48411c Reviewed-on: https://chromium-review.googlesource.com/1059974 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#559409}
-
Gary Kacmarcik authored
This class contains all the platform-independent code for creating the Keyboard Map. Bug: 832811 Change-Id: Icb4dbf85419c72e795b090bae816b0b1c6b03f67 Reviewed-on: https://chromium-review.googlesource.com/1062925 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559408}
-
Tom Anderson authored
Includes 4 changes: https://chromium.googlesource.com/chromium/buildtools/+log/a9e946f166b73f9dc170129f6586a1e68efb0ab3..94288c26d2ffe3aec9848c147839afee597acefd Notably, libc++ and libunwind are rolled. BUG=767901 R=thakis Change-Id: Ie4ce691439dea7a362501ebaba9c2ccc130ea90a Reviewed-on: https://chromium-review.googlesource.com/1063019Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559407}
-
Lucas Gadani authored
This is a reland of 7a5a390d Original change's description: > Remove CacheStorage mojom typemaps. > > This CL removes the typemaps for CacheStorage and converts the browser usage of > CacheStorage types to mojo types. > > Bug: 612287 > Change-Id: Ied68ed00f2cc7af71cc33660544be9894cbb2eb1 > Reviewed-on: https://chromium-review.googlesource.com/1058334 > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559058} Bug: 612287 Change-Id: Iea6d8ef4f67616be7350edec7705d71b2b1ac126 Reviewed-on: https://chromium-review.googlesource.com/1061986Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#559406}
-
Stefan Zager authored
For IntersectionObserver, we only want to hit test down to the target element. BUG=827639 R=chrishtr@chromium.org,pdr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7c64a73577c1d685ba73ecc6ad388cd790122ad8 Reviewed-on: https://chromium-review.googlesource.com/1054132 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559405}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d6b41a27678f..05da1c16dfb4 $ git log d6b41a276..05da1c16d --date=short --no-merges --format='%ad %ae %s' 2018-05-16 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ c8403ec14..89c43d202 (1 commit) 2018-05-16 angle-skia-autoroll Roll third_party/externals/angle2/ 80c32ccbb..f299a378f (6 commits) 2018-05-16 brianosman Suppress bad-function-cast warning 2018-05-15 enne Driver bug workaround: pack_parameters_workaround_with_pack_buffer 2018-05-16 jvanverth Fix check for valid proxies returned by AtlasManager. 2018-05-16 skcms-skia-autoroll Roll skia/third_party/skcms a7e79c5..5cc905d (1 commits) 2018-05-16 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 596f653f5..c8403ec14 (1 commit) 2018-05-15 bungeman SkImage::onRefEncoded to return sk_sp. 2018-05-15 enne Driver bug workaround: gl_clear_broken 2018-05-16 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ e475674ef..596f653f5 (1 commit) 2018-05-15 enne Driver bug workaround: restore_scissor_on_fbo_change 2018-05-16 kjlubick Remove problematic pre-allocations when deserializing 2018-05-16 herb Fix compiler warning for MSVC 2018-05-16 skcms-skia-autoroll Roll skia/third_party/skcms e040063..a7e79c5 (2 commits) Created with: roll-dep src/third_party/skia BUG=chromium: 829614,chromium: 829614,chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ic77fdbcc06c7d4ce7c8354c041e9997d3be8bb76 Reviewed-on: https://chromium-review.googlesource.com/1063112 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559404}
-
Rakina Zata Amni authored
The wrong request id is used while binding OnGetNearestFindResultReply. The original IPC version used activate_.current_request_id but we used current_session_id_ in the mojoification on crrev.com/c/1051143, making replies received in OnGetNearestFindResultReply to be dropped because the request id don't match. This CL makes the mojo call to use activate_.current_request_id. Bug: 843448 Change-Id: I049d4f560ed82d36f8d3ffb876217ba94a46fe1c Reviewed-on: https://chromium-review.googlesource.com/1063045Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#559403}
-
Erik Chen authored
The tests recently started flaking. It's unclear why. Bug: 843467, 843843 Change-Id: Ie5141f65a6da01314da263ab5b875126e4e4fb3e Reviewed-on: https://chromium-review.googlesource.com/1062834 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Chris Harrelson authored
descendants. When <foreignObject> was made a stacking context, it also had the side-effect of painting it at the same time as positioned elements. This is a change to painting order and caused a regression. Instead, implement a new mechanism by which a "replaced normal-flow stacking" element paints during the foreground phase of the LayoutObject paint tree walk. This is used for now just for <foreignObject>, but may be applied to other replaced elements such as iframes or embedded objects in the future. Bug:842668 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I450944986abfb6610084444abf2724e7406145cf Reviewed-on: https://chromium-review.googlesource.com/1060333 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559401}
-
Abhishek Arya authored
R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: 843183 Change-Id: I194ad5ccfa7f6145beccc1f4b4c0e083e4f5c681 Reviewed-on: https://chromium-review.googlesource.com/1063120 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559400}
-
Xiaohan Wang authored
Add a new MediaLog level so that we don't have to abuse MEDIALOG_ERROR, which could end up in MediaError.message and should be carefully used. Also update documentation on MediaLog levels. Also use MEDIALOG_WARNING in audio_timestamp_validator.cc for non-fatal issues. Bug: 843808 Test: Manually tested and verified in about://media-internals Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I20350d305b3f55d1f59e6d2324cc3be7452bcbbe Reviewed-on: https://chromium-review.googlesource.com/1063009Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#559399}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/07bcf9fc1678..78fd93090e2f $ git log 07bcf9fc1..78fd93090 --date=short --no-merges --format='%ad %ae %s' 2018-05-16 sullivan Implement gerrit_service.PostChangeComment Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I877559f12f54994c3fe6e4f05ec5e664474e0733 Reviewed-on: https://chromium-review.googlesource.com/1063175Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559398}
-
Tessa Nijssen authored
Previously, when a Textfield instance changed its text direction, no change was made to its horizontal alignment. Now, ChangeTextDirectionAndLayoutAlignment() calls SetHorizontalAlignment() with the correct alignment based on text direction. Text direction Horizontal alignment Right-to-left -> Aligned right Left-to-right -> Aligned left This fixes a bug where toggling RTL in a Textfield did not change the text writing direction. A unit test was also added to test ChangeTextDirectionAndLayoutAlignment(). This test checks that a call to the method properly updates the textfield's text direction and horizontal alignment. Bug: 841123 Change-Id: I8dadc1272a3474dc72ae9470bdc7d9949e8fd854 Reviewed-on: https://chromium-review.googlesource.com/1060626 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559397}
-
Jeffrey Kardatzke authored
This is an obvious coding error, the wrong variable was used for checking if an iterator was empty. Depending upon if a specific bit was set in that random memory location, then we'd get the right/wrong behavior. Bug: 842196 Test: Icons load (although they usually did before) Change-Id: Ie52747f0b03e82ba2915df3f8ce9198a9a22452f Reviewed-on: https://chromium-review.googlesource.com/1062199Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#559396}
-
Bailey Berro authored
This change adds more descriptive mount errors in order to display more detailed reasons for a failed mount to the user. Bug: chromium:757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I11d46ca74d40d77276bce6839899ac723b3b77c6 Reviewed-on: https://chromium-review.googlesource.com/1060428 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#559395}
-
Jinsuk Kim authored
BindingManager.java is not in use by the target defined in Chrome build any more. This CL removes the corresponding DEPS exception rule. Bug: 617324 Change-Id: I1c0a35d6f950d237b72b33c2dad69847d5bfc50c Reviewed-on: https://chromium-review.googlesource.com/1060719Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559394}
-
Alan Cutter authored
This CL fixes the review nits in https://chromium-review.googlesource.com/c/chromium/src/+/1049126 Bug: 788051 Change-Id: Ie05dfc59896f528408ef305c9f56cadfafa587d0 Reviewed-on: https://chromium-review.googlesource.com/1058737Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#559393}
-
Joel Einbinder authored
Some native functions don't have names in their toString, so now we use the identifier the user typed in as a fallback. Change-Id: I79ad4e630a39ff23a109485ea5afded9d660d54e Reviewed-on: https://chromium-review.googlesource.com/1063037Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#559392}
-
Dan Beam authored
R=dpapad@chromium.org BUG=843736 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I900160ee6481b1b7d034e5b105afb6087c317a31 Reviewed-on: https://chromium-review.googlesource.com/1063042Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#559391}
-
Ken Rockot authored
Bug: 826213 Change-Id: I11392bd9b865a4026470caa0dd613a860ade48ed Reviewed-on: https://chromium-review.googlesource.com/1063006Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
|handleInterceptLoadurl| defined in OverlayContentDelegate seems to have ended up not being overriden at all, and always return false. This CL deletes the interface and simplifies the callsite. Change-Id: I880634cb284376742602836699f7dc862a9ce60d Reviewed-on: https://chromium-review.googlesource.com/1060774Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559389}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6054012..5cc09ffc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ife3c47dccaeaea4bde12bdabc6cf0e8c1925603b Reviewed-on: https://chromium-review.googlesource.com/1062125Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#559388}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2a0def7..c8403ec BUG=chromium:841296 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I3e6d72c823a849eca2b4f46cd28599c4d585a174 Reviewed-on: https://chromium-review.googlesource.com/1062287 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559387}
-
Sunny Sachanandani authored
SetCurrent stack trace crash key shows that we set a null context in ReleaseCurrent in SetDrawRectangle. Remove the debugging code there, and add explicit CHECKs before and afer SetDrawRectangle. Also alias surface handles associated with the surface because a logic error there could cause MakeCurrent to be skipped. Bug: 724999 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I91a0bd0f410690e7f8b1b2e6429d52c223ab851f Reviewed-on: https://chromium-review.googlesource.com/1050880 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#559386}
-
Takuto Ikuta authored
linux_chromium_asan_rel_ng used -j150 in buildbots. https://chromium-review.googlesource.com/c/chromium/tools/build/+/860278 Change-Id: Ia087d08bd9bea25b1a076a0e55378a9bbf7de074 Reviewed-on: https://chromium-review.googlesource.com/1060940Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#559385}
-
Avi Drissman authored
Activating windows allows popunders, and is disallowed in Chromium. Ensure that we do not activate a window when we show a chooser bubble. BUG=838314 Change-Id: I052adb7b4bc37a439961059ab95670edcf85cd69 Reviewed-on: https://chromium-review.googlesource.com/1059451 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#559384}
-
Daniel Murphy authored
Patch is as small as possible for merging. Bug: 842990 Change-Id: I9968ffee1bf3279e61e1ec13e4d541f713caf12f Reviewed-on: https://chromium-review.googlesource.com/1062935 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#559383}
-
Ben Pastene authored
Replaces our use of cros_vm directly. Needed because going through cros_run_vm_test.py gives us smarter VM-bootup logic. cros_vm.py lacks this is and is rather dumb. Also bump timeout of cros-vm bot's timeout on telemetry unittests by a few min. (Added in this CL 'cause all of this is aimed at getting telemetry_perf_unittests stable.) Bug: 839187 Change-Id: I3fe6a8ec52d4a6f47b8b1ef475390346aa920ec3 Reviewed-on: https://chromium-review.googlesource.com/1062590Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#559382}
-
https://chromium.googlesource.com/angle/angle.git/+log/21386a349acc..0e1c158ed0e6 $ git log 21386a349..0e1c158ed --date=short --no-merges --format='%ad %ae %s' 2018-05-16 ynovikov Log error of RegisterClassA in DisplayWGL::initialize 2018-05-16 ynovikov Revert "Don't double-terminate a display." 2018-05-14 lucferron Vulkan: Implement copyImage and enable all tests for it 2018-05-14 lucferron Vulkan: Finish implementation of the copySubImage 2018-05-14 lucferron Vulkan: Implement PACK_STATE dirty bit and remove warning Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I6cf729cc19105c4b6c06f9cd02858c77b25028fd Reviewed-on: https://chromium-review.googlesource.com/1063020Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559381}
-
Kenneth Russell authored
Actually cover the code which reads luci-milo.cfg. Bug: 843842 No-Try: True Change-Id: Icd0fcaa2b6037c1ae3560a8ddb6e6ba777b3ac80 Tbr: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1063270 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Chris Lu authored
What the logic does: - Gets favicons for every cell Todos: - Cancel favicon requests for cells that leave the page - Refactor FaviconLoader to use LargeIconService and NSCache - Cancel all pending requests when the user leaves the Recent Tabs Page - Prefetching - give "Show full history" cell it's own cell. Currently clashes by implementing with UrlCell Screenshot: https://drive.google.com/open?id=1LD70rytXsaKoK0aJp0OhqBZOerq-FY5o Doc: https://docs.google.com/document/d/1-c4YEmRta2qcg2HC9VzQZoeI9CBG3yccfN3GBITU910/edit# Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic5515194dd3040ec48857a69f73222fb4aaa6e97 Reviewed-on: https://chromium-review.googlesource.com/1025311Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#559379}
-
CJ DiMeglio authored
Currently, there is a edge case where we may lose the context_provider before we have set the callback to reset the frame sink. This change guards against that, but in the future, we want to move |frame_sink_destroyed_callback_|'s initialization to VideoFrameSubmitter's construction time. Bug: 842432 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1437d2b91f416ff5f2f310530d6443f8f8014213 Reviewed-on: https://chromium-review.googlesource.com/1058341Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#559378}
-
Maggie Chen authored
|is_protected_video| is added to the GL command buffer function interface of glScheduleDCLayer and the DCRendererLayerParams structure. The default is false for now and will be used later for Windows to support protected video decoding. When is_protected_video is true, the video content should be protected by hardware until it is displayed. BUG=843814 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib441af24c3be32d8ae41944d3a410364f804dd25 Reviewed-on: https://chromium-review.googlesource.com/1056629Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Timothy Loh authored
Similar to how we dismiss the app list when launching a Crostini app or terminal from the main list of apps, we should also dismiss it when launching from search or the recently used app list. Bug: 839207 Change-Id: I2968e827c6feacb7e58660a0784463d091bf90e4 Reviewed-on: https://chromium-review.googlesource.com/1060834Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#559376}
-
Fady Samuel authored
This CL moves top/bottom bar control updating to a separate UpdateControls method in RenderWidgetHostViewAndroid. If surface sync is on then it gets called in DidUpdateVisualProperties, and if surface sync is off it continues to get called in OnFrameMetadataUpdated. Change-Id: Ieb4926a4393686db05afd153ec243b72a85c45c7 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1062084 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#559375}
-
John Abd-El-Malek authored
We'll enable to see if it they still flake or not. Bug: 715632 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2a305db1120d98b1a1bb632bb4c2e1315a2571b2 Reviewed-on: https://chromium-review.googlesource.com/1063105Reviewed-by:
-
